- 26 Sep, 2017 40 commits
-
-
Ian Vollick authored
With this CL, a number of conditions that were glommed together and checked with one EXPECT_TRUE are not separated to make test failures easier to understand. Bug: None Change-Id: I849bb26befc52b89a61422a4ff63059c376cd60d Reviewed-on: https://chromium-review.googlesource.com/684538Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#504382}
-
Evan Stade authored
NotificationDisplayService. Allow notification sources, like EolNotification, to register their custom handlers with NotificationDisplayService. Bug: 578868,755413 Change-Id: Ie7c4464c174625dc4de4c8e5f3053a47659e6d66 Reviewed-on: https://chromium-review.googlesource.com/648474 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#504381}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/ba14c0a5f12b..a7caeb529121 $ git log ba14c0a5f..a7caeb529 --date=short --no-merges --format='%ad %ae %s' 2017-09-26 dsinclair Rename CFPDF_* classes Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ibfb22ebb7dc67b5ba1af8ff56d73c7411333fa7b Reviewed-on: https://chromium-review.googlesource.com/684674 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504380}
-
Daniel Bratell authored
V8ScriptValueSerializerTest and V8ScriptValueSerializerTestForModules had a few methods in common. This patch makes those methods be shared, or in the case or non-identical methods, renamed to not collide in jumbo builds. Bug: 745732 Change-Id: Ia51d9f8dba1910902465dc4cffc193031b47ee3f Reviewed-on: https://chromium-review.googlesource.com/677446Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#504379}
-
Marc Treib authored
This reverts commit 71921771. Reason for revert: telemetry_perf_unittests failing again: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests Original change's description: > Reland "[tools/perf] Re-enable meadia system health smoke tests" > > This reverts commit ed15e687. > > Reason for revert: Tests should now fit within the allotted time. > > Original change's description: > > Revert "[tools/perf] Re-enable meadia system health smoke tests" > > > > This reverts commit 359bafda. > > > > Reason for revert: > > > > Seeing telemetry-perf bot failures. > > > > Original change's description: > > > [tools/perf] Re-enable meadia system health smoke tests > > > > > > These are running fine on bots now. > > > > > > Bug: 726439 > > > Change-Id: I97a5f9e85d873c685af14085f9534081fd3a5ee5 > > > Reviewed-on: https://chromium-review.googlesource.com/655299 > > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#500564} > > > > TBR=perezju@chromium.org,nednguyen@google.com > > > > Change-Id: Ib3d38babf138c04ea32fa62cf257d20727593888 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 726439, 763379 > > Reviewed-on: https://chromium-review.googlesource.com/657917 > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Commit-Queue: Roger McFarlane <rogerm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#500594} > > TBR=rogerm@chromium.org,perezju@chromium.org,nednguyen@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 726439, 763379 > Change-Id: I309dfdd0f7b32bd4dc275904fc24ef1e251f8c85 > Reviewed-on: https://chromium-review.googlesource.com/684024 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504352} TBR=rogerm@chromium.org,perezju@chromium.org,nednguyen@google.com Change-Id: Ib027b20abc609bab8a6269fe658ad5b135eb66b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726439, 763379 Reviewed-on: https://chromium-review.googlesource.com/685094Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504378}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/6bba6de94461..f6f7cf60985d $ git log 6bba6de94..f6f7cf609 --date=short --no-merges --format='%ad %ae %s' 2017-09-25 brianosman Invalidate path VBs when paths are destroyed Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I561c148fe6131b4f923e122a99400e67dad7ee21 Reviewed-on: https://chromium-review.googlesource.com/684555Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504377}
-
Theresa Wellington authored
* Disable animation when changing content in the bottom sheet on low-end devices * Set a background color on the content displayed in the sheet to compensate for a JB bug * Use #setBackgroundColor instead of #setBackgroundResource to fix a JB bug BUG=766237,749959 Change-Id: Ic300905d8c79a137f55bc6732d70d65444f6a921 Reviewed-on: https://chromium-review.googlesource.com/683216Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#504376}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99e3e3dd. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2435 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry-1 TBR=qyearsley@chromium.org No-Export: true Change-Id: I35ab110b68b64b063cf9dc3699f4a5aedfc6a86c Reviewed-on: https://chromium-review.googlesource.com/684117 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504375}
-
Edward Lemur authored
Bug: 745469 Change-Id: I1c97a913769352d9e352e2cbb2d99fd52e655439 Reviewed-on: https://chromium-review.googlesource.com/681817 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Henrik Kjellander <kjellander@chromium.org> Cr-Commit-Position: refs/heads/master@{#504374}
-
Elodie Banel authored
The iPhone X being quite tall, the 100em page was not tall enough and since it fit on one page, the toolbar could not be scrolled out of the way. Additionally, I've noticed that in the iPhone X simulator the JSCompletionTimeout is getting hit regularly when loading a page but it works fine with a slightly longer delay, so extended that as well. Bug: none Change-Id: I22a1ca799853b38801b9c50b87a47f3cac7a09b5 Reviewed-on: https://chromium-review.googlesource.com/684735 Commit-Queue: Elodie Banel <lod@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#504373}
-
Nathanael Alcock authored
This change reimplements the import/export functionality to the PM settings as it existed in the previous version, before the Material redesign. Bug: 674536 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I686dc1152e95bc74ad21c3137b5aebf226801aed Reviewed-on: https://chromium-review.googlesource.com/663380 Commit-Queue: Nathanael Alcock <varkor@google.com> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504372}
-
Biao She authored
Bug: 767572 Change-Id: I7a9c90372c719bc423603d9e6a9a4ce33f292191 Reviewed-on: https://chromium-review.googlesource.com/677988 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#504371}
-
Mike Reed authored
https://skia-review.googlesource.com/c/skia/+/50980 Bug: Change-Id: Ibab6c30df52f78269c8f16fc2f5e21f362668385 Reviewed-on: https://chromium-review.googlesource.com/684774 Commit-Queue: Mike Reed <reed@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#504370}
-
Elodie Banel authored
This test was already failing and disabled on device. It is now failing on iPhone X simulator as well for the same reason so disabling it on simulator as well. Bug: 755888 Change-Id: I13ab73aa46a4698ff8c50cea1d786a9c1f5e4a85 Tbr: noyau@chromium.org Reviewed-on: https://chromium-review.googlesource.com/684312Reviewed-by:
Elodie Banel <lod@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#504369}
-
Marti Wong authored
This CL prevents the selection of promo cell (the following screenshot) https://drive.google.com/file/d/0B1dtd3IUt4I7RUh5MjdLRWtaYmM by setting promo cell’s selection style to none. Bug: 695749 Change-Id: I5df7ec5033a379f68970fa8cf11789b2a11078a9 Reviewed-on: https://chromium-review.googlesource.com/684634Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#504368}
-
Jérôme Lebel authored
In enum CBError, for 10.13, CBErrorMaxConnection has been removed, and CBErrorConnectionFailed and CBErrorConnectionLimitReached have added. 10.12: * CBErrorMaxConnection (value 10): The device already has the maximum number of connections. 10.13: * CBErrorConnectionFailed (value 10): The connection failed. * CBErrorLimitReached (value 11): The device already has the maximum number of connections. So for 10.12 or earlier, CBErrorMaxConnection should be counted as CBERROR_CONNECTION_LIMIT_REACHED. Bug: Change-Id: I3f9dac126b5701639d7b5ed7984e414ddcc02d29 Reviewed-on: https://chromium-review.googlesource.com/680215 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504367}
-
Ned Nguyen authored
TBR=horo@chromium.org, falken@chromium.org Bug: 767086 Change-Id: Ibbbe0ef8f1d4b90cf5daa511756a741f2acb200a Reviewed-on: https://chromium-review.googlesource.com/682494Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#504366}
-
tzik authored
NGPhysicalFragment needs special handling on the destruction rather than being destroyed by WTF::RefCounted. However, existing style of the destruction hook will be unavailable after unifying base::RefCounted and WTF::RefCounted. This CL adds a proper way to inject the destruction function of a ref counted object. The destruction function will be injected to base::RefCounted after the unification. Bug: 763844 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If763525a55c4621abd711a16a531817528a42b69 Reviewed-on: https://chromium-review.googlesource.com/681955Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#504365}
-
tzik authored
This CL removes the getter of the ref count value from WTF::RefCountedBase, which is missing on base::RefCounted and will be unavailable after these unification. And this also removes all usage of the getter. Bug: 763844 Change-Id: I3b91d16213a160c9c6a2bf1e4cea16598043c00e Reviewed-on: https://chromium-review.googlesource.com/680618Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#504364}
-
Evan Stade authored
There are two branches currently: - if at least one user has a maximized window, fade shelf to black and back. Note that this branch is broken, and instead all you see is a white flash, but this is easily fixed if need be. - otherwise, set shelf to hidden and then let the user switch update the state from there. If we remove both of these branches and just let the user switch change the state of the shelf, the outcome is nearly indistinguishable. Scratching the second bullet point above seems to have no discernible effect. Scratching the first branch just means there will be no fade-to- black, however the addition and removal of launcher icons is animated regardless, so it still looks smooth. Additionally, the fade-to-black doesn't work on the system tray (clock, avatar), and hasn't worked at all for 4 months and no one noticed. In a sense, removing this branch is an improvement because it removes a white flash. Bug: 756085 Change-Id: If40c65e02035947709be31db466dea144ab0b462 Reviewed-on: https://chromium-review.googlesource.com/683035 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#504363}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6f2b6f8f72ff..02e80da6090c $ git log 6f2b6f8f7..02e80da60 --date=short --no-merges --format='%ad %ae %s' 2017-09-24 apodtele Tweak per-face LCD filtering controls. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org Change-Id: Ief384669998d1994f574fdf86229a05ec16f6426 Reviewed-on: https://chromium-review.googlesource.com/682176Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504362}
-
Daniel Bratell authored
A bit of cleanup after a recent commit that added an unnecessary header file. Bug: 745732 Change-Id: I1a90f22c9301ab60a09ea2fec9020c5da431460b Reviewed-on: https://chromium-review.googlesource.com/684177 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#504361}
-
Andrey Kraynov authored
|Element*| objects. Bug: 766448 Change-Id: I5c195095cc692f3cc3fd6d7fb68fbaf98ffc875e Reviewed-on: https://chromium-review.googlesource.com/673146Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#504360}
-
Mohamad Ahmadi authored
- Replaces grey_typeText with grey_replaceText so that the test can be enabled in iOS11. - Modifies the test so that the navigation buttons are not used to go to the previous editor field. The reason for that changes is that on iPhone 5/5s, due to the size of the screen, the previous field may be under the scroll and therefore the "previous" navigation button is disabled. Bug: 753098 Change-Id: I3343014e8374cea6bbfa3031a92f631ad7d9039d Reviewed-on: https://chromium-review.googlesource.com/682341Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#504359}
-
Jeremy Roman authored
Suspected proximate cause of rare crashes during stylesheet loading. There's not much we can do if these resources are failing to load, but this at least stops the compression logic from crashing and makes Chrome behave how it did before the addition of |is_gzipped|. Bug: 749963 Change-Id: Ia9262dc4febbe8f9d81fdc555252a372e1d63820 Reviewed-on: https://chromium-review.googlesource.com/682642Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504358}
-
Ramin Halavati authored
Missing traffic annotation added to ServiceWorkerFetchDispatcher::MaybeStartNavigationPreloadWithURLLoader Bug: 766239 Bug: 656607 Change-Id: I4df9cd4389cfe494fb34176f9efe005f76a24f73 Reviewed-on: https://chromium-review.googlesource.com/678498 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#504357}
-
Marc Treib authored
TBR=torne@chromium.org Bug: 767180 Change-Id: I3ad4f6d1b67d19eb09f5dd489699031d629ff740 Reviewed-on: https://chromium-review.googlesource.com/684375Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504356}
-
Lucas Furukawa Gadani authored
Change-Id: I7b5950fbeb943479cb73569f0265fa1d999e951c Reviewed-on: https://chromium-review.googlesource.com/684556Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#504355}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/639e972bf15c..0b563bed301e $ git log 639e972bf..0b563bed3 --date=short --no-merges --format='%ad %ae %s' 2017-09-26 nednguyen Roll snap-it to the latest version Created with: roll-dep src/third_party/catapult BUG=763119 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I96c44060e96843f8352d87872b0be5aea0602f46 Reviewed-on: https://chromium-review.googlesource.com/684554 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504354}
-
Elly Fong-Jones authored
This isn't wanted for Harmony, and it looks a bit out of place even in the non-Harmony version of this dialog. Bug: 610428 Change-Id: I82429d8317d392eaf29803bd1870f1a07420dba1 Reviewed-on: https://chromium-review.googlesource.com/681837Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#504353}
-
Juan Antonio Navarro Pérez authored
This reverts commit ed15e687. Reason for revert: Tests should now fit within the allotted time. Original change's description: > Revert "[tools/perf] Re-enable meadia system health smoke tests" > > This reverts commit 359bafda. > > Reason for revert: > > Seeing telemetry-perf bot failures. > > Original change's description: > > [tools/perf] Re-enable meadia system health smoke tests > > > > These are running fine on bots now. > > > > Bug: 726439 > > Change-Id: I97a5f9e85d873c685af14085f9534081fd3a5ee5 > > Reviewed-on: https://chromium-review.googlesource.com/655299 > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#500564} > > TBR=perezju@chromium.org,nednguyen@google.com > > Change-Id: Ib3d38babf138c04ea32fa62cf257d20727593888 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 726439, 763379 > Reviewed-on: https://chromium-review.googlesource.com/657917 > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Commit-Queue: Roger McFarlane <rogerm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500594} TBR=rogerm@chromium.org,perezju@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 726439, 763379 Change-Id: I309dfdd0f7b32bd4dc275904fc24ef1e251f8c85 Reviewed-on: https://chromium-review.googlesource.com/684024Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#504352}
-
Christian Dullweber authored
This enables the new Clear Browsing Data dialog by default for desktop. privacy_page_test.js needs a small fix, so it doesn't break. I will change privacy_page_test.js to completely run on the new ui in https://crrev.com/c/647713. Bug: 725401 Change-Id: I8647e53bc93725c84cf45ada46123d84038c9a78 Reviewed-on: https://chromium-review.googlesource.com/647712Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#504351}
-
Patrik Höglund authored
This reverts commit 6569f043. Reason for revert: Still fails on the bot for some reason, but passes on my local machine. Original change's description: > Re-enabling Firefox interop test. > > The fix is now in the Firefox nightly; verified the test passes > locally. > > Depends on https://webrtc-review.googlesource.com/c/webrtc.DEPS/+/3401. > > R=ehmaldonado@chromium.org > > Bug: 751211 > Change-Id: I191db39747711b09a0c36e367e8e08fac0c53ea5 > Reviewed-on: https://chromium-review.googlesource.com/681701 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Reviewed-by: Henrik Kjellander <kjellander@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504331} TBR=kjellander@chromium.org,phoglund@chromium.org,ehmaldonado@chromium.org Change-Id: I75ad86884d347f7853d6c616dbf284fbe0729c11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 751211 Reviewed-on: https://chromium-review.googlesource.com/684313Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#504350}
-
Vitalii Iarko authored
Previously it was propagated to Java. In this CL, it is used there as a placeholder. Thumbnail fade-in works as before. The change is guarded with a feature, which is enabled by default in Chrome Home. Also ic_snippet_thumbnail_placeholder.xml background is changed from default_primary color to modern_light_grey. Render tests golden images changes: -ArticleSnippetsTest.long_snippet_narrow.Nexus_5-19.png -ArticleSnippetsTest.long_snippet.Nexus_5-19.png Change thumbnail placeholder background color -ArticleSnippetsTest.modern-long_snippet_narrow.Nexus_5-19.png -ArticleSnippetsTest.modern-long_snippet.Nexus_5-19.png Replace thumbnail placeholder with thumbnail dominant color Bug: 754183 Change-Id: I732a56bd33c699c48472a6e3bfebbd01e273154f Reviewed-on: https://chromium-review.googlesource.com/677444Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#504349}
-
Ramin Halavati authored
Unnecessary policy options removed from the sample, comments added. Bug: 656607 Change-Id: I71123785e9a1d032908a1d0c42884c26cff15f20 Reviewed-on: https://chromium-review.googlesource.com/684018Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#504348}
-
Olivier Robin authored
Use standard way to select tab. Bug: None Change-Id: I531a3e450d93c860b62f8896379e8097d7b1f622 Reviewed-on: https://chromium-review.googlesource.com/684438Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#504347}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e8e9916c. With Chromium commits locally applied on WPT: e8e9916c "Trusted Types: First stab at TrustedScriptURL." Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2434 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I809a86e7b89c8556f686725814f4272a104367b3 Reviewed-on: https://chromium-review.googlesource.com/684234 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504346}
-
Brian White authored
Getting the previously freed object at "this" is only useful if the corruption was found in the "dummy" field. If in fact it is the histogram name that has been damaged, we must look up the object from the string's base address. About 1/2 of the crashes are due to a corrupted string so this will effectively double the number of data points to analyze. Bug: 744734 Change-Id: I9a923b7c416330d906bf2373ced3df08874299aa Reviewed-on: https://chromium-review.googlesource.com/683734Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#504345}
-
Guido Urdaneta authored
This CL adds new methods to support restarting a MediaStreamVideoSource. By default, sources continue to be nonrestartable, but the MediaStreamVideoCapturerSource does implement the restart capability. This is a preparatory CL to support MediaStreamTrack.applyConstraints(), which requires the ability to change the video format of a video source. Bug: 763319 Change-Id: I91b868326f1fcc52a8146612e4cd0429774f82e1 Reviewed-on: https://chromium-review.googlesource.com/675687 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504344}
-
Emi Morikawa authored
This CL implements blob request body for bypassing to a service worker. When a request body exists, SWURLLoaderJob creates BlobHandle to forward a request to the service worker. Bug: 764154 Change-Id: Ie432db242b643443b161a4c8ea8adbbc08169e15 Reviewed-on: https://chromium-review.googlesource.com/672103 Commit-Queue: Emi Morikawa <emim@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#504343}
-