- 07 Mar, 2020 40 commits
-
-
Filip Gorski authored
Removes the knowledge of ActivityTabProvider class and ChromeActivity#getActivityTabProvider() from: * org.chromium.chrome.browser.toolbar.* * org.chromium.chorme.browser.omnibox.* Bug: 1054072 Change-Id: I362d425b2dd2927a00e0e28d6c641931ddf3f518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080089Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#748001}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I760a86ee5aa29d3e5ea9fb20190a4890dca9f9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093134Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748000}
-
Sinan Sahin authored
Disable the test for Android L for now to avoid revert and reland of the previous CL as this test seems to fail on L only. TBR=twellington@chromium.org Bug: 1059421 Change-Id: I2533672b7d584db64af42a178b24df53b5e7ac99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092161 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#747999}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97c0ebd7cc1e..64bb65eb045a git log 97c0ebd7cc1e..64bb65eb045a --date=short --first-parent --format='%ad %ae %s' 2020-03-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@64bb65eb045a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I88b22c15915156d74d6c3717c1d75430d3640169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747998}
-
Mirko Bonadei authored
The usage of all_dependent_configs is considered a GN anti-pattern and it should be used only when the public_deps/deps/public_configs/configs system is not enough. There is no real reason to use all_dependent_configs in //third_party/googletest and since its usage has increased in crrev.com/c/2090420, this CL addresses the problems and removes its usage. Bug: 1059240 Change-Id: I4ff2bd0a19ad2ddd0b25866fcf738ab2d05a523b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091487 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747997}
-
Kyle Horimoto authored
This CL: (1) Adds a new os_settings_search_tag_strings.grdp file which contains search tags for this effort, and adds a few network-related search tags (see go/cros-settings-search for details). (2) Adds a SearchConcept struct and SearchResultIcon enum used to create metadata for a search result with potential alternate descriptions. (3) Creates an OsSettingsLocalizedStringsProvider class with a few Add*SearchTags() and Remove*SearchTags() functions for the tags added in step 1 above. Bug: 1059099 Change-Id: Ib5a126c3ff0ba16ffb734cb4cf0570500cec3b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086811 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#747996}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b32d49ba. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iebc2481d486645cdd42b642bf1347467f133683e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093251Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747995}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c5c7ea9e66a..c5f5b9e95179 git log 0c5c7ea9e66a..c5f5b9e95179 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 jbudorick@chromium.org devil: don't retry system app modification on timeout. Created with: gclient setdep -r src/third_party/catapult@c5f5b9e95179 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056214 Tbr: nuskos@google.com Change-Id: I45c2d156d59b32b01593a4a83ffcae2e9be7a8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093113Reviewed-by:
-
Sophie Chang authored
Bug: 1050101 Change-Id: I3cb44dc5fd903b60a55a2850e43179ef78ff253d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090510 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#747993}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b0124fec65c..cf573d844da6 git log 1b0124fec65c..cf573d844da6 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 chinmaygarde@google.com Prepare texture for cross context usage when using the Metal backend. Created with: gclient setdep -r src/third_party/skia@cf573d844da6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I799eb9fef00100c1c9621ddb1fc3269645024a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093111Reviewed-by:
-
Marijn Kruisselbrink authored
When restoring a handle from IDB it won't be readable. If a website then requests write access we need to prompt for both at the same time. This CL implements this by removing a now invalid DCHECK in NativeFileSystemHandleBase and adding support to NativeFileSystemPermissionRequestManager to combine two requests into one prompt. Bug: 984769 Change-Id: Ib1574c8142943adc412e7310505b63fc061f4557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092189 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#747991}
-
Ken Rockot authored
This introduces support for typemaps specified as GN targets, with new cpp_typemaps and blink_cpp_typemaps variables that mojom() targets can used to reference their typemap rules. The underlying work to use the typemap configuration is shared with the existing typemap infrastructure, but the net result is that we no longer need separate .typemap files or global "bindings configurations" once everything is converted to this approach. Bug: 1059389 Change-Id: Id2e5fe765d3c7600a3f50e337fb693f1b3a3cc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090716 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747990}
-
Ryan Hansberry authored
Bug: 953149 Change-Id: I9c06047e68b0dd2d4bd713dca0b6241d704e6847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089993 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#747989}
-
Noel Gordon authored
The asset is not used after CL:2093072. Tbr: alex Bug: 1035691 Change-Id: I719a15922acde88a4d0d4d1641e97d345dd7bc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093071Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747988}
-
Daniel Libby authored
This change adds a policy for ScrollToTextFragment, and plumbs a content switch down to blink, where it is used to override the state of blink::features::kTextFragmentAnchor. This policy is not marked as dynamic_refresh, since the values are set early on in renderer startup, with no ability to change dynamically. Bug: 1055513 Change-Id: I28aae1eb036e94d68974423c871b1d806275d03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083383Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747987}
-
Avery Musbach authored
The argument to base::UserMetricsAction should always be a string literal. See the comment where base::UserMetricsAction is defined. Bug: 872319 Change-Id: I1b9de6000b06f51df5c429c3ceabf49607ef8a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092874Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#747986}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/727115e42480..83e394a59e78 Created with: gclient setdep -r src-internal@83e394a59e78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1059158 Tbr: jbudorick@google.com Change-Id: I56b758926d24c7d7c3048075207eb5d34ebb6749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092714Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747985}
-
Daniel Clark authored
This change moves the logic for handling highlight-on-hover for cells in date controls out of the JS and into :hover CSS rules. I'd originally planned for this work to wait until the old form controls implementation was removed. However, the highlight-managing code is setting ARIA attributes in a way that doesn't make sense now that the highlight positions no longer drive selection and are merely decorative. So as part of improving the screen reader experience for these controls it seems best to go ahead and do this work now. The highlight-managing code is now all effectively dead code when FormControlsRefresh is enabled that can be straightforwardly chopped out when the time comes to remove the old implementation. A follow-up change will ensure that the correct ARIA attributes are set for selection changes. Bug: 1046054, 1053798 Change-Id: Ie5081ef23b308a82bfc03887f96c912a82f411b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083866 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747984}
-
Ian Wells authored
Add StreamModelUpdateRequest and functions for converting wire protos into store protos Bug: 1044139 Change-Id: I243ebabc331884500dec480c69d843d38546a34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020545 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#747983}
-
Henrique Nakashima authored
CachedFeatureFlags should not have feature-specific code. Move the code in it related to Start Surface to a new class StartSurfaceConfiguration. Since many other packages check whether the start surface is enabled, the class is public. Bug: 1012975, 1058104 Change-Id: I3ee516ca4cab32f1b0f727192f0a32dfdbf3f050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070967Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#747982}
-
Xinghui Lu authored
Based on the comment in https://crrev.com/c/2067462, to make the implementation of remote database manager and v4 local database manager consistent, remove the NOTREACHED() in the CancelCheck method. Bug: 1050859 Change-Id: I1bf9bbc5ec76864274085c57e3e4e98a8622bebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083569Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747981}
-
Chris Davis authored
This change removes a number of static initializers throughout the codebase. In most cases, code was moved to a function that returned a reference to a local static which is created on demand. I also made upstream changes to unrar, openvr and openxr which had static inits in their code which were appearing in chrome.dll. I am including the changes for unrar since that code doesn't get updated locally and the codebase had diverged with local changes. Bug: 341941 Change-Id: I3de5b282b0243dda86fa913f2677794373ae5c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088955Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747980}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ib823528514afe8743c6af5a055a8c7923e90ef95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089697Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#747979}
-
Xianzhu Wang authored
The '_ms' postfix was redundant with the 'ms' unit of the measurement, and was inconsistent with other record_time measurements. This is a safe rename because the measurement is neither used nor monitored anywhere. Change-Id: Ibe8d72c41b6116213e0cddbd61085bd9e438474b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092672Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747978}
-
sauski authored
As part of the Friendly Settings Privacy settings redesign the "Do not track" toggle is being moved to the cookies page. To make moving cleaner this CL first creates a new custom polymer element and tests encompassing the toggle and the associated dialog. The new element is then placed in both locations in sections whose visibility is already controlled by the privacySettingsRedesign flag. Bug: 1032584 Change-Id: Id3190592989174fa7a0c51f7263844a1326e7ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092136Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#747977}
-
Philip Rogers authored
This reverts commit 3088046f. Reason for revert: Suspected as causing a ProxyCommit regression. Original change's description: > Skip commits for painted scrollbar thumb movement > > Painted scrollbars are used for overlay scrollbars on MacOS. Thumb > movement would cause a commit on every scroll change because the update > rect (set via Layer::SetNeedsDisplay) would change. This patch ignores > the update rect in PaintedScrollbarLayer::Update and uses part > invalidation for causing commits. With this change, scroll offset > changes do not cause commits. > > Bug: 1048384f > Change-Id: I79bac7fbd9756cb71af7c3b83be3df824dd7a5cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078847 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745544} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048384f, 1059436 Change-Id: I7e6e36fca7afecae35d969ca655965984a90e891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092185Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747976}
-
Ben Joyce authored
Bug: 1052460 Change-Id: I301486ab2d3e9c84decfca20333968c48a8ce50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090365 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#747975}
-
Xianzhu Wang authored
It contained only one demo test. Remove the benchmark because https://chromium-review.googlesource.com/c/chromium/src/+/2090977 makes record_time_partial_invalidation work for all web pages. Most of the changes in this CL were automatically generated by tools/perf/generate_perf_sharding.py. Change-Id: Iff8d805d83b845b03890af3113c0024f1e2c879f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092178 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Mei Liang authored
Change-Id: I45a9c08d8846f5e9c4dca549a23cddb85b4bc3b1 Bug: 1059299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092120Reviewed-by:
-
Regan Hsu authored
There is currently a delay in disabling the 'Confirm' button when the user submits a new PIN. While the PIN is asynchronously updating, the user can also continue typing into the PIN field. This CL disables the (1) 'Confirm' button and (2) PIN keyboard when the user submits a new PIN. The 'Confirm' button and PIN keyboard are re-enabled after the asynchronous update completes. Fixed: 1054322 Change-Id: Ied13b3b57bde18e9279d2f3a7bc02e3ad4188bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085595Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747972}
-
Karan Bhatia authored
This should be helpful to diagnose if the per-rule memory limit should be changed. BUG=974391 Change-Id: I42d5630ba9d1dde40fb963f13d9513cdbe7ca893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084676 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747971}
-
Noel Gordon authored
Follow-up to CL:2090553. Caret icons should be a 20px x 20px box based on the spec, so give them 20px CSS height and width. Add display so we can CSS transform the caret box as a unit. The -webkit mask-image arrow_left.svg used as the caret box background has SVG viewport 20px x 20px and 20px width/height attributes. No need for a -webkit-mask-position: center [1]. For RTL, read that from the main page HTML element (:host-context) and CSS transform the caret box with rotate(-180deg) when in RTL. Manually tested that it rotates correctly for <html dir=rtl>. [1] Visually, the arrow-left.svg content does not seem to be perfectly centered of its SVG viewbox. The content appears shifted slightly left to my eyes. Possible bug in that SVG icon, just noting. Asset images/files/ui/arrow_left.svg added in CL:2090553 is now unused and will be removed in a follow-up CL. Tbr: alex No-Tree-Checks: true Bug: 1035691 Change-Id: Ida53f6885be1f991cc285af5b19e5cba2d8ee365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093072Reviewed-by:
-
Luum Habtemariam authored
Print preview currently has a constant maximum copies allowed (of 1000). Since we're now reliably getting the max copies supported from each printer, this change plumbs that max to the print preview UI and errors the user appropriately. Main changes: - Added separate CopiesCapability and CopiesTicketItem representations, as per the spec (https://developers.google.com/cloud-print/docs/cdd#cdd) Bug: chromium:1027830 Test: manually confirmed behavior and tests pass Change-Id: Ibcf53b9a43328e1846fd485c2e300420832499a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055351 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1a5c7a16ba71..03ed5f6c4698 git log 1a5c7a16ba71..03ed5f6c4698 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 ianelliott@google.com Revert "Instantiate rx::DisplayEGL when device type EGL is selected" Created with: gclient setdep -r src/third_party/angle@03ed5f6c4698 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Ie7d11850c370716d5186f2e72e3e3a6623bfef53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092712Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie80da210c1aacbf4bcb7424550165efdc2173996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092991Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747967}
-
Xianzhu Wang authored
Instead of invalidating an element with specific element id which workred for one test only, now skip cache of display item and subsequence at pre-defined intervals, which works for any web page. Remove benchmark rasterize_and_record_micro.partial_invalidation which contained only one demo test and was not monitored. I plan to replace record_time with record_time_partial_invalidation for rasterize_and_record_micro.* benchmarks in the perf sheriff monitor list. Change-Id: I6515d08ac56b21573b1ba6986fb1cb2a00221c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090977 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c46171246cf5..97c0ebd7cc1e git log c46171246cf5..97c0ebd7cc1e --date=short --first-parent --format='%ad %ae %s' 2020-03-06 mathias@chromium.org Reland "Support emulating vision deficiencies" Created with: gclient setdep -r src/third_party/devtools-frontend/src@97c0ebd7cc1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003700 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I12ed8ed86c37e138cd5ce2d58e9a45e54e677c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092456Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic89a35f09601c47e069ba395f1b911fed30e64d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092082Reviewed-by:
-
Michael Spang authored
It's an error to enable VULKAN without exposing fuchsia.vulkan.loader.Loader in the sandbox. The rest of the flags are still ignored and left as a TODO. Bug: 1059497 Change-Id: I96a4c1f51b5ee76f5df075a53afd92e029169f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093052 Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Michael Spang <spang@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#747963}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b3bfbaa3217f..0c5c7ea9e66a git log b3bfbaa3217f..0c5c7ea9e66a --date=short --first-parent --format='%ad %ae %s' 2020-03-06 ericlaw@microsoft.com [NetLog Viewer] Show loaded filename in title Created with: gclient setdep -r src/third_party/catapult@0c5c7ea9e66a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058919 Tbr: nuskos@google.com Change-Id: I68761464e70c45ad6ebd880671f83183d63afc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092453Reviewed-by:
-
