- 14 Dec, 2020 40 commits
-
-
Erik Chen authored
This CL has no intended behavior change. Change-Id: Ic05292cb7f620cd02e2950bee17b48c0ae69b725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585541 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#836742}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607925234-871dfb77196d03b9fcef95521dbd7963c906e6ee.profdata to chrome-linux-master-1607968714-2c0d8e306c302723844f6b00a98bd81e984a44c7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib9a429aa2088d617b48f40e524d685fd5c005259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836741}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c16dc7107fd3..7a0ca4ead94d 2020-12-14 capn@google.com Check that MSan builds use Clang If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I7ce57becb74239967bd0403f4e840cbea83b7656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836740}
-
James Cook authored
Better document which kinds of "apps" use this type. See also go/cros-app-types Bug: none Change-Id: Ia6b799915bc17a40ea151a9feda5a2e2da7ec3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587869 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836739}
-
Jeffrey Kardatzke authored
BUG=chromium:1158107 TEST=Fuzzer test passes Change-Id: I8451e40e0ac5e89059e336618ebe2ed737ef96c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585823 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836738}
-
Leonard Grey authored
Bug: 1152274 Change-Id: If300d7e0fd0c39d56d4918ba0a414d93b88b7c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587375Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#836737}
-
Xi Han authored
Records Suggestions.Tile.Tapped when tapping on an MV tile in Start. Bug: 1033257 Change-Id: I720f8a987c37e6fa1a11751652cd1efe0f235a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590284Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836736}
-
Jeffrey Kardatzke authored
BUG=b:153111783 TEST=Encrypted HEVC playback works w/ clear testing flag enabled Change-Id: I08372658b04c2cadf2b6d032e619406ea05516e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587521 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#836735}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I50af9c054ccff43951ff6897e6a9dea04d93b2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836734}
-
Gayane Petrosyan authored
cleanup() should have also been called after line:79 when iframe is detected. Bug: 1157974 Change-Id: I505fa12a82a17da4f3a2ae6dcd239c0f0613be59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588644Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#836733}
-
Fredrik Söderqvist authored
Similarly as for effects. 'clip-path' is (sometimes, if mask) applied via PaintLayerPainter, and we need an SVGResourceClient for it to manage resources properly (respond to clip-path changes etc.). See also crbug.com/892734. Bug: 1158417, 1028063 Change-Id: I2aae303c6dcbf9bd5964bf40253a7fa7cb733058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589876Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#836732}
-
Sunny Sachanandani authored
When rendering HDR video/texture quads, SkiaRenderer disables implicit color conversion in Skia by making the SkImage color space match the destination color space. After the above fix was landed, an old DCHECK was left in accidentally. This CL fixes the incorrect DCHECK. Bug: 1153917 Change-Id: I1ba9da4ae4a78090fb3e96d3196cc141a0b6618a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587831Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#836731}
-
Shuran Huang authored
This reverts part of the code in commit 57f97b28. The reason is that, based on mmenke@'s comment in crrev/c/2570123, copying the whole set once per saved cookie for comparison is generally not worth the overhead, should use an enum class object instead. Bug: 1136102 Change-Id: I3bcc07a84d64e8ce55fb999567e154fdbfe43443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580461Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Shuran Huang <shuuran@chromium.org> Cr-Commit-Position: refs/heads/master@{#836730}
-
Corentin Wallez authored
TBR=ynovikov@chromium.org Bug: chromium:1136231 Change-Id: Ib05d4463514e29bc4827b32a10ac6459011043b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590039Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#836729}
-
Ravjit Singh Uppal authored
As part of one time permissions for Geolocation on desktop, updated the Content Settings Bubble and Site Settings page to reflect the change. Bug: 1150347 Change-Id: I6d13c59315a60fdf64a4ef54d52a2b7882f752a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544889Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#836728}
-
Tom Anderson authored
This is needed so //ui/gfx/x/ can register event dispatchers. BUG=739898 R=sky Change-Id: Iacff98f103a1a0094f6e11e0453da20580b3aeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585750 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#836727}
-
Nate Fischer authored
No change to logic. This adds laisminchillo@ to support_library OWNERS. She has already reviewed several changes to this directory and has been a committer for quite some time. Test: N/A Change-Id: I2920f0b4fa2e39c800d97217b13ef1d478d5751e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589639 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#836726}
-
Joe Downing authored
When you install the CRD Host MSI and the website is open to either /access or /support (after generating a code), the install will appear to be successful but the user will get a warning that they need to reboot their machine. This is because although the files were removed, the website is using the old NMH processes which are still in memory. To prevent this error (and to ensure the new NMH are being used), we can run taskkill as a custom action to close the in-memory instances of the Me2Me and It2Me native messaging hosts. This will prevent the error from being displayed. The user will needed to refresh the website if they are in this state, but they won't be running old code. Bug: 1003606 Change-Id: Ia6355942acb154eaabf2b2a7d84a5250e9d1a1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587619Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#836725}
-
Emilio Cobos Álvarez authored
Couldn't help myself when I noticed this bug with ::file-selector-button. Fixed: 978105 Change-Id: I42da51ffa7117e0d4ecd55e2e12fbb7548571378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587042 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#836724}
-
Wei Li authored
Bug: none Change-Id: I387f48a86be50c70c10d107d30c6b35328a3b7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587766Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#836723}
-
Clark DuVall authored
With isolated splits enabled, the classes from a DFM will not be available in the base ClassLoader. This change makes sure all of the calls to inflate in autofill_assistant are able to access the classes defined in the DFM. Bug: 1158028, b/174219371 Change-Id: I6e6599f0831b089d97d5041864ce9df41c00e0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587872Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836722}
-
Dylan Cutler authored
private. This is part of a larger effort to make CanonicalCookie's generic constructor private. This CL replaces uses of the constructor with the factory CreateUnsafeCookieForTesting. This factory is meant for test-only code and should not be used in production. Bug: 1102874 Change-Id: I842f1d66d746bffe17bc060c2554ba1e269d3774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588647Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#836721}
-
Abigail Klein authored
This ensures that the tab strip name is announced when it is focused by the accessible pane manager. Bug: 1097760 Change-Id: Ieba4986c83ae750feb3c4b0690a3d0bc6eca39d7 AX-Relnotes: Tab strip is named "Tab strip". Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588892 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#836720}
-
Kyra Moed authored
Implement multipage PDF file format saving capabilities atop PNG to PDF image format conversion. Bug: b:161237869 Change-Id: Ib74311185a3e4a6535b88042f203db956a77669a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580363 Commit-Queue: Kyra Moed <kmoed@google.com> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#836719}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d0f99d5405b4..3df29be28445 2020-12-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from c594de23cdd7 to c0bcfaf3bae9 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I8a95ab819cb16357199bc42ab10f293f8dda3333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588616 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836718}
-
Aaron Leventhal authored
Hypertext is updated when a node changes, or on a parent of a textnode that changes. There are some cases where the hypertexts do not match the available children. In some cases this results in returning a null hyperlink, because cached data in AXHyperText was stale. A DumpWithoutCrashing() was added to help narrow these situations down, and the situation occurs quite often. The problem is that when AXPlatformNodeBase::UpdateComputedHypertext() is called, IsLeaf() is not updated nor are the platform children. This occurs because although the SendPendingAccessibiityEvents() has sent an updated root, the change for the root is not merged with other changes (TreeUpdatesCanBeMerged() returns false for any root update, even if it has the same id as the previous root). This causes all updates to be processed separately. When the root is processed, other updates have not yet occurred and the root object still appears to be a leaf. Other possibilities to fix this: - Do not send root_id in an update unless it's actually a new root. This may not catch all cases of the issue, but perhaps it's a good thing to do anyway. - Allow updates to be merged, even when there is a change on the root. - Compute hypertext on demand and memoize, so that it's computed after all atomic updates are finished - Instead of calling OnAtomicUpdateFinished() at the end of AXTree::Unserialize(), return the updates back to the caller and allow the caller to collect the updates and process a single call to OnAtomicUpdateFinished(); With any of these alternate approaches, it should be possible to remove the logic to ensure hypertext updates on parents in CollectChangedNodesAndParentsForAtomicUpdate(), because the renderer already sends parents nodes to the serializer with ChildrenChanged or TextChanged(). Bug: 1157731 Change-Id: I4e9eefa9b0f90d80daa1b7db2305ca92caaf32b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587371Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#836717}
-
Kinuko Yasuda authored
Bug: 1010491 Change-Id: Ic86d00d46d6dad7a0f3db31562e68e268273c496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586454Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#836716}
-
Leonard Grey authored
Bug: 1152274 Change-Id: I81358a8df4b853654ba031bce0a251ed8445a8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586156 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#836715}
-
Adithya Srinivasan authored
Change-Id: If231540e44354a1dcf1c4d8e8e4deb13516b3059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589913Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#836714}
-
Julie Jeongeun Kim authored
This CL replaces base::Contains() and find() with one find() call for the map lookup avoid performing a double map lookup from |process_mojo_map_| in extensions::RendererStartupHelper. Bug: 1157200 Change-Id: Ie16f2269fa0ad70d22e81c9f7018a172105b63ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588671 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836713}
-
Stephen Chenney authored
This unblocks moving the study to Beta. Bug: 1120345 Change-Id: I9c74480ae41d45aa4d1647f5848367ff89bd0a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586122Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#836712}
-
Dylan Cutler authored
constructor is private. This is part of a larger effort to make CanonicalCookie's generic constructor private. This CL replaces uses of the constructor with the factory CreateUnsafeCookieForTesting. This factory is meant for test-only code and should not be used in production. Bug: 1102874 Change-Id: I548be72deb5985faa27d7a0dd5119f3fa8e185f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590056Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#836711}
-
Jeroen Dhollander authored
This will allow us to easier move this class to the Libassistant mojm service. All dependencies have been moved to the new class |AudioInputHost|. This class currently talks directly to |AudioInputImpl|, but later it will instead talk to the mojom APIs. Some notes: - |AudioInputImpl| still depends on |AssistantClient::Get()->RequestAudioStreamFactory()|, because the Libassistant mojom service will also use an audio stream factory to open/close its audio input. In a follow up CL I will introduce a delegate to sever this dependency. - There is one behavior change: |power_manager_client_->NotifyWakeNotification()| was previously only called when DSP was enabled, and it is now always called (when Libassistant starts a conversation). I can think of no reason why this would be an issue. Bug: b/171748795 Test: chromeos_unittests, deployed on real hardware with and without DSP. Change-Id: I119521c7a72bf5361019d70240c02ba47a23d6ad Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582537 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836710}
-
Victor Costan authored
This CL reduces the places where the IO thread is plumbed through the IndexedDB browser-side implementation. This is intended to reduce the cognitive effort of moving IndexedDB and its QuotaClient to the Storage Service. This CL relies on the following observations: * IndexedDBBackingStore::io_task_runner_ was unused. It can be removed. * QuotaManagerProxy can be used on any thread, and proxies the calls to QuotaManager on the IO thread. * IndexedDBContextImpl::io_task_runner_ was used via IndexedDBContextImpl::IOTaskRunner() in QuotaManagerProxy invocations (covered above) and by IndexedDBDispatcherHost. Moving it to IndexedDBDispatcherHost::io_task_runner_ clarifies its use. No functional changes are introduced. Bug: 1015214, 1016065 Change-Id: I79ccd5540f4ef5b3b8e387ab335aab656e6e0478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587796Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836709}
-
David Van Cleve authored
The org.chromium.url.Origin class is a user-friendly wrapper around an org.chromium.url.internal.mojom.Origin, which also happens to be the type one obtains from Mojo-generated interfaces in Java that take url.mojom.Origin in their .mojom definitions. In order to make it possible (or, at least, explicitly "supported", without the stigma of accessing fields of a class in an "internal" namespace) to manipulate the origins obtained via these code-generated interfaces, this CL adds a new url.Origin(url.internal.mojom.Origin) constructor. In the long run, it would be best if Mojo could just give us the user-friendly type instead of the "internal" type: that's also tracked in the associated bug. Bug: 1156866 Change-Id: I2e52feaca9bbd6c5514a15b07c27e7300c8e34e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586327Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836708}
-
David Maunder authored
Apply batching to CriticalPersistedTabData tests so that they run faster. Speedup: 3984 ms -> 2676 ms (33% improvement). Bug: 1152295 Change-Id: I0054ef160bf969d3c1ab4be6851743a7c76a6e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587518Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#836707}
-
Saurabh Nijhara authored
This reverts commit b886f7f1. Reason for revert: The enum values are not in sync with the error codes in update engine code. The update engine team wants to first correct the enum before adding more values to it. This change needs to be re-landed after the enum is corrected by the update engine team with correct enum value. Original change's description: > Add enum value for error update download canceled per policy > > This CL adds error code for update download canceled due to > DeviceAutoUpdateTimeRestrictions policy to the > enum so that it can be reflected in the histogram. This error code is > already added in update engine code in the following CL - > https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2567121 > > Bug: chromium:1117450 > Change-Id: I69d109553c28a4948d725183293640d8eb044731 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584984 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Saurabh Nijhara <snijhara@google.com> > Cr-Commit-Position: refs/heads/master@{#836042} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1117450 Change-Id: I8bf8eb277af123d8a220a1ea1bf488df059c2eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587729Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#836706}
-
Joel Riley authored
Previously disabling word highlighting caused focus ring to highlight individual nodes instead of paragraphs, which caused the navigation control panel to bounce around too quickly. Bug: 1157941 Change-Id: I3f73ac13f8595df9ceb5c205e1fb0c1041654931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587489Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#836705}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/bd6d8e4204b5..a3edbfa983ba 2020-12-14 wl@gnu.org [type42] Pacify static analysis tools (#59682). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I0aa14a64c054fe60cd58df829b868aa36033c990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#836704}
-
Andrii Shyshkalov authored
R=gbeaty Change-Id: Ic567bb94e9505b5e5b3f5f6c7908652fc00da20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589318 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836703}
-