- 26 Sep, 2019 40 commits
-
-
Yasmin authored
Bug: 1005813 Change-Id: Ia88ff78c8167025bc054c1293616d8e157167dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824109Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700171}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1619d75c48d5..6d92ddf0280a Created with: gclient setdep -r src-internal@6d92ddf0280a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1006258 Change-Id: Ib6faab5530ea9a57f3013bbbfed556f969c2a824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826166Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700170}
-
Justin Cohen authored
This reverts commit 0cdaecb6. Reason for revert: This is fixed in iOS 13.1 Original change's description: > [ios] Double up experimental settings to work around iOS13 crash. > > This is for test only. > > Bug: 993298 > Change-Id: I1ad64dc60828040403be5bc0e8265d89c1ddf60c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757311 > Auto-Submit: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688586} TBR=rohitrao@chromium.org,justincohen@chromium.org,srikanthg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993298 Change-Id: Ib9f66e4d155b3836847fb379551fbc6fd4e02c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823870Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#700169}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f703443b1f67..442ff2ebbd66 git log f703443b1f67..442ff2ebbd66 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 527a689307a4..510ca9d616f5 (6 commits) Created with: gclient setdep -r src/third_party/angle@442ff2ebbd66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: Ia813040d738d175e15a4d83e42a3d533d7cf54f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700168}
-
Stepan Khapugin authored
On iOS 12, and on iOS 13 with no multiwindow plist keys, iOS doesn't create a SceneDelegate, which would normally take care of creating a SceneState and a SceneController. Do this in AppDelegate. Bug: none Change-Id: Iaa3f505bbe588f75a9fe1c3728c773ba82e32162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789536 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700167}
-
Matthias Körber authored
TBR=mkwst@chromium.org Bug: 875768 Change-Id: I5158a8144d87584a844071aee35ce44b9119369b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824475 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#700166}
-
Jan Krcal authored
This CL increases the icon size (in non-touch-ui) from 20dp to 22dp. This is the maximum size that can be achieved for a 28dp element while having 1dp border and 2dp padding, as required by the UX specs. This change only applies for the kAnimatedAvatarButton feature. Bug: 967317 Change-Id: I81a6a7fe07d7469f61f933afbcd25a7f9389df5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825519 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#700165}
-
Sadrul Habib Chowdhury authored
The flag guards against variable-shadowing. More details in the bug. Bug: 794619 Change-Id: Ib430e00a3704c6fe6696efdaad1696a4434455d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825621 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#700164}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/527a689307a4..510ca9d616f5 git log 527a689307a4..510ca9d616f5 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 alanbaker@google.com Only allow previously declared forward refs in structs (#2920) 2019-09-25 stevenperron@google.com Handle id overflow in wrap-opkill (#2916) 2019-09-25 afdx@google.com spirv-fuzz: do not replace struct indices with synonyms (#2915) 2019-09-25 afdx@google.com spirv-fuzz: Fixes to preconditions for adding dead break/continue edges (#2904) 2019-09-25 afdx@google.com spirv-fuzz: do not replace a pointer argument to a function call with a synonym (#2901) 2019-09-25 afdx@google.com spirv-fuzz: do not replace boolean constant argument to OpPhi instruction (#2903) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@510ca9d616f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: I3561eb243b413d2cd4b4b0b172ec15b5aec99d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826162Reviewed-by:
-
Matthias Körber authored
Bug: 1007974 Change-Id: Ifa3e548a7b7987a3782bd70568389126a77de74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825217 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6150156d. With Chromium commits locally applied on WPT: 561a338c "Convert SensorProvider client to use BrowserInterfaceBroker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I37b168482514e3c1c811c236eac501421b4cb52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823761Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700161}
-
Hirokazu Honda authored
Bug: 935411 Test: VP9 HW decoder is used for VP9 SVC stream with Hangout Meet on atlas and zork Change-Id: Ic94fe9bb0a6cc666abc94deb265ec3de6e270e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809005Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700160}
-
Christoph Schwering authored
Removed autofill: :DeserializeFormDataFromBase64String() autofill: :SerializeFormDataToBase64String() Change-Id: Id393ecde0d134d9d03836ec1c6be0c053ef1bf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824082Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#700159}
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I5c45d9089a02844e0043e314e69cb57058b33b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798666 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700158}
-
Christian Dullweber authored
To correctly block access to shared workers in nested iframes, they should consider a SiteForCookies and not just the origin of the top-level frame when checking cookie access. RenderFrameHost changes were originally written by morlovich@chromium.org Bug: 989926 Change-Id: Ifac24a89717ea782d15bf3479f54e5cd50e41917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816545 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#700157}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/692a818a2c79..505d23409c8d git log 692a818a2c79..505d23409c8d --date=short --no-merges --format='%ad %ae %s' 2019-09-26 primiano@google.com Merge "Always use O_BINARY on Windows, to avoid silly EOL translations." Created with: gclient setdep -r src/third_party/perfetto@505d23409c8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I39636ae1bc9b790484ab034973d47cc3a812fe1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826161Reviewed-by:
-
Hiroki Nakagawa authored
ServiceWorker: Force WebServiceWorkerInstalledScriptsManagerParams to initialize its members on constructor This is a follow-up CL for: https://chromium-review.googlesource.com/c/chromium/src/+/1824511/4/third_party/blink/renderer/modules/service_worker/service_worker_installed_scripts_manager_test.cc#145 Bug: 938219 Change-Id: I6c93323d666f2f2b9feeae296e52799301156bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826068Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#700155}
-
Finnur Thorarinsson authored
This reverts commit bb636093. Reason for revert: Unfortunately, this CL also breaks the same bot I mentioned in my previous revert. See: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 If you look at build 83404, that's where ProtoBackgroundTracingTest.ProtoTraceReceived is no longer failing (because that's where my revert kicked in). But then you relanded your change in build 83427, and the test started failing again. Please address this issue before re-landing this CL. Original change's description: > tracing: Add process descriptor in traces > > Adds process descriptor to traces. Currently only in privacy filtered > mode. This will be fixed after JSON exporter handles multiple pids. > > Change-Id: Ie1db96d891aa3124e9704b61c546ebf5de5e48eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711085 > Commit-Queue: ssid <ssid@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700104} TBR=oysteine@chromium.org,ssid@chromium.org,eseckler@chromium.org Change-Id: I184391fa8bd6d1f8275a8b1025c1c12a09c70275 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826897Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#700154}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b3ae56238672..dd2bd9ef0665 git log b3ae56238672..dd2bd9ef0665 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 ulan@chromium.org [metrics] Add metrics reported by page Created with: gclient setdep -r src/third_party/catapult@dd2bd9ef0665 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1007178 Change-Id: I85df9d2d025850e262c56837a60874fdbe83e79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826160Reviewed-by:
-
Ricky Liang authored
Currently throughout the Chrome and WebRTC stack we implicitly assume that the camera frames are pre-rotated to the display orientation. This CL allows the CrOS VideoCaptureDevice to pre-rotate the GpuMemoryBuffer-based camera frames. Rotate the DUT UI and verify that the frames are displayed / encoded correctly. Bug: 982201 Test: Manually test on DUT using Chrome camera app and WebRTC apps. Change-Id: I7f7a6d470280200ea89f60ca3dcbe8f521756e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824760Reviewed-by:Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#700152}
-
Rune Lillesveen authored
This reverts commit c689a99e. Reason for revert: See comments from estade@ in: https://chromium-review.googlesource.com/c/chromium/src/+/1821782 Original change's description: > Make dark theme Gtk affect preferred color scheme. > > Selecting a dark Gtk theme gives a dark NativeThemeGtk and UI, but it > didn't affect the preferred color scheme on the web instance. Hence, the > prefers-color-scheme media query still matched 'light', not 'dark'. > > Observe the ui native theme instance to propagate any theme changes to > the web instance. Code copied from the NativeThemeWin implementation. > > Bug: 998903 > Change-Id: I204bf8a4f73b60ddc227e4de75af4aa31a4a07d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774922 > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691358} TBR=estade@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 998903 Change-Id: I7cad45498a8ae6c50c963015037fe14b9cf67f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823856Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#700151}
-
Miyoung Shin authored
This change converts SpatialNavigationHost mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I21e9a3456b5e55b7e69907c7ae24d6d1e5d8364b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824504 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#700150}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a5bb612e624..731ce5cd88f2 git log 9a5bb612e624..731ce5cd88f2 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@731ce5cd88f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I3d7cfe7cde747b3d53bbea9b8a2e0a11435b54f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826181Reviewed-by:
-
Austin Tankiang authored
This dialog was only relevant to the legacy drive sync client, so remove it. Bug: 1003238 Change-Id: I0df8b043f585916684f019af62bfd0c9ca238a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819287Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#700148}
-
Guido Urdaneta authored
Bug: 1008005 Change-Id: I8b4361012430447010ec98bf19cddf79638378fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824107Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#700147}
-
Roman Sorokin authored
I believe it causes flakes of kiosk browsertest which use this helper Bug: 1008290 Change-Id: I883a18445b4bbc8d4db6a2901f61c7eb5bf5f8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826478Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700146}
-
Rune Lillesveen authored
The select popup background uses the "menu" system color as its background color. Make sure it's based on the used color-scheme. Bug: 939811 Change-Id: I2e57ac5fac8938e9bfcbe1460a9e78fdb33191bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824472Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#700145}
-
Oriol Brufau authored
The test failed due to issue 942811, which was fixed in https://crrev.com/c/1796323. But it was still marked as failing for non-LayoutNG. Bug: 942811 Change-Id: I8f346f07591709d1abccaabd24505a66864b5321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824113Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#700144}
-
François Beaufort authored
This CL simply set the default value of vertexInput in GPURenderPipelineDescriptor to an empty dictionary as specified in https://gpuweb.github.io/gpuweb/#dom-gpurenderpipelinedescriptor-vertexinput Bug: 877147 Change-Id: I3e8d8fe42217a563b133767319d9695d21683186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824884 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#700143}
-
Fredrik Söderquist authored
It seem unnecessary that every client should need to handle this (potentially forgetting to) - especially since what is needed is to call back into ImageResourceContent which in turn checks with its observers. Move this call so that it happens just after the ImageNotifyFinished() notification, and then merge that whole sequence (which happens twice) into a new method HandleObserverFinished(...). The existing MarkObserverFinished(...) is merged into the new method since it is its only caller. Change-Id: I00fe6c4b31ee7499e7b89c4b2881beaeab95783d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824893Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#700142}
-
hyunjune authored
This patch fix up typo to replace 'becase' with 'because' on the comment. Change-Id: I645c741892531f105189bfac001ff7fb70cd8105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824733 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#700141}
-
Mohamed Amir Yosef authored
After recent refactoring, this class isn't needed anymore! Change-Id: Ib2e4b5c4420ccea6d949d2bfc9fa3d897768b7d5 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823875 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Renato Silva authored
This commit adds an empty space between the cr-toggle and the end of the field in the Polymer element 'oobe-a11y-option'. Without this space, the ripples created by the 'cr-toggle' would overflow to the right, creating an unnecessary horizontal scroller. Tested locally. Bug: 887866 Change-Id: I698da984fa75bae198395aa55150d433ad79d10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825218Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#700139}
-
Rafał Godlewski authored
Fixes wrong range calculation of the bold part of the message in one variant of leak detection dialog. Bug: 1007992 Change-Id: I1fb63a3005ecd442edeb0622e668c7f027a85762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823943Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Rafał Godlewski <rgod@google.com> Cr-Commit-Position: refs/heads/master@{#700138}
-
Mihai Sardarescu authored
In M77, showing the signed-in account view was disabled due to the fact that the preferences used to compute authService->HaveAccountsChanged() were not correctly updated (see crbug.com/1006717). To avoid user confusion, it is important to avoid showing the signed-in accounts dialog on the first session after an update from M77 in order to allow the authentication service to update its internal preferences. Bug: 1007899 Change-Id: I81aa30beee0fe6c108724e83bc62e462c2f92994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824259 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700137}
-
Henrik Grunell authored
Bug: None Change-Id: I65b1cf1d76e1d29d10179839a17dab635e7db98f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825521Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#700136}
-
Xiaocheng Hu authored
Note that the test failures are due to an existing bug crbug.com/1008146 that we fail to sort terms in a summation in the serialization. The bug is orthogonal to the implementation of min/max. Bug: 978682 Change-Id: Ieb04637427bdd7ba30e3bed82036d098598b6bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824835 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Note that the test failures are due to an existing bug crbug.com/1008146 that we fail to sort terms in a summation in the serialization. The bug is orthogonal to the implementation of min/max. Bug: 978682 Change-Id: I0407fd40488f8e1a262e697977a9b80e22f9788c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825726Reviewed-by:
-
Fredrik Söderquist authored
The transform for <svg:image> was not being updated properly when the reference box was changed. Bug: 1007146 Change-Id: I39e73105e4a2d284afd1588e38eb8ff90e45c6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824271Reviewed-by:
-
Xiaocheng Hu authored
The existing code is too aggressive in simplifying calc() expressions that, math functions (min/max etc) can be simplified away when they can be directly resolved. This doesn't match the spec (*), and is fixed in this patch. (*) https://drafts.csswg.org/css-values-4/#math-function-simplify-a-calculation Bug: 825895 Change-Id: Id5796299da50e40b09bc38bf0271c8f5cd7897de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825325Reviewed-by:
-
