GitLab

This change allows scanout buffers to be kept alive until the last of
SurfaceOzone{Canvas,EGL} and HardwareDisplayController are destroyed. For
HardwareDisplayController this means that buffers will be kept around
until the CRTC is properly restored. For SurfaceOzoneEGL this means that
on monitor disconnects (HDC is destroyed) the buffers are kept alive for
any remaining EGL operations still happening.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/393233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284708 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284707 0039d316-1c4b-4281-b951-d872f2087c98

This change fixes the following problem:
1. Run browser with remote debugging enabled (--remote-debugging-port=9222)
2. Open remote debugging front-end in the same browser (localhost:9222)
3. Inspect that front-end using built-in DevTools.
4. Go to Timeline and press Ctrl+R

Result:
Timeline recording starts automatically and never stops after reload.

With this patch:
It will stop recoding after reload.

BUG=None

Review URL: https://codereview.chromium.org/409073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284706 0039d316-1c4b-4281-b951-d872f2087c98

Pull grit 171 to get the new deps fixes required to implement this.

This removes the call to grit for querying inputs completely, and enables depfile writing to enable automatic rebuilds when things are out-of-date.

Adds a new outputs variable that bypasses querying grit for outputs. This will assert that the given files exist in grit. This version allows outputs to be empty in which case it will revert to the old dynamic behavior. I'm going to land this with just the worst cases fixed to make landing easier. Then followup with converting the rest of the grit targets and removing the dynamic option.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/407653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284705 0039d316-1c4b-4281-b951-d872f2087c98

be safe to land. Mainly adding FailureValue but not wiring it via
PageTestResults/GTestTestResults/PageRunner yet.

The remaining change will be landed separately to better isolate
the problem that caused it to be reverted.

BUG=392901

Review URL: https://codereview.chromium.org/405283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284704 0039d316-1c4b-4281-b951-d872f2087c98

Reland of https://codereview.chromium.org/404603002/ but without the problematic extensions.gypi changes.

R=agl@chromium.org, dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/400233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284703 0039d316-1c4b-4281-b951-d872f2087c98

Modify TraceEventTestFixture.TraceBufferVectorReportFull to assert the overflowed_at_ts is between the timestamp of last event and current trace_log's time.

BUG=395739

Review URL: https://codereview.chromium.org/402283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284702 0039d316-1c4b-4281-b951-d872f2087c98

R=cmasone@chromium.org,viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/407733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284701 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383609
TEST=none
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/411543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284700 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rouslan@chromium.org
BUG=395169

Review URL: https://codereview.chromium.org/408143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284699 0039d316-1c4b-4281-b951-d872f2087c98

The hpack constant table was 40-60 KB (gcc: 40 KB, clang: 60KB), for 
storing 2 KB of data. Not optimal.

By making it an ordinary static data table we save 60 KB with clang:

Total change: -64153 bytes
==========================
  1 added, totalling +2056 bytes across 1 sources
  1 removed, totalling -66215 bytes across 1 sources
  1 grown, for a net change of +14 bytes (367 bytes before, 381 bytes after) across 1 sources
  1 shrunk, for a net change of -8 bytes (10504 bytes before, 10496 bytes after) across 1 sources

and save 40 KB with gcc:

Total change: -41382 bytes
==========================
  1 added, totalling +2056 bytes across 1 sources
  2 removed, totalling -43597 bytes across 2 sources
  1 grown, for a net change of +167 bytes (341 bytes before, 508 bytes after) across 1 sources
  1 shrunk, for a net change of -8 bytes (10576 bytes before, 10568 bytes after) across 1 sources

BUG=394269

Review URL: https://codereview.chromium.org/393573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284698 0039d316-1c4b-4281-b951-d872f2087c98

Check the return values from FcPatternGet*() so unset
properties won't override the defaults from
LinuxFontDelegate. Most properties have default values
assigned to them by Fontconfig, but subpixel rendering
notably doesn't.

BUG=395014

Review URL: https://codereview.chromium.org/407763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284697 0039d316-1c4b-4281-b951-d872f2087c98

The associated bug has been marked fixed for a long time. One of the
suppressions (bug_30704f) still fires, so we'll need to file
a separate issue for it.

BUG=30704
TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/409793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284696 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284695 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/b85a0aab6905af8b329539b7573a7555b727d5e5..d09622e3d3826ec3e67d6b17dae6af2ed750f143

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/406253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284694 0039d316-1c4b-4281-b951-d872f2087c98

A memchr() search of a zero-byte range returns an undefined value.
On arm32 it always returns NULL, but on arm64 it does not.  This
causes random crashes while reading /proc/self/maps when loading the
64-bit libchrome.

Fix by setting the value to which memchr() assigns to NULL if the
search range is zero bytes.  There are three calls to memchr().  Two
of them could encounter this; the third is safe.

BUG=394306

Review URL: https://codereview.chromium.org/405153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284693 0039d316-1c4b-4281-b951-d872f2087c98

Exclude WebNavigationApiTest.* and InspectUITest.* browser_tests as they are flaky under Dr. Memory.

TBR=zhaoqin@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/407143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284692 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/381683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284691 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fsamuel@chromium.org

BUG=none

Review URL: https://codereview.chromium.org/408893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284690 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to mock_color_chooser.

BUG=331299

Review URL: https://codereview.chromium.org/404373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284689 0039d316-1c4b-4281-b951-d872f2087c98

Enforce SafetyMode for YouTube if prefs::kForceSafeSearch is on, by modifying (or adding) YouTube's PrefCookie in the HTTP header.

This is essentially a followup to https://codereview.chromium.org/11186002/

Note: This is a fixed reland of crrev.com/282546 / https://codereview.chromium.org/354183002/ which was reverted due to a bug in ParseRequestCookieLine.

TBRing since it has already been reviewed in the first try.

TBR=erikwright@chromium.org

BUG=344815

Review URL: https://codereview.chromium.org/388823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284687 0039d316-1c4b-4281-b951-d872f2087c98

Add completion callback as a parameter of PromoteDemotedChanges.
This is mainly for tests to wait for the completion of the operation.

BUG=344769
TEST=unit_tests --gtest_filter='DriveBackendSyncTest.*'

Review URL: https://codereview.chromium.org/407073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284686 0039d316-1c4b-4281-b951-d872f2087c98

Improved gesture output.

Review URL: https://codereview.chromium.org/409563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284685 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies PnaclCoordinator considerably and reduces the total
amount of code in the trusted plugin.

BUG=239656

Review URL: https://codereview.chromium.org/393693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284684 0039d316-1c4b-4281-b951-d872f2087c98

This CL extracts the GetLanguageList(), GetAcceptLanguageList and
GetLoginKeyboardLayouts() methods from NetworkScreenHandler to a helper
file. The methods will be reused by SigninScreenHandler to implement a
language and keyboard layout picker for public session pods.

BUG=214904,241790
TEST=Updated and extended unit tests

Review URL: https://codereview.chromium.org/397723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284683 0039d316-1c4b-4281-b951-d872f2087c98

Extracted LoginEventRecorder from BootTimesLoader to loose dependecies.

BUG=387613
R=nkostylev@chromium.org
TBR=bauerb@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/391373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284682 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This broke build:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/419

With error:
/mnt/data/b/build/slave/Linux_ChromiumOS_Tests__dbg__2_/build/src/out/Debug/app_shell_browsertests: symbol lookup error: /mnt/data/b/build/slave/Linux_ChromiumOS_Tests__dbg__2_/build/src/out/Debug/lib/libmedia.so: undefined symbol: Ebml_Serialize

Original issue's description:
> Clean up. Experimental user avatars removed.
> 
> BUG=387738
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284666

TBR=scherkus@chromium.org,nkostylev@chromium.org,merkulova@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=387738

Review URL: https://codereview.chromium.org/411523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318770
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/235953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284675 0039d316-1c4b-4281-b951-d872f2087c98

Ensures that buffer received from the java side are correctly aligned.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/405893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284672 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue where the clipping window would get a focus event
when the SadTab was displayed causing the focus to be set to nothing,
disabling all keyboard shortcuts.

This is fixed by making the clipping window nonfocusable.

BUG=393119

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284177

Review URL: https://codereview.chromium.org/397493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284670 0039d316-1c4b-4281-b951-d872f2087c98

This fixes building "all" on non-ARM platforms.

TBR=ben@chromium.org
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/404353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284669 0039d316-1c4b-4281-b951-d872f2087c98

Since upgrading the builder to 10.8, it never failed again.

BUG=370551
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/401103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284668 0039d316-1c4b-4281-b951-d872f2087c98

The ProfileManager can call its callback (which points to CreateProfileHandler::OnProfileCreated) with a NULL profile (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/profiles/profile_manager.cc&l=397). This case was not handled in CreateProfileHandler::ShowProfileCreationError.

BUG=395558

Review URL: https://codereview.chromium.org/405883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387738

Review URL: https://codereview.chromium.org/395133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284666 0039d316-1c4b-4281-b951-d872f2087c98

It is flakey on win bots.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/15075
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/builds/30300

TBR=achuith@chromium.org
NOTRY=true
BUG=394454

Review URL: https://codereview.chromium.org/406233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284665 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This patch seems to make following browser_tests flakey

PPAPINaClNewlibTest.Graphics2D_FlushOffscreenUpdate
NetInternalsTest.netInternalsHSTSViewAddOverwrite
NetInternalsTest.netInternalsHSTSViewAddDelete
NetInternalsTest.netInternalsHSTSViewAddTwice

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34734
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32086
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/47545


Original issue's description:
> This is jamesr@ code I am landing.
> 
> On Windows the message pump code tried to manage the systemwide timer resolution to fire delayed tasks with better than 15ms resolution but it was buggy:
> 
> 1- A short task that was not followed by any other task will leave the systemwide timer pegged to 1ms
> 
> 2- After we decided to crank up the timer we would 'lease' the timer for 1 second, for no good reason.
> 
> Both issues are detrimental to battery power.
> 
> The source of both problems is that we tried to decide with incomplete information. This patch solves that by having 1 bit for each pending task that requires a high resolution timer and a sum of the number of tasks that require high res timers.
> 
> BUG=153139
> TEST=included here, also see the bug for manual testing.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284625

TBR=jamesr@chromium.org,darin@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=153139

Review URL: https://codereview.chromium.org/407073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284664 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284663 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/412433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284662 0039d316-1c4b-4281-b951-d872f2087c98

The blink roll contains a fix to the problem, but is stale at the moment.

BUG=395882
TBR=jochen@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/405413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284661 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/404913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284660 0039d316-1c4b-4281-b951-d872f2087c98