- 06 Feb, 2015 40 commits
-
-
calamity authored
This CL fixes an issue where the experimental app list animation from the start page to the custom launcher page was janky because the bounds were being calculated incorrectly. This CL fixes the animation to use the size of the view being animated rather than the entire contents bounds. BUG=None Review URL: https://codereview.chromium.org/901133003 Cr-Commit-Position: refs/heads/master@{#314980}
-
nhiroki authored
SWRegistration.unregister() depends on WebSWProvider, but it's not available in SWGlobalScope because the provider isn't supplied on the worker startup sequence. This series of CLs make it available and support unregister() in the service worker context. This CL implements createServiceWorkerProvider() to supply a provider and sets the document URL of its provider host to the worker script URL in order to allow unregister() call on SWGlobalScope. [1] Chromium: THIS PATCH [2] Blink: https://codereview.chromium.org/900793002/ BUG=452910 TEST=compile Review URL: https://codereview.chromium.org/893363003 Cr-Commit-Position: refs/heads/master@{#314979}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/66fcf2e..f05b633 TBR=dcheng@chromium.org,apavlov@chromium.org Review URL: https://codereview.chromium.org/906433002 Cr-Commit-Position: refs/heads/master@{#314978}
-
v8-autoroll authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/901153008 Cr-Commit-Position: refs/heads/master@{#314977}
-
zhaoqin authored
TBR=clamy@chromium.org BUG=455994 NOTRY=true Review URL: https://codereview.chromium.org/901393002 Cr-Commit-Position: refs/heads/master@{#314976}
-
ckocagil authored
BUG= R=msw Review URL: https://codereview.chromium.org/891183003 Cr-Commit-Position: refs/heads/master@{#314975}
-
nasko authored
BUG=304341,450799 Review URL: https://codereview.chromium.org/894843003 Cr-Commit-Position: refs/heads/master@{#314974}
-
reillyg authored
This patch adds an additional function to the UsbService::Observer interface that should be used to perform cleanup operations when a USB device is disconnected. This is separate from the OnDeviceRemoved function so that implementations of that function, which may depend on other subsystems' knowledge of a connected device, can run before any cleanup actions have taken place. A browsertest for the chrome.usb.getUserSelectedDevices is included which demonstrates the need for this 2-phase event handling. BUG=452298 Review URL: https://codereview.chromium.org/891853002 Cr-Commit-Position: refs/heads/master@{#314973}
-
gunsch authored
R=thakis@chromium.org BUG=455342 Review URL: https://codereview.chromium.org/874163005 Cr-Commit-Position: refs/heads/master@{#314972}
-
tbarzic authored
The "usbDevices" entry in permission list should be inside an object Review URL: https://codereview.chromium.org/886353008 Cr-Commit-Position: refs/heads/master@{#314971}
-
pkasting authored
Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. BUG=455884,455942,455952 TEST=none TBR=mmenke,michaeln,zea Review URL: https://codereview.chromium.org/900793009 Cr-Commit-Position: refs/heads/master@{#314970}
-
jamiewalch authored
This was broken by https://codereview.chromium.org/834673007. Constructing a PairingRegistry with a null delegate causes pairing to be offered, but if selected, the host process will crash. BUG=455501 Review URL: https://codereview.chromium.org/903963002 Cr-Commit-Position: refs/heads/master@{#314969}
-
hirono authored
We no longer need these UMA. This reverts commit 7f60d255. BUG=433734 TEST=None Review URL: https://codereview.chromium.org/888083004 Cr-Commit-Position: refs/heads/master@{#314968}
-
dcheng authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/897223003 Cr-Commit-Position: refs/heads/master@{#314967}
-
garykac authored
Previously each locale filename was passed separately on the command line. This causes problems on Windows because of the 8K command line limit. A follow-up cl will move the webapp filenames into separate files to reduce the liklihood that we'll encounter this limit in the future. BUG= Review URL: https://codereview.chromium.org/905553002 Cr-Commit-Position: refs/heads/master@{#314966}
-
hirono authored
The model dispatches the requests depends on the entry's location. BUG=410766 TEST=FileManagerJsTest.FileSystemMetadataModel Review URL: https://codereview.chromium.org/890423004 Cr-Commit-Position: refs/heads/master@{#314965}
-
dcheng authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/897423002 Cr-Commit-Position: refs/heads/master@{#314964}
-
thakis authored
This reverts r127788. Positional parameters aren't part of the C standard (they are part of POSIX though), we don't really use them in the codebase, and they don't work in chrome/android with libc++. Rather than have a test for them, make them also not work on Windows (like they originally didn't) -- we shouldn't use positional printf parameters anyways. Change the 5 uses to not use positional parameters. BUG=118064,117028,427718 Review URL: https://codereview.chromium.org/902643002 Cr-Commit-Position: refs/heads/master@{#314963}
-
raymes authored
This is interfering slightly with tab ordering. The plugin never used to be tab focusable. BUG=455552 Review URL: https://codereview.chromium.org/889603005 Cr-Commit-Position: refs/heads/master@{#314962}
-
jamiewalch authored
The onBlur handler was accidentally removed by my recent refactoring. The images are required for submissions to CWS; only the icon needs to included in the crx, however. Review URL: https://codereview.chromium.org/868663007 Cr-Commit-Position: refs/heads/master@{#314961}
-
nasko authored
This test fails within the WebContentsObserverSanityChecker, since no IPC for RenderFrameCreated is sent. Disable while we find a good way to make the sanity checker play nicely within the unit test framework running in --site-per-process BUG=417518 Review URL: https://codereview.chromium.org/905463004 Cr-Commit-Position: refs/heads/master@{#314960}
-
afakhry authored
R=calamity@chromium.org BUG=455895 TEST=manual Review URL: https://codereview.chromium.org/901153007 Cr-Commit-Position: refs/heads/master@{#314959}
-
tengs authored
BUG=455311 Review URL: https://codereview.chromium.org/868503003 Cr-Commit-Position: refs/heads/master@{#314958}
-
dcheng authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/900793008 Cr-Commit-Position: refs/heads/master@{#314957}
-
cjhopman authored
This adds a new distallable type (mobile-friendly distillable) and adds a histogram for tracking what types of pages are actually distilled. BUG=444160 Review URL: https://codereview.chromium.org/900963003 Cr-Commit-Position: refs/heads/master@{#314956}
-
michaelpg authored
Review URL: https://codereview.chromium.org/905653002 Cr-Commit-Position: refs/heads/master@{#314955}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/dc9973e..66fcf2e TBR=dcheng@chromium.org,apavlov@chromium.org Review URL: https://codereview.chromium.org/898143004 Cr-Commit-Position: refs/heads/master@{#314954}
-
dcheng authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/900183004 Cr-Commit-Position: refs/heads/master@{#314953}
-
jiajia.qin authored
In old implementation, 'audio/aac' is not supported when using IsSupportedMediaMimeType to check. That will block aac audio to play. Review URL: https://codereview.chromium.org/895523002 Cr-Commit-Position: refs/heads/master@{#314952}
-
dcheng authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/900613004 Cr-Commit-Position: refs/heads/master@{#314951}
-
tapted authored
Revert of Roll Clang 223108:228129 (patchset #5 id:80001 of https://codereview.chromium.org/881763003/) Reason for revert: compiler crash in http://build.chromium.org/p/chromium/builders/Mac/builds/33226 Assertion failed: (Offset <= PieceOffset && "overlapping or duplicate pieces"), function emitLocPieces, file /work/chromium/src/third_party/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp, line 1676. 0. Program arguments: /Volumes/data/b/build/slave/Mac/build/src/third_party/llvm-build/Release+Asserts/bin/clang -cc1 -triple x86_64-apple-macosx10.6.0 /* snip */ -x c ../../third_party/mesa/src/src/mesa/program/prog_opt_constant_fold.c 1. <eof> parser at end of file 2. Code generation clang:error: unable to execute command: Illegal instruction: 4 clang:error: clang frontend command failed due to signal (use -v to see invocation) clang version 3.7.0 (trunk 228129) Target: x86_64-apple-darwin13.4.0 Original issue's description: > Roll Clang 223108:228129 > > Also introduce a build number in the package name, stop versioning > the Blink GC plugin, and remove repackage.sh. > > BUG=444089 > > Committed: https://crrev.com/d30327adf468b78f79819a69bca12b64b7cb70ae > Cr-Commit-Position: refs/heads/master@{#314946} TBR=thakis@chromium.org,jln@chromium.org,jbauman@chromium.org,hans@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444089 Review URL: https://codereview.chromium.org/898713004 Cr-Commit-Position: refs/heads/master@{#314950}
-
earthdok authored
Revert of Linux MSan: enable swarming/sharding for browser_tests. (patchset #1 id:1 of https://codereview.chromium.org/899283003/) Reason for revert: broke browser_tests Original issue's description: > Linux MSan: enable swarming/sharding for browser_tests. > > Also, try enabling swarming for base_unittests on CrOS MSan. > > BUG=454828 > TBR=phajdan.jr@chromium.org > > Committed: https://crrev.com/0f7445a90f7a8e2aa54a812d2c96654cefbd8eaf > Cr-Commit-Position: refs/heads/master@{#314892} TBR=phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454828 Review URL: https://codereview.chromium.org/898083003 Cr-Commit-Position: refs/heads/master@{#314949}
-
dfalcantara authored
Show only the eTLD+1 instead of the full URL. BUG=453170 Review URL: https://codereview.chromium.org/898183002 Cr-Commit-Position: refs/heads/master@{#314948}
-
jamiewalch authored
* Add keypress JS event handler * Change some keycode->name conversions to match what we get from NaCl This CL also bumps the version number since I've already pushed v1.0 to CWS. Review URL: https://codereview.chromium.org/882063007 Cr-Commit-Position: refs/heads/master@{#314947}
-
hans authored
Also introduce a build number in the package name, stop versioning the Blink GC plugin, and remove repackage.sh. BUG=444089 Review URL: https://codereview.chromium.org/881763003 Cr-Commit-Position: refs/heads/master@{#314946}
-
satorux authored
The change only handles files moved/renamed withing the same BUILD.gn file. If files are moved beyond the same BUILD.gn file, the affected BUILD.gn files should be fixed manually. BUG=404616 TEST=1) rename files with git mv 2) run tools/git/mass-rename.sh 3) confirm that BUILD.gn is updated as expected Review URL: https://codereview.chromium.org/894973002 Cr-Commit-Position: refs/heads/master@{#314945}
-
dcheng authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/905463005 Cr-Commit-Position: refs/heads/master@{#314944}
-
dcheng authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/898173002 Cr-Commit-Position: refs/heads/master@{#314943}
-
newt authored
This adds a new widget, ButtonCompat, which is a Material-styled button. On pre-L devices, the widget approximates the Material style, but doesn't have ripples or shadows. The color of ButtonCompat can be easily changed using setButtonColor(). This also adds a style ButtomBorderlessCompat than can be applied to Buttons to make them look like borderless Material buttons. BUG=442690 Review URL: https://codereview.chromium.org/902893004 Cr-Commit-Position: refs/heads/master@{#314942}
-
jvoung authored
Allow building in parallel. It may be a runtime dependency but it's not a build-time dependency. Happened to notice the serialization in the graph: http://chromium-build-stats.appspot.com/ninja_log/2015/02/05/build48-m1/ninja_log.build48-m1.chrome-bot.20150205-093049.13303.gz/trace.html BUG=none Review URL: https://codereview.chromium.org/902033002 Cr-Commit-Position: refs/heads/master@{#314941}
-