- 20 Feb, 2020 40 commits
-
-
Greg Thompson authored
BUG=1054342 R=bcwhite@chromium.org Change-Id: Icb07c344efbef1592730dce1ca40bc0079e378e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066542 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#743167}
-
liberato@chromium.org authored
This reverts commit 62751ae7. Reason for revert: MediaCodec tends to tell us things that aren't exactly true. Plus, overlay promotion get skipped. Bug: 1054174, 1049192 Original change's description: > Plumb color space from MediaCodec to MCVD. > > Bug: 1049192 > Change-Id: I49ca6860718a2a015cfccf07150bd3aa4344b781 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042042 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740406} TBR=dalecurtis@chromium.org,liberato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049192 Change-Id: I97b1ab9ade5477d992b8a6fc5e7ecbd7cb84f7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065339Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#743166}
-
Michael Lippautz authored
- Hide GCInfoTable for most users as the table is mostly an implementation detail. - Provide a type alias GCInfoIndex. - Functional: Use relaxed memory order when reading the index in the fast path. The setup is done under lock and the index retrieval itself should not be used for external synchronization. Change-Id: I5f4ac9c6493520e2b719f9fc867e3337fd7b0937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062440 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743165}
-
Mikel Astiz authored
This reverts commit 7a6d0761. Reason for revert: the underlying issue that caused the revert was addressed in crrev.com/c/2062328 by lowercasing GUIDs that are populated via sync's originator client item ID. Bug: 1052789 Original change's description: > Revert "Enforce lower-case use of GUIDs for sync" > > This reverts commit b6a3c9f3. > > Reason for revert: bookmarks created around 2016, between [M44..M51] > use an uppercase GUID as originator client item ID. > > Original change's description: > > Enforce lower-case use of GUIDs for sync > > > > base::GenerateGUID() produces lower-case GUIDs and they should get > > exposed to the sync protocol exclusively in this canonical form to avoid > > running into issues. > > > > This patch replaces all occurrences in sync codebase with: > > git grep -l 'IsValidGUID' -- components/sync* | \ > > xargs sed -i 's/IsValidGUID/IsValidGUIDOutputString/g' > > > > In addition, the implicit GUIDs used for bookmark sync, in particular > > for permanent nodes, are updated to adopt lower-case GUIDs. These are > > never committed to the server so there are no backward-compatibility > > considerations. > > > > Change-Id: I0d0468f3475e1a27a161e2af15853c757f53e201 > > Bug: 978430 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054154 > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741381} > > TBR=sky@chromium.org,treib@chromium.org,mastiz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 978430 > Change-Id: If3a135e24cb61d15cfc7616dd1160e76ce9dd3e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061749 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742118} TBR=sky@chromium.org,treib@chromium.org,mastiz@chromium.org Bug: 978430 Change-Id: I9bb6813c5b3edba7b6204e515475d6e644212c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064931Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743164}
-
Alison Maher authored
As per the following spec resolution, SVG text no longer should be adjusted in forced colors mode by default. https://github.com/w3c/csswg-drafts/issues/3855 Bug: 970285 Change-Id: I11a785f64ca6f7e7840b17d6b59d4ce9b9f8b4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055431Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743163}
-
Sylvain Defresne authored
Bug: 1049042 Change-Id: Ib5932f00c2b100aec03240f994370748ff8d2a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065730Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743162}
-
Aaron Krajeski authored
Waiting for the compositor "activation" means that we cannot parallelize the layers. Create an experiment here to remove it. Tests and perf with this WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/2057346 Bug: 1046463 Change-Id: I7631a84eca45e2ce20de51628c8c652108ba6cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056933 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743161}
-
Justin Cohen authored
The intent handler for SearchInChromeIntent and OpenInChromeIntent both assumed the intents would only happen while the app was backgrounded. This worked since that's usually true, and the startupInformation would be processed when the app was foregrounded. However, OpenInChromeIntents can be chained, and presumably this is also true for SearchInChromeIntent, which means the first in the chain will trigger while the app is backgrounded, and the remainder when the app is in the foreground. Instead of assuming the foregrounding step will process startupInformation, let the logic flow to -continueUserActivityURL. Bug: 1051783 Change-Id: Ia61334ac33995030744c1316f5accef2eae15b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062097Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743160}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0cd68ab14a08..4386ad19fb62 git log 0cd68ab14a08..4386ad19fb62 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 csmartdalton@google.com Add GrOpsRenderPass::bindPipeline() 2020-02-20 robertphillips@google.com Add private GrContext::compile API (take 2) 2020-02-20 robertphillips@google.com Revert "Add private GrContext::compile API" 2020-02-20 reed@google.com clean up leftovers from 3d samples Created with: gclient setdep -r src/third_party/skia@4386ad19fb62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ie4a82096603ce5005e5812a1ff48e37abe90a493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743159}
-
Lijin Shen authored
Google sans is commonly used in button texts and headlines. For style consistency across the clank, this CL updates the font style of the button from Roboto to Google sans. Bug: 1053602 Change-Id: I189a968487ae89a5c27f1b25ca426143de3a8e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063415Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743158}
-
Mikhail Atuchin authored
The problem is that browser_tests depends on //chrome:chrome_dll. After changing one file (lets say in ch/br/) both chrome.dll and browser_tests.exe will be linked. It's unnecessary and takes a lot of time. The CL remove the redundant dependency. Change-Id: I9886bbfc149e89bf42d27d976383d08f2262fed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066739 Auto-Submit: Mikhail Atuchin <atuchin@yandex-team.ru> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#743157}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Iac5e02b8c3c890274cdaf13237dd551c173c6ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067259Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743156}
-
Mason Freed authored
The [1] CL caused renderer/core to depend on base, without adding deps for that dependency. The actual dependency is just on ui/base:features, so this CL makes that change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1984748 Fixed: 1052085 Change-Id: Ia1fdd06903e920148d26943f4c860dcce0b243aa Bug: 1052085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063630Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#743155}
-
Eldar Rello authored
Bug: chromium:1032987 Change-Id: I450c68280a8ab8b0b2bbaa5fa31e0245dbfba780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066625 Commit-Queue: Eldar Rello <elrello@microsoft.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#743154}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8e303f0eba46..a139c005963b git log 8e303f0eba46..a139c005963b --date=short --first-parent --format='%ad %ae %s' 2020-02-20 vapier@chromium.org repo_util: add more encoding=utf-8 settings when we capture output 2020-02-20 vapier@chromium.org puppet_metrics_unittest: fix test assert for Python 3 2020-02-19 dburger@chromium.org Manual fix up of ge_build_config.json and config --update. 2020-02-19 dburger@chromium.org Add command line option to specify chrome preload directory. 2020-02-19 vapier@chromium.org cros_build_lib: run: drop error_code_ok backwards compat 2020-02-19 vapier@chromium.org cbuildbot_launch: switch to python3 only 2020-02-19 tcwang@google.com afdo: Fix Python3 compatibility of toolchain_util.py 2020-02-19 vapier@chromium.org contrib: force all modules to be python3 only Created with: gclient setdep -r src/third_party/chromite@a139c005963b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I47e7a860c8e0b62431016e4810fdbb4b03ebd053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066799Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743153}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //media/muxers/ to Once or Repeating Bug: 1007809 Change-Id: I9d412676b0c9386de89d400e2126af2e20745821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065333Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#743152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1cd8b3dcc1d..a9f14d4ed59b Created with: gclient setdep -r src-internal@a9f14d4ed59b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9aa7e7cfadcd93b44c457528e3604e10f6e51c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066800Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743151}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e161c4dd654..cdda76d1c88e git log 2e161c4dd654..cdda76d1c88e --date=short --first-parent --format='%ad %ae %s' 2020-02-20 phoglund@webrtc.org Make scenario unittests faster. Created with: gclient setdep -r src/third_party/webrtc@cdda76d1c88e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic20c8f8f9bbf410b30cbf3376c82ee613b12ea11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743150}
-
Elly Fong-Jones authored
This change removes CryptoModulePasswordDialogView::{Accept,Cancel} and replaces them with explicit callbacks. It also changes the behavior (hence the separate CL): the old code used to explicitly clear the password entry field's text on the closure path. I can't find any good reason why this would be done, and views::TextField has never guaranteed that setting the text will cause the old text to be securely erased from memory. In any case, if we want that behavior, it should happen in //ui/views, not here. Bug: 1011446 Change-Id: I3b81438511cf8eb3e52241543024ec081c467636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062887 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743149}
-
Benoît Lizé authored
kSimpleCacheEvictionWithSize was launched in M63, time to remove the feature from the codebase :). Bug: 736437 Change-Id: I7e1ffd378a011eca0c414ccf712e9aceb4297704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066897Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#743148}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6afd7913..099ad342 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If17ef0a9d699b4078629bbfd6d10d0bedd6ced5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066857Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743147}
-
Steve Kobes authored
Bug: 1045064 Change-Id: I49a454e4333c3f32a5516e632901ff368ddbe729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065322Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#743146}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: Ib2a14bd7b1fb312c0d4d91fd3ecceb9ac42c482d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044084 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#743145}
-
Vladislav Kuzkokov authored
Bug: 1054425 Change-Id: I9365f76d33657c1208f735769a8b482a89d346f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066741 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#743144}
-
Michael Sun authored
To support the "stop" event generated by the Bluetooth devices with AVRCP (Audio/Video Remote Control Profile), add handling for the stop key. BUG=b/147367020 Change-Id: I4bc9efa74173d8ffeab0affb4d685bc587f07616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063809Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#743143}
-
Liquan (Max) Gu authored
Cause analysis: We are trying to enable two test suites for BottomSheet(BS) PaymentHandler (PH) UI - PaymentRequestServiceWorkerPaymentAppTest and PaymentHandlerChangePaymentMethodTest. Currently the two tests would fail (BS PH enabled) because they are both timeout on waiting for PaymentRequestUI#onDismiss() to be called. The reason why it's never invoked is because when mDialog.isShowing(), not only mDialog.dismiss() is bypassed (in DimmingDialog), but mDialog's dismiss listener callback is bypassed as well (in Android's Dialog.java). Why dimming dialog is not showing in BS PH UI is because of scrim. For CCT PH UI, the scrim is provided by PR UI; for BottomSheet PH UI, it's by BottomSheet. As a result, DimmingDialog (the scrim) is showing in CCT and not showing in BS PH UI. Before change: PaymentHandlerChangePaymentMethodTest and PaymentRequestServiceWorkerPaymentAppTest fails on some tests. After change: All tests are green. Change: * Replace DialogInterface.onDismissListener with DimmingDialog.onDismissListener. * Add onDismissListener invocation for DimmingDialog's dismissal. Bug: 1045088 Change-Id: Iaedebfb1e9250eeb1974c63083c33cf8a89149df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047344 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743142}
-
Tobias Sargeant authored
Now that proguarded builds set sourcefile to a recognisable string, we can use that to determine if a stack frame references Chromium code. Also add the prefixes of other Chromium packages so that this continues to work in the un-proguarded case. Bug: 1044585 Change-Id: I6ce03c09da4de8942cd2db6436700f83ab93b141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059970Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#743141}
-
Matt Menke authored
SharedWorkerServiceImpl was using a SiteForCookies based on the URL of the worker being loaded, but a NetworkIsolationKey based on the URL of the RenderFrameHost. In practice, these are always the same...except for the case of extensions loading a SharedWorker of some site. This CL fixes the issue. Bug: 1052148 Change-Id: I53d37354defdcca5fe0ea3f1412ee7a638016a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057525 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#743140}
-
Andrew Grieve authored
Bug: 1036426 Change-Id: I86c0dc4e22ae620b0b085b0683f8ccd2c06c3f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066453 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743139}
-
Toni Barzic authored
When OOBE dialog is hidden, the login shelf should be notified, so it can clear its cached dialog_state_. Otherwise, it will keep using the cached dialog state when calculating shutdown button visibility, and the button will remain hidden if the lock screen is shown later in the session. BUG=1051826 Change-Id: Id3fba45fd912a3eca2cc5b62b0e66f787d6e91d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058999Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743138}
-
Charlie Hu authored
This reverts commit df399aaa. Reason for revert: The dependency CL got reverted. Reland after the dependency CL is relanded. Original change's description: > Revert "Replace param |disposition| with |should_report| on IsFeatureEnabled" > > This reverts commit ccf8b883. > > Reason for revert: To revert https://chromium-review.googlesource.com/c/chromium/src/+/2028666 > > https://chromium-review.googlesource.com/c/chromium/src/+/2028666 seems to cause LinuxCFI tests failures. > > LinuxCFI tests start failing at > https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16433 > 16433 contains https://chromium-review.googlesource.com/c/chromium/src/+/2028666 > > Original change's description: > > Replace param |disposition| with |should_report| on IsFeatureEnabled > > > > Previously |disposition| on IsFeatureEnabled have an awkward type > > base::Optional<mojom::FeaturePolicyDisposition>*, which has 3 states > > correspond to FeatureEnabledState: > > - base::nullopt <= kEnabled > > - FeaturePolicyDisposition::kReport <= kReportOnly > > - FeaturePolicyDisposition::kEnforce <= kDisabled > > > > This CL simplifies the representation of this piece of information to > > |should_report|, and removes FeatureEnabledState enum. > > > > The mapping of FeatureEnabledState to new logic: > > kEnabled: enabled=true; should_report=false > > kReportOnly: enabled = true; should_report=true > > kDisabled: enabled = false; should_report=true > > > > Change-Id: I1fa82fb5e9924b8eed448853b139772e024bd531 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037326 > > > Change-Id: Id6531935bbc777662fc3af2af65612495cb5a803 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059555 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I016c9280e74db35d35d04dcbcf4dfe93ee022836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061397 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#743137}
-
Robert Sesek authored
Bug: 778317 Change-Id: I9d9ab96a40d9ba664428d7e514ba3fcc314a9a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065317 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#743136}
-
Manu Cornet authored
Distribute a little more logic from the shelf layout manager to individual shelf components where it belongs. Now that most coordinates are calculated within the screen, moving this logic around is a lot easier. Change-Id: Ib682350c7bcea935ddea21918b8ba09e3903a367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066107 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743135}
-
Tanmoy Mollik authored
Bug: 1053143 Change-Id: Id2ab9ef1d311f2565f4247644a0f677ed049841c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065028Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743134}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f0a082ec3466..bf2de16258dc git log f0a082ec3466..bf2de16258dc --date=short --first-parent --format='%ad %ae %s' 2020-02-20 aerotwist@chromium.org [screenshot] Makes screenshots platform-specific 2020-02-20 yangguo@chromium.org Roll upstream changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@bf2de16258dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051458 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3cc3af6baf4e11126bfe46661002279452080c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066798Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743133}
-
Rayan Kanso authored
Check for the installed apps, then return an empty list if in incognito mode, to prevent the ability to use this API for detecting incognito mode. Bug: 1045506 Change-Id: I83c4611947990af470d64ac723fc6695893e2a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066778 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#743132}
-
Natalie Chouinard authored
Lint is no longer incorrectly generating errors for valid v27 usages of these navbar APIs, so we can now remove these suppressions. Bug: 856861 Change-Id: If211e8446ad2eb13634b7134b778e2e5b5a0b2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065848 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#743131}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c2ca38da431c..df5f7f9e4e1a git log c2ca38da431c..df5f7f9e4e1a --date=short --first-parent --format='%ad %ae %s' 2020-02-20 treehugger-gerrit@google.com Merge "test: log gtest onto logcat" 2020-02-20 taylori@google.com Merge "perfetto-ui: Correct resolution upon loading" 2020-02-20 treehugger-gerrit@google.com Merge "Add some benchmarks for data sources and track events" Created with: gclient setdep -r src/third_party/perfetto@df5f7f9e4e1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id2faa2c572cbde8f12fcb9d2c7861629161cdaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066797Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743130}
-
Xiaohan Wang authored
See discussion thread at https://groups.google.com/a/chromium.org/g/cxx/c/h4bdRqbduNY/m/O8Blk8SoEQAJ The recommendation style is as follows: class Foo : public IComIsFun { IFACEMETHODIMP IsFun(BOOL* fun) override; }; HRESULT Foo::IsFun(BOOL* fun) { *fun = false; return S_OK; } Change-Id: I3209682f14489d9c1b31cf5f563a50cccf42a05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065857Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743129}
-
Olivier Robin authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/8c3afe370288..559a3893cb58 $ git log 8c3afe370..559a3893c --date=short --no-merges --format='%ad %ae %s' 2020-02-19 featherless Revert "Temporarily use the `develop` .gitattributes." 2020-02-19 featherless Update snapshot tests. 2020-02-19 featherless Remove checked in files. 2020-02-19 featherless Temporarily use the `develop` .gitattributes. 2020-02-19 featherless Bump the version correctly. 2020-02-19 featherless Bump the release. 2020-02-19 featherless Update changelog. 2020-02-19 featherless Revert "Revert "merge release-candidate"" 2020-02-19 featherless Revert "Revert all commits to stable since v104.0.1." 2020-02-19 featherless Revert all commits to stable since v104.0.1. 2020-02-19 featherless Revert "merge release-candidate" 2020-02-18 yarneo update changelog 2020-02-17 yarneo Bumped version number to 105.0.0. 2020-02-17 yarneo Hand-modified CHANGELOG.md API diff. 2020-02-17 yarneo Automatic changelog preparation for release. 2020-02-16 56741989+copybara-service[bot] [Dialogs] Add snapshot tests for additional dialog configurations. (#9646) 2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor title-icon, title-icon-view frames calculations to accommodate adjustable insets (#9657) 2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor action frame calculations to accommodate adjustable insets (5 seconds ago) (#9656) 2020-02-15 galiak [Dialogs] Refactor content frame calculations to accommodate adjustable insets (#9710) 2020-02-15 galiak [Dialogs] Refactor title frame calculations to accommodate adjustable insets (#9709) 2020-02-14 galiak [Dialogs] Update adjustable insets values (#9695) 2020-02-14 galiak [Dialogs] Update adjustable insets comments (#9694) 2020-02-14 andrewoverton Remove unneeded subspec (#9748) 2020-02-14 galiak [Dialogs] Fix custom title icon view layout - top inset (#9721) 2020-02-14 bryanoltman Fix invalid podspec (#9745) 2020-02-14 randallli [Material][Availability] Migrates cards to MDCAvailability. (#9728) 2020-02-14 randallli [Material][Availability] Migrates Tabs to MDCAvailability. (#9716) 2020-02-14 randallli [Material][Availability] Migrates Chips to MDCAvailability. (#9713) 2020-02-14 randallli [Material][Availability] Migrates Bottom Navigation to MDCAvailability. (#9717) 2020-02-14 andrewoverton [Dialogs] Migrate dialogs to availability (#9743) 2020-02-14 randallli Add @jakerockland to CODEOWNERS: NavigationDrawer (#9715) 2020-02-14 bryanoltman [Material][Availability] Migrates Flexible Header to MDCAvailability. (#9744) 2020-02-14 andrewoverton [Material][Availability] Migrates Schemes to MDCAvailability (#9736) 2020-02-14 bryanoltman [Material][Availability] Migrates Ink to MDCAvailability. (#9741) 2020-02-14 bryanoltman [Material][Availability] Migrates Snackbar to MDCAvailability. (#9739) 2020-02-14 andrewoverton [private] Make private/color use availability (#9738) 2020-02-14 bryanoltman [Material][Availability] Migrates activity indicator to MDCAvailability. (#9735) 2020-02-14 bryanoltman [Material][Availability] Migrates Action sheet to MDCAvailability. (#9733) 2020-02-14 andrewoverton Move static const assignment to MDCTextControl.m (#9701) 2020-02-14 randallli [Material][Availability] Migrates Slider to MDCAvailability. (#9704) 2020-02-13 andrewoverton [Material][Availability] Migrates Text Controls to MDCAvailability (#9720) 2020-02-13 andrewoverton Remove test spec (#9718) 2020-02-13 andrewoverton [TextControls] Changes from text-area-feature-branch with additional podspec and BUILD file changes (#9711) 2020-02-13 randallli Delete Dialogs OWNERS file (#9697) 2020-02-13 randallli Delete NavigationDrawer OWNERS file (#9696) 2020-02-13 galiak [Dialogs] Adding accessory view vertical inset to private header (#9692) 2020-02-12 56741989+copybara-service[bot] [Component] MDCButton. (#9667) 2020-02-11 56741989+copybara-service[bot] [Dialogs] Adding an adjustable insets feature flag. Flag default is NO. Clients must enable flag if they want to customize the inset. This flag has no effect yet in this CL. Adjustable layout logic will be introduced in followup CLs. (#9648) 2020-02-11 bryanoltman [TextFields] Delete deprecated MDCTextFieldTypographyThemer (#9689) 2020-02-11 bryanoltman [Buttons] Delete deprecated MDCOutlinedButtonThemer (#9688) 2020-02-19 yarneo snapshots 2020-02-19 yarneo updated changelog 2020-02-18 bryanoltman [Dialogs] Add reference images for MDCAlertControllerConfigurationsTests (#9757) 2020-02-18 yarneo update changelog 2020-02-17 yarneo Bumped version number to 105.0.0. 2020-02-17 yarneo Hand-modified CHANGELOG.md API diff. 2020-02-17 yarneo Automatic changelog preparation for release. 2020-02-16 56741989+copybara-service[bot] [Dialogs] Add snapshot tests for additional dialog configurations. (#9646) 2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor title-icon, title-icon-view frames calculations to accommodate adjustable insets (#9657) 2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor action frame calculations to accommodate adjustable insets (5 seconds ago) (#9656) 2020-02-15 galiak [Dialogs] Refactor content frame calculations to accommodate adjustable insets (#9710) 2020-02-15 galiak [Dialogs] Refactor title frame calculations to accommodate adjustable insets (#9709) 2020-02-14 galiak [Dialogs] Update adjustable insets values (#9695) 2020-02-14 galiak [Dialogs] Update adjustable insets comments (#9694) 2020-02-14 andrewoverton Remove unneeded subspec (#9748) 2020-02-14 galiak [Dialogs] Fix custom title icon view layout - top inset (#9721) 2020-02-14 bryanoltman Fix invalid podspec (#9745) 2020-02-14 randallli [Material][Availability] Migrates cards to MDCAvailability. (#9728) 2020-02-14 randallli [Material][Availability] Migrates Action sheet to MDCAvailability. (#9732) 2020-02-14 randallli [Material][Availability] Migrates Tabs to MDCAvailability. (#9716) 2020-02-14 randallli [Material][Availability] Migrates Chips to MDCAvailability. (#9713) 2020-02-14 randallli [Material][Availability] Migrates Bottom Navigation to MDCAvailability. (#9717) 2020-02-14 andrewoverton [Dialogs] Migrate dialogs to availability (#9743) 2020-02-14 randallli Add @jakerockland to CODEOWNERS: NavigationDrawer (#9715) 2020-02-14 bryanoltman [Material][Availability] Migrates Flexible Header to MDCAvailability. (#9744) 2020-02-14 andrewoverton [Material][Availability] Migrates Schemes to MDCAvailability (#9736) 2020-02-14 bryanoltman [Material][Availability] Migrates Ink to MDCAvailability. (#9741) 2020-02-14 bryanoltman [Material][Availability] Migrates Snackbar to MDCAvailability. (#9739) 2020-02-14 andrewoverton [private] Make private/color use availability (#9738) 2020-02-14 bryanoltman [Material][Availability] Migrates activity indicator to MDCAvailability. (#9735) 2020-02-14 bryanoltman [Material][Availability] Migrates Action sheet to MDCAvailability. (#9733) 2020-02-14 andrewoverton Move static const assignment to MDCTextControl.m (#9701) 2020-02-14 randallli [Material][Availability] Migrates Slider to MDCAvailability. (#9704) 2020-02-13 andrewoverton [Material][Availability] Migrates Text Controls to MDCAvailability (#9720) 2020-02-13 andrewoverton Remove test spec (#9718) 2020-02-13 andrewoverton [TextControls] Changes from text-area-feature-branch with additional podspec and BUILD file changes (#9711) 2020-02-13 randallli Delete Dialogs OWNERS file (#9697) 2020-02-13 randallli Delete NavigationDrawer OWNERS file (#9696) 2020-02-13 randallli [buttons] Fix tvOS target bug. (#9705) 2020-02-13 galiak [Dialogs] Adding accessory view vertical inset to private header (#9692) 2020-02-12 56741989+copybara-service[bot] [Component] MDCButton. (#9667) 2020-02-12 56741989+copybara-service[bot] [FlexibleHeader] Added property for minimumHeaderViewHeight (#9649) 2020-02-12 yarneo fix snapshot tests for CI (#9698) 2020-02-12 bryanoltman [TextFields] Update snapshot goldens (#9691) 2020-02-11 56741989+copybara-service[bot] [Dialogs] Adding an adjustable insets feature flag. Flag default is NO. Clients must enable flag if they want to customize the inset. This flag has no effect yet in this CL. Adjustable layout logic will be introduced in followup CLs. (#9648) 2020-02-11 bryanoltman [TextFields] Delete deprecated MDCTextFieldTypographyThemer (#9689) 2020-02-11 bryanoltman [Buttons] Delete deprecated MDCOutlinedButtonThemer (#9688) Created with: roll-dep src/ios/third_party/material_components_ios/src Change-Id: Ia980199891d4d55704b8d616505b74adacf417d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066757 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743128}
-