- 08 Aug, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9f64ec44. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1d58126b9c4ecac18069d462a2a65ee9ebc0b826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744050Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685272}
-
Manu Cornet authored
Bug: 973482, 973446 Change-Id: I20d801d414f24f6bba4e155a7d6f1c7020a07eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743186Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#685271}
-
Jacob DeWitt authored
Per the latest WebXR spec, XRInputSource.gamepad.id must be the empty string. Update the browser and layout tests to actually check this. Also update the browser tests that run on Windows to check the profiles array contents against expected values for WMR and OpenVR. Bug: 989114, 942201 Change-Id: I36dff42cff55728d5d90384623623ea871d3a13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742439 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#685270}
-
Bence Béky authored
Remove unused FLAGS_quic_headers_stream_id_in_v99. Sync values of flags with update_flags.py. Change-Id: I807595a7cbe26cf203e722120dbd2afba8fcdd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742214 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#685269}
-
Marijn Kruisselbrink authored
With network service shipped everywhere these tests should not and indeed appear to not flake anymore. Bug: 800898 Change-Id: I2cc59a6a5917e57629f1087e4868e636f2f72d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742733 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#685268}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e86a8560f202..4c833efb60a1 git log e86a8560f202..4c833efb60a1 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 tobine@google.com Vulkan: Enable sampler objects 2019-08-08 iannucci@chromium.org [infra/config] Actually set properties_j in the right place. 2019-08-08 tobine@google.com Sampler::syncState now returns angle::Result 2019-08-08 m.maiya@samsung.com Vulkan: Support the vertex_type_2_10_10_10_rev format 2019-08-08 jdarpinian@chromium.org Reenable extra_warnings config for angle_utils Created with: gclient setdep -r src/third_party/angle@4c833efb60a1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:973721 Change-Id: Iada1cf88d1a514decd2c0dd060e35d5d2bc27f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744281Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685267}
-
Matt Simmons authored
R=yusufo@chromium.org Change-Id: Iffd4d640e373c721ade6c4a30417f64629987c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742519Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#685266}
-
Michael Lippautz authored
- Move trivial initializers to declaration site - Move Visit* methods to private section - Remove unused parameter around Persistent APIs Bug: 982754 Change-Id: Iec4102f1466a8b65251aa69892d041f450ac069e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743636 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#685265}
-
Peter Boström authored
This dead code is fairly confusing when searching for usages of the ContentsWebView. Bug: None Change-Id: I3e074609853aaca9c122ce0ab2ebde10c00dc9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743192 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#685264}
-
Matthew Webb authored
This CL makes the fingerprint enrollment + completion animation available to other platforms outside of CrOS. Bug: 974046 Change-Id: Ia5b87a98be543296dd4c1bbbfb10f6e71a1d58ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724898Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Matthew Webb <noviv@google.com> Cr-Commit-Position: refs/heads/master@{#685263}
-
Allen Bauer authored
An OTR profile is needed for the HaTS dialog which hosts a WebView used to present the survey to the user. Using a freshly created OTR profiles will (hopefully) ensure that no PII information is sent with the request for the survey content and when the response is sent back. This OTR profile needs to be destroyed once the dialog is dismissed. Since the WebView renderer may not shutdown synchronously, the destruction of the profile can only happen once the renderer is gone. Bug: 807714 Change-Id: I4cff23071f288ad6825a116e687f7775812777e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726269Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#685262}
-
Martin Robinson authored
Typically, Views nodes that have an unknown role are one of a variety of views. The ATK_ROLE_PANEL is a more accurate classification for these. For other nodes with an unknown role we can use ATK_ROLE_UNKNOWN. Bug: 866344 Change-Id: Ifae26ec0f04487abfec86d57df7914ab459967cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741921Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#685261}
-
Avery Musbach authored
The present CL adds a unit test OverviewSessionTest.AddDisplay to verify that overview mode ends when a display is added. Bug: 988839 Change-Id: I529f45bb5120bf03affcb07b0075050c296ee25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743854Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#685260}
-
ssid authored
leveldb_proto is a component that allows storing proto objects in a leveldb database. A client can get a leveldb_proto database by calling a static method. This simple API made it easy for developers to integrate leveldb_proto in their components, this resulted in a large amount of clients, with each one using a unique leveldb instance. Having multiple db instances increases memory consumption, as each database caches frequently used contents. There has been an effort to move leveldb_proto databases from multiple instances to a shared instance, to decrease memory consumption and simplify configuration. As part of this effort there have been many changes to the database retrieval API. Our first approach was to use a ProtoDatabaseProvider instead of a static method. This provider owns the shared instance, so there should be one provider per Profile. To do this we created it with a ProtoDatabaseProviderFactory, which was a BrowserContextKeyedServiceFactory. Some clients need to initialize their database in reduced mode, so they don't have access to a BrowserContext/Profile. Instead they have a SimpleFactoryKey, which is moved to a Profile once a full startup occurs. Our second approach was to change our ProtoDatabaseProviderFactory to a SimpleKeyedServiceFactory. This worked for most clients, but some of them need to initialize their database from BrowserContext itself, which can't access SimpleFactoryKey because it lives in //components/keyed_service. This CL removes ProtoDatabaseProviderFactory, ProtoDatabaseProvider is now created and owned by StoragePartition for all cases except for reduced mode. In reduced mode the DB provider is created by StartupData, and then it transfers it to StoragePartition when initializing in full mode. In addition we also removed IOS's ProtoDatabaseProviderFactory, ProtoDatabaseProvider is now created and owned by BrowserState. Bug: 943354 Change-Id: I7cdeca4bff33a910969e21ed3d879938cf43842c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656712Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#685259}
-
Robert Sesek authored
Change-Id: I8fcc58fb170a55c0e4afeedf401474ce63273093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742613 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#685258}
-
Jeremy Roman authored
Avoid it entirely where the input is constant ASCII. Change-Id: I76944b318f75ac188d53c1903687e74b26dde83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743258 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#685257}
-
Raphael Kubo da Costa authored
kRotationDOMMatrix has not been used since commit 7e8c0421 ("[sensors] Fix orientation sensor layout test"). Change-Id: I2c85083df36e778acc0512bb8212a18f564334d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742132 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685256}
-
Antonio Gomes authored
This is a follow up of [1], where these files were Onion soup'ed. [1] crrev.com/c/1731644 BUG=923394 R=guidou@chromium.org Change-Id: Ia0138ca8e0b3ed26c5614fd0d2ca2367bc8be266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744047 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#685255}
-
Scott Little authored
This reverts commit 0d6bba53. Reason for revert: Broke webkit_layout_tests on WebKit Linux Leak bot: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/2935 Original change's description: > Fix sending scrollend on main thread snap > > This CL sends scrollend event if GSE is being > handled on the main thread after the snap (if > the snap has started after GSE). It also takes > care of sending scrollend event for snap after > fling. > > Bug: 907601 > Change-Id: I21aba5d098b25ddc765d78a7792ec8a2fb7987cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743253 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685217} TBR=bokan@chromium.org,nzolghadr@chromium.org Change-Id: Ib7901d4284565f8cd636e1e4064163750bf08d4e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744517Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685254}
-
Matthew Jones authored
This reverts commit a5cf7b8f. Reason for revert: Breaking Android WebView L bot/tests: https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20L%20%28dbg%29/8779#overview-tab java.lang.AssertionError: Android WebView is missing the following declared Blink interfaces: interface OffscreenCanvasRenderingContext2D interface OffscreenCanvas : EventTarget interface HTMLCanvasElement : HTMLElement.method transferControlToOffscreen . Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt Original change's description: > Disable viz-dependent features on WebView > > This adds a flag to disable: > - window.OffscreenCanvas > - Context2DCreation.desynchronize. > - HTMLCanvasElement.transferControlToOffscreen > > Bug: 940953 > Change-Id: If774e41adbaa6bef94a058f783225b27e5d0669a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736804 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685170} TBR=boliu@chromium.org,chrishtr@chromium.org,alexmos@chromium.org,fserb@chromium.org,wfh@chromium.org Change-Id: Ie8105469766f1182c9f6d44c263bc180e5067c2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744516Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#685253}
-
Clark DuVall authored
This path is no longer used now that NavigationLoaderOnUI is default. Bug: 979264 Change-Id: Iacfd172d4f1eaa742f642b712279841995db4cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744285 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#685252}
-
Eric Willigers authored
WPT to verify the width and height properties do not inherit. https://drafts.csswg.org/css-sizing-3/#propdef-width Change-Id: Ib35db7d4d5b55a5bc1b56db38eff49ec0fb4c427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741785Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#685251}
-
Danyao Wang authored
This change was announced to developers in M76. This patch will ship it in M78. Spec: https://w3c.github.io/payment-request/#shipping-address-changed-algorithm Intent to ship and implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/69dw-4Myc_A Chrome Status entry: https://chromestatus.com/features/5653566570102784 Bug: 821771 Change-Id: Idedf89cc868e7b98ff00ef649d898458c3edbe49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741296Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#685250}
-
James Cook authored
Before this change, base/debug/debugger.h was transitively included by 21,000 .cc files in the chrome build target. After this change it is included 24 times. Notes at go/chrome-transitive-includes TBR=sky@chromium.org Bug: none Change-Id: I1bcfa6e5c882cdd33b04d241b3038ef37ccc5250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742728Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#685249}
-
Avery Musbach authored
1. StartTabletActiveRightSnapPreviousLeftSnap is supposed to test with the right snapped window active (according to both the name and the comment), but actually tests with the left snapped window active. The present CL makes it test what it is supposed to test. 2. Among the tests with an active window and a previous window, some make it totally clear by activating both windows one after the other, while others just activate one window and assume that the other one will be previous. The present CL works out this inconsistency (at least for the tests that are the focus of my attention at the moment). 3. The comment on StartTabletActiveLeftSnapPreviousLeftSnap has some text left over from before [1], and currently does not even make sense. The present CL removes the offending text. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1535172 Change-Id: I086612a9cc180dd5092cd3c8794ccc29ee8b5a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738633Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#685248}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome BUG=762641 TBR=wutao@google.com Change-Id: Ia862df593cfa4da52c102af7ce43e5496fb2f7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744006Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#685247}
-
rbpotter authored
- Add a prefix replacement for chrome://resources, since this is needed across various Web UI pages - Always add Polymer 3 arguments to closure_flags, even if they are defined by the invoker. This allows Polymer 3 pages to set additional prefixes without having to also re-add the polymer 3 closure arguments. Bug: 965770 Change-Id: Id377a4c454862794ef4330e148615d987bc19030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742445Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#685246}
-
Nick Diego Yamane authored
The main user of GLib MessagePump implementation is Aura/X11, while Ozone-based ports use mainly libevent version, which exposes WatchFileDescriptor API that is used by higher level components through MessageLoop[Current]For{UI,IO} interfaces. Currently, there's no such API in MessagePumpGlib. The motivation here is to make MessageLoopCurrent API usage transparent, regardless which message pump is used in UI thread. This benefits X11 migration to Ozone on Linux desktop, which (just like Aura/X11) must integrate with Gtk, so GLib-based loop in browser's main thread is a natural path. So, this CL implements the aforementioned API in GLib MessageLoop following the same design, assumptions and overall structure as its original libevent-based version. As a follow-up, https://crrev.com/c/1730972 refactors code using MessagePumpLibevent::{FdWatchController,FdWatcher} directly, replacing them by MessageLoopCurrent*ForUI counterparts as well as refactoring X11EventSourceLibevent (which Implementation has been used as reference for this CL) in the same direction, so in the end it has no libevent specific code and the build-time glib/libevent switch (use_glib gn var) is possible. Bug: 988094, 789065 Test: base_unittests (MessagePumpGLibFdWatchTest.*) Change-Id: I843ab924d18c08b6384e0716bc36c4f5f8482fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731031 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#685245}
-
Dominic Battre authored
This CL introduces the logging for form and field signature hashes as they exist in UKMs to simplify detecting a specific form and field. R=kolos@chromium.org Bug: 928595 Change-Id: I5a5f3a9311896e8d9ec9b46d3862e0182dbb5aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733546Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#685244}
-
Anton Bikineev authored
Bug: 991989 Change-Id: Ib1e4102664a9be9e110199e386c31aaae7271702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743732Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#685243}
-
Nate Fischer authored
Follow-up to https://crrev.com/c/1733793. We can remove the #include statements as well. Bug: 990490 Test: N/A Change-Id: I4703be8307d2bb744179eec8a0e110ba5e292fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743061 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#685242}
-
Scott Little authored
This reverts commit 3ce9f4d8. Reason for revert: Broke browser_tests on win-asan bot. https://ci.chromium.org/p/chromium/builders/ci/win-asan/6832 Original change's description: > Make ResourcePrefetchPredictor use correct NetworkIsolationKeys. > > ResourcePrefetchPredictor was always using the origin of the initial > page being navigated to in constructing the NetworkIsolationKey. > With this CL, it uses the origin it expects the page to redirect to > instead. > > Bug: 987735 > Change-Id: Ic66c33bb5f99a9a00485ffe46c70e0947e0e430b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730782 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685173} TBR=pasko@chromium.org,mmenke@chromium.org,tbansal@chromium.org Change-Id: I7af5589722eafc8a0157c639acb357e8d28ae0bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744512Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685241}
-
Ioana Pandele authored
Bug: 986322 Change-Id: I282d1f1fd87ee03394857a21c612ba8d1be987b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736361Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#685240}
-
Prashant Malani authored
This reverts commit c3311e2b. Reason for revert: Chromium OS can continue to use the std::deque version, since it checks out this directory at a specific commit. Chromium can revert to using the circular_deque variant. This means that there will be a transitional discrepancy between MidiMessageQueue implementations in Chromium and Chromium OS, but those should be resolved once libchrome in Chromium OS gets uprev-ed. BUG=chromium:787643 TEST=None Original change's description: > midi: Use std::deque for MidiMessageQueue > > For the purposes of this class, the semantics of circular_deque and > std::deque are the same. Switching to std::deque will make this class > easier to re-use outside of Chrome, by reducing its dependency on > src/base/containers. > > BUG=chromium:701005 > TEST=MIDI works on Chrome. > > Change-Id: Iae83c69ef85682fbde75e6078cd5eb262b9f4082 > Reviewed-on: https://chromium-review.googlesource.com/784010 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518599} TBR=toyoshim@chromium.org,pmalani@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:701005 Change-Id: Id061ff49297b1b40b3e0417ad3022e744a7c2fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743035Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#685239}
-
Kyle Milka authored
This method was only used for reseting the background. Bug: None. Change-Id: I64b35e1832cf739324230d1b4e5460a18d83d0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719831 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#685238}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3fc53be382f582d7eb482058fb24a6b5b2afe485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685237}
-
Daniel Clark authored
An <input type='url'> should have LocalizedControlType of "url" per https://w3c.github.io/html-aam/#el-input-url Currently its LocalizedControlType is "edit". This change updates it to the correct value by adding an entry to BrowserAccessibility::GetLocalizedStringForRoleDescription(). Bug: 990386 Change-Id: I92cee38c5fb0b9c81229cb6070784271187f4154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733202Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#685236}
-
Lily Chen authored
Callers of this method seem to only care whether the effective SameSite is None, so just give them that. This is for prophylaxis of subtle bugs that may arise from GetEffectiveSameSite now possibly returning different values if called at different times. Bug: None Change-Id: If2c9cd38f2be41d039b144e1af6a043f799ab0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743131Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#685235}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/efffd0a5fa22..940c2b500589 git log efffd0a5fa22..940c2b500589 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 gustaf@webrtc.org AEC3: Reduce level of log messages 2019-08-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5744654b..498f5876 (685023:685149) 2019-08-08 tommi@webrtc.org Remove MediaTransport from Call. 2019-08-08 asapersson@webrtc.org Update test::CreateVideoStreams to use configured scale_resolution_down_by if set. 2019-08-08 oprypin@webrtc.org Delete shim of PRId64 et al. on Windows 2019-08-08 nisse@webrtc.org Change return type of of ReceiveStatistics::Create to unique_ptr. 2019-08-08 sprang@webrtc.org Remove unused fallbacks in PacedSender 2019-08-08 peah@webrtc.org Removing unused fallback variant for the reverb computation 2019-08-08 tommi@webrtc.org Call Call::GetStats() from the correct thread in ProbingEndToEndTest. 2019-08-08 tommi@webrtc.org Call Call::GetStats() from the correct thread in VideoSendStreamTest. Created with: gclient setdep -r src/third_party/webrtc@940c2b500589 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:none Change-Id: I19e1508a1421f78de872effd98f1a13c8456331e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685234}
-
Guido Urdaneta authored
This is to be followed by a move of this file to Blink. Bug: 704136 Change-Id: Ib75c46e895b585cc6da84d67c5d9388551df0d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744426Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#685233}
-