GitLab

Currently this logic needs to be copied and called every time
chrome::AttemptRestart() is called. Moving it within chrome::AttemptRestart()
allows it to be reused. Moreover, it seems that calling
chrome::AttemptRestart() without the said logic (there are such occurrences),
is not correct.

This is in preparation of reducing the number of "Restart" codepaths in MD
Settings.

BUG=617830

Review-Url: https://codereview.chromium.org/2033173002
Cr-Commit-Position: refs/heads/master@{#398195}

ExternalNavigationHandler#intentsHaveSameResolvers() will be called on each
WebAPK navigation. Removing the duplicate call to
PackageManager#queryIntentActivities() saves 2ms per navigation.

BUG=609122
TEST=None

Review-Url: https://codereview.chromium.org/2035203002
Cr-Commit-Position: refs/heads/master@{#398194}

This CL mistakenly disabled the 'detach' behavior for ScrollbarManager:

https://codereview.chromium.org/1930183002

... because it seemed like DelayScrollPositionClampScope would be sufficient
to preserve all the necessary state for scrollbars as they were added and
removed during the multiple layout passes of flex layout.  However, that
was premature: even though the scroll positions were preserved, destroying
and recreating scrollbars during layout will invalidate the
ScrollingCoordinator's mapping from Scrollbar to WebScrollbarLayer.

One side effect is that if a scroll event handler forces layout to run during
a scrollbar drag, and the Scrollbar/WebScrollbarLayer association is broken,
then the compositor will think that the scrollbar drag has ended, even though
mouse-up has not yet happened.

This CL also sneaks in a tiny optimization: if auto scrollbars are frozen,
then childFlexBasSizeRequiresLayout should not return true due to the child
having auto scrollbars (since the scrollbars cannot change).

BUG=617498
R=eae@chromium.org,cbiesinger@chromium.org

Review-Url: https://codereview.chromium.org/2042923002
Cr-Commit-Position: refs/heads/master@{#398193}

This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.

This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.

BUG=615277

Review-Url: https://codereview.chromium.org/2035303002
Cr-Commit-Position: refs/heads/master@{#398192}

BUG=610086

Review-Url: https://codereview.chromium.org/2046493005
Cr-Commit-Position: refs/heads/master@{#398191}

Spec: https://drafts.css-houdini.org/css-typed-om/#the-stylepropertymap

BUG=545318

Review-Url: https://codereview.chromium.org/1874623002
Cr-Commit-Position: refs/heads/master@{#398190}

When --isolate-extensions or --site-per-process modes are enabled, all
extensions frames run in extension processes and are not mixed in regular
web renderers. This causes a problem with security checks for
web_accessible_resources, which allow all navigations to extension pages
when they are performed in extension process. This is no longer true and
this patch addresses this by using a NavigationThrottle to perform the
proper checks on the UI thread (also PlzNavigate compatible).

BUG=616488
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2042483002
Cr-Commit-Position: refs/heads/master@{#398189}

It had been a while since I'd run `mb audit` and there were
a few new builders that didn't have entries. This adds those,
removes some builders that are gone, and fixes some typos.

TBR=brettw@chromium.org
BUG=605732

Review-Url: https://codereview.chromium.org/2047583002
Cr-Commit-Position: refs/heads/master@{#398188}

This CL corrects the timestamp sent with the encoded frame data from
VTVideoEncodeAccelerator. Recently, this functionality is added to the
VEA interface and we can use the frame's original capture timestamp.

BUG=350106
TEST=AppRTC loopback in Macbook Air.

Review-Url: https://codereview.chromium.org/2039423002
Cr-Commit-Position: refs/heads/master@{#398187}

This patch completes the implementation of multi-process find-in-page, as described in the design doc: https://docs.google.com/document/d/12S_6X2MWWLoyJslajcajL2ELU7zhodPxMOxa8Bg4Wg0/view

BUG=457440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1959183002
Cr-Commit-Position: refs/heads/master@{#398186}

Revert of Fix event page process cleanup when running in --isolate-extensions mode. (patchset #6 id:100001 of https://codereview.chromium.org/2028873002/ )

Reason for revert:
Speculative revert of this CL to check if it is the root cause of https://crbug.com/616989.

Original issue's description:
> Fix event page process cleanup when running in --isolate-extensions mode.
>
> With --isolate-extensions, navigations can start in one RenderFrameHost
> and complete in another. This was not possible to happen with extensions
> related RenderFrameHosts in the past, so the code wasn't able to handle
> it. This CL refactors the OnNetworkRequest(Started|Stopped) to use the
> navigation request id as the stable identifier instead of the associated
> RenderFrameHost.
>
> BUG=612668
>
> Committed: https://crrev.com/c25500369dd9a7f49d2b7d276556b2e22ba840c8
> Cr-Commit-Position: refs/heads/master@{#397328}

TBR=rdevlin.cronin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=612668

Review-Url: https://codereview.chromium.org/2044643003
Cr-Commit-Position: refs/heads/master@{#398185}

Previous code change 2018643002 (for user menu redesign) modified code on the spot and did not put the changes behind any flag. This CL is to:
1. add flags for the previous code change;
2. add back some of the deleted resources as they will still be used when the flag is not turned on.

BUG=615893

Review-Url: https://codereview.chromium.org/2034093003
Cr-Commit-Position: refs/heads/master@{#398184}

Needed for downloads UI.

BUG=616324

Review-Url: https://codereview.chromium.org/2039413003
Cr-Commit-Position: refs/heads/master@{#398183}

EarlGrey typically handles synchronization with the UI, but it is
useful when manipulating non-UI APIs to be able to wait for a certain
state.

BUG=610837

Review-Url: https://codereview.chromium.org/2044433003
Cr-Commit-Position: refs/heads/master@{#398182}

These friend declarations were added because MSVC had a bug around the
visibility of nested classes. They are no longer necessary.

BUG=617504

Review-Url: https://codereview.chromium.org/2043633002
Cr-Commit-Position: refs/heads/master@{#398181}

Notifications content settings don't consider the embedding origin
when updating the content setting values. Remove unused embedder
param in SetNotificationSettingForOrigin.

Review-Url: https://codereview.chromium.org/2035323002
Cr-Commit-Position: refs/heads/master@{#398180}

This was added for the texture-layer code but not the surface layer. If
the viewport is changed but a new buffer isn't attached then the old
resource information will be re-sent with the new Surface. The
SurfaceFactory will handle refcounting uses of the buffer.

Review-Url: https://codereview.chromium.org/2032173002
Cr-Commit-Position: refs/heads/master@{#398179}

ShelfModel, ShelfItemDelegate and ShelfItemDelegate have no dependencies on
ash::Shell, ash::RootWindowController or aura::Window so they can be moved
as-is.

No functional changes.

BUG=615155
TEST=compiles

Review-Url: https://codereview.chromium.org/2046513003
Cr-Commit-Position: refs/heads/master@{#398178}

Otherwise, GN does not get that it's a ToT build and the build dir
is not clobbered.

BUG=617771

Review-Url: https://codereview.chromium.org/2039103003
Cr-Commit-Position: refs/heads/master@{#398177}

This change replaces the two tab switcher borders that existed
(standard and incognito) with a single white one that can be tinted
to any color it needs to be.

BUG=606612

Review-Url: https://codereview.chromium.org/2045733002
Cr-Commit-Position: refs/heads/master@{#398176}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f8c7729d..7ed4b5d5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2044713002
Cr-Commit-Position: refs/heads/master@{#398175}

Content settings are not used on all platforms. Some content settings are only
used on desktop platforms, or desktop and android. We shouldn't register these
types on other platforms that aren't using them, so that we don't create unused
prefs for them and more importantly so that we don't sync settings to these
platforms which would go unused but be a potential privacy concern.

In this CL, an enum WebsiteSettingsInfo::Platform is added and used when
registering content settings to indicate which platform set it is applied to.

BUG=604632

Review-Url: https://codereview.chromium.org/1991623005
Cr-Commit-Position: refs/heads/master@{#398174}

Have Resource::setRevalidatingRequest() just overwrite
m_resourceRequest, and keep an m_isRevalidating bit to track
whether a revalidation is progress.

Ideally we'd get to a point where the m_isRevalidating bit
isn't needed, or at least doesn't need to be accessible
outside of Resource and its subclasses.

BUG=

Review-Url: https://codereview.chromium.org/1997833002
Cr-Commit-Position: refs/heads/master@{#398173}

R=jamescook@chromium.org
TBR=jamescook@chromium.org
BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2040803006
Cr-Commit-Position: refs/heads/master@{#398172}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/ba8c5aa..f43726c

BUG=
TEST=bots
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2043913002
Cr-Commit-Position: refs/heads/master@{#398171}

No change in logic.

BUG=549781
TBR=jbauman@chromium.org

Review-Url: https://codereview.chromium.org/2048453002
Cr-Commit-Position: refs/heads/master@{#398170}

Since we no longer support WinXP/WS2K3 and Vista/WS2K8, we can clean up our
code a bit by removing logic and conditions which only apply to those versions.

BUG=607676

Review-Url: https://codereview.chromium.org/2037163002
Cr-Commit-Position: refs/heads/master@{#398169}

This is necessary in cases that document.write changes the effective
URL of the about:blank page, and then the user goes back.

BUG=446959
TEST=See bug for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2032903007
Cr-Commit-Position: refs/heads/master@{#398168}

Some destruction flows don't seem to call OnWidgetActivationChanged
before destroying the window, which causes the extension keybinding
registry reference in the global registry to become stale. Update the
active registry on deletion.

BUG=616970

Review-Url: https://codereview.chromium.org/2046653002
Cr-Commit-Position: refs/heads/master@{#398167}

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise are more useful in the
superclass WebUIMessageHandler instead of SettingsPageUIHandler.

Review-Url: https://codereview.chromium.org/2040473002
Cr-Commit-Position: refs/heads/master@{#398166}

Typed CSSOM: Rename Matrix to CSSMatrix and MatrixTransformComponent to CSSMatrixTransformComponent.

I didn't rename MatrixTranformComponent to CSSMatrix because WebKitCSSMatrix is implemented as CSSMatrix.

Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#cssmatrix

Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159

BUG=610173

Review-Url: https://codereview.chromium.org/2038453002
Cr-Commit-Position: refs/heads/master@{#398165}

https://chromium.googlesource.com/skia.git/+log/dc27a648d2ff..ee295645bd91

$ git log dc27a648d..ee295645b --date=short --no-merges --format='%ad %ae %s'
2016-06-06 bsalomon Make GrShape track the winding direction and starting point for rrect types. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042813002
2016-06-06 brianosman Add new SkSourceGammaTreatment enum, used in situations like mipmap construction, where we need to know if we should respect (vs. ignore) the gamma encoding of sRGB tagged images. Plumb that extensively.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review-Url: https://codereview.chromium.org/2047533003
Cr-Commit-Position: refs/heads/master@{#398164}

Another mistake in https://codereview.chromium.org/2032923002/
|persistent_license_support_| was unused on Android.  Rather than
adding more ifdefs, just check that the caller isn't setting this
to true on Android.

BUG=

Review-Url: https://codereview.chromium.org/2043763002
Cr-Commit-Position: refs/heads/master@{#398163}

Mojo C++ bindings GYP build: only unset "-Wglobal-constructors' for unittests depending on WTF types.

BUG=583738

Review-Url: https://codereview.chromium.org/2038413003
Cr-Commit-Position: refs/heads/master@{#398162}

Allow the caller of the "test" template from //testing/test.gni to override
some of the parameters or to provide additional values. This is required by
downstream iOS tests.

BUG=603100

Review-Url: https://codereview.chromium.org/2043843003
Cr-Commit-Position: refs/heads/master@{#398161}

Add a histogram for tracking the response codes and error codes when trying the fetch hash-prefix updates from the Pver4 SafeBrowsing service.

BUG=543161, 616603

Review-Url: https://codereview.chromium.org/2029753002
Cr-Commit-Position: refs/heads/master@{#398160}

BUG=609122

Review-Url: https://codereview.chromium.org/2038983002
Cr-Commit-Position: refs/heads/master@{#398159}

Look to just be super flaky. Failure on different test each time.

BUG=615483

Review-Url: https://codereview.chromium.org/2046773002
Cr-Commit-Position: refs/heads/master@{#398158}

shortcut overlay.

BUG=608315
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1977183002
Cr-Commit-Position: refs/heads/master@{#398157}

Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const (patchset #3 id:40001 of https://codereview.chromium.org/2034013002/ )

Reason for revert:
"""
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15: error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue of type 'const blink::CSSValue *'
    CSSValue* cssValue = m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20TSan%20Builder/builds/23734/steps/compile/logs/stdio

Original issue's description:
> Make CSSComputedStyledeclaration::getPropertyCSSValue return const
>
> Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
> CSSValue* instead of a regular CSSValue*. This required changing
> CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
> CSSValue* as well, and marking CSSValueList::copy() as a const method
> (which it already was, it was just missing the const modifier). This is
> pre-work for making CSSValueList store const CSSValues.
>
> This patch is mostly mechanical changes, but does contain one logic
> change: the static method mergeTextDecorationValues in EditingStyle
> needs to be changed since it modifies a CSSValueList that points inside
> the mutable style. Instead, the function is changed to take two
> CSSValueLists and return a new one, and the callsite is changed to
> replace the old CSSValueList with the new one in the style rather than
> modifying the old CSSValueList in-place.
>
> BUG=526586
>
> Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
> Cr-Commit-Position: refs/heads/master@{#398151}

TBR=haraken@chromium.org,timloh@chromium.org,yukishiino@chromium.org,sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526586

Review-Url: https://codereview.chromium.org/2042113002
Cr-Commit-Position: refs/heads/master@{#398156}