- 28 Jan, 2020 40 commits
-
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I1ddc44348261707de426dc3b4168196145a52f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017463 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735929}
-
Armando Miraglia authored
After manual testing on a Ubuntu distribution (more precisely a XUbuntu 18.04) I was able to determine that libnss_compat is needed by ALSA to communicate with libnss and be able to read the groups available on the system. This CL adds the affected library to the loaded list of libraries in the audio sandbox hook for linux. Bug: 1032949 Change-Id: I779158f6cf4eb48ef6b29469ee52181f0c69a70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023893Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#735928}
-
Wez authored
IntlHash is no longer a valid DOM |code| value, so remove it from the DomCode tables, along with the associated KeycodeConverter work-around for it having a native keycode indistinguishable from US Backslash on all platforms, except at the actual USB Usage level. Bug: 952051 Change-Id: I0774105ab845ce5cbda475e9ae19f792745eca0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020708 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#735927}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1042208 Change-Id: I2cb1c8961842dafcec1e755567133bf8730ef7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017406 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#735926}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/99dead98309c..f76da63fbdfc git log 99dead98309c..f76da63fbdfc --date=short --first-parent --format='%ad %ae %s' 2020-01-28 kjlubick@google.com [canvaskit] Update build script to support latest Emscripten Created with: gclient setdep -r src/third_party/skia@f76da63fbdfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Ib54e1fdd041fc472e30335b6bd8607775dc4f75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735925}
-
Jonah Ryan-Davis authored
There was a mismatch between methods of retrieving GLX extensions in Chrome, causing certain available/used extensions to not appear on about::gpu. Additionally, there is an opportunity to cache the extension string and save calls. Bug: 1043761 Change-Id: I39bde9702daf9b5cf80a5cc1c9a030ef56623913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015644 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735924}
-
Avi Drissman authored
This is part of the work of cleaning out sdk_forward_declarations. BUG=1044828 Change-Id: Ifc1affd27e949b4d46d94d10b001f6988df8b290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019585 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735923}
-
Austin Eng authored
This reverts commit 4c3c01fd. Reason for revert: See crbug.com/1046362. Suspect that the Clang roll is causing a breakage on the Dawn CQ. No Dawn changes in the regression range, so reverting this suspect CL. Original change's description: > Roll clang n332890-c2443155-2 : n340584-68051c12-1. > > Ran `tools/clang/scripts/upload_revision.py efb130fc93059bdf02d3a83950ddabc5d119f9de`. > > This increases the clang version from 10 to 11. > > Bug: 1030664 > Change-Id: I8b7ad7f85895abda80e45860ab7e0215e6740d13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020894 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735635} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Id2b490358eb3e9a7d4d220ab87cd357e895e218d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024456Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#735922}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d9709fb4b440..315382afa699 git log d9709fb4b440..315382afa699 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 skyostil@chromium.org Revert "timeline: Support new style slice ids ('id2')" 2020-01-28 abennetts@google.com Introduce a repository filter for commits. 2020-01-28 skyostil@chromium.org timeline: Support new style slice ids ('id2') Created with: gclient setdep -r src/third_party/catapult@315382afa699 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1045197,chromium:639003 Tbr: skyostil@google.com Change-Id: I67c6879c8133b2609b1e65dec1191b0aeb20e54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025059Reviewed-by:
-
Etienne Pierre-doray authored
This histogram is expired. It is also causing dead lock issues when called from WorkerThread::Start. Bug: 1043353 Change-Id: Ica96db5b06ed85a84953413b6be0cc5b2213e9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016163 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#735920}
-
Sebastien Marchand authored
The current convention is to not send notification when the system exit memory pressure, this isn't ideal as it doesn't let stateful listeners know that they should stop their intervention. This CL was uploaded by git cl split. R=morlovich@chromium.org Change-Id: Ief0ffac5125e55a233e483e2a749e65927fc6894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017046 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#735919}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/0681dd61d3b0..821d564bc789 git log 0681dd61d3b0..821d564bc789 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 rharrison@google.com Rolling 5 dependencies and updating expectations (#975) Created with: gclient setdep -r src/third_party/shaderc/src@821d564bc789 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I54bd6a6d4ec0415decf1a22c5c74857eac521e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025057Reviewed-by:
-
Guido Urdaneta authored
Bug: 1017219 Change-Id: I06d6990385f0e251fcffbf7b5149731022c4b2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023894 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#735917}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/759ef9738531..912cec0c6822 git log 759ef9738531..912cec0c6822 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 tvanderlippe@chromium.org Add istanbul-diff to node_modules Created with: gclient setdep -r src/third_party/devtools-frontend/src@912cec0c6822 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9b4cdb7d1c23682c5ea8ec8ef0414f6737e7e88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025060Reviewed-by:
-
Yi Gu authored
This test passes on several bots but is marked as Crash only. Update the expectation accordingly. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=virtual/compositor_threaded_scrollbar_scrolling/fast/scrolling/scrollbars/mouse-scrolling-on-div-scrollbar-thumb.html TBR=bokan@chromium.org Bug: 979408 Change-Id: I12d30310e567f08b3093236a9a098fd5d41074b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024538Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735915}
-
Yao Xiao authored
What: Currently we only know ad status of a LocalFrame. This patch will add the status to RemoteFrames. Why: This makes it easier to implement some ad detections - sticky ads, interstitial ads, etc. Those detections will involve frequently querying the layout information and is_ad information of a Frame. So we tag remote frame to avoid going through the browser process each time we want to know ad status on a remote frame, so that the detection/intervention can probably all be done on the renderer side. How: Add the "ad_frame_type" bit to FrameReplicationState. In ContentSubresourceFilterThrottleManager::ReadyToCommitNavigation, set the frame replication state and also notify all RemoteFrames about the new status. Testing is done within content/ to avoid exposing the proxy details outside of content/. Bug: 939370 Change-Id: I26fd2acb10b3a5e837aacdc3d3f3e2a05563694b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913074 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#735914}
-
Tim Volodine authored
The test is flaky on the android-pie-arm64-rel bot. BUG=1046382 NOTRY=true TBR=chouinard@chromium.org,xingliu@chromium.org Change-Id: Ib10da045ae988a1e12a268fff1c9a7ddfe55e1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023500 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#735913}
-
Maksim Ivanov authored
This is a tiny cleanup that replaces a RepeatingCallback with a OnceCallback in the place where it wasn't needed (OneShotTimer in ash::LoginAuthUserView::ChallengeResponseView). Bug: 983103 Change-Id: Iad4c5a8755e1a8f6fb087bae54af93122fde58e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020933Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#735912}
-
Yi Gu authored
This test has been very flaky, 10000+ occurences on Mac: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYgsSBUZsYWtlIldjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L21lZGlhY2FwdHVyZS1zdHJlYW1zL2lkbGhhcm5lc3MuaHR0cHMud2luZG93Lmh0bWwM&show_all_occurrences=1 TBR=armax@chromium.org NOTRY=True Bug: 1042848 Change-Id: I75c6aea3f8bcd67465bf283e9d46270efb1338c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024181Reviewed-by:
-
Rodney Ding authored
Captures maximum decoded byte sizes of all JS resources per page load. Bug: 1033626 Change-Id: Ib4717fcdcfab6cdc81f8a0416dc3227643a5fdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005812 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#735910}
-
Andrew Solovey authored
Add H4 style at histograms at chrome://histograms page. This change applied for both: |Histogram| and |SparseHistogram| classes. Unit tests updated to be consistent with new output format. R=dcheng@chromium.org, sinhak@chromium.org Bug: 1006447 Change-Id: I5cbc7ec7267fb49d16569b8057e39d5578ab276d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019128Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Andrei Salavei <solovey@google.com> Cr-Commit-Position: refs/heads/master@{#735909}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/20be649ad2fd..db1cab866afd git log 20be649ad2fd..db1cab866afd --date=short --first-parent --format='%ad %ae %s' 2020-01-28 kimjae@chromium.org build_dlc.py: Build stage DLC_ID and DLC_PACKAGE validity detailed exceptions 2020-01-28 bmgordon@chromium.org xz_auto: Enable multi-threaded xz 2020-01-27 achuith@chromium.org cros_chrome_sdk: Update SDK_VERSION on fallback. 2020-01-27 saklein@chromium.org flash_ap: refactor 2020-01-27 saklein@chromium.org flash_ap: clean up commands 2020-01-27 saklein@chromium.org flash_ap: Simplified board config naming scheme. 2020-01-27 saklein@chromium.org flash_ap: Reorganize files Created with: gclient setdep -r src/third_party/chromite@db1cab866afd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ie7a6e4ac0a8f89a93ad5c9e70e08f5132b0d5c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025054Reviewed-by:
-
Gauthier Ambard authored
This CL fixes the position of the identity disk (by fixing the position of the invisible toolbar). The constraint was updated when the phone was rotating, but it was too soon to take into account the safe area. This CL removes this updates and instead relies on the update from -updateConstraints as it is called by the CollectionViewController when its view safe area is updated. It also removes the implementation of -viewSafeAreaInsetsDidChange as it is not reliably called. Fixed: 1041831 Change-Id: I5a8c2681cf91f440ffd50b74dbb537143dcd4495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023889 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Ben Mason authored
This reverts commit 02d5da92. Reason for revert: generate_javadoc.py updated in crbug.com/1036426 Original change's description: > Don't build generate_javadoc on preview Android SDK > > Bug: 1044636 > TBR: pauljensen so we can green up the builders > Change-Id: I59d296744a6b7481262315db2a66d173a39cf4c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016879 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ben Mason <benmason@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734532} TBR=pauljensen@chromium.org,agrieve@chromium.org,mheikal@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044636 Change-Id: I35af821524b0d8e5a87737b82e8b9e20bce3bdc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024917Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#735906}
-
Rodney Ding authored
Captures total decoded byte sizes for all JS resources per page load. Added decoded body length in code and mojom. This CL is rebased from https://chromium-review.googlesource.com/c/chromium/src/+/1901629 Bug: 1033626 Change-Id: I9b18fccdca670e5208b15a387749b76edb5ac2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003293 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I032290d413ba4e988311c66f1f93433ca74141e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025008Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#735904}
-
David Benjamin authored
This fixes a regression from MacViews. See https://crbug.com/987744#c2. Bug: 987744 Change-Id: I8b26d6738161cc8677d78b2cd8da3b4070831d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003301Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#735903}
-
Robert Sesek authored
Use this to gate copying internal-only resources. Bug: 1021255 Change-Id: I66f6143df12f6eeaaa1c27249350105ba39a6178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023947Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#735902}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe199f552f17..985f7cf5466a Created with: gclient setdep -r src-internal@985f7cf5466a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie4e248a18b1ff90b1ae8f0da50f3a7c5db62d8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025053Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735901}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I84f3ad157f9d894b99811a58bf437409da2e0c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024988Reviewed-by:
-
Kevin Ellis authored
Bug: 1015083 Change-Id: I8d8137d85ccdf9a6fe68f6be1b12a483ef0eabea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023191Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#735899}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/903be3ea..e750f450 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id69bef60fd21f9f318d6f65d0831ef9c0ef6773d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025227Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735898}
-
bttk authored
Bug: 1046181 Change-Id: If643b47c35736a6ae50af6f4d072f8a54a5b9777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018169Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#735897}
-
Anatoliy Potapchuk authored
Previously, when ExternalCache was corrupted, state of KioskAppData was set to STATUS_ERROR, which caused it to disappear after file load. Now, we are only setting this status when we have other data to display on the screen (it is actually the installation from the crx file, not just external cache load). The test coverage of kiosk_app_data is postponed into a following cl, which will try to cover that states of *kiosk_app_data (crbug.com/1046364). Bug: 1035860 Change-Id: I97245a59f1807e43ac12a8601396b52a39229cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014408Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#735896}
-
Friedrich Horschig authored
Currently, a AutofillPopupControllerImpl::Hide call will always hide the AutofillPopupView it manages. If the delegate that provides data for view is preparing to push updated data to the controller, hiding might cause flickering or might close the updated pop-up. Therefore, the controller now can enter a waiting state in which it only proceeds to hide, if the reason is urgent (e.g. if the tab is gone or the view destroyed) but not if the user might actually wait for the data update. Bug: 1043963 Change-Id: I6b766d2b92f55711a551f21954b40f02cfc21dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019025 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735895}
-
Yi Gu authored
Similar to crrev.com/c/2024913, there are two more tests started to timeout: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXQsSBUZsYWtlIlJjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZmFzdC9tdWx0aWNvbC9mbG9hdC13aXRoLW1hcmdpbi1tb3ZlZC1ieS1jaGlsZC1ibG9jay5odG1sDA https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVwsSBUZsYWtlIkxjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2Nzcy9jc3MtbXVsdGljb2wvbXVsdGljb2wtcnVsZS0wMDIueGh0DA TBR=ikilpatrick@chromium.org Bug: 1045282 Change-Id: Id1ddd1b3d93feb2ebcf7ffa836ac9db96e837a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024914Reviewed-by:
-
Adam Ettenberger authored
This CL migrates the IAccessibleText implementation for - get_textAtOffset - get_textBeforeOffset - get_textAfterOffset .. from BrowserAccessibilityComWin to the base class AXPlatformNodeWin, and adds a helper method which unifies their implementation. https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_text.html There was an issue that get_text{Before|After}Offset were not implemented correctly according to this spec which is being addressed by this change : * BeforeOffset and AfterOffset were not returning the adjacent boundary start / end offsets. AfterOffset was setting the |star_offset| to |offset| which included that character, and BeforeOffset was setting the |end_offset| to |offset| which did exclude it. Both methods however did not select a start and end offset that formed a complete boundary. "Returns the substring of the specified text type that is located {before|after} the given character and does not include it." "For example, if text type is IA2_TEXT_BOUNDARY_WORD, then the complete word that is closest to and located {before|after} offset is returned." There is another difference for get_text{At|Before|After}Offset but it is not being addressed with this change : * AtOffset allows invalid indices for IA2_TEXT_BOUNDARY_LINE, e.g. IA2_TEXT_OFFSET_LENGTH. "All methods that operate on particular characters use character indices (e.g. IAccessibleText::textAtOffset) from 0 to length-1." Bug: 1038767, 1039516 Change-Id: Icb0916e9b96e8e2fe48c0e8a2e232381fcf421a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989027 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#735893}
-
Yi Gu authored
This test started to timeout: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWAsSBUZsYWtlIk1jaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2Nzcy9jc3MtbXVsdGljb2wvbXVsdGljb2wtd2lkdGgtMDAzLnhodAw TBR=ikilpatrick@chromium.org Bug: 1045282 Change-Id: Ia73ef9b04ac5d9cd8fa8ed80c3aacfc189e91922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024913Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bb54eb5faa03..759ef9738531 git log bb54eb5faa03..759ef9738531 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 sigurds@chromium.org [coverage] Improve displaying of coverage timeline (experiment) Created with: gclient setdep -r src/third_party/devtools-frontend/src@759ef9738531 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1022031,chromium:1042927 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id2d33dccb9cad7221a4b11aea85b9554989a4c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024978Reviewed-by:
-
Maxim Kolosovskiy authored
to fill a confirmation field This CL appends https://crrev/734460 with saving a generated password in |UserData|. |UserData| can persist over multiple steps. So, the generated password can be filled in another field (namely, a password confirmation field) or shown to a user. Bug: 1043132 Change-Id: I9f9900d03afc965f9ccb5aa51fe12ee96eb00290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022674 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#735890}
-
