- 12 Nov, 2020 40 commits
-
-
Devlin Cronin authored
Add support for an allFrames boolean in the scripting.executeScript() API. If specified, the code is executed in all frames within the tab (that the extension has permission to access). Bug: 1144839 Change-Id: Idecc69cf9599dfc821e2d309078324a6e34b0a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532901Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827032}
-
Eugene But authored
Update |hidden| argument calculations as follows: - Remove GetError() check, because same check was made earlier in the method and results in early return - Remove "is main frame" check as unnecessary, because DidFinishNavigation is not called for iframe - Remove navigation_context->GetResponseHeaders()->response_code() > 600 check, as it looks like a mistake which overrides correct comparison to status code 400 (range of HTTP status codes is [100, 599]). Bug: 924298 Change-Id: I0dc570d34ef6aed0654f7d0742190f425b2ac966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535017 Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#827031}
-
Daniel Hosseinian authored
Currently, GUIDs are returned as and stored in std::string. A dedicated base::GUID class would introduce greater type safety. Mark existing GUID functions as deprecated. Add tests for the new class. Bug: 1026195 Change-Id: I15d0c8a5907291d48d2e1ddf029390170e81993b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200456 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827030}
-
spdonghao authored
In this CL, we do two changes: 1. Add a start surface check in ToolbarManager#ToolbarNtpDelegate#isLocationBarShown. Before[1], this returns true even if it's in start surface v2 homepage, that causes the ToolbarPhone[2] set background color transparent[3]. [1] Demo: https://drive.google.com/file/d/1dPJwI4lK-9ch5Wwnx06oY9IIXenLIGzr/view?usp=sharing [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;drc=5b8933e94139a0ab5be46141666fdfcce0f624f6;l=2366 [3] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;drc=5b8933e94139a0ab5be46141666fdfcce0f624f6;l=712 2. Add a shrink animation for omnibox when it's about to be scrolled up and toolbar container is showing. Please see demo (The left one is the fixed one): https://drive.google.com/file/d/1jRfYGx9lD3UfxaTabhaNe9Cs_YWTJt2J/view?usp=sharing Bug: 1113852, 1136595 Change-Id: I549223c7a8b7c2e2f56ab62e0d0a090e1185fc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517544 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827029}
-
adoneria authored
This is an attempt to fix the error where mac builder is not able to find file /opt/s/w/ir/cache/builder/src/out/Release/gen/chrome/updater/version_info.py. Bug: 1148430 Change-Id: I671f32660913c03f0fa61c993e4fcb027c00f3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535220Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#827028}
-
Joel Hockey authored
Refactor only change. Move data conversions into FileHelper where path translation and file sharing for VMs can be done. The current code assumes only Arc is using this code, but we will soon support crostini and pluginvm. FileHelper::GetFilenames receives a list of files from the source window and returns a list of ui::FileInfo. To support this, DragDropOperation::GetFilenames has been refactored to take FileHelper and aura::Window*. FileHelper::GetMimeTypeForUriList now takes target window since the mime type will be different based on target. FileHelper::GetUrlFromPath changed to SendFileInfo which takes a callback to run when data is ready. The async callback allows files to be shared with a VM before sending the data. FileHelper::GetUrlsFromPickle changed to SendPickle which also takes a callback to run when data is ready. Bug: 1144138 Change-Id: I0356d4681705df5be174ac1debff51f4903eb742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531087 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827027}
-
Roman Arora authored
This is a reland of 74dbe648 This CL was reverted because of a flaky test in TabSearchAppTest. The test 'Verify ShowUI' was originally flaky and is now disabled with: https://chromium-review.googlesource.com/c/chromium/src/+/2533325 This is no longer an issue since this test is disabled. Original change's description: > Tab Search: Infinite list component > > A list component that renders DOM items on demand based on the viewable > scroll area and user navigation and scrolling interactions. Provides a > performance gain for use cases where users have several dozens of items > that should be available while scrolling the list by deferring scripting > and rendering costs until necessary to fill the current scroll view. > > Bug: 1099917 > Change-Id: Ib22c0edf5ebc5febe3d8d6d4f7d8ac319e9bd0a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503401 > Commit-Queue: Roman Arora <romanarora@google.com> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826287} Bug: 1099917 Change-Id: Ief4a032b3e66957576e5ce3677159345d1de9c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535013 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#827026}
-
Frank Liberato authored
Also removes "Allow copy" finch param. Code now uses "enabled" path. Bug: 1147960, 1022246 Change-Id: Ie3e7fcb85b2ed2a4ef67e41b0777aec137521bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533039 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#827025}
-
Will Harris authored
Change-Id: Ibb6f8213ef0892885cdcad3a3dd4d04e111a1edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535797Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827024}
-
David Bokan authored
The linked bug occurs, for both text and element fragments, because we try to avoid scrolling to fragments when the scroll offset will be restored by history. Manual scroll restoration is a web API that allows the page to override the scroll restoration, we treat it separately but want to avoid scrolling the fragment in this case too. However, the special case for manual restoration was missing a check that the navigation was actually a history navigation. Without this check, an ordinary (non-history) page load that sets manual restoration before the fragment is invoked will prevent it from scrolling. Bug: 1147568 Change-Id: I83e1a3cc12e9f40243c42ee21c52fef2acb36993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533149Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827023}
-
Wenbin Zhang authored
The current sharding algorithm calculates the expected shard time and stick to it. When a test has a long runtime, it could cause its sibling shard to be empty. Updating the algorithm to always update the expect time for the remaining after each shard. Also will ensure each shard should have at least one test. Bug: chromium:1130157 Change-Id: I3c335cfc58e35b48e5fd374c9d7546184cd68c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481006Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#827022}
-
David authored
There seems to be a change in M87 unrelated to the CrOS MediaApp which broke PDF loading. I think this was due to tighter CSP. This change sets our CSP so we can load PDFs as blob urls in our untrusted context and adds a test for coverage of the "object-src" policy. Further work to make our tests better & provide coverage for "frame-src" is captured in crbug/1148090. Bug: b/172881869, 1148090 Change-Id: I6e5ea0816c7f8c5a4eb382ed376e4fd98f9f671c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531075Reviewed-by:
dstockwell <dstockwell@chromium.org> Reviewed-by:
David Lei <dlei@google.com> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: David Lei <dlei@google.com> Commit-Queue: dstockwell <dstockwell@chromium.org> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#827021}
-
Sinan Sahin authored
- Swap show and hide animation interpolators - Delay the translation animation by 100ms Bug: 1137941 Change-Id: Icd70f2f78fae6093f908ff4ef79b6ffe805e9678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533529Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#827020}
-
Haiyang Pan authored
This is a reland of bce662eb It was revert in crrev.com/c/2530204, to make room for other builders. The host pool looks in a good shape today, so reland this CL and prepare to fully enable the MM-x86-rel on CQ Original change's description: > luci: increase the experimental percentage to 100 from 70 for MM-x86-rel > > The pool has plenty of 4-cores for extra builds: http://shortn/_koR1dg8Vvu > Also the host pool also has plenty of rooms: http://shortn/_xqhW5Z67ft > > Bug: 997376, 1127110 > Change-Id: I56b432d960c2f1821934667ac2f38d3fcb4705bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450331 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#813888} Bug: 997376 Bug: 1127110 Change-Id: I652429f328af4cb11fe22efc6286af832d77b43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535641Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#827019}
-
Patrick Noland authored
This crash can occur if, e.g. there are no new tabs open and DWB informs us that a site is suspended. This CL also adds a unit test for this case and two instrumentation tests; one for this case and one for a related one. Bug: 1148363 Change-Id: I7fad393bd0369c4650fb7b8c2d8bd3c3cde40bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535912Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#827018}
-
Brandon Wylie authored
TBR=peconn@chromium.org Bug: 1148493 Change-Id: I5ea9b0aab0cc0d069fea5f6f19a04712dd99eca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536080Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827017}
-
Ghazale Hosseinabadi authored
This CL displays an error in chrome://extensions page when service worker registrations fails, as opposed to calling DCHECK(false). Bug: 1136582 Change-Id: Ie1619a922966d1b2e16ca316dc8f5dae8d448616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505602 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827016}
-
Thomas Guilbert authored
The test can end before the video's first frames are painted. This CL attempts to fix the issue by making sure we have a frame per video before ending. Bug: 963141 Change-Id: Iccc9f771f4e7e366914b00b3a6004a08cf9829b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225372 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#827015}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/442f894c74b5..54fc9abd737d $ git log 442f894c7..54fc9abd7 --date=short --no-merges --format='%ad %ae %s' 2020-11-12 nharper Add out_alert to ProofVerifier::VerifyCertChain 2020-11-12 bnc Fix QuicSpdySessionTestServer.SendHttp3GoAway. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: If4b7a3415b433cc4e648b49d0c966c98b3f2cef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535690 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827014}
-
Shimi Zhang authored
Bug: 1126778 Change-Id: Icbf0745c97febdb4a640cc401f7fd2d625fe207a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536074Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#827013}
-
Ian Wells authored
Enabling for the default channel only to avoid including the change in beta when branch point is close. After branch, both enable_jdk_library_desugaring and enable_feedv2_modern should be unconditionally true. Bug: 1115463 Change-Id: I693a3f79f94280887f4d7e85711e6fe7e50ee8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519931Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#827012}
-
Tibor Goldschwendt authored
If the module visibility state is controlled by a policy the user is not able to set module visibility. We communicate that by graying out the toggle and showing a business icon explain the situation. Toggle off: screenshot/8dUeEADe6jyvyLa Toggle on: screenshot/K4WGhYvGnESmLYF Bug: 1142878 Change-Id: Id3af801552c6c01a2bf3611233c08de892393469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533581 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827011}
-
Alexander Cooper authored
The Lighting Estimation API has stabilized a little bit for the time being; this change updates the test page with the API changes. Change-Id: I770e0bb0e70e28e7373dbc650c5332247f6bb30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532772Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#827010}
-
Brandon Wylie authored
TBR=wychen@chromium.org Bug: 1148365 Change-Id: I853864863384398c02832d415e2e0c4affa8fb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536079Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827009}
-
Jeffrey Kardatzke authored
BUG=chrome:1148422 TEST=fuzzer test case now passes Change-Id: I1d466d470b827249f5884cca8db9e61bdd291563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534153 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#827008}
-
Xiaodan Zhu authored
This CL removed the periods in the strings of reverse gesture toasts Bug: 1107183 Change-Id: Ia2196d08443a4ecc08a59e1680388eb74b2c3543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535913Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827007}
-
Kevin McNee authored
This allows for the use of portals with the --enable-experimental-web-platform-features flag. Note that this is the same configuration as the M85 origin trial: same-origin, Android only (see issue 1040212). We'll hold off using this flag for enabling for desktop and/or cross origin cases until those are further developed. Bug: None Change-Id: I0579c241c58aec3e37e5dd7fba4e8375d43d91a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518613Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827006}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f86e9704c66b..696f7382ade0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,dbertoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1147077 Tbr: zmin@google.com,dbertoni@google.com Change-Id: I4d7799190c714c00c863c21c5a0d6d482e3009f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827005}
-
Eric Orth authored
Made `RecordParsed::rdata_` nullable but missed a deref in `RecordParsed::IsEqual()`. Original change's description: > Revert "Ignore unknown record types in DNS responses" > > This reverts commit e4620991. > > Reason for revert: Suspected for causing crashes on Windows/Intel. > For more info see bug. > > Bug: 1148269 > > Original change's description: > > Ignore unknown record types in DNS responses > > > > Previously worked only for address requests. Other request types (e.g. > > HTTPS), on seeing any unrecognized (and therefore unparsable) record > > type in the response, would fail the whole response as malformed. > > > > Bug: 1147247 > > Change-Id: Icd9e5ab2e39cf09ffe7c3945b011ebf1d4b45778 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529619 > > Commit-Queue: Eric Orth <ericorth@chromium.org> > > Auto-Submit: Eric Orth <ericorth@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826462} > > TBR=mmenke@chromium.org,ericorth@chromium.org > > Change-Id: I03ea912d1a9c8a01be3d84a3f4d417c385f97c2d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1147247 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533548 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826873} Bug: 1148269,1147247 Fixed: 1147247 Change-Id: I312c095e519c62d730e5fb6165833727f5d913be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534629 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827004}
-
dpapad authored
There is no reason for this file to be part of the shared webui_resources.grd, as it is only used by NTP as follows: 1) chrome-search://local-ntp/ (deprecated) 2) chrome://new-tab-page The former directly inlines the image by using flattenhtml=true, whereas the latter consumes it from a chrome:// URL. This is part of the effort of auto-genearting the contents of webui_resources.grd. Bug: 1132403 Change-Id: I20642b4c845393daf72597f156f7a934c9f3ea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533646 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827003}
-
Peter Wen authored
These defaults are no longer necessary now that downstream is using its own suppressions and baseline files. This makes sure that all targets use lint the way that these updated docs say. Bug: 1139957 Change-Id: I1ce9d79e990d472c719cdde688f2ca34a8100ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533575 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#827002}
-
Avi Drissman authored
If a string destined for a menu cannot be turned into a CFString, base64 it to allow for diagnosis. Bug: 1140620 Change-Id: I78447813c8cfa5cae92e3e02f693313faf5336ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535553 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827001}
-
Lu Huang authored
design doc: https://docs.google.com/document/d/19dGklalQTRtRrG3PKrVbDRmYPLHGLnsGEwUaed7sAFQ/edit?usp=sharing overview cl: https://chromium-review.googlesource.com/c/chromium/src/+/2393252 Chrome status: https://www.chromestatus.com/feature/5739732661174272 Bug: 1072058 Change-Id: I8a73e070d0121635be015239dc8f6c34a55fad97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461219 Commit-Queue: Lu Huang <luhua@microsoft.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827000}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ie35ef33111b2c4e5c766d8de5caa9d7612e703f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535556Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826999}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/43efdd17a959..c6215e29d0ea 2020-11-12 michael.liao@microsoft.com [ARIA]: Improve ARIAUtils.alert function If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146247 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icddbd36c5b902248e985812438308c7e91072d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826998}
-
Nick Diego Yamane authored
A regression was introduced with initial extended-drag integration in Ozone/Wayland, which causes some misbehaviours described in more details at https://crbug.com/1148021. This CL addresses the issue the following issue: wl_pointer events may come in while the drag session is still running, which is particularly troublesome when it happens just after the drop event, making the event to be dispatched to the wrong window, e.g: the latest one for which an wl_data_device::enter was received. Further details can be found in the above mentioned link. To make window drag controller more resistant to such cases, this modifies it such that it ignores wl_pointer events until the session is finished. Bug: 1148021 Change-Id: I559ec271dd2d5bfd5609a8f89528ddda760fe321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533693 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#826997}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4804ac8724ff..e6dc3d37f58c 2020-11-12 zzyiwei@google.com Disable VK_KHR_external_memory_fd for Android build 2020-11-12 natsu@google.com Handle image properties from external device memory 2020-11-12 capn@google.com Fix conditionally enabling Reactor MSan instrumentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I50a14f8d0551f6d685ccbc43ff2f16288bdba687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826996}
-
Tom Anderson authored
This fixes a regression after f4d4d111 which rolled in the addition of metrics for harfbuzz. The issue is that the system harfbuzz and our //third_party harfbuzz were getting loaded at the same time. This CL adds HB metrics for component builds to prevent loading the system harfbuzz. This change is not done for non-component builds because it's not necessary and we don't want to accidentally add a dependency on HB's metrics. R=drott Bug: 1146397 Change-Id: Ifaebf0c86bedefb29cc88709eb89fb42af5a7b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522922 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#826995}
-
Salvador Guerrero authored
This CL fixes an invalid reference when ENABLE_BASE_TRACING is disabled. It is done by moving all references to tracing clases inside the trace event macro, which is compiled out when base tracing is disabled. Change-Id: I3cde469873163ac457fc9d1057b02f6da17b6632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535610 Commit-Queue: Salvador Guerrero <salg@google.com> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#826994}
-
Jacob Kopczynski authored
Moving appropriate builders into it. Bug: chromium:1127088 Change-Id: Ie4bc188c2ef86a8f87e7b9d606c34d06651ced50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534177 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#826993}
-