- 12 Dec, 2018 40 commits
-
-
Yoav Weiss authored
This change implements the processing model from PR 168[1], when it comes to setResourceTimingBufferSize(), clearResourceTimings() and the firing of the resourcetimingbufferfull event. This is a reland of [2] which is a reland of [3] (but with nicer tests). [1] https://github.com/w3c/resource-timing/pull/168 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1350950 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1345269 Bug: 908181, 908414 Change-Id: I3a6c6e9d6a9aa5b5f907d1e86bec701ff2fa022d Reviewed-on: https://chromium-review.googlesource.com/c/1373819Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#615929}
-
Ken Rockot authored
This tears down all running per-profile Service instances for a specific BrowserContext within NotifyWillBeDestroyed rather than waiting until BrowserContext destruction, ensuring that it's safe for Service instances to refer to other BrowserContext state (e.g. keyed services) all the way up until their destruction. Bug: 913400 Change-Id: I75321476aebd954d1e5768dc2b5d4d81784a55b2 Reviewed-on: https://chromium-review.googlesource.com/c/1372318Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#615928}
-
Dominic Battre authored
This CL contains two minor cleanups ins the password manager: 1. Rename ClearPasswordValues to MaybeClearPasswordValues because the function only clears password values in some cases which was not reflected in the function name and confused me a lot. 2. Delete some unused local variables. I hope that they are intentionally unused. Bug: 831123 Change-Id: Iba308f48d13f6755b9cc1e6fb2cde19c5dc911f6 Reviewed-on: https://chromium-review.googlesource.com/c/1373761Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#615927}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8aca9026..c5def5f3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d45c4b8772e88a586bcad9e7b107b0046ae2f8a Reviewed-on: https://chromium-review.googlesource.com/c/1374090Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615926}
-
danakj authored
This is a reland of 573f4675 Was reverted because SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames failed when it landed. But the test went back to green for a few runs before this was reverted, so I don't think it was at fault. We'll see if it starts failing again on reland, and I'll watch the mac bots here in the CQ. TBR=dcheng Original change's description: > Remove code to store the last popup transiently in WebFrameWidgetImpl > > This code was copied over from WebViewImpl when adding the HidePopups > call in order to have a pinch zoom or scroll tap outside the current > popup in a non-main-frame-local-rooted iframe hide the current popup. > > This is modifying state on WebViewImpl meant to track between TapDown > and Tap, to avoid the Tap showing a popup that was hidden by TapDown. > > WebFrameWidgetImpl does not show popups on Tap, and if it did, it > should track this transient state locally not on WebViewImpl. > > Also remove the undocumented FALLTHROUGH which was not explained > in 671732 as it now goes to nothing. > > R=dcheng@chromium.org > > Change-Id: I9d67539cf0afbb9db239b73bf83418e1a877e6db > Bug: 912193, 671732 > Reviewed-on: https://chromium-review.googlesource.com/c/1372539 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615708} Bug: 912193, 671732 Change-Id: I18e8e146b5b525239d1667e267d44fa8a295599d Reviewed-on: https://chromium-review.googlesource.com/c/1374193Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615925}
-
Nicolas Pena authored
Blink intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XZU_DhQ9ZGs Bug: 911314 Change-Id: I4a79d6d3a81ec260c7db5c2bea7b2d533a1285b2 Reviewed-on: https://chromium-review.googlesource.com/c/1359480Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#615924}
-
Matthew Jones authored
Bug: 901952 Change-Id: I54bf2e5679b57d2780310272fbdf4d5defe06dcc Reviewed-on: https://chromium-review.googlesource.com/c/1366322Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#615923}
-
Friedrich Horschig authored
This test has a history of flakiness (see linked bug). Although the failure happens on Windows as well, the retry seems to succeed reliably enough. Flakiness Dashboard shows flakiness on linux-chromeos-rel as well, so disabling for all of linux. TBR=ekaramad@chromium.org Bug: 914098 Change-Id: Idfd3680040c0dba5b52504d5808c2840611dd1c4 Reviewed-on: https://chromium-review.googlesource.com/c/1373768Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615922}
-
Jinsong Fan authored
During restoring from the old cache, RestoreFromListValue always traverses all entries and sets the size of the entries to restore_size_. The CL adds check if the cache is full during restoring for performance, and sets restore_size_ to the number of cache entries that were restored. Change-Id: I40f33f326e8aa92a2b8897879c652b8b3b41e825 Reviewed-on: https://chromium-review.googlesource.com/c/1369747 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615921}
-
Joe Mason authored
Change-Id: I046ae0849fcaf1810979e019f18d3cb6f1b9785e Reviewed-on: https://chromium-review.googlesource.com/c/1374195Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#615920}
-
Steven Valdez authored
Bug: 914373 Change-Id: I31f9e3801fdc4a82497c6d2c4af6a26952c348a1 Reviewed-on: https://chromium-review.googlesource.com/c/1374150Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615919}
-
Friedrich Horschig authored
This test was failing frequently, see linked bug for details. TBR=javierrobles@chromium.org Bug: 914374 Change-Id: I6cf9df559992c594258314fbb7e736a6da9c023d Reviewed-on: https://chromium-review.googlesource.com/c/1373766Reviewed-by:
-
Peter Mayo authored
Update the files of links post blink rename. Tweak some of the verb agreements. Bug:None Change-Id: Ia18ed363b4d3a7c100ed676f89cf8c4f5833bd0b Reviewed-on: https://chromium-review.googlesource.com/c/1372476Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#615917}
-
David Tseng authored
Reland: Remove hard coded accessibility desktop tree id and make RenderFrameHost implement AXHostDelegate Account for Mac codepath in AutomationInternalApi::PerformActionFunction. Original change: This change is part of the effort to move AutomationManagerAura into ui/. This change in particular removes deps on content/ inside of AutomationManagerAura. Highlights: - removes usage of hard-coded desktop tree id in automation api (native and js bindings) - makes all known tree managers implement AXHostDelegate TBR=servolk@chromium.org,jamescook@chromium.org,sky@chromium.org,dmazzoni@chromium.org Bug: 888152 Test: existing browser_tests (Automation Api tests, ChromeVox tests). Change-Id: Ia81220ad90c9a0f3177d66a71e6b6e3afc67ce22 Reviewed-on: https://chromium-review.googlesource.com/c/1372482Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615916}
-
Harald Alvestrand authored
This reverts commit 68c1d92a. Reason for revert: Fixed an issue that fits the symptoms Original change's description: > Revert "Create RTCDtlsTransport objects in the blink layer" > > This reverts commit d7d59c5b. > > Reason for revert: virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpSender-transport.https.html fails in "WebKit Linux Trusty MSAN". > > Original change's description: > > Create RTCDtlsTransport objects in the blink layer > > > > This CL does on-demand creation of blink-layer transport > > objects. It also introduces a way to get at the webrtc::PeerConnection > > object from the WebPeerConnectionHandler API. > > > > Bug: chromium:907849 > > Change-Id: Ic86a5a66289c31d1f939a47d58bc194c32471cbd > > Reviewed-on: https://chromium-review.googlesource.com/c/1358060 > > Commit-Queue: Harald Alvestrand <hta@chromium.org> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#615072} > > TBR=hta@chromium.org,haraken@chromium.org,hbos@chromium.org,guidou@chromium.org > > Change-Id: Ie9c8d2e3dc5f97fc94ca5bf43cc30a9407d9fa4c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:907849 > Reviewed-on: https://chromium-review.googlesource.com/c/1369719 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615115} Change-Id: Ic0dcb6851d725eec31fb4203770cd21b88ce3e88 Bug: chromium:907849 Reviewed-on: https://chromium-review.googlesource.com/c/1371890Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615915}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/069664e58b9d..b59d04f79ee3 git log 069664e58b9d..b59d04f79ee3 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 cwallez@chromium.org Run linux-dawn-rel on the CQ 2018-12-12 hao.x.li@intel.com Roll Chromium build to fix undeclared argument in mac toolchain Created with: gclient setdep -r src/third_party/dawn@b59d04f79ee3 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:901830 TBR=cwallez@chromium.org Change-Id: If4b9dabc9a7d49cf0d9311d7d9b793440c1e1c88 Reviewed-on: https://chromium-review.googlesource.com/c/1374129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615914}
-
Annie Sullivan authored
Bug: 914390 Change-Id: Ib8d55b5782dd17b280440e87117654b5ede876be TBR: charliea@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/1374198Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615913}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50dd0e1a15cc..6f7831a8afd6 Created with: gclient setdep -r src-internal@6f7831a8afd6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I336dc01a3c6eaae5e9581d9553901c0ca1b831e6 Reviewed-on: https://chromium-review.googlesource.com/c/1374130Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615912}
-
Daniel Bratell authored
ChromeOS cryptauth unittest use cryptauth_api.pb which moved from components/cryptauth to chromeos/services/device_sync in bug 912743. A file still included that file from the old path (and the new path) which worked in trees where an earlier tree had generated it but didn't work in a clean tree. The files presumably had the same include guards so that is was ok to include both. TBR=khorimoto@chromium.org Bug: 912743 Change-Id: I6708c674f5fd99c94e233df5ec9b9c462c7814ad Reviewed-on: https://chromium-review.googlesource.com/c/1373826Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#615911}
-
Keiichi Watanabe authored
video.WebRTC* tasts tests are disabled on chrome bot by CL:1363805 because of a bug reported at crbug.com/909975. Since this bug was fixed by CL:1367388, we can run these tests now. Bug: 909975 Change-Id: I74b719988470552fe5abc39f217dda0086e15e71 Reviewed-on: https://chromium-review.googlesource.com/c/1367333 Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#615910}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7cfbbc30ae1c..ff2d54966a03 git log 7cfbbc30ae1c..ff2d54966a03 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 lalitm@google.com Merge "trace_processor: change CreateSchema -> Init and return base::Optional" Created with: gclient setdep -r src/third_party/perfetto@ff2d54966a03 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I70cb4c7d206c41f2b94f820526489cb60466c2a5 Reviewed-on: https://chromium-review.googlesource.com/c/1374069Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 01694e80. Reason for revert: Does not fix the bug it intended to fix. Reverting will facilitate merging of an alternative patch. Original change's description: > Address race between device notifications and enumerations in AudioDeviceListenerMac > > Originally AudioDeviceListenerMac assumed that once CoreAudio reports that a device does not exist, > it was no longer possible to get notifications related to that device, so it was safe to remove > the listener for that device. > However, since notifications can come from multiple threads and the corresponding callbacks make > a thread jump, we have observed that it is indeed possible to get notifications about removed devices > which can lead to a crash if the listener for that notification has been removed. > To address this issue, this CL does not remove listeners when the device is removed, but instead > marks the listener as deleted and posts a task to remove listeners that have been marked as deleted > for several seconds, at a time when we can confidently no longer expect notifications from the removed device. > > Bug: 911311 > Change-Id: I07cc9c8e24a0cfdfadcc04d0e8bd33e14ab61422 > Reviewed-on: https://chromium-review.googlesource.com/c/1363187 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Oskar Sundbom <ossu@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614391} TBR=guidou@chromium.org,olka@chromium.org,ossu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911311 Change-Id: Ic05d999b32ddb308649384ae29c1721d595e6347 Reviewed-on: https://chromium-review.googlesource.com/c/1373840Reviewed-by:
-
Ria Jiang authored
HitTestQuery sometimes uses the negation of the position in rect, making fuzzer min to be (min + 1) to avoid integer overflow after negation. Bug: 910592 Test: hit_test_query_fuzzer Change-Id: I78d1d15467d13d8cb65278dff85408fd22e73c3c Reviewed-on: https://chromium-review.googlesource.com/c/1372920Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#615907}
-
Francois Doray authored
There is no reason to prevent this. Change-Id: Ice12038054b3ffcbf1e165017a8c1238fb84670e Reviewed-on: https://chromium-review.googlesource.com/c/1371934Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#615906}
-
Donna Wu authored
A new method GetPort(...) for SerialPortManager Mojo interface is added. The argument list for SerialPort::Open(...) method has been changed and the related code has been adjusted accordingly. BUG=908833 Change-Id: Iba156b1abb0e636ee623cd3de6eae6d0773722ff Reviewed-on: https://chromium-review.googlesource.com/c/1369711Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#615905}
-
shivanisha authored
Entries that are added to the back/forward list without the user's intention are marked to be skipped on subsequent back button invocations. This CL only adds the bit and subsequent CLs will add metrics and the intervention logic based on this bit. Test: content_browsertests --gtest_filter=*SkipOnBack* Bug: 907167 Change-Id: I169031de2c977b53605960b8baf0cd1f6ac4ef47 Reviewed-on: https://chromium-review.googlesource.com/c/1344199 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615904}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/24328a055465..2af6ffae8264 git log 24328a055465..2af6ffae8264 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 afdx@google.com Added test related to access chains, to be extended when issue 2183 is addressed. (#2192) 2018-12-12 afdx@google.com Validate during reduction (#2194) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2af6ffae8264 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic5a8f944fbf3e834113cbcb3afdce06ea4d578bd Reviewed-on: https://chromium-review.googlesource.com/c/1374033Reviewed-by:
-
Armando Miraglia authored
Same as crrev.com/c/1373817, as I forgot to remove this one too in the previous CL since I did not catch it. BUG=736309 TESTED=ninja -C out/Default/ content_unittests && ./out/Default/content_unittests Change-Id: I2d645cfcf65640b7a4a4623976be5642d32d30d2 Reviewed-on: https://chromium-review.googlesource.com/c/1373824Reviewed-by:
-
Michael Lippautz authored
Those labels will be shown in DevTools for global handles rooting objects from a V8GlobalValueMap. V8 CL: http://crrev.com/c/1372069 Change-Id: I3a35bf4bb3cab4034e8e2af318fc1144f78d90c3 Reviewed-on: https://chromium-review.googlesource.com/c/1371822 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
chrome://downloadsNicolas Ouellet-payeur authored
Adds a message for managed users at the top of the chrome://downloads page. Enterprise users will now see a message that says "Your browser is managed by your organization", with a link they can click to view a help center article. The new UI is hidden behind a flag so that most users don't see this WIP feature just yet. Bug: 893628 Change-Id: I23781e239e3b87e7b8d4f59a679292774eea54a3 Reviewed-on: https://chromium-review.googlesource.com/c/1352616Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#615900}
-
Annie Sullivan authored
NOTRY: True TBR: charliea@chromium.org Bug: 914379 Change-Id: I565eb45766ffec543c53afc5d8ebd31b7652790a Reviewed-on: https://chromium-review.googlesource.com/c/1374191Reviewed-by:
-
Daniel Bratell authored
In some (non default) jumbo configurations, two identical MaybeGetConnectorForProcess functions ended up in tha same translation unit. It would be good to share the implementation between frame_host and renderer_host but I know no good place and the function is small, so instead give them unique names. Change-Id: I6dcb65e7f3a095ec7a73bd6bc40944180ddc6f07 Reviewed-on: https://chromium-review.googlesource.com/c/1348334Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#615898}
-
Lukasz Suder authored
When Autofill Assistant is running the keyboard shouldn't be shown. The only exceptions from this rule are: * Focus action * Asking for CVC * During Payment Request The current solution is imperfect. We only detect once the keyboard was shown and hide it. We should find eventually better solution to disable it permanently. Bug: 806868 Change-Id: I85641652f8c43ec6d3ddb59742510ff793f7f901 Reviewed-on: https://chromium-review.googlesource.com/c/1371814 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#615897}
-
Owen Min authored
Serial number should be put at the top level of report as it doesn't belong to any Browser or Profile instance. Bug: 910594 Change-Id: I1a70c322814c3b7f03ac3d8bf23ea64c38e31d22 Reviewed-on: https://chromium-review.googlesource.com/c/1372713 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615896}
-
Stephen White authored
The plan is to move the actual test targets in Dawn to Dawn's src/test directory. This change makes Chrome temporarily point at some intermediate proxy targets, so we can move the real ones without breaking Chrome. Bug: dawn:61 Change-Id: I27a66a0daffe212da3fe2a0aaba7d4a250a376ea Reviewed-on: https://chromium-review.googlesource.com/c/1373892Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615895}
-
Friedrich Horschig authored
The tests were reenabled in https://crrev.com/c/1362814 but started to flake again. Probably for a different reason but the tests have changed a lot since, so disabling is easier wrt conflicts and keeps any possible improvements. TBR=achuith@chromium.org Bug: 891484, 891277 Change-Id: Id046f7bf0558dcd98c4e0c06dc71049feb938a3d Reviewed-on: https://chromium-review.googlesource.com/c/1373822Reviewed-by:
-
Thomas Tangl authored
Before: https://drive.google.com/file/d/1CGW5Lfwln-jO1d_yCleuOtYv8lIRFyiy/view?usp=sharing After: https://drive.google.com/file/d/1oXkLoEzcUjto-0wvG9tKiPfC1jEbtU9u/view?usp=sharing Bug: 914030 Change-Id: I5dea177a8cb0c479ce491729a80fd5e88d5cfd5e Reviewed-on: https://chromium-review.googlesource.com/c/1371880 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615893}
-
Jan Krcal authored
This CL changes the implementation of CreditCard::Compare() so that we do not distinguish masked from unmasked server cards. This distinction was not needed by any of the call sites and it is undesired for wallet data sync. Namely, we do not want to write to database new server cards if the only difference is that some cards in the DB are unmasked whereas all cards from sync protos are (by definition) masked. This DB write does not change anything in the DB but it is unnecessary and it also pollutes UMA metrics. Bug: 908905 Change-Id: I187e8f717c7595220545febc22e479ea6806baf9 Reviewed-on: https://chromium-review.googlesource.com/c/1373449Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615892}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd3ad7fe5db7..2b0ac1d1ccfa git log dd3ad7fe5db7..2b0ac1d1ccfa --date=short --no-merges --format='%ad %ae %s' 2018-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 09056de49d52..9fbaf697cd86 (1 commits) Created with: gclient setdep -r src/third_party/skia@2b0ac1d1ccfa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I8f732e106dd9eac2ea57f6014319fc4940a39178 Reviewed-on: https://chromium-review.googlesource.com/c/1374030Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b7b8ca415e..50dd0e1a15cc Created with: gclient setdep -r src-internal@50dd0e1a15cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifd07ededc05d4f9d3af7c34a76b42b53993344ae Reviewed-on: https://chromium-review.googlesource.com/c/1374031Reviewed-by:
-
