GitLab

https://chromium.googlesource.com/chromium/src/+/b5c5c86c21a0bf51cc910e0b62611aea45aa0b0d
removed most of the custom logic for sync requests from
DocumentThreadableLoader. This left a lot of helper methods with only
one caller, where previously there had been two.

* Inline HandleResponse() into ResponseReceived()
* Inline HandleReceivedData() into DataReceived()
* Inline HandleSuccessfulFinish() into NotifyFinished()
* Merge LoadRequestAsync() and LoadRequestSync() paths, and inline
  the single path into LoadRequest().

Change-Id: Ie068b49396c355884e2d71588b35280dbe07a86f
Reviewed-on: https://chromium-review.googlesource.com/1087312
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565404}

This ensures we aren't running deferred runnables and reacting
to the omnibox positioning when the omnibox isn't focused.

BUG=512087,444670

Change-Id: Ie353c94caf9bbf753ea2c55dbb7974df78bcc9e4
Reviewed-on: https://chromium-review.googlesource.com/1091505Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565403}

This eliminates some console logging that should not be in production,
and fixes a potential bug in the reset screen that generates a
CONSOLE error in ResetTest but does not cause the test to fail.

Bug: 647411
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I54e8d9d6c93a3e6aeed42381f8658d182bd1c965
Reviewed-on: https://chromium-review.googlesource.com/1087210Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565402}

- Fixes an offset bug on didSelectCell on BookmarkFolderVC.
- Adds UITextFieldDelegate methods for BookmarkFolderItem, this way tapping on Done will commit the
cell title on editing.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icf73a51ff2d37738e92da2f41d1046d5397250b4
Reviewed-on: https://chromium-review.googlesource.com/1091218
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565401}

- Overwrite IsSupportedMediaTypeCB so that we don't depend too much on
  MimeUtil implementation details.
- More "using" of blink types.
- Separate the concept of an "invalid" type and an "unsupported" type.
  * In this test, IsSupportedMediaTypeCB() will support all types except
    for the invalid ones.
  * Invalid types should never be passed to GetContentTypeConfigRule().
  * GetContentTypeConfigRule() will support all "supported" types.
  * Add test cases for (subset) invalid/unsupported codec(s).

Bug: 848532
Test: New test cases added
Change-Id: I6ad01d2fa2ed3d63c5db18b9336259f7bd66537f
Reviewed-on: https://chromium-review.googlesource.com/1090113
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565400}

For rendering.mobile, the "_desktop_gpu_raster" suffix is added to the
names of pages with the GPU_RASTERIZATION tag enabled. This needs to be
added to the rendering_mobile.json file to fix missing pages.

Bug: 849392
Change-Id: I338542a87b681835a99451f09488c5b7bd54a416
Reviewed-on: https://chromium-review.googlesource.com/1090755Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#565399}

Bug: 780556
Change-Id: Iee5496e123f8969cc68ce774ad339d4c90f7c7f0
Reviewed-on: https://chromium-review.googlesource.com/1085248
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565398}

BUG=849816

Change-Id: Ie726f28d1f6c760f8330b03a93387ad7479c335c
Reviewed-on: https://chromium-review.googlesource.com/1089659Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565397}

Commit cc859bf0 introduced a new variant
of select file dialog: SELECT_EXISTING_FOLDER. Because existing code
used 'default' clauses in multiple switch statements, the compiler did
not catch that there was missing impl for the ChromeOS UI. This change
adds that missing impl.

Bug: 772180,848303
Change-Id: Ic990bf838d3a8c300414259f246715ae2efdcfe3
Reviewed-on: https://chromium-review.googlesource.com/1089877Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565396}

This CL follows on crrev.com/c/1002890, which added a new
|incremented_omnibox_typed_score| column to the visits database.

Modifies the interface to HistoryBackend::AddPageVisit() to take a
boolean |should_increment_typed_count| parameter, and moves the
decision on whether the |typed_count| should be incremented into the
caller HistoryBackend::AddPage().

When there are redirects, AddPage() now checks if the first redirect
is a simple HTTP to HTTPS redirect (that is, only the scheme if the
URL changes, along with the addition or removal of trivial subdomains
such as "www." or "m."), and if it is counts the HTTPS URL typed for
incrementing the omnibox score, rather than the initial HTTP URL. This
will cause the omnibox to learn to suggest the HTTPS URL directly.

A followup CL will rename |typed_count| and related terms to
|omnibox_typed_score| to clarify their meaning.

Bug: 542484
Change-Id: I5edac0fd24f30230000b0fc7258e8c48b6a2e78c
Reviewed-on: https://chromium-review.googlesource.com/1048826Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565395}

This factory rejects profiles with non-invertible XYZ matrices.
The old code accepted those matrices, allowing the SkImage color
space to have such a matrix. That led to failures when attempting
to decode an image (and transform to that space).

Bug: chromium:850354
Change-Id: I37de7ece181eeee0d6e8a5b389e6a6abf95e1ad3
Reviewed-on: https://chromium-review.googlesource.com/1091144Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#565394}

Sync between client and service side to eliminate races.
Then execute any callbacks on the client thread task runner.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7dc7a2aa0b7f6ed30f7a083c622fb5cbf68d521e
Reviewed-on: https://chromium-review.googlesource.com/1089637
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565393}

This is done in similar fashion to what was done with CaptionBar to
decouple the controller and event callbacks:
https://chromium-review.googlesource.com/c/chromium/src/+/1086508/6

Bug: b:80542452
Change-Id: I992d2f5d0ee63e4d28a383b4e4f7ceafeabfff80
Reviewed-on: https://chromium-review.googlesource.com/1088233Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#565392}

When a Crostini app is started by clicking on the launcher item, this
change makes the app windows start in the same display as the launcher.

BUG=chromium:843001
TEST=Manual test on an eve device.

Change-Id: Id3b65d71148d1e4107d8f9bddd31b2a27df6a58b
Reviewed-on: https://chromium-review.googlesource.com/1089880Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565391}

At the moment, the implementation of the startup notification protocol [1]
does only make sure that the window manager gets notified when the startup
process finishes for non-primary instances of the main process, that is,
when the user attempts to spawn a new chromium-browser process while another
instance is already running.

This is because ProcessSingleton::NotifyOtherProcessWithTimeout() is the only
placed where NotifyWindowManagerStartupComplete() is being called, which used
to be fine when chromium relied on GTK+ for its top-level windows (GTK+ calls
gdk_display_notify_startup_complete() when mapping the top-level window) in
the past, but now that chromium relies on Aura, it's necessary to add another
explicit call in the codepath that completes startup for the main instance.

[1] https://www.freedesktop.org/wiki/Specifications/startup-notification-spec

Bug: 553956
Change-Id: Ie9bf2db9bc04589229a18785771b6fc97dbcc9bd
Reviewed-on: https://chromium-review.googlesource.com/1072088Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565390}

Check that the display supports color correction before trying to apply
it to the hardware.

BUG=850182
TEST=Ran on device and verified NOTREACHED in
HardwareDisplayPlaneManagerLegacy isn't triggered.

Change-Id: I086e718e7ebfa8bbaf0286dac411ffee45a743ef
Reviewed-on: https://chromium-review.googlesource.com/1089858Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565389}

Bug: 850078
Change-Id: I414ccfe5457ea91f482ed18494c70b2dbc1681b4
Reviewed-on: https://chromium-review.googlesource.com/1089831
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565388}

Using wpt-import in Chromium ab8ee841.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"
fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests."
c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19163

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
rego@igalia.com:
  external/wpt/css/css-ui

TBR=foolip

No-Export: true
Change-Id: Ie665876ce5e3950d3c44bf473ec091fc4dc5d26b
Reviewed-on: https://chromium-review.googlesource.com/1091219
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565387}

Since dynamic pins are going away.

Bug: 779166
Change-Id: I3872a872b84f0780facd161f7abb88990a872b31
Reviewed-on: https://chromium-review.googlesource.com/1087646
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565386}

Merge the following into item_horizontal_padding:
 - icon_to_label_padding
 - item_left_margin
 - label_to_minor_text_padding

Merge the following into touchable_item_horizontal_padding:
 - touchable_icon_to_label_padding
 - touchable_item_left_margin

Bug: 850172
Change-Id: I3ae0207b1a1d332ac636b70a2f3c48817068ca20
Reviewed-on: https://chromium-review.googlesource.com/1089431
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565385}

We don't need to compiler workarounds for initializing text runs
anymore.

Also, harmonize escaped notation: Replace \x notation with using full
length \U universal character names.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I020cb509bf3a89eebbf9629da45a26061e4ac04c
Reviewed-on: https://chromium-review.googlesource.com/1091461
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565384}

1. Mimic Page Info behavior on URL -> add copying URL to clipboard
after long press on header
2. Move code to using lambdas in TabularContextMenuUi.java

Change-Id: If61c74b6abe1bff37b7fe168715041d8ed5d0028
Reviewed-on: https://chromium-review.googlesource.com/1088692Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#565383}

https://chromium.googlesource.com/catapult.git/+log/1331d4b..72a8685


git log 1331d4b..72a8685 --date=short --no-merges --format='%ad %ae %s'
2018-06-07 simonhatch@chromium.org Dashboard - Remove some unused indexes from TestMetadata.
2018-06-07 simonhatch@chromium.org Dashboard - Skip empty last_ran_timestamps
2018-06-07 simonhatch@chromium.org HistogramSet - Merge TagMap diagnostics in add_reserved_diagnostics
2018-06-07 simonhatch@chromium.org Dashboard - Removed unused global from pinpoint_request.py


Created with:
  gclient setdep -r src/third_party/catapult@72a8685

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:849752
TBR=sullivan@chromium.org

Change-Id: I34997ad164552bf636bd13c5dce8f68fd2f47c16
Reviewed-on: https://chromium-review.googlesource.com/1091173Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565382}

Clients of //ios/web_view may display a favicon as a UIImageView.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I85da27ac6fbcd4b8a0244d468daf17cb8c619499
Reviewed-on: https://chromium-review.googlesource.com/1089644Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565381}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0de5a91..a206cf9


git log 0de5a91..a206cf9 --date=short --no-merges --format='%ad %ae %s'
2018-06-07 hidehiko@chromium.org Remove 90 min timeout for Pre-CQ launching.
2018-06-07 nya@chromium.org sync_stages: Detect early crashes of pre-CQ builders with Buildbucket.


Created with:
  gclient setdep -r src/third_party/chromite@a206cf9

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:843640,chromium:843640
TBR=chrome-os-gardeners@chromium.org

Change-Id: I8545700c0cb5acc6ddf0a2762670d305be5692af
Reviewed-on: https://chromium-review.googlesource.com/1090764Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565380}

Releasing new Chromedriver 2.40

Change-Id: Icca7d51d495fe4fe86aa3bc49c00d04eb636fa40
Reviewed-on: https://chromium-review.googlesource.com/1091234
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565379}

The SimplerURLLoader API is compatible with the out-of-process network
service.

This is the only code that uses chunked uploads, and the new API for
that requires the consumer handle all the complexities of that, which
makes this CL much more complicated than most URLFetcher to
SimplerURLLoader conversions.

BUG:  810555

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr
Change-Id: I4cc1f5f8710d08830062e95296ae5d814a6097e8
Reviewed-on: https://chromium-review.googlesource.com/1050825Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565378}

Move image_decoding_cases into rendering folder and modify to inherit
from RenderingStory class

Bug: 849392
Change-Id: I56b02c60c1f674f7c48b8bf378b8bc92f68f4205
Reviewed-on: https://chromium-review.googlesource.com/1089290
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565377}

fidl_library.gni will be used for targets defined outside "third_party",
so promoting the GN template to a higher level makes sense.

The relocation was verified using "gn gen --check".

TBR=sergeyu@chromium.org

Change-Id: Ib632e466185f77f7b4f5bc43b13439bdd28faf3c
Reviewed-on: https://chromium-review.googlesource.com/1091157Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565376}

This change creates the NetBiosClientInterface. This interface will allow
us to create a FakeNetBiosClient that can be injected into the
NetBiosHostLocator class for testing.

Bug: chromium:757625
Change-Id: Iadf5965ce43a504f5babe2220944d91b48b9d537
Reviewed-on: https://chromium-review.googlesource.com/1081299
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565375}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/1da9c3346d87..f7d78b109d17

$ git log 1da9c3346..f7d78b109 --date=short --no-merges --format='%ad %ae %s'
2018-06-05 liberato Updated chromium/patches/README
2018-05-31 michael avcodec/vp3: Fix end of bitstream check in unpack_superblocks()
2018-06-05 liberato Automatically build chrome patches with find_patches.py
2018-05-31 modmaker Fix heap buffer overflow.
2018-06-01 liberato Add check_merge.py
2018-05-24 liberato Add null check for encryption info.
2018-05-21 liberato Configs for merge-m68a
2018-05-15 michael avformat/mov: Only fail for STCO/STSC contradictions if both exist
2018-05-15 michael avformat/mov: Break out early if chunk_count is 0 in mov_build_index()
2018-05-20 jerome.borsboom avcodec/vc1: FIELDTX is only present in interlaced frame I/BI pictures
(...)

Created with:
  roll-dep src/third_party/ffmpeg
BUG=832852

Change-Id: If5ffa2bfedd2bdd9a43ac338455af9993d634b93
Reviewed-on: https://chromium-review.googlesource.com/1087767Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565374}

Now that the app shell is being built on the bots, it shouldn't give verbose
logging output during the build.  This CL is a partial merge of [1], which fixed
the issue for the Linux Chrome packages.

[1] https://chromium.googlesource.com/chromium/src/+/8e3b5543f0dfc6585ad06aa2c2235a3a813438cd

BUG=None
R=michaelpg

Change-Id: Id97fe1b3e6694a15e36f324d954a9fa7e2b61e7b
Reviewed-on: https://chromium-review.googlesource.com/1091295Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565373}

We previously had a behavior in the new Android horizontal tab switcher where
opening the tab switcher would show the previous tab instead of the current one.
I previously landed a CL to remove this behavior, but swiping down from the
toolbar is still showing the previous tab. It turns out there's a totally
separate piece of pre-existing logic that, together with the scroll snapping,
is actually causing swiping down from the toolbar to still go to the previous
tab. We of course did not notice this prior to removing the "show previous tab"
behavior.

This CL fixes this pre-existing logic to not show the previous tab.

Bug: 849480,831359
Change-Id: I0b89f87e536c5d4938638fbd6ac7fabde568e772
Reviewed-on: https://chromium-review.googlesource.com/1091230Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565372}

These tests mix use of QuitCurrent*Deprecated() with use of the current
RunLoop::Quit*Closure() model. Migrate them off the deprecated API so
that we can enforce quit-by-closure-only wherever QuitClosure is used.

Bug: 844016
Change-Id: I5c8b2557d361ea9ade9f5da0440bac7f7878440e
Reviewed-on: https://chromium-review.googlesource.com/1090214Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565371}

Add function to convert byte array spans into stringpiece
representations in fido_parsing_utils.

Change-Id: I8a5aca9c980cee994aeb6b46fd2cfd7f5417998c
Reviewed-on: https://chromium-review.googlesource.com/1087816
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565370}

content:Shell used QuitCurrent*Deprecated(), while many of the //content
browser-tests use the modern RunLoop::Quit*Closure() mechanism.

Migrate content::Shell off the deprecated API, so that we can enforce
quit-by-closure-only wherever QuitClosure is used.

TBR: kinuko
Bug: 844016
Change-Id: I661c3ed1c799680dea9760d3fb43d78aa8039897
Reviewed-on: https://chromium-review.googlesource.com/1090219Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565369}

We are in the process of migrating ContentHashFetcher from
URLRequestFetcher to SimpleURLLoader (see bug 844926).

For this, we need to stop storing URLRequestContextGetter
raw pointers in ContentHash::FetchParam. Instead it will store
a std::unique_ptr<network::SharedURLLoaderFactoryInfo> instance,
which is non-copyable.

This is a preparation CL that adapts ContentHash::FetchParam
to hold non-copyable members. For this, it removes both copy-ctor
and the assignment overload (=), and uses std::move to pass
FetchParam instances around.

BUG=844926

Change-Id: I417543ddd377eef39146fcce69c325a35c499f6c
Reviewed-on: https://chromium-review.googlesource.com/1089273
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565368}

Bug: 843124
Change-Id: I56b9beb4e16e74361cf291998fc78ec232c6fc0c
Reviewed-on: https://chromium-review.googlesource.com/1089587
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565367}

Bug: 813104
Change-Id: I0139374f0f05c2a685d413e8c9d4bfcd5204cd67
Reviewed-on: https://chromium-review.googlesource.com/1088702
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565366}

Also rename from LevelDBWrapper to StorageArea to better reflect what
the interface is used for.

Bug: 781870, 809771
Change-Id: I712fee920d95f5e18dc6bfa74d1277c8aed4bd19
Reviewed-on: https://chromium-review.googlesource.com/1087495Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565365}