- 27 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/34c9aac3f30d..25a8165f50bc 2020-07-27 rharrison@google.com Clean up issues discovered by Infer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I639cfa98d922ae7c3762a6ac440fab595fd3175e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320198Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791940}
-
Robert Sesek authored
The order of the get_parts() dict is different between 2 and 3, which causes entitlements to be copied in different order. Fix this by sorting the entitlements before processing. Also fixes a bytes vs str issue and a set() stringification difference. Change-Id: If3e5594ce1e9d505a2ce2e3042c35a257f121daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320414Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#791939}
-
Zhenyao Mo authored
BUG=711140 TEST=none TBR=asvitkine@chromium.org Change-Id: Idb70f3b9d518523eeb7ef2d27cea98e0b056e481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320415Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#791938}
-
Theresa Wellington authored
TBR=sinansahin@google.com BUG=1109965 Change-Id: I157f44d8557a457390321194e9e81be53fe2ea07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319344Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#791937}
-
Xiaohui Chen authored
Name cannot directly use binary data, convert to base64 instead sans the path divider. Bug: None Change-Id: Ibb0a7d4dfe749fee50ac2812b55280850f1284ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318479Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#791936}
-
Ken Rockot authored
This CL moves Chrome's renderer-side error page auto-reload behavior implementation to a new browser-side NetErrorAutoReloader helper within the error_page component. Correpsonding tests are rewritten as browser tests within components_browsertests. Bug: 1098578 Change-Id: I42e7af0a3d23364d5065e474312f35620299ff54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302927Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#791935}
-
My Nguyen authored
As policy is disabled by default, giving managed users more choices when the policy is enabled. Bug: 1108233 Change-Id: I86a2dd347116ea78d72134261fdc51c80f6d0d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312023Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#791934}
-
George Steel authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2303353 addressing post-submission comments. Add missed test case and fix list sorting. Bug: 1105144 Change-Id: I307065b3a8f4915a8b400c328ef2998fa8305e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314296Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#791933}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.25-1595242326-benchmark-86.0.4208.0-r1 to 86-4183.39-1595842708-benchmark-86.0.4208.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I49798df8826d23fdb5605a86771cb80e7ee5ab0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320201Reviewed-by:
-
Henrique Nakashima authored
This fixes some lint warnings, so we can remove the suppressions. Bug: 1107950 Change-Id: Idbe53038d4595fb571d374f04665671dd68e4d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310789 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#791931}
-
Livvie Lin authored
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/2298324. Disable the "Always Show Full URLs" View menu item if the pref is managed by policy. Change-Id: Ib7c03080865cb4b13d064fc24b936b9fb5236833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318308Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791930}
-
Brandon Wylie authored
Bug: 1105810 Change-Id: If5f201407af5b666e898fb14c0cdc48078342cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310771Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
-
dpapad authored
This is addressing several identical TODOs in the code. Bug: None Change-Id: I298b4d9e5a2fd048342b265cef11b74b53fb2c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318645 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791928}
-
Andre Le authored
Add a rough sketch of media controls view to the system tray. Contains the layout for the chip, artwork, title and artist label. UI screenshot (dummy content): https://screenshot.googleplex.com/jGkyTezPpoS Change-Id: I5c96ee6ca73da086063e1fe3c2842b969f5e24ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314197Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#791927}
-
Lijin Shen authored
This animation coordinator has not imported by any other component. Bug: 1081343 Change-Id: I165eba183183e3417cf1041d8e906fdefedb3764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317776Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#791926}
-
Peter Wen authored
Allow linting with a minSdkVersion that is different that the current APK/Bundle's min_sdk_version. This paves the way for using a single unified target for most lint runs. e.g. monochrome_public_bundle can set lint_min_sdk_version to 21 so that it lints against a lower minSdkVersion than its min_sdk_version (24). Bug: 1108791 Change-Id: I703d1ef19f7fc9182f52bc6ef0ae8535c024b10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316334 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Geoff Lang authored
Bug: chromium:1100599 Change-Id: I6c41ad568d09ffba4ddf2edd4ea2d0a44d047cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307656Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#791924}
-
Devlin Cronin authored
Update remaining tests under //content/browser/portal to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: I7618db78b2d55c9919e91ab4c2c7ff7f9589e827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316449Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791923}
-
nancylingwang authored
When clicks the launcher button, AppServiceAppResult is created for each app, and call LoadIcon, which could genearte mojom calls to load the icon. Remove SweepReleasedIcons when the view is closed to keep the icon cache in IconCache. When the app is removed or the icon is updated, call RemoveIcon to clear the map in IconCache. BUG=1104650 Change-Id: I6f5bfb44c9892187976f89ecb3993430fb565f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318486 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#791922}
-
Adithya Srinivasan authored
This reverts commit ffc377fd. Reason for revert: Suspect that this CL is causing All/DumpAccessibilityEventsTest.AccessibilityEventsAriaComboBoxNext/uia and All/DumpAccessibilityEventsTest.AccessibilityEventsListboxNext/uia to fail (https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/69290) Original change's description: > Fire UIA SelectionItem events on aria-checked changes for radio buttons > > According to the following spec radio and menuitemradio should expose > UIA SelectedItem.IsSelected when aria-checked is set : > https://www.w3.org/TR/core-aam-1.1/#mapping_state-property_table > > This CL ensures that radio / menuitemradio fire appropriate > SelectionItem events, and whenever a SelectionItem changes its > selection state that we also fire a Property Changed event for > SelectionItem.IsSelected. > > AX-Relnotes: Fire missing events for ARIA radio/menuitemradio when aria-checked changes. Narrator will now announce selected state changes for this scenario. > Bug: 1102580 > Change-Id: I72f479e25f61b0ddffc28f73d4a9c34e8dc4ecb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212982 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#791802} TBR=nektar@chromium.org,aleventhal@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,iapres@microsoft.com,Adam.Ettenberger@microsoft.com Change-Id: I3b387e3202afb366f0f64671270524c4792e12ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321113Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791921}
-
John Lee authored
Fixed: 1098542 Change-Id: I44d2ea06756939a4d60d533b90d40c57e9e09a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318307Reviewed-by:
-
Pete Williamson authored
When we added the explore surface, we did not also override the navigateToHelpPage method. This change adds an override to fix the "Learn More" feature of the discover feed. The web page we direct the user to is for the NTP, reviewers might want to check that it still makes sense for the explore surface as part of this code reivew. Bug: 1106875 Change-Id: I45c572a5fc75e28bcc927d0625dd6179f6fafd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315184Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#791919}
-
Wei Li authored
Change the type of a menu separator to a property which can be set separately. Also add some basic unit tests for this class. Bug: 1108460 Change-Id: I7201e2b22c56e0b5efa366758bd217bba15ede10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314658 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#791918}
-
Richard He authored
Use vpython for `generate_gradle.py` and `list_java_targets.py` Change-Id: I39bb601add8cc1c019a3aab9bca60bee0e341084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315400 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Update tests under //chrome/browser/pdf to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: I03badfdb5956066553b4d6d278aae6b34ad94715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316702Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791916}
-
Devlin Cronin authored
Update remaining tests under //chrome/browser to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: Ib6da6799bb906b7547ab8d4fce4066a0a976df24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316948Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791915}
-
John Lee authored
Bug: 1084620 Change-Id: Idde2fe2bc1ce4f387a20a00d01aa7c8ba13354a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311039 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#791914}
-
Sophie Chang authored
Bug: 1108891 Change-Id: I627b0ca7aa08dbe3717654ff6ba1cb9233237540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316324Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791913}
-
Guillaume Jenkins authored
In preparation for bringing Chrome Browser Cloud Management to iOS, this adds a command-line switch to control whether CBCM is enabled. It needs to be a command-line flag because policy infrastructure is initialized before Finch / about flags and field trials. Bug: 1066495 Change-Id: I0bd27e5ee863deda949afa64b248ca5445f9ef8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316620 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#791912}
-
Liviu Tinta authored
Because word is highlighted the cursor position is lost. The fix moves highlighting after code knows if the event was 'preventdefaulted'. Bug: 1076078 Change-Id: I08ebece22beee7cc71dd6e8241cb42f7be2e0331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183174Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#791911}
-
Ian Kilpatrick authored
TBR: atotic@chromium.org Bug: 1108224 Change-Id: I29901956f130097aec56b1f37def05595c59664f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318550Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#791910}
-
Lijin Shen authored
Update email address in presubmit warning message Bug: 1109248 Change-Id: If55f0651bf1606a596dfb65733d01d23411e7db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317845Reviewed-by:
-
Alexei Svitkine authored
Bug: None Change-Id: Id0981a264b247208a78ba0cddad59166528c53fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304974 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#791908}
-
David Benjamin authored
Instead parent the sheet to the specified gfx::NativeWindow directly. This avoids a host of bugs around the native constrained dialogs machinery, but does mean the dialog is now window-modal rather than tab-modal. On Windows, where we also use the native dialog, the sheet is similarly window-modal and the certificate viewer only ever opens in response to the user clicking in browser-owned UI or DevTools, so there shouldn't be an abuse concern. See https://crbug.com/1098786#c4 Bug: 762915, 1078158, 1098786 Change-Id: Iafeee58fd04aff9f8b88e8c2f030fe18913f81f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313160Reviewed-by:
-
Ben Kelly authored
Previously BlobBytesConsumer would read the BlobData object by first create a DataPipeGetter and then passing the resulting pipe to a FormDataBytesConsumer. The FormDataBytesConsumer would then internally use a DataPipeBytesConsumer to read the pipe. This CL attempts to simply things by having BlobBytesConsumer use a DataPipeBytesConsumer directly. In addition, it uses BlobData->ReadAll() avoiding the need to create a DataPipeGetter. This removes one mojo call. Bug: 1076081 Change-Id: I0f270cd99c9808c85d43523ac700aafe75d49c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171017Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#791906}
-
Hiroki Nakagawa authored
As a part of the Onion Soup project, this CL moves PreviewsState from content/public/common/ to blink/public/common/. In addition, this merges WebURLRequest::PreviewsState into that. Notable changes in this CL: - PreviewTypes enums define both FOO_BAR and kFooBar styles to avoid non-essential diffs. FOO_BAR is used for the content side, and kFooBar is used for the blink side. Follow-up CLs will merge FOO_BAR into kFooBar. - This CL adds a new dependency rule in component/previews/content/DEPS to allow to include blink/public/common/previews_state.h from there. Change-Id: I5ce7e8bb844416ac2482143665925e08b7858746 Bug: 860403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319489Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#791905}
-
Evan Stade authored
Bug: 1097216 Change-Id: Ibdb9a50ea5f6a7313bd65f45cf9bd38744eb9469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317685Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#791904}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1595789207-a5f1c4250bc5f6d42bdf1b980d8df879d82cd223.profdata to chrome-win32-master-1595851043-c14119a80137ce7090e196461287429806779e74.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id4a39f0baf4669bf2233c14ea24208e3fe4eb4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320191Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/60cbf70944cf..4fd830acab6f 2020-07-27 landrey@webrtc.org Add possibility to adjust frames before comparison in pc level tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I05f3f0b46f26c18e8755e1f1e24387e8ff5273ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320043Reviewed-by:
-
arthursonzogni authored
A python server is used has a communication channel in between documents from different browsing context group and potentially cross-origin. There are two methods: - one for writing a message. - one for reading the message. I initially supposed we won't need to store more than one message in the stash. It turns out there are tests doing two write in a row without any read in the middle. It was throwing an exception when this happened. This patch makes the server to maintain a queue of messages instead. It doesn't throw errors anymore. Bug: chromium:1109194 Change-Id: I25f8dc2c2a032781a4527a0994e94e46f85e12c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317865Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791901}
-
