- 09 Jan, 2020 33 commits
-
-
Oksana Zhuravlova authored
This change adds traces under BrowserMainLoop::CreateThreads:PreMainMessageLoopRun(). Bug: 1019793 Change-Id: I89577b30b797af78e19cf6afc0079a264fc1df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986906Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#729585}
-
Antonio Gomes authored
... down to renderer/platform/mediastream, and also rename it to webaudio_destination_consumer.h. BUG=919392, 704136 R=haraken@chromium.org Change-Id: I1592af19495c729ab7911036c1a6858e610822f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991403Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#729584}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I08583b374f6ac6fc688730cba2ab91ee4688cf3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729583}
-
Fabrice de Gans-Riberi authored
This reverts commit 71a290c2. Reason for revert: Suspected cause of failures in WizardController* tests on chromeos: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1413 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16312 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/33460 Original change's description: > Reland "Squash top level error code returned from host resolver." > > This is a reland of 834f2092 > > Original change's description: > > Squash top level error code returned from host resolver. > > > > If the host resolution process fails, the top level error code should > > now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g. > > ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be > > found in ResolveErrorInfo. > > > > Bug: 1016325 > > Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678 > > Commit-Queue: Katharine Daly <dalyk@google.com> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Eric Orth <ericorth@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#728725} > > Bug: 1016325, 1039639 > Change-Id: Ifcf5d1c8d3e5558e81b9efc784d234d034ee9a52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990249 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#729518} TBR=jam@chromium.org,mmenke@chromium.org,ericorth@chromium.org,dalyk@google.com Change-Id: If09e8178659f5d47503ccee5cb8919d099b2330a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016325, 1039639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992812Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#729582}
-
Matt Reynolds authored
A single physical device may expose multiple HID interfaces. Each interface is represented by a HidDeviceInfo object. To allow HidDeviceInfo objects to be grouped by physical device, a |physical_device_id| member is added that will be used to identify the physical device. This CL adds the new member and updates callsites to provide a value for the physical device ID when constructing a HidDeviceInfo. The platform logic to construct the ID will be added in a followup CL. BUG=1011499 Change-Id: I0f821de0693d625a5279f057b9986dc71923ccda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987113 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729581}
-
Sam Fortiner authored
We plan to start experimenting with preferring compositing over LCDText in the next couple weeks (tracked via https://crbug.com/984346). This histogram will help provide insight into the impact on text quality and needs extended to cover the experimentation timeframe. Bug: 1036860 Change-Id: I8612404f727604b0f94211c1bbfa5233c2d9acf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990259Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#729580}
-
Alex Cooper authored
vr_pixeltests were failing on Windows 7, so they were disabled for all windows platforms, though the evidence is that they were fine on other platforms. Given that VR is not supported on Win7, only disable these tests on that platform. Fixed: 1035767 Change-Id: Ic97593f9b324c30111ec1465ae3da41de7aa2c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985126Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#729579}
-
Gang Wu authored
https://cs.chromium.org/chromium/src/skia/ext/image_operations.cc?g=0&l=408 The first parameter should be the source of image, not the destination. Bug: 1039791 Change-Id: Ib0fc4cc2b3a15143b4ceb3de7ca558e0d279e3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990206 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#729578}
-
Kent Tamura authored
If a radio button is connected or owned by a form, radio button groups are managed by RadioButtonGroupScope in order to complete various operations for a group in O(1). Otherwise, we did not assume a radio button belonged to any groups. It didn't conform to the HTML standard, and was not interoperable with Firefox. After this CL, such radio buttons are grouped without RadioButtonGroupScope's help. We iterate over the tree including the target radio buttons to find a checked button in the group or |required| attribute in the group. Bug: 883723 Change-Id: I56185559592dff6b0254655aeb499ed6ac29df64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988087 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#729577}
-
Ross Zwisler authored
We will need this flag until we have completed the uprev of SKL-Y and SKL-U Chrome OS systems to their new kernels. It's unclear exactly when this will be done, but my best guess right now is around M87. Also, remove Jon from the flag contacts as he's moved on to other adventures. BUG=b:144308685 Change-Id: I7675b7542b8f73a82f958bb50dfc9bd64a91486a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991723Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Ross Zwisler <zwisler@google.com> Auto-Submit: Ross Zwisler <zwisler@google.com> Cr-Commit-Position: refs/heads/master@{#729576}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I8082fccac2a20d00e916f9e6d2abeb88de8e1ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991983Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#729575}
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in device/gamepad to reduce the pre-processed size of header files and shorter build time. Additionally, this CL modifies device/fido as well. - device/gamepad - device/fido This CL has no behavior changes. Bug: 1001360 Change-Id: If8a759c7551699c41d594ef4831d2f099bec02a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989710Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#729574}
-
Karan Bhatia authored
It's not used anymore. BUG=None Change-Id: I62d5b22b61ed08e7a6be8fac730506137b5b5b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992502 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729573}
-
Ian Kilpatrick authored
Previously we'd store intermediate calculations of margins directly on a FlexItem's box. This instead stores the intermediate margin calculations on the FlexItem directly. This is primarily just a refactor / cleanup. (The existing code was fine, not causing any bugs/issues), but was somewhat confusing from a LayoutNG p.o.v. as transient calculations shouldn't be stored directly on the LayoutBox. Change-Id: Ia37b3837ecbbfbd3f61c19571536fc8484d85d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977196 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#729572}
-
Simon Que authored
This CL migrates the trunk/branch builders: CI: - GPU Win x64 Builder - Win x64 Builder Try: - win10_chromium_x64_rel_ng Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I0a688a919a1199a583200ce8d4928777c03b7370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965739Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#729571}
-
Johannes Henkel authored
Upstream PR: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1990896 New Rev: dee0c0c65cc2df6284e75ae9fca083dc604c9fca TBR=caseq Change-Id: I66f6146ec38c1abfeeb04822cb7d1c7f64b580ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992202 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#729570}
-
Michael Spang authored
Chromecast cross compiled builds are always stripped before being deployed to the target, so local symbolizion doesn't work there. Enable print_unsymbolized_stack_traces in this config to ensure traces are in a consistent format, which should be post-processed with asan_symbolize.py. Bug: 1040148 Change-Id: Ib133644336beba363faf0efe7792d8bee62531c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991727Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729569}
-
Natalie Chouinard authored
Extract the following preferences to Settings build target, along with owned resources: - ButtonPreference.java - ChromeBaseCheckBoxPreference.java - ChromeSwitchPreference.java - TextMessagePreference.java Bug: 1035928 Change-Id: I1aa8e616bbb1b98bc4217ef2669d5388dab40cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991732 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729568}
-
Kurt Horimoto authored
This is the only infobars::InfoBar subclasses used on iOS. Bug: 1030357 Change-Id: I70bc1336792bd861921dcafbec20ffa7ed1a6142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990077 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#729567}
-
Chong Gu authored
When remote debugging port set to 0, allow web_engine_shell to find available port to use. Allow web_engine_shell to log the remote debugging port (if turned on). Bug: 1014642 Change-Id: I7e7b98f10eb8ea0aa17c1a4761bbb50bf9d32dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984626 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#729566}
-
Yuichiro Hanada authored
We changed the flag according to whether an app is launched by a key event or not, however it leads to undesirable results because of the unpredictability of which element will be focused on startup. This CL stops sending an intent to exit touch mode when launching an ARC++ app by a key event. Bug: b:146477273 Test: Launch app by enter key and checks the mode is not changed. Change-Id: Id57099803572cb3e800553c4cbb1022cc215a1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977876Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#729565}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a47e1e9794a7..bd26a09fd13c git log a47e1e9794a7..bd26a09fd13c --date=short --first-parent --format='%ad %ae %s' 2020-01-08 mattm@chromium.org netlog_viewer: remove obsolete code to handle 0 source IDs Created with: gclient setdep -r src/third_party/catapult@bd26a09fd13c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: I831b8996493d19690d1baa949ada7bcd1b96e623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991796Reviewed-by:
-
Mia Glaese authored
Adapt metrics collection to OverviewModeStates. Before: State change metrics are collected at visibility change, even if state does not change. After: Metrics are only collected if state changes. Bug: 1025296 Change-Id: I1e6ab1282a7a154d5542d24f27b6b97a942ba32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980477 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#729563}
-
Mythri A authored
Bug: chromium:1039752 Change-Id: I78c02405c0f146aa862104dd9fd7df634fed71c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991341 Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#729562}
-
Xianzhu Wang authored
Previously we used the default float to int conversion which truncated the fraction part of the zoomed line height, and the painted document marker might overflow the visual rect of the display item client, causing residues when a document marker is removed. Now use ceilf(). Bug: 1004799 Change-Id: I8df56c563e4c468241a0710f37a80a1e6c55c45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989858 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729561}
-
Matt Falkenhagen authored
The feature is already enabled by default, and will be removed from the study. Also the study will remove the "All" suffix in favor of just "Ui_Ps" to indicate both ServiceWorkerOnUI and ServiceWorkerPrefersUnusedProcess enabled. Bug: 692909 Change-Id: I39cfeeae8036673dddced0ad728a6e3829f35d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989744Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#729560}
-
gogerald authored
Screenshot: https://drive.google.com/a/google.com/file/d/1L6h8C25L-4BTqVNBHwWYPEXHZwol8oNb/view?usp=sharing Bug: 1040242 Change-Id: I1384044eb5fc3be346d191a6b77d9b15d1ebd422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992165 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
Adrienne Walker authored
Bug: 1015214 Change-Id: I69553d4434f7b8b5d647373869a94705b45a234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992599 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#729558}
-
Demetrios Papadopoulos authored
Some permissions are only needed by one of chrome://settings or chrome://os-settings but not both. Specifically, with this CL the following APIs are only accessible by chrome://os-settings - chrome.bluetooth - chrome.bluetoothPrivate - chrome.networkingPrivate - chrome.system.display - chrome.usersPrivate while the following only accessible by chrome://settings - chrome.autofillPrivate - chrome.management - chrome.passwordsPrivate Bug: 990177 Change-Id: Id40dbcd1cf92eaf7227744c9b38267cc786c1476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990027Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#729557}
-
Alex Cooper authored
Currently WebXr uses a custom consent flow. Due to changes in the spec, and desired expansion to other platforms, WebXr needs to switch to using the Permissions API instead. This change adds a flag to enable development of switching the consent prompt out with calls to the permissions api. Note that while the spec is evolving to allow proper querying by sites in the renderer, this flag is intended to only gate switching the internals. (e.g. using the permissions API to prompt for user consent to initiate a WebXr session). Bug: 1033592 Change-Id: I0eec6308f6432cbff3c60bff3e949fe3b2205926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992267 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#729556}
-
Suzy Li authored
This CL resolves a crash issue when calling isUVPAA on clank twice by adding pending requests queue in clank. Bug: 1039822 Change-Id: I4b380f3c045f6921291ea9264243ed53a65ee93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990491 Commit-Queue: Suzy Li <suzyli@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#729555}
-
Connie Wan authored
Previously it was being colored dark/light based on the browser theme, which made the color the same as the actual group in the tab strip. But bubbles are not affected by browser themes, but rather by native themes, similar to context menus. See attached bugs for full context. Bug: 1027483, 1039998 Change-Id: Id783f71e643b720f3c138e736db25d69a92d122b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992310Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#729554}
-
Devlin Cronin authored
When a user uninstalls an externally-added (sideloaded) extension, we store a pref so that Chrome doesn't try to re-add the extension when it next sees it. Currently, this is stored as a bit in the extension's entry in the ExtensionPrefs (setting "state" to "EXTERNAL_EXTENSION_UNINSTALLED"). Unfortunately, this causes a number of interesting side effects, because it means that, in this specific scenario, the Preferences retain the Extension's entry even after uninstallation. Then, when re-installation is attempted, some of those preferences can have an impact. In the past, this has also led to improper behavior around installation of an extension (see linked bug). Fix this by instead storing uninstalled external extension IDs in a separate preference entry ("extensions.external_uninstalls"). This way, we can fully remove the Extension's entry in preferences when it's uninstalled. Add migration logic to move all externally-uninstalled extensions into the new array, and remove their entries from prefs. Add unit tests for the migration logic, external uninstall being set and retained, and for the scenario of a user uninstalling an external extension and re-installing it again. Bug: 795026 Change-Id: I177777ed78cf0a85ad9be4366999a80aecd495ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982239 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#729553}
-
- 08 Jan, 2020 7 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3a797afd61ff..0d462e99bc1f git log 3a797afd61ff..0d462e99bc1f --date=short --first-parent --format='%ad %ae %s' 2020-01-08 ehmaldonado@google.com git-hyper-blame: Simplify code and tests. 2020-01-08 ehmaldonado@google.com depot_tools: Add tests for gclient_paths 2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@0d462e99bc1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib0da3c38e158ef9e35afd57338b59dae4d04a21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991786Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/625b71f2a1fc..fbc5981eaf58 Created with: gclient setdep -r src-internal@fbc5981eaf58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1027573,chromium:1033541,chromium:1034074 Tbr: jbudorick@google.com Change-Id: Ia354351ddc82feeafac9d05e384a1ad6465d5f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991794Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729551}
-
kylechar authored
The VizDisplayCompositor feature can't be disabled on Android and WebView has a separate VizForWebView feature it checks. Remove the remaining feature checks in Android/WebView code and delete dead code. Bug: 936425 Change-Id: I855ce93245c15fcde44730b43e80d18834df2a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990332Reviewed-by:
-
Jenny Zhang authored
Track number of unique search queries issued. Will be used to calculate overall Search CTR. A unique search query is defined as whenever the search box goes from empty to non-empty. TBR=holte@chromium.org Bug: 1035529 Change-Id: Iaeadb897c5ad86ba6a65c9b49edb4ff8fb427d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977187 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729549}
-
Sajjad Mirza authored
Bug: 1035215 Change-Id: If3cadd81545eaa1fe4f69e8f25e7e638854c853a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990471Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5c660e0cd868..4a6e84920793 git log 5c660e0cd868..4a6e84920793 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 mtklein@google.com add add/sub/min/max w/ constant ops 2020-01-08 michaelludwig@google.com Reland "Avoid loop-dependent behavior in GrMemoryPoolBench" 2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-08 mtklein@google.com clamp to [0,1] before blending with normalized 2020-01-08 brianosman@google.com Expose the Input variable and Child name collections in SkRuntimeEffect Created with: gclient setdep -r src/third_party/skia@4a6e84920793 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I98e9703e2620546b45209892709fdbe84e77e1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991787Reviewed-by:
-
Devlin Cronin authored
Update NavigationBrowserTests to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Additionally, we no longer have to worry about the lifetime of the observer (since it handles its own cleanup), so these can be properly scoped. Bug: 1034150 Change-Id: Idf52898484da7e5ec3fd0d3210580acba8294096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983591Reviewed-by:
-
