- 09 Mar, 2018 40 commits
-
-
Sergey Ulanov authored
ioctl_netc_get_if_info() has been replaced with ioctl_netc_get_num_ifs() and ioctl_netc_get_num_ifs(). Update the corresponding code in //net. Bug: 818320 Change-Id: I42746f97616000f8839bcb0433c42e1d7feca129 Reviewed-on: https://chromium-review.googlesource.com/956613 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#542236}
-
Xiaoqian Dai authored
Bug: 798633 Change-Id: Idaa380f6594bfa2ea98b46eca357f6a78941e8a9 Reviewed-on: https://chromium-review.googlesource.com/955953 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542235}
-
Ryan Landay authored
StackLayout#flingStacks() currently takes a boolean: true if we should scroll over to the incognito tab stack, and false if we should scroll over to the normal tab stack. This CL is a straightforward change to make this method instead take an integer value representing the index of the new tab stack. This is necessary to enable StackLayout to support more than two tab stacks. Bug: 648314 Change-Id: I4e58707c1e389638fca1c6a013abf022a8d248bc Reviewed-on: https://chromium-review.googlesource.com/957425Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#542234}
-
https://skia.googlesource.com/skia.git/+log/b537879c7214..43f0ba073068 $ git log b537879c7..43f0ba073 --date=short --no-merges --format='%ad %ae %s' 2018-03-09 reed update tool to sniff images during deserialization 2018-03-09 egdaniel Fix no gpu build 2018-03-09 herb Remove getCache from SkAutoGlyphCache* 2018-03-09 bsalomon Fix breakage from merge conflict related to deleteTestingOnlyBackendTexture sig. change 2018-03-09 robertphillips Enable opList-based DDLs 2018-03-09 bsalomon Make GrGpu::deleteTestingOnlyBackendTexture() take const GrBackendTexture& 2018-03-09 brianosman Fix a logical test in GrColorSpaceXform::Equals 2018-03-09 egdaniel Add promise images for deferred instantiation of wrapped gpu textures 2018-03-09 herb Remove one use of AttachCache, and a paint variant of FindOrCreate... 2018-03-09 robertphillips Make GrTextureStripAtlas DDL friendly 2018-03-09 bsalomon Vulkan backend render targets don't allow client to specify stencil bits 2018-03-09 angle-skia-autoroll Roll skia/third_party/externals/angle2/ e8a93c6ed..331404098 (1 commit) 2018-03-09 update-skps Update SKP version 2018-03-08 csmartdalton ccpr: Fix stale array access after dynamic resize 2018-03-09 bsalomon Add GM configs that test rendering to a GL backend texture and render target 2018-03-08 csmartdalton ccpr: Fix crash on zero-length fan tessellations 2018-03-09 herb Remove all uses of getCache with get. 2018-03-08 bungeman Avoid serializing to 'typ1' on Mac. 2018-03-09 caryclark some fuzzer fixes Created with: roll-dep src/third_party/skia BUG=809763 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: If8fabf2721caab7a00df51dc9698da43867a7e7e Reviewed-on: https://chromium-review.googlesource.com/956755 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542233}
-
Greg Kerr authored
This CL reverts the GPU process to the V1 sandbox while a series of hangs are resolved. Tbr: creis@chromium.org Bug: 812228 Change-Id: Ie87cf5228d19cf3c50892b2f19133c3d3f2e2593 Reviewed-on: https://chromium-review.googlesource.com/957463 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#542232}
-
David Reveman authored
This implements a CursorView class based on FastInkView. It provides smooth low-latency cursor movement with optional motion blur on Chrome OS devices, especially devices with HW overlay support. Single buffer updates are done on a high priority cursor paint thread and events are routed directly to this thread from the EVDEV thread. This provides minimum latency updates that are not affected by any work done on the UI thread. The result is smoothness guarantees that are as good or better than existing HW cursor on Chrome OS devices. Fast ink based cursor is currently limited to when motion blur is enabled but can become the default mechanism to display the cursor. And as a result allow the HW overlay currently assigned to the HW cursor to be used for contents and apps. Bug: 722793 Test: chrome --ash-enable-cursor-motion-blur Change-Id: I2baf0b5746610aca33f44b966556304d4cfc700c Reviewed-on: https://chromium-review.googlesource.com/846992Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542231}
-
Bin Zhao authored
There is a bug that when we switch from network1 to network2, DIAL devices from network1 stays on MR dialog. Current implementation will not restart the timer and notify extension about sink list changes if network2 has no DIAL device. Fix it by always restart time when we get DIAL device events from DIAL registry. Bug: 820215 Change-Id: Ia149778427f142bffbb9ebd61b0de920b7a54289 Reviewed-on: https://chromium-review.googlesource.com/956310Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542230}
-
James Wallace-Lee authored
In webview, frames with no damage sometimes call AbortDraw to prevent draws. These aborts should not set did_draw_in_last_frame_ or the scheduler will request new BeginFrames when it doesn't need to. This CL stops setting did_draw_in_last_frame_ in AbortDraw while still setting it in WillDraw. Bug: 687695 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I84c39a5e06d578ea92558d81ce2fad5dc423cf75 Reviewed-on: https://chromium-review.googlesource.com/933292 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#542229}
-
Joel Einbinder authored
Change-Id: Id06be3a64b74d8453fd79cfa5915b4490e943d7c Reviewed-on: https://chromium-review.googlesource.com/956876Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542228}
-
MinChen authored
changes in this cl: - For clamshell devices, which we should not turn screen off by tapping the power button. Starts the menu animation immediately as press the power button. - Make the initial opacity in the menu animation not fixed, use the value in previous animation. - Still delay the power menu animation if we should turn screen off by tapping the power button. And differeniate the timer fire time according to the initial scrern state. Bug: 799524 Change-Id: Icad6c4e66be2ec41978456862c337ff494bfac00 Reviewed-on: https://chromium-review.googlesource.com/953374Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#542227}
-
Brandon Jones authored
Supports both Oculus Touch (6DoF) and the Oculus Remote (3DoF). Automatically switches between them as each form of input becomes active. Bug: 812287 Change-Id: If99852472d2d536dbc739b159a73ebcb83820c4b Reviewed-on: https://chromium-review.googlesource.com/956681Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542226}
-
Nico Weber authored
Currently fails on the libc++ bot with ../../chrome/browser/task_manager/sampling/shared_sampler_win_unittest.cc(144): error: Expected: (physical_bytes()) >= (initial_value + allocated_size), actual: 15224832 vs 19419136 The reason seems to be that memory use is only counted if the memory is referenced, and with libc++ the compiler is apparently able to optimize away the memory's initialization. Add some reading code to make sure the memory references remain. Bug: 801780 Change-Id: I8edef2eda4be8b4344ebc934768ecd58ee39496b Reviewed-on: https://chromium-review.googlesource.com/956571 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#542225}
-
Ian Vollick authored
With this change, a user may both resize and reposition the content quad when in "repositioning" mode. Bug: 799270 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I86aed8d83db82998c64e982922e21298c6a243ec Reviewed-on: https://chromium-review.googlesource.com/956499 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#542224}
-
James Cook authored
TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu was disabled for flake. The most likely cause is test-only race conditions in sending session state from the browser to ash. It does not need to be a browser test. Move it to ash_unittests to avoid the race conditions and re-enable it. Bug: 819987 Test: ash_unittests Change-Id: Iecf37fbb9d0115c5d1f9299e729fb66d193f7048 Reviewed-on: https://chromium-review.googlesource.com/957308Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#542223}
-
Alexander Timin authored
Add new histograms to capture per-task-type task duration for different renderer visibility states separately. BUG=820494 R=rkaplow@chromium.org CC=panicker@chromium.org Change-Id: Icce8e262cc87a4d3f73809abdbcda34a124a1bb9 Reviewed-on: https://chromium-review.googlesource.com/955855Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542222}
-
Artur Khachatryan authored
These tests are failing on Waterfall for Android Chromium build bot. Disabling tests. Bug: chromedriver:2286 Change-Id: I26b53ee52beaa5d942957ed8271b3aa6e3c42ddc Reviewed-on: https://chromium-review.googlesource.com/956547Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542221}
-
Xiaoqian Dai authored
Bug: 809298 Change-Id: I7d8b5e5e9a792b689129937c912bc16e6ef2e053 Reviewed-on: https://chromium-review.googlesource.com/950139Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#542220}
-
Sorin Jianu authored
Bug: 819834 Change-Id: I624029d327940f86be4852fbebe7f5a525d72a30 Reviewed-on: https://chromium-review.googlesource.com/953976Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542219}
-
Aaron Leventhal authored
TBR=nektar@chromium.org Bug: None Change-Id: Ie0078dadf64e05ab8c0b9ff53549c4b8a726ad18 Reviewed-on: https://chromium-review.googlesource.com/956295Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542218}
-
Emily Hanley authored
Bug: 758632 Change-Id: I7fc16ec27f1e24978c85c0b4a58970b19ffc5045 Reviewed-on: https://chromium-review.googlesource.com/955924Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#542217}
-
James Wallace-Lee authored
active_tree_needs_first_draw_ was set to false on invalidate so that it wouldn't block commits. Instead, fallback tick handling guarantees that every activated frame has a draw. This CL removes the change along with its associated test (introduced in crrev.com/1092123005). Bug: 819430 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibf6008512638943b7caa771f7ca6a953851607d6 Reviewed-on: https://chromium-review.googlesource.com/953208Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#542216}
-
Tom Sepez authored
Bug: 809614 Change-Id: I63fb89898c9ed83e532fd148a0a4dd318c194693 Reviewed-on: https://chromium-review.googlesource.com/956488 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#542215}
-
John Budorick authored
TBR=rockot@chromium.org No-Tree-Checks: true No-Try: true Bug: 820407 Change-Id: Ib10cd0c33aa8ad1725c22e180aa679352cd8883d Reviewed-on: https://chromium-review.googlesource.com/957462 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542214}
-
jonross authored
A series of tests across viz_browser_tests, viz_content_browsertests, and viz_content_unittests have been fixed. This change re-enables them. At the same time it updates the ordering of the filter files to reflect some recent triaging. Grouping together similar root-cause issues. TBR=kylechar@chromium.org Bug: 760181 Change-Id: Ib7040cd995cfdd7d92f3c3e677b87ebcaf920bc5 Reviewed-on: https://chromium-review.googlesource.com/957319 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#542213}
-
Xi Han authored
ServiceManager may need to launch child processes before a BrowserMainLoop has been created, and therefore before any BrowserThreads exists. We therefore replace the BrowserThread::PROCESS_LAUNCHER with a global TaskScheduler sequence, created on-demand when the ServiceManager or ChildProcessLauncherHelper first need it. Under Windows we must use a single-thread TaskRunner, while on other platforms we are able to use a normal TaskScheduler sequence. File crbug.com/820200 to track that. Bug: 815225 Change-Id: Ia0f46461fb9cc92fddacf81ee96b764de8477d11 Reviewed-on: https://chromium-review.googlesource.com/941264 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542212}
-
Xianzhu Wang authored
Animated images may change before invalidation. For example, an image with SVG animation gets ImageChanged notification periodically but a paint triggered by some other change may not just follow an invalidation of the animated image. Bug: 819683 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5acb3eedc0ac714a600ac6df752dc22245bf3d1d Reviewed-on: https://chromium-review.googlesource.com/956303 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542211}
-
https://pdfium.googlesource.com/pdfium.git/+log/3baef5c6daf5..69da36c5f841 $ git log 3baef5c6d..69da36c5f --date=short --no-merges --format='%ad %ae %s' 2018-03-09 rharrison Explicitly mark helper methods that only operate on ASCII ranges Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I111e9f1393101c60788b1cf62523606b3d233a42 Reviewed-on: https://chromium-review.googlesource.com/957313 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542210}
-
Luc Ferron authored
Bug: 820419 Tbr: kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibd95ec218a700b7a9a6e34336f4ddee5442f8b02 Reviewed-on: https://chromium-review.googlesource.com/956116Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Luc Ferron <lucferron@chromium.org> Cr-Commit-Position: refs/heads/master@{#542209}
-
Katie D authored
Bug: 820373 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I992efd466f5bcb7f20c0b4045be91b9d0f3704c8 Reviewed-on: https://chromium-review.googlesource.com/956699 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542208}
-
wutao authored
This cl revises some Keyboard Shortcut Viewer (KSV) strings based on the feedback from TC. Bug: b/74114276, b/74085777, b/74086686, b/74114046 Test: Wait TC to verify. Change-Id: Idb1a6a3695af135ed6a146c58f7048abfbcc4618 Reviewed-on: https://chromium-review.googlesource.com/956607Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#542207}
-
https://chromium.googlesource.com/catapult.git/+log/b90b97cf8dec..e490e96cd7f3 $ git log b90b97cf8..e490e96cd --date=short --no-merges --format='%ad %ae %s' 2018-03-08 dtu [dashboard] Add api_auth.Email() function. 2018-03-08 dtu [pinpoint] Delete extraneous patch argument when trying a patch. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I5e184099e83aa7a3aa66bbd528b9a7e36afaa948 Reviewed-on: https://chromium-review.googlesource.com/957311 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542206}
-
Qiang Xu authored
Changes: OnDisplayConfigurationChanged could not distinguish the case of swapping primary display. We now bind a callback in OnDisplayAdded ( it is called on reconnecting, leaving dock mode, exiting mirror mode) and run the callback in OnDisplayConfigurationChanged. Bug: 805046 Test: tested on device and added test coverage Change-Id: I332c9d368e9df4fc5630317902f2776eab5dc983 Reviewed-on: https://chromium-review.googlesource.com/956928Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#542205}
-
Charles Harrison authored
Bug: None Change-Id: I18438a934cecdb22a4586aee0ccd92db55ff08de Reviewed-on: https://chromium-review.googlesource.com/947746Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#542204}
-
rbpotter authored
Many webpages use window.print() immediately followed by window.close() in JS. This means that the renderer and web contents are torn down while the PDF is still being converted for the printer on Windows. However, the web contents are not needed if the full PDF document has already been rendered, so the PrintViewManager should just release the query and allow conversion and spooling to complete instead of cancelling the job. The CL to send the Print Preview PDF directly to the PrintViewManager broke this for users that use Print Preview because we no longer store an extra copy of the web contents in the BackgroundPrintingManager. This has been broken if using the system dialog since M64 or earlier. Bug: 820105 Change-Id: I308adba43b3604509275f6c0f2946545b94dd1d5 Reviewed-on: https://chromium-review.googlesource.com/956257 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#542203}
-
Dominic Mazzoni authored
The bounding box highlighted by assistive technology like ZoomText is wrong if the display resolution is not set to 100%. BUG=812892,820298 Change-Id: Id488583666c5e01e7aaed5ade7a5a3faeff900cd Reviewed-on: https://chromium-review.googlesource.com/955545 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#542202}
-
Ryan Landay authored
I have a series of CLs in progress to allow StackLayout to support more than two tab stacks. This CL contains the necessary updates to the geometry logic. After this CL (and the preceding ones), the only thing keeping StackLayout from displaying more than two tab stacks is that a lot of the logic is hard coded to always show all normal tabs in one stack and all incognito tabs in another. I will split much of StackLayout into a base class in a future CL to allow creating variants with different behavior. When we display two tab stacks, we use asymmetric margins: we put one tab stack up against the edge of the screen (with a small border added by the Stack itself), and show the edge of the other tab stack on the other side. This CL does not change the behavior for this case. For three or more stacks, the behavior I'm going with for now is to make the margins symmetric. So no matter which stack is focused, we show the current tab centered, with the edge of a neighboring tab showing on either side if present, or a blank margin on that side otherwise. Bug: 648314 Change-Id: I383d9601f521a2eec47263f219027bc23818b3e2 Reviewed-on: https://chromium-review.googlesource.com/940613 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542201}
-
Sheng-Hao Tsao authored
This CL adds 2 things to JEA interface. 1. Exif. Currently HW JEA only encodes the image with APP0 JFIF segment. After this CL, it accepts Exif buffer and would insert the APP1 segment if Exif buffer is provided. 2. IPC compatibility. IPC from ChromeOS side relies on the buffer ID to identify the encoded results. The ID of VideoFrame is generated randomly at Chromium side which ChromeOS doesn't know. The CL changes JEA interface to use output buffer ID to identify each encode attemp. BUG=819847 TEST=Verified that JEA can be used from ChromeOS side with Exif buffer. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I87f13a435f9875999ca79dd5769fb925a9c59fb8 Reviewed-on: https://chromium-review.googlesource.com/954411 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#542200}
-
Min Qin authored
This feature is currently defined in content/. This Cl moves it to components/download to remove download dependency on content/. BUG=803135 Change-Id: Iabbc34eff56554722d4aa7bde1f461135984ac74 Reviewed-on: https://chromium-review.googlesource.com/955899 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542199}
-
lgcheng authored
Since ArcAppDialg is no longer parented to AppList anymore, remove checks for parent widget. Also remove related test expectations. Bug: 820293 Test: Pass browser_test Change-Id: Iea0732ea329e6552ddb30c557dcc9575821a0394 Reviewed-on: https://chromium-review.googlesource.com/956666 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#542198}
-
Morten Stenshorne authored
Rename the method to PositionEmptyChildWithParentBfc(), and make it a const method. Also get rid of unused and unimplemented PositionWithBfcOffset(const NGBfcOffset&). Also some fixes in comments and parameter names, and added some comments on my own. Moved a DCHECK(is_empty_block) to also hit when PositionEmptyChildWithParentBfc(), just to be clear about the fact that the block has to be empty at this point. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7d171aa40d3f3a5705f7a0126725a7905d37c504 Reviewed-on: https://chromium-review.googlesource.com/955645Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#542197}
-