- 19 Jul, 2018 40 commits
-
-
Maja Kabus authored
Modified data and codeBase attributes definition in *.idl file. Bug: 739170 Change-Id: Ia332493450d0e780e4e6eb332708216da02060d1 Reviewed-on: https://chromium-review.googlesource.com/1137824 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#576465}
-
Michael Hablich authored
This is a roll-back to V8 6.9.427. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org NOTRY=true Change-Id: I4d7f1c1a1408f37cfcab66001ceba90851183cb3 Reviewed-on: https://chromium-review.googlesource.com/1143278 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#576464}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ed4c83aac3f1..e34766b47b67 git log ed4c83aac3f1..e34766b47b67 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 hidehiko@chromium.org Add four more boards to pre-cq. 2018-07-19 xixuan@chromium.org SkylabSuite: Separate create and wait for buildbot silency check. Created with: gclient setdep -r src/third_party/chromite@e34766b47b67 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5759c93332ddaec1c7cd63f5f72c3ff043282a11 Reviewed-on: https://chromium-review.googlesource.com/1143028Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576463}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1b013420703b..c6f7ba31d255 git log 1b013420703b..c6f7ba31d255 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 hjd@google.com Merge "perfetto-ui: Increase correctness of build" 2018-07-18 hjd@google.com perfetto-ui: Increase correctness of build Created with: gclient setdep -r src/third_party/perfetto@c6f7ba31d255 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iac780d43d91857fa9265da29b695e1f075ecc7bf Reviewed-on: https://chromium-review.googlesource.com/1143030 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576462}
-
Rayan Kanso authored
Collect errors per registration on initialization, and clear the corrupt data if applicable. Change-Id: I4f8da3c389e70a6d041c72a0e08c3ae1b5a85051 Reviewed-on: https://chromium-review.googlesource.com/1141881 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#576461}
-
Thomas Tangl authored
When sync is paused, i.e. the user has an auth error, the sync section on the syncSetup page will be hidden. Bug: 864754 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic72c9c02f0479feff27b73199a80702bfa7a5514 Reviewed-on: https://chromium-review.googlesource.com/1141577Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#576460}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b423247bc239..0b0043392bfd git log b423247bc239..0b0043392bfd --date=short --no-merges --format='%ad %ae %s' 2018-07-19 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-07-19 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 38971fd13599..6a5d98c4b528 (5 commits) 2018-07-19 rmistry@google.com Revert "Update markdown files" Created with: gclient setdep -r src/third_party/skia@0b0043392bfd The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I05d7b8ad5c954d7be817c5827eca418b90aaffdb Reviewed-on: https://chromium-review.googlesource.com/1143027Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576459}
-
Mark Cogan authored
This CL special-cases NTP URLs (chrome://newtab) in the tab grid mediator to set no title or favicon in the grid items sent to the consumer; this means that the corresponding cells in the tab grid will have no titles or favicons. In order to cleanly support cells having no icons, the icon image view background is set to be clear when there is no image. Bug: 865074 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I13eeeb3c494f7c5f300f2b179da4887dfeb9cdca Reviewed-on: https://chromium-review.googlesource.com/1143262Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#576458}
-
Henrique Grandinetti authored
Bug: 850589 Change-Id: Ic7fbe53143ac5ffb940822a0af76e89f5060e084 Reviewed-on: https://chromium-review.googlesource.com/1142207Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#576457}
-
Christian Dullweber authored
Disable failing tests on Linux: virtual/outofblink-cors-ns/http/tests/fetch/chromium/call-extra-crash-tee.html virtual/outofblink-cors-ns/http/tests/fetch/chromium/release-handle-crash.html https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/8969 Tbr: yhirano@chromium.org Bug: 862184 Change-Id: Ib65bb4bb3b3b2d4cd58f8ffb10e2f49b5772e632 Reviewed-on: https://chromium-review.googlesource.com/1143273Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576456}
-
chrome://flagsUlan Degenbaev authored
- Adds chrome://flags entry - Adds a FeatureFlag - Make existing Blink flag dependent on the Chrome flag Bug: 808143 Change-Id: Ib48328a63cda8007cf863741cae92957757538e2 Reviewed-on: https://chromium-review.googlesource.com/1140328 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576455}
-
Christian Dullweber authored
This reverts commit 93488940. Reason for revert: PictureInPictureWindowControllerBrowserTest.UpdateVideoSrcKeepsPictureInPictureWindowOpened is very flaky: https://crbug.com/865410 Original change's description: > [Picture-in-Picture] Update window playback when video src changes. > > This CL make sure the Picture-in-Picture window playback state is > reflected when video src changes. It is a follow-up to > https://chromium-review.googlesource.com/1089331 > > Bug: 726619 > Change-Id: Ic756c03aa023d3e4e229c7495686ea8f322503e3 > Reviewed-on: https://chromium-review.googlesource.com/1133168 > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576428} TBR=dalecurtis@chromium.org,wolenetz@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org Change-Id: I2b35b9ef8c119915b1c07f9f12321439c3242ab2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726619, 865410 Reviewed-on: https://chromium-review.googlesource.com/1143324Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576454}
-
Mythri Alle authored
Storing the generated code for javascript resources in a separate cache gives more flexibility in the implementation of the code cache.More details in the design doc [1] This cl just adds the GeneratedCodeCache class but does not use it yet. There will be follow up cls to actually use the cache. [1] https://docs.google.com/document/d/1O_PVZPn37Ev3_DWJjQLX-gid__OKxnXP1UsE8g_YkRY/edit?usp=sharing Bug: chromium:812168 Change-Id: I04b709d8e443217f8235859731e75fdf94c62971 Reviewed-on: https://chromium-review.googlesource.com/1107703 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#576453}
-
Orsi Batiz authored
Attribute src of HTMLIFrameElement changed from USVString to URLString Attribute src of HTMLTrackElement changed from USVString to URLString Attribute src of HTMLInputElement changed from USVString to URLString Attribute src of HTMLFrameElement changed from USVString to URLString Tests created for assignment to src Bug: 739170 Change-Id: I52254462ab7325264420aac989f08a30adfe4933 Reviewed-on: https://chromium-review.googlesource.com/1139062 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#576452}
-
Ned Nguyen authored
This CL also add extra validation to perf_json_config_validator script (run on PRESUBMIT) to prevent this bug from happening again Bug:865181 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ie68f426d3e5f073c5239ef05e14b67ac89b6911b NOTRY=true # webkit_layout_tests flaky Change-Id: Ie68f426d3e5f073c5239ef05e14b67ac89b6911b Reviewed-on: https://chromium-review.googlesource.com/1142950 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#576451}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6a5d98c4b528..da92a476b50a git log 6a5d98c4b528..da92a476b50a --date=short --no-merges --format='%ad %ae %s' 2018-07-19 jiawei.shao@intel.com Clean up VaryingPacking Created with: gclient setdep -r src/third_party/angle@da92a476b50a The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4313ba5fe706e374e0b75686d1929b60348831a3 Reviewed-on: https://chromium-review.googlesource.com/1143029Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576450}
-
Christian Dullweber authored
Fix spelling mistake. The constant is called FILTERABLE_DATA_TYPES and not FILTERABLE_DATATYPES. Tbr: jochen@chromium.org Change-Id: Id01c1081169aadc7544d1bd2beaf5050bdb26cf1 Reviewed-on: https://chromium-review.googlesource.com/1142782Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576449}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I91b1172aaa09d35ae2e2500c374bec1ade9dccea Reviewed-on: https://chromium-review.googlesource.com/1143130 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576448}
-
tzik authored
This CL updates all remaining user of base::Timer to use its subclasses, and renames base::Timer to base::TimerBase to ensure there's no user anymore. Bug: 850247 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I73d70cbbe338e17f5d7de34acd1c961ce05c4305 Reviewed-on: https://chromium-review.googlesource.com/1124200 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#576447}
-
Christian Dullweber authored
This reverts commit 016ff4b3. Reason for revert: LoginCursorTest.CursorHidden is still failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6897 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28314 Original change's description: > Reland "Enable powerwash shortcut in views-based login screen." > > This reverts commit 14fd238a. > Removes the chrome.send('showAddUser') in md_login.js to avoid a race > between the powerwash dialog and the Gaia signin screen. > > Bug: 837501 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I7ab656ebe522cbd164073b73b3dd927cca7b1f13 > Reviewed-on: https://chromium-review.googlesource.com/1129384 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576306} TBR=derat@chromium.org,dcheng@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org Change-Id: I7044802f815396b7c918f1153342d531122d8852 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837501 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1143206Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576446}
-
Christian Dullweber authored
Disable the-audio-api/the-pannernode-interface/panner-distance-clamping.html on Mac. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4131 Tbr: rtoy@chromium.org Bug: 865371 Change-Id: I0c451ec5350c672fe75d18e6a0ee3610a40a6e09 Reviewed-on: https://chromium-review.googlesource.com/1143193Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576445}
-
Gabriel Charette authored
rhalavati@ is the right owner (from privacy) for this and prefs/OWNERS don't need to involved in its cleanup nor related tweaks (e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1129385) R=rhalavati@chromium.org Bug: 861722 Change-Id: I45e517388285980df2eadcb04cd85edf1558b28d Reviewed-on: https://chromium-review.googlesource.com/1142291Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#576444}
-
Takuto Ikuta authored
New clang detects this unused variable. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/ios-device/4574 ../../ios/chrome/browser/browser_state/chrome_browser_state_io_data.mm:86:7: error: unused variable 'iter' [-Werror,-Wunused-variable] iter; ^ 1 error generated. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I019c3ecf8677e4b93f8289a722686bc186476bfe Reviewed-on: https://chromium-review.googlesource.com/1143172 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#576443}
-
Henrik Boström authored
NOTRY=True Bug: None Change-Id: I99e4e5580845d21dde4ce0edc5f070693c318441 Reviewed-on: https://chromium-review.googlesource.com/1142769Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576442}
-
kristipark authored
Screenshots: https://screenshot.googleplex.com/mWo3G36cOfw.png https://screenshot.googleplex.com/iBoyPES2wys.png https://screenshot.googleplex.com/LOeXotyNyc0.png Bug: 865086 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5d1737b6b3a1ded99c3518f9c4f4d48e93482df5 Reviewed-on: https://chromium-review.googlesource.com/1142504 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#576441}
-
Jérôme Lebel authored
Adapting helper methods in SigninEarlGreyUI to sign-in when signin::kUnifiedConsent is enabled. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie661295d002baf4143757f1f385518cee3d634ce Reviewed-on: https://chromium-review.googlesource.com/1140293Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576440}
-
Henrik Boström authored
Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/yC_UowCRnaY This CL implements and ships the following: - RTCRtpTransceiver Everything except setCodecPreferences(), as originally planned, and stop(), which recently is being up for spec discussions for unresolved issues. stop() is not essential, you can simply set transceiver.direction = "inactive". - RTCPeerConnection.getTransceivers(). - RTCTrackEvent (and RTCTrackEventInit) gets the transceiver attribute previously missing. RTCPeerConnection.addTransceiver() will be added in the next CL. Transceivers are only supported if sdpSemantics:'unified-plan' is used, for more information see the intent to ship which explains the background. In "Unified Plan", the following methods get a change in behavior because of this CL: - RTCPeerConnection.addTrack() - RTCPeerConnection.removeTrack() - RTCPeerConnection.setLocalDescription() - RTCPeerConnection.setRemoteDescription() When transceivers are not supported, getTransceivers() simply return an empty set. external/wpt/webrtc/ runs in default "Plan B" mode, virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/ runs in "Unified Plan" mode. -expected.txt files are updated accordingly. If there is no -expected.txt file in "virtual" then it uses the same -expected.txt as the non-"virtual" if there is one; PASS-only files are needed in "virtual" if the non-"virtual" one contained any FAIL (as opposed to ommiting the -expected.txt file because everything passed). // All the bots already passed except for one unrelated test failure // on a single bot. NOTRY to skip waiting for retry. NOTRY=True Bug: 777617 Change-Id: Ifd4d39e4f90511ebf4871536da210c3e8a1d08d0 Reviewed-on: https://chromium-review.googlesource.com/1141963 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#576439}
-
Christian Dullweber authored
This reverts commit 0ea138d6. Reason for revert: The CL probably broke a number of tests: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/63 Original change's description: > [Blink] Unify pre-snapping of <video> to match <iframe> > > This CL changes the pre-snapping policy of <video> so that only the size > of the contents is pre-snapped, while the location will exactly match the > content box's final location. > > BUG=730284 > > Change-Id: Id10bd0fbd8021a11b7db4a2950a908f3d1b50ac0 > Reviewed-on: https://chromium-review.googlesource.com/1141328 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576317} TBR=trchen@chromium.org,chrishtr@chromium.org Change-Id: I518e659cbab820263480b02ae347c99468dd95fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730284 Reviewed-on: https://chromium-review.googlesource.com/1143205Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576438}
-
Mark Cogan authored
- Fade in the grid toolbars and the other grid cells sooner in the animation (20% delay instead of 40%) - Start the cell fade-in from 20% opacity (not 0%). - Adjust the timing of the presentation and dismissal animations. - Add spring to the resize animations when entering/exiting the grid. - Adjust the timing curve of the inactive cell appearance animations. - Match the device corner radius in the "tab" state of the animations (meaning that on iPhone X, the active cell transitions to/from more rounded corners). Bug: 865028 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iddea1d4addfe2192f8175f02599eca39c59edffd Reviewed-on: https://chromium-review.googlesource.com/1142156 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576437}
-
Friedrich Horschig authored
This CL causes the accessory sheet to close when a user selected a valid filling suggestions. There is no indicator of the negative case yet (i.e. error during filling). TBR=rouslan@chromium.org TBR Reason: The test has been flaky for a while and also doesn't make much sense. Like all the others, I am disabling it. The feature it tests isn't even activated yet. Bug: 856026, 857592 Change-Id: I8ccdbe2b06c49215b0799fd435823e584dfe4f11 Reviewed-on: https://chromium-review.googlesource.com/1126244 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576436}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 96e63637. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21544 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kozyatinskiy@chromium.org: external/wpt/console TBR=foolip No-Export: true Change-Id: Ia010fb7467e3a5df5870eb88e74ef9d4abf03aab Reviewed-on: https://chromium-review.googlesource.com/1143018 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576435}
-
Henrik Grunell authored
Change-Id: I7d74cb5fa93c2b271f9238ca28e243fc126bfd60 Reviewed-on: https://chromium-review.googlesource.com/1135005Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#576434}
-
Jérôme Lebel authored
Second part of crrev.com/c/1138621 after crrev.com/i/652748 is landed. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibff91f4bfb24351ea66b77c730e182bcb48426f2 Reviewed-on: https://chromium-review.googlesource.com/1140323Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576433}
-
Matt Falkenhagen authored
Follow-up to the interface name change in r576345. TBR=kinuko Bug: 629701 Change-Id: Ia330b4c96871b109004bc917a232c592bc75d83e Reviewed-on: https://chromium-review.googlesource.com/1143099Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576432}
-
Colin Blundell authored
Minor cleanup to always access the information of whether signin is prohibited via the accessor method rather than directly via the ivar. Change-Id: I208930ce094d40d22a325cdca6fd36cf26da441a Reviewed-on: https://chromium-review.googlesource.com/1142771Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#576431}
-
Yutaka Hirano authored
With this CL, CORSURLLoaderFactory rejects ill-configuared requests. - CORS needs a proper origin (including an opaque unique origin) attached to a request. Hence CORSURLLoaderFactory rejects a request which has a CORS-enabled mode and null request_initiator. Also, a request with null request_initiator won't set the CORS flag with this CL. - The relationship between fetch credentials mode and load_flags is a bit unclear. If a request's credentials mode is "omit" but one of LOAD_DO_NOT_SAVE_COOKIES, LOAD_DO_NOT_SEND_COOKIES and LOAD_DO_NOT_SEND_AUTH_DATA is not set on load_flags, that is likely a mis-configuration, so fail the request. Bug: 736308, 862184 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I51fb491b865de330b22b028a0eddbc30043e6b69 Reviewed-on: https://chromium-review.googlesource.com/1136342 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576430}
-
Keishi Hattori authored
Oilpan: Mark navigation-interrupted-by-fragment.html as Timeout in HeapIncrementalMarkingStress mode Bug: 865348 Change-Id: Ie0b5b7d0db19b880293b84fe14d3431b8d9ebfc0 Reviewed-on: https://chromium-review.googlesource.com/1143117Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576429}
-
François Beaufort authored
This CL make sure the Picture-in-Picture window playback state is reflected when video src changes. It is a follow-up to https://chromium-review.googlesource.com/1089331 Bug: 726619 Change-Id: Ic756c03aa023d3e4e229c7495686ea8f322503e3 Reviewed-on: https://chromium-review.googlesource.com/1133168 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#576428}
-
Trent Apted authored
This affects file manager tests, gallery tests, and others. With a few exceptions, these tests have no use for the browser() that StartupBrowserCreator creates during startup. Not creating one leaves more time for the tests to do things they really care about before potentially timing out. In fact, _not_ creating the Browser surfaces an existing bug more prominently. That is, some tests have an iceberg dependency on the existence of this Browser* that they should never have had in the first place. Bug: 736930 Change-Id: I1030e41800f3d2e0e5868ecd64d70c7d30f47c28 Reviewed-on: https://chromium-review.googlesource.com/1117977Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#576427}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/639bc9086732..6a5d98c4b528 git log 639bc9086732..6a5d98c4b528 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 jiawei.shao@intel.com ES31: Implement Vertex Attrib Binding on D3D11 2018-07-18 geofflang@chromium.org Vulkan: Disable the depth/stencil states when there are no depth/stencil buffers Created with: gclient setdep -r src/third_party/angle@6a5d98c4b528 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I568d1fe855b0a6183728e749812ec0cc61eb372a Reviewed-on: https://chromium-review.googlesource.com/1142175Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576426}
-