GitLab

Bug: 938717
Change-Id: Ied6a40e873849bdd91d499fe1a9093752d144763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504500
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638326}

Previously, the animated voice input toggle was slightly off center:
https://screenshot.googleplex.com/tODAXyEw64F

Bug: 924624
Change-Id: I30b230a22afa152a4081aa9f25347a696a002179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506381
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638325}

Updates the resource manager to not require a mime type when loading
a bundled resource. This is the same as the behavior in [1].

[1] https://cs.chromium.org/chromium/src/extensions/browser/extension_protocols.cc?q=extension_protocols.cc&sq=package:chromium&dr&l=340

Bug: 902646
Change-Id: Ib65eafd6fc900351a9270317a711c9d3ab092f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501194
Commit-Queue: dstockwell <dstockwell@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638324}

Bug: 902646,938857
Change-Id: I8a6165fc0de258b634733b77ac166c184882318a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505733Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638323}

https://chromium.googlesource.com/webm/libvpx.git/+log/503cb8e63a06..d64e328624e0

$ git log 503cb8e63..d64e32862 --date=short --no-merges --format='%ad %ae %s'
2019-03-05 jianj vp9 svc example: use CONFIG_VP9_DECODER guarding decoding.
2019-02-12 angiebird Add rd_diff_arr to store future blocks' rd diff
2019-03-04 angiebird Fix compile error when DUMP_TPL_STATS is 1
2019-03-04 marpan vp9-rtc: Speed feature changes to speed 9
2019-03-01 marpan vp9-rtc: Adjust force split logic for screen mode
2019-03-01 marpan vp9-rtc: Fix for scroll motion for rtc
2018-12-07 paulwilkins Strengthened film grain setting.
2019-02-26 paulwilkins Fix RD multiplier bug impacting AQ1.

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: I8619ec2af03d0f24d3e243fd9c647c4db39c3ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506459
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#638322}

Previously the wrapper script would only be used for coverage builds
that required selective instrumentation of specific files. Now it
will also be used for any coverage builds.

Since the script's job is to remove flags from files that shouldn't
have them the default_coverage config now adds to cflags even in a
CQ build.

Bug: 918215
Change-Id: I012c5732d46bf5cff9eaf8f50615739bb781cc29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496002
Commit-Queue: Sajjad Mirza <sajjadm@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638321}

Bug: 923475
Change-Id: I83a67e5053bf50ce6299523eb0cadff68b8169d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506656Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638320}

The feature toggles are on track to be launched in M73 via server-side
variations, so let's enable them all by default for M74.

Bug: 902704
Change-Id: I0763b2ecb8a572d975cd6da56892e74e3da59a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503572
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638319}

The class has no superclasses or subclasses, so it is confusing for the
reader to see the virtual qualifier here. This change clarifies for the
readers how this class is used.

Change-Id: I22fc58f88a0dd7091c530ce55357ed783d4b46c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506377
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638318}

This reverts commit 3194759c.

Reason for revert: Caused https://crbug.com/938839. Seems that the 
workaround is still needed even without animations.

Original change's description:
> Settings cleanup: Remove obsolete setTimeout() work-around.
> 
> This workaround refers to 859794 which is obsolete after removal of
> page/subpage animations.
> 
> Bug: 859794
> Change-Id: I688ec714117f90a797db1b1baacc6eb9d2138751
> Reviewed-on: https://chromium-review.googlesource.com/c/1490436
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Reviewed-by: calamity <calamity@chromium.org>
> Commit-Queue: calamity <calamity@chromium.org>
> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636347}

TBR=calamity@chromium.org,dpapad@chromium.org,hcarmona@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 859794,938839
Change-Id: Id83ed5c68320815b75c49acb06b21afbb7ed9007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506464Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638317}

This change:
1) Adds 4 new properties to CaptionStyle.
2) Adds caption_style_win.cc that contains a Windows implementation for
   CaptionStyle::FromSystemSettings().
3) Adds a new feature flag to enable Windows system styling.
4) Follows the same pattern as the earlier change here:
   https://chromium-review.googlesource.com/c/chromium/src/+/1418399

Next steps:
Add support for background opacity, window opacity, and window color

Bug: 897730

Change-Id: Iefb0092c32b4fdb3d4d6412a2e21b9bdf018887f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482140Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#638316}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0668403dfdd6..61a1b5f31059


git log 0668403dfdd6..61a1b5f31059 --date=short --no-merges --format='%ad %ae %s'
2019-03-06 spang@chromium.org Avoid unnecessary invocations of "git fetch"


Created with:
  gclient setdep -r src/third_party/depot_tools@61a1b5f31059

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:938627
TBR=agable@chromium.org

Change-Id: I06964df9cebf7fa67eb148d0477220f3fe9259ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506475Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638315}

This CL adds support to send ExtensionHostMsg_PostMessage IPC from
worker threads. This allows reply to work targeting a Service
Worker.

Bug: 925927
Test: chrome.runtime.sendMessage can use reply callback.
Change-Id: I2c64992847f0f8746a455941a58841e5f1fea8c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506009
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638314}

R=benmason@chromium.org

Change-Id: Ie53cce111fb1cbc2024050efd70bf3874ccef459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506471Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638313}

This prevents a bug which can occurr for URLs that redirect. The bug is a bit
subtle, so see the crbug.com/937581 for more details.

We're almost guaranteed that Chrome hasn't seen a redirect for the final URL,
so this will fix the problem of redirecting before hitting the offline url
loader request interceptor. We will intercept requests for either the original
URL or the final URL.

Note that because we're using a different URL in the intent, when a URL is a
redirect, we will always open the page in a new tab. This is not ideal, but
is preferable to failing to open the page.

Bug: 937581
Change-Id: I04f02556e93eba1ca0b2380313f1052c7f8f7cd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505895
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638312}

Bug: 925949
Change-Id: I55a9d8280be7cbe435f7c84629b79e919fdff016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499955
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638311}

We introduced two new accessibility attributes for image
annotations. When these attributes change, it's exposed to
assistive technology as part of the accessible name,
so we need to fire name changed events to guarantee that
AT is updated.

Bug: 905419

Change-Id: I63d64b895ccbfc3265f037de3227be3da4dc41dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504705
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638310}

Tbr: eae@chromium.org
NoTry: True
Change-Id: I8811ef4a85c350663e280543f76a950abae858a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505901Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638309}

There can be a race between the browser receiving window bounds updates
and the IME ensuring the text caret is visible.

* Repeat the text caret visibility request after virtual keyboard
  occluded bounds update. This is a no-op if the caret is already
  visible.
* Fix double-conversion of local bounds to screen bounds in chrome's
  receipt of occluded bounds from ash.
* Clarify variable names with coordinate system.

Bug: 937722

Change-Id: I0f49413ca63582469cf0a4b61cde69733c1841ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504150Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638308}

BUG=937880

Change-Id: Ib222ad6cddf23b0f28863e75f1bc729e638c6ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504460
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638307}

MediaStreamSourceNode and related nodes should report they have
activity whenever the context is running, because they actually do.
This prevents the nodes from getting prematurely collected.
Unfortunately, this also means nodes will not be collected until the
context is suspended or stopped.



Bug: 937231
Change-Id: I4cd93fe757d8f34fbbc0c68aeaace4727c77be14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496541Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638306}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/767948b07604..c3ec692344cb


git log 767948b07604..c3ec692344cb --date=short --no-merges --format='%ad %ae %s'
2019-03-06 dgarrett@google.com workspace_stages: Add SyncChrome timeout.


Created with:
  gclient setdep -r src/third_party/chromite@c3ec692344cb

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I58f7b56c9a2251c891eda19d3884929a6987e9ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506477Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638305}

This also moves the ignore blacklist flag one call level higher for use
in browser tests, instead of having to load hints for every test.

Bug: 938621
Change-Id: Ie13f87463dccb9e2a3d57a0cda9b89a80fdb9f55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504256Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638304}

Bug: 933515

Change-Id: I2c4f239144d3ed060d5bace974b5646b086ca9db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479422
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638303}

Updating +[ChromeMatchers googleServicesSettingsButton], to find the
"Sync and Google services" cell. This cell cannot be found with its
accessibility text since the sync status (detail text of the cell)
can vary.

The issue was created with:
crrev.com/c/1497003

Bug: 937855
Change-Id: Ia8ab1f90a3c8476f2710b48cdcacb1278aa292e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503414Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638302}

There are missing clang runtime libraries that are needed to
successfully link libmojo in a coverage configuration. This
workaround lets us get coverage data for the rest of Chrome on
Chrome OS.

This patch was authored by Noel Gordon, who initially reported this
issue.

Bug: 865376
Change-Id: I88b309760836639b80dfa0f7b67e4bb5c2b55d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493471
Commit-Queue: Sajjad Mirza <sajjadm@google.com>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638301}

According to the specification, when you drag a window to snap it, the
preview area (referred to as "Indicator") should fade out over 67 ms,
fast out, linear in:
https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#window-drop

Currently, it fades out over 250 ms, fast out, slow in.

BEFORE:
https://photos.app.goo.gl/MQa3rZ4jKX4hZLba7

AFTER:
https://photos.app.goo.gl/iLFHyvqxFZsfreEC6

Test: manual
Bug: 934977
Change-Id: I27d3e4d758097f2a87207880b2bc5ca9622dad7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504037
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638300}

infra cl: https://chrome-internal-review.googlesource.com/c/infradata/config/+/914125

Bug: 936908
Change-Id: I15d82cdf4ca0edb78a7258b6477deaaa0941c6f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496656
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638299}

Changelog: https://github.com/googlechrome/lighthouse/compare/v4.0.0...v4.1.0

Change-Id: Ief76c7c2d0fb4b44e9332b91c2a6bb99f46a9d2e
Bug: 772558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506382
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638298}

Previously, boolean fields such as the "Can be default" which display a green
check-mark or red x-mark would additionally contain invisible (CSS font-size 0)
text "true" or "false" in order to allow selecting and copying them.

This CL removes this hidden text as we're no longer supporting selecting and
copying partial outputs.

Bug: 937321
Change-Id: Ic347c3f99d645463c59bc2c15d95aaf9148b2f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496923Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638297}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2179093ac06..0ab64c504cf5


Created with:
  gclient setdep -r src-internal@0ab64c504cf5

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:937987
TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org

Change-Id: I2f2f1b098b44f2404bf4d9fee5dc52c364a536e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506364Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638296}

Bug: 933784
Change-Id: I3bc03760dea254fa33f8c660689739db65a1ce9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492791
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638295}

The attribute values change from on/off/auto to lazy/eager/auto

Bug: 936572
Change-Id: I014891934cde248c1ea0a969d89b3b0d75eec2a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500017Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638294}

A nested clip-path should resolve against the original elements
reference box, but it would instead resolve against the referencing
<clipPath>.
Pass the appropriate reference box to SVGLayoutSupport::IntersectsClipPath.

Took the opportunity to export some related tests to WPT.

Bug: 938913
Change-Id: I6d6ad88f0a97028b21b1f1a488afbdd42a96264b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505949Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#638293}

Bug: 937218
Change-Id: I66a30f2f095731957055cf082e39657a5c551b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497415Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638292}

https://pdfium.googlesource.com/pdfium.git/+log/9ba187ae4751..3df5c7cf7b58


git log 9ba187ae4751..3df5c7cf7b58 --date=short --no-merges --format='%ad %ae %s'
2019-03-06 tsepez@chromium.org Fix temporary going out of scope too early in XFA_LoadImageData()


Created with:
  gclient setdep -r src/third_party/pdfium@3df5c7cf7b58

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:937199
TBR=dsinclair@chromium.org

Change-Id: I89e3c61b3e366e54de2f5ef32bc6b18d1d339ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506476Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638291}

And instead make function public.
I did not move the definition, because, as far as I can tell, the
declarations/definitions are rather out of sync for this file.

BUG=none
TEST=none

Change-Id: Ie0b21ffdf14513e1e67c4d1d0dce70703745387f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505838
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638290}

This CL adds origin_trial_feature_name to
- "BuiltInModuleInfra"
- "BuiltInModuleKvStorage"
While "BuiltInModuleInfra" origin trial is not needed for
end users, this is needed in terms of implementation, because
"BuiltInModuleInfra" should be enabled if "BuiltInModuleKvStorage"
is enabled, and thus "BuiltInModuleInfra" flag should also depend
on origin trials.
By adding origin_trial_feature_name to "BuiltInModuleInfra",
origin_trials::BuiltInModuleInfraEnabled() takes care of
the dependency.

As origin trials requires ExecutionContext, this CL associates
built-in module feature control with Modulator, by introducing
- Modulator::BuiltInModuleInfraEnabled()
- Modulator::BuiltInModuleEnabled()
This CL plumbs Modulator via ModuleScriptFetcher::Fetch() and
ImportMap, to plumb Modulator::BuiltInModule*Enabled() to
layered_api.cc.

It seems a little confusing that ModuleScriptFetcher takes
both Modulator and ResourceFetcher that refer
module map settings object and fetch client settings object,
respectively.
This is actually consistent, because built-in modules are
associated with module map settings object and the current
implementation of import maps is also associated with
Modulator (crbug/928435), while fetching should refer to
fetch client settings object.
This apparent inconsistency should be resolved by
- Fixing Issue 928435, or
- Enabling Built-in modules by default (which will remove
  dependencies to ExecutionContext/Modulator again), or
- Refactoring ModuleScriptFetcher.

This CL implements individual control over built-in modules
in ModulatorImplBase::BuiltInModuleEnabled().
After this CL,
- "BuiltInModuleKvStorage" enables "kv-storage" and "blank" only, and
- "BuiltInModuleInfra" flag enables "blank" only,
while they enabled all built-in modules before this CL.

Bug: 829084, 928435
Change-Id: I0ee2838c0981192e9a993cb784bc39d866682836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497468
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638289}

This works for network service both enabled and disabled.

Bug: 938696
Change-Id: I2210f44861976b14508c1eff8401bc12958dc87c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504692
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638288}

Before this patch, a payment app that was slow to respond to
`canmakepayment` event would leave a window of time when the user could
enter the tab overview mode in Android, which did not cancel the ongoing
payment, even though the merchant page was no longer in focus.

The tab overview mode displays a list of user tabs and is used for tab
switching. Chrome already listened to tab switch events, so selecting a
different tab does cancel the ongoing payment.

This patch cancels the ongoing payment when Chrome enters into the
overview mode.

After this patch, Chrome cancels the ongoing payment if the user enters
the tab overview mode, which can happen when the payment app is slow to
respond to `canmakepayment` event.

Bug: 817073
Change-Id: I852d8467bb4e349bcc9afb322d973a9bccca0910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506374Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638287}