- 05 Apr, 2018 40 commits
-
-
Min Qin authored
TBR=horo@chromium.org BUG=829417 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1a2b8c446cd5003bccc07eae997b146bbb008850 Reviewed-on: https://chromium-review.googlesource.com/998305Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548447}
-
Stephen McGruer authored
This reverts commit d1f4cdd4. Reason for revert: Breaks compile on WinMSVC64 (dbg), due to unreachable code (the return after the #endif): https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.win%2FWinMSVC64__dbg_%2F4540%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout c:\b\c\b\win\src\chrome\browser\chrome_content_browser_client.cc(4172) : warning C4702: unreachable code Original change's description: > [Picture in Picture] Move generic code to content/. > > Currently, all Picture in Picture code is housed in chrome/. Since > only some of the Picture in Picture work is Chrome specific, we move > the more generic work into content/. > > This change completely moves the PictureInPictureWindowController > and OverlaySurfaceEmbedder into content/. > > This change will also pave for some future work related to user > initiated commands from the window, such as play/pause. IPC messaging > for MediaPlayerDelegateMsg must be done through content/ rather than > in chrome/. > > OverlayWindowViews continues to be the desktop Chrome implementation > of OverlayWindow, which is now moved into content/. With the > convergence of historically platform-dependent implementations (views > vs cocoa) into just views, there will only be one window implementation > for Chrome. > > BUG: 726619 821874 > Change-Id: I6ef73552c6729aec235f4a6d176fd4109f6674b3 > Reviewed-on: https://chromium-review.googlesource.com/972841 > Commit-Queue: apacible <apacible@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548428} TBR=ellyjones@chromium.org,kinuko@chromium.org,lazyboy@chromium.org,mlamouri@chromium.org,apacible@chromium.org Change-Id: I3a18da4e27bbff14d2acfa11707727d46e033f73 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/998173Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#548446}
-
Gauthier Ambard authored
This CL adjusts the color of the elements of the tools menu when they are enabled. Bug: 824210 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7aaca16482f40a97dfe713a1847e25ea697103f9 Reviewed-on: https://chromium-review.googlesource.com/997818Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#548445}
-
Lutz Justen authored
Created specializations of ActiveDirectoryPolicyManager for user and device policy instead of handling everything inside the base class. The differences between user and device policy are still small right now, but they're only going to grow (as I noticed while working on policy for extensions), so it's important to do the split early on. Keeps all ActiveDirectory*PolicyManagers in one file to simplify reviews, but they are going to be moved to their own files in an upcoming CL. BUG=chromium:735100 TEST=out/Release/unit_tests --gtest_filter=*ActiveDirectoryPolicyManagerTest.* Tested on device Change-Id: I55b5d8cfb3646058510729f2028a6b6aa2f9584e Reviewed-on: https://chromium-review.googlesource.com/972482 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#548444}
-
Jun Choi authored
Since AAGUID always has fixed size(16), change |aaguid_| of AttestedCredentialData from std::vector<uint8_t> to std::array<uint8_t, 16>. This is a reland of https://crrev.com/c/981682, which was reverted due to combining use of templates with COMPONENTS_EXPORT and failed compilation in win_msvc_dbg. Bug: 780078 Change-Id: Iaa97895cabaa4685ca5909df8c3544a6e84ecf78 Reviewed-on: https://chromium-review.googlesource.com/996963Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548443}
-
Ramin Halavati authored
Switches that are passed from traffic annotation auditor to clang tool are moved from source to a text file for easier update. Bug: 690323 Change-Id: Icb1fbfdfde6898532158bb3c9ee0e4710a3e043b Reviewed-on: https://chromium-review.googlesource.com/997738Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#548442}
-
Mitsuru Oshima authored
This reverts commit 0abbd025. Reason for revert: other git cl upload uploaded the wrong CL. Original change's description: > Don't skip updating widget when resizing ClientControlledShellSurface > > ClientControlledShellSurface doesn't use configure to resize. > > BUG=828586 > TEST=manual > > Change-Id: I19c165741917f8a6855fab20a5938e9b020e02c0 > Reviewed-on: https://chromium-review.googlesource.com/994173 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548433} TBR=reveman@chromium.org,oshima@chromium.org Change-Id: Iac7a79ec338601463261650cbfcec5f91ea44a61 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828586 Reviewed-on: https://chromium-review.googlesource.com/998172Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#548441}
-
Ken Rockot authored
This reverts commit 7c2240a7. Reason for revert: https://crbug.com/829218 Original change's description: > Re-enable WebRequestApiTest.WebRequestClientsGoogleComProtection > > Re-enables this test with the Network Service enabled. > > This test did some things which the Network Service does not support and > does not need to support, or which otherwise made testing with the > Network Service more complex than necessary. The following changes have > been made: > > * We no longer attempt to load a network resource from a WebUI > renderer. This will not be supported with Network Service and is no > longer desirable to have working in production anyway. There should > no longer be any WebUI pages making network requests. > > * Use http instead of https for the clients1.google.com requests. This > allows such requests to be handled by the EmbeddedTestServer which > already exists in BrowserTestBase, which is itself not configured to > handle HTTPS requests. Since these requests are filtered by > hostname, the scheme doesn't matter. > > * Switch the test to use a SimpleURLLoader instead of a > FakeURLFetcher. This allows the test code to exercise the same > behavior with or without the Network Service enabled. > > Bug: 721414 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Iad1f2deaec2e218b9cb168acbe71c90591dc6acf > Reviewed-on: https://chromium-review.googlesource.com/972425 > Commit-Queue: Ken Rockot <rockot@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548137} TBR=jam@chromium.org,rockot@chromium.org,karandeepb@chromium.org Change-Id: I054a7e11a4945e379cd45405546a90ee4d1e9577 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/998076Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#548440}
-
Michael Thiessen authored
Allows Chrome to stay in VR when Chrome is paused, so that when Chrome is resumed it's still in VR. We use the isInVrSession API to know when Chrome is resumed whether the user is still in VR or not, and if not we exit VR. There are a few edge cases, like making sure we close the old DLA when launching a new DLA, and making sure we exit WebVR presentation when launched from an intent rather than resumed from Dashboard. Bug: 780887 Change-Id: I4c399080958a65744bb1e89a16d1493cb1ef0a52 Reviewed-on: https://chromium-review.googlesource.com/986745 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#548439}
-
Dale Curtis authored
Layout tests do not always meet the requirements to avoid being "napped", in which case test timeouts and other odd behavior may occur; this is most prevalent with large repeat values and a small number of tests. This sets NSAppSleepDisabled to YES for blink tests. BUG=811525 TEST=manual Change-Id: I80ae1aeb0f5577f1977b3685e98655ea1253e3e6 Reviewed-on: https://chromium-review.googlesource.com/996483Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#548438}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78ba74d75584..ecf6e8e622df $ git log 78ba74d75..ecf6e8e62 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:815077,chromium:659188 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If68f8532b45c663ca8f23029bb4f22f30f367ad4 Reviewed-on: https://chromium-review.googlesource.com/997762 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548437}
-
Matthew Jones authored
This change implements a simple bottom toolbar that has an android view, a composited component, resizes the viewport, and scrolls on and off-screen. This toolbar is implemented using the new MVC guidelines: - The BottomToolbarController sets up all the components of the bottom toolbar. - The BottomToolbarMediator is responsible for pushing updates to the model and running most of the business logic. - The BottomToolbarModel is a blob of state with no actual business logic. - The BottomToolbarViewBinder reacts to events from a PropertyModelChangeProcessor and updates the relevant views. BUG=815324,825965 Change-Id: I75e5aac6a2bb2a21ea9e4010fc81076d2d39da8b Reviewed-on: https://chromium-review.googlesource.com/980577 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#548436}
-
Christian Dullweber authored
Similar to site settings and chrome://settings/siteData, cookies should by counted by the number of hosts instead of origins to avoid confusion. Change-Id: Ib148c5c1131a63adadce523e30e1453f69c9b318 Reviewed-on: https://chromium-review.googlesource.com/997842 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
chaopeng authored
To support Windows Touchpad swipe left/right navigation change, we need to allow completing the overscroll by inertial scroll event (fling). Also after overscroll completion, we need to ignore the rest of the inertial scroll events (flings) in the same sequence. Bug: 647140 Change-Id: I20542bd3fe95689eb2dfd8922aef077b9d64d139 Reviewed-on: https://chromium-review.googlesource.com/982101 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#548434}
-
Mitsuru Oshima authored
ClientControlledShellSurface doesn't use configure to resize. BUG=828586 TEST=manual Change-Id: I19c165741917f8a6855fab20a5938e9b020e02c0 Reviewed-on: https://chromium-review.googlesource.com/994173 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#548433}
-
Sammie Quon authored
Flaky in mash. TBR=oshima@chromium.org Bug: 827435 Change-Id: I0563bd2b139d9f1ee4be1117a064e6dc29973fc2 Reviewed-on: https://chromium-review.googlesource.com/998052Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#548432}
-
Stephen Chenney authored
These appear to be issues with the GPU used on the machine. TBR=kbr@chromium.org Change-Id: I5009748dad3de63acbbdcc3b7920f09a2fdfaa80 Reviewed-on: https://chromium-review.googlesource.com/996866Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#548431}
-
Fredrik Söderquist authored
Issue the click in the test further down the rect in the hope that the selection code won't end up picking one or the other of the <text>s, but only the one further down. Bug: 829316 Change-Id: Iae3419bf902a864ea8ec46e69764480c0f240b8a Reviewed-on: https://chromium-review.googlesource.com/997843Reviewed-by:
-
Mikel Astiz authored
Follow-up to https://chromium-review.googlesource.com/997197 where, presumably, the wrong test was disabled. TBR=beccahughes@chromium.org TBR=thomasanderson@chromium.org Bug: 829228 Change-Id: Icd680733174a87d05172fe842b0dc0eed46aa80d Reviewed-on: https://chromium-review.googlesource.com/997745 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548429}
-
Jennifer Apacible authored
Currently, all Picture in Picture code is housed in chrome/. Since only some of the Picture in Picture work is Chrome specific, we move the more generic work into content/. This change completely moves the PictureInPictureWindowController and OverlaySurfaceEmbedder into content/. This change will also pave for some future work related to user initiated commands from the window, such as play/pause. IPC messaging for MediaPlayerDelegateMsg must be done through content/ rather than in chrome/. OverlayWindowViews continues to be the desktop Chrome implementation of OverlayWindow, which is now moved into content/. With the convergence of historically platform-dependent implementations (views vs cocoa) into just views, there will only be one window implementation for Chrome. BUG: 726619 821874 Change-Id: I6ef73552c6729aec235f4a6d176fd4109f6674b3 Reviewed-on: https://chromium-review.googlesource.com/972841 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#548428}
-
Adam Langley authored
It took me a little while to figure out why the bounds in this function were valid so I added some comments. Change-Id: I1244b966dbb6b7984dfc4fbceaa7ed6a2f369aa3 Reviewed-on: https://chromium-review.googlesource.com/984958Reviewed-by:
-
Christopher Grant authored
Latest UX spec drops this element in favor of controller tooltips. BUG=829059 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I933a6c0e6ba2877a13777200a9774328ea04a826 Reviewed-on: https://chromium-review.googlesource.com/996525Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#548426}
-
Jinho Bang authored
Until now, we had to use IsSecureContext() to check whether an execution context is a secure context manually. But we can use [SecureContext] instead of the manual check now. After this change, all related APIs including PaymentRequest will not be exposed in non-secure context. Bug: none Change-Id: Ie5b3fc6641e882cc2844595fea350b6adb3425db Reviewed-on: https://chromium-review.googlesource.com/818594Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#548425}
-
Raphael Kubo da Costa authored
This prevents GCC from spamming the build with warnings such as ../../base/message_loop/message_pump_for_io.h:39:22: warning: missing terminating ' character #error Platform doesn't define MessagePumpForIO Change-Id: Ice62f39141a613c2ab4a56c031826c43292f287f Reviewed-on: https://chromium-review.googlesource.com/997632 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#548424}
-
Xida Chen authored
The comments in this function is a copy-paste of OnSetTouchAction. This CL simplifies it. TBR=dtapuska@chromium.org Bug: None Change-Id: I279871ad1e92084c95eff990785ca1591e17f5df Reviewed-on: https://chromium-review.googlesource.com/997761Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#548423}
-
Andrey Kosyakov authored
... just tell content to proceed with no certificate instead of cancelling the request. Bug: 757181 Change-Id: Ib7db0d5bbbdf73dfd3bad4fb5827519eb8c0dbbd Reviewed-on: https://chromium-review.googlesource.com/996954Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#548422}
-
Michael Lippautz authored
Verification requires iterability of pages implying that we cannot have a linear allocation area. The area was however potentially set up during compaction. Bug: chromium:757440 Change-Id: I9b12ecac032893aaa6d6f022149cec0a6130ebf9 Reviewed-on: https://chromium-review.googlesource.com/997672Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548421}
-
Annie Sullivan authored
NOTRY=true Bug: 828917 Change-Id: I5c36321a1e1ac1c5076e8e3025f9007e47142f73 Reviewed-on: https://chromium-review.googlesource.com/996183 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#548420}
-
Marc Treib authored
This CL plumbs the IdentityManager through to PSS, via SigninManagerWrapper. There are no behavioral changes, in particular the IdentityManager isn't used at all yet. Uses will follow soon (https://crrev.com/c/983914). This does require a small test change to make the newly-instantiated IdentityManager happy (without that change, it complains that its view of the primary account isn't consistent with SigninManager's). Bug: 825190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8b313f5572339a2c1319725fa4012b4a41365e08 Reviewed-on: https://chromium-review.googlesource.com/995414 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#548419}
-
Emily Hanley authored
Change-Id: I0c30913c829ee940f984b7df83cf813083f6be76 Reviewed-on: https://chromium-review.googlesource.com/992994Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#548418}
-
Amirhossein Simjour authored
When an autofill option is selected, before Autofill popup closes, the focus might be on autofill and the input connection might be null. This patch makes sure that this doesn't lead to crash. Change-Id: Ifcafd1de990c9f9789b455544f8feddef13e8be6 Reviewed-on: https://chromium-review.googlesource.com/996798Reviewed-by:
-
Francois Doray authored
TaskScheduler needs access to command line arguments in an upcoming CL that allows disabling background tasks via a command line argument (https://chromium-review.googlesource.com/c/chromium/src/+/996439). The order of initialization matches what is done elsewhere in the codebase. Bug: 726937 Change-Id: I4e709db4c7f36c9e062d43aa686f5309cc8f3745 Reviewed-on: https://chromium-review.googlesource.com/996559Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#548416}
-
Kevin McNee authored
These affected tests process GesturePinchUpdates outside of a GesturePinchBegin/End pair. We add the missing begin and end events. Bug: 787924 Change-Id: Ic087d85b39bb7a39c794c62dea06cba622125a12 Reviewed-on: https://chromium-review.googlesource.com/986540Reviewed-by:
-
Francois Doray authored
These properties are available on TabLifecycleUnitExternal, which is intended for use outside of chrome/browser/resource_coordinator/. Bug: 775644 Change-Id: I5708c3be32806c0109ad04ece1fffaa5f1f0709f Reviewed-on: https://chromium-review.googlesource.com/858046 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#548414}
-
Allen Bauer authored
Added IsMaterialRefreshMode() function to ChromeLayoutProvider. Bug: 822000 Change-Id: I379d7603838cdec60b3f94fc0e163e9907995b61 Reviewed-on: https://chromium-review.googlesource.com/988052 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#548413}
-
Gabriel Charette authored
This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle() Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which focused on RunLoops with a variable name. The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. If there was a comment above the MessageLoop::ScopedNestableTaskAllower, it should have been moved alongside the augmented RunLoop. Includes should have been stripped if the was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rsleevi@chromium.org Bug: 781352 Change-Id: Ieef9ec8a22e3c7451a27124b447883db7ff3f500 Reviewed-on: https://chromium-review.googlesource.com/995975Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#548412}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9db18b4f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15368 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing kojii@chromium.org: external/wpt/css/css-scoping mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mstensho@chromium.org: external/wpt/css/css-multicol worker-dev@chromium.org: external/wpt/workers TBR=foolip No-Export: true Change-Id: I16e485d604f6bbfa375cd14d8624a12641304ad1 Reviewed-on: https://chromium-review.googlesource.com/996863 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#548411}
-
Kristian H. Kristensen authored
CL:989024 updated the MD5 sums for the video_VideoDecodeAccelerator test, but thanks to the magic of copy and paste, the VP8 sum ended up being the same as the VP9 sum. Fix that. BUG=827032 TEST=video_VideoDecodeAccelerator Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> TBR=dalecurtis@chromium.org,posciak@chromium.org Change-Id: If55a5371c45ae01103f80f4007df8e7338570142 Reviewed-on: https://chromium-review.googlesource.com/994068 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Show $root_gen_dir to make it more obvious when paths are generated. Expand "Other" in canned_queries to have one group per top-level directory to give a bit more granularity. Change-Id: Ib9630b5aa04e1c52d51e3afa8772a4a2d4392555 Reviewed-on: https://chromium-review.googlesource.com/996909Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#548409}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/61ee69a66e73..26ad1acbcb4c $ git log 61ee69a66..26ad1acbc --date=short --no-merges --format='%ad %ae %s' 2018-04-04 mpsuzuki * src/truetype/ttobjs.c (trick_names): Add 3 tricky fonts (#53554), `DFHei-Md-HK-BF', `DFKaiShu-Md-HK-BF' and `DFMing-Bd-HK-BF'. (tt_check_trickyness_sfnt_ids): Add checksums for 3 tricky fonts in above. 2018-04-03 wl Minor comment improvement. 2018-04-01 wl * builds/toplevel.mk (work): Use $(SEP). 2018-03-30 wl [truetype] Fix memory leak (only if tracing is on). 2018-03-26 apodtele Documentation improvement. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org BUG=chromium:811110 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1053 ChromiumOS-Issue: chromium:825973 Change-Id: Icfc49484a500e0c75edebb7d58b76d3c7442d5ea Reviewed-on: https://chromium-review.googlesource.com/995918 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#548408}
-
