- 20 Jun, 2018 40 commits
-
-
Tiger Oakes authored
Removed context#getApplicationContext calls from /chrome/android/java/src/org/chromium/chrome/browser/services/gcm Continuation of work in bug 646094. This CL was uploaded by git cl split. R=peter@chromium.org Bug: 846456 Change-Id: If4634124016982063b17725552585ef08d333a94 Reviewed-on: https://chromium-review.googlesource.com/1095914 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568805}
-
Greg Kraynov authored
Bug: 783309 Change-Id: I0e32bfa8001ceb6be444b99852ca73f38dec8bbc Reviewed-on: https://chromium-review.googlesource.com/1102682Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#568804}
-
Luke Bjerring authored
Note that this is not a functional change; it just helps authors of idlharness tests identify what's gone wrong if they have incorrect add_objects params. testharness.js drops the stack for thrown errors and prints a (useless) new stack. Change-Id: I6dd90c461f0ab58e57978a28e3e5e9eb366a4827 Reviewed-on: https://chromium-review.googlesource.com/1104311 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#568803}
-
stkhapugin@chromium.org authored
Bug: 852787 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ied16b9651281b7907e8628752938a2d6b42ae9c3 Reviewed-on: https://chromium-review.googlesource.com/1106337 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568802}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 68b65a6c. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19932 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source TBR=robertma No-Export: true Change-Id: I6257e3f545b54c38592ac72a01e92028de1b4e18 Reviewed-on: https://chromium-review.googlesource.com/1107640 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568801}
-
clamy authored
This CL is part of a serie of CLs to remove usage of Navigation::GetVisibleEntry when possible. Instead, we use WebContents::GetVisibleURL or NavigationController::GetLastCommittedEntry when appropriate. Bug: 853705 Change-Id: I97ddfe4712fe68ff730ebc7ff1a6756094d3554d Reviewed-on: https://chromium-review.googlesource.com/1104349Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568800}
-
Johnny(Jianning) Ding authored
The incumbent realm schedules the currently-running callback although it may not correspond to the currently-running function object. The goal for this CL to is check whether the script setting is disabled before invoking JS callback, then checking the context which originally schedules the current-running callback seems to make more sense. Please notice that this CL changes the behavior of the method IsCallbackFunctionRunnable to require the execution context of the incumbent environment to be not empty, not paused and enabled for JavaScript. Bug: 849600,849601,849730,848086,849915,851357 Change-Id: Id8ab0f9f67f9602635b295b414d2d0026c87e4ab Reviewed-on: https://chromium-review.googlesource.com/1087536 Commit-Queue: Johnny Ding <jnd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568799}
-
Noel Gordon authored
Significant test-time can be shaved by testing one image for now since testing two images (previous code) makes MSAN unhappy. Some better way for testing the gallery-open-select-image case seems possible, and one that could also be fast (that case is being removed in the CL). That may be the focus of a future CL, but here our goal is to make the test suite fast by testing one thing in a fixture, not multiple things (see previous code). Herein, test open-an-image-in-gallery meaning one image only, not two (since two costs us 2 x O(1)secs [1]), which might help to get this test re-enabled on MSAN again (issue 837551). As a reminder to future readers, this FilesApp test fixture only tests opening and closing the Gallery from FileApp and that's all that needs testing here. Refer to GalleryBrowserTest for the integration tests of the Gallery features. [1] The time it takes to decode and draw the JPEG image (~1sec) in the test step is way longer than the time it takes libjpeg_turbo to decode it (at most 10ms). Something else is taking up a lot of time, but I am not sure what it is yet: thumb-nailing? image resizing? ... Bug: 837551 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I9ac3b0433d8f5fbd2f04516af21bf17482eb8401 Reviewed-on: https://chromium-review.googlesource.com/1106178 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568798}
-
Marc Treib authored
Resolving possibly one of the oldest TODOs in our codebase :) Bug: none Change-Id: Ib9bfc4f857b45b80c8bfac89ebf3079e2738ab6a Reviewed-on: https://chromium-review.googlesource.com/1107627 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#568797}
-
Matt Falkenhagen authored
When the network service or NetS13nSW is enabled, requests skip service worker loaders entirely when the controller has no fetch event handler. This was broke assumptions in DocumentThreadableLoader, since it expected service worker machinery to return "fallback for CORS" responses for certain requests when there was a controller. Bug: 850839 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I32b058caacb14cba2e53dd8667fe9fc930a776e8 Reviewed-on: https://chromium-review.googlesource.com/1107435Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#568796}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9edff1c2..60f929c0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3febf555d52efbf5b1467b8555dc0d406aa9d662 Reviewed-on: https://chromium-review.googlesource.com/1107639Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568795}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f04148c810aa..056a68da896d git log f04148c810aa..056a68da896d --date=short --no-merges --format='%ad %ae %s' 2018-06-20 mbonadei@webrtc.org Revert "Enable any address ports by default." 2018-06-20 aleloi@webrtc.org Init GainControlImpl with correct lock. 2018-06-20 asapersson@webrtc.org Add functionality to set min/max bitrate per simulcast layer through RtpEncodingParameters. 2018-06-20 nisse@webrtc.org Delete pre_decode_callback. 2018-06-20 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before PC in ObjC Created with: gclient setdep -r src/third_party/webrtc@056a68da896d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iba9c503fa109f6124c33ff2045a0455df841f35b Reviewed-on: https://chromium-review.googlesource.com/1107598 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568794}
-
stkhapugin@chromium.org authored
Uses proper view controller containment APIs when displaying the popup. Updates layout on screen rotation. Bug: 837006 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie7ff928d68b5cedc526cbe6057e1286cb54bd637 Reviewed-on: https://chromium-review.googlesource.com/1106175Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568793}
-
Vaclav Brozek authored
Specifically, to the component and iOS, based on past areas of work. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8c1254a9a19c956f2a5a18d06e6030c3c137fb54 Reviewed-on: https://chromium-review.googlesource.com/1107701Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568792}
-
Justin Cohen authored
TBR=hinoka@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9f05716edc1ee2b47af96557295cdf4cbd9f43a0 Reviewed-on: https://chromium-review.googlesource.com/1106677 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568791}
-
cathiechen authored
The inside marker could be a child of anonymous block not LI. When we are finding symbol marker if meet anonymous block we should check its parent. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8127ff9d38b351f97171f7a0cc8c8c3fdd896e6c Reviewed-on: https://chromium-review.googlesource.com/1102296 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568790}
-
Sylvain Defresne authored
The implementation of mailto: handler observes the SyncService so it needs to unregister itself during shutdown. Add a method called during application shutdown to unregister the handler. Bug: 854159 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I99e6de4f488ef6ef0fe7cd7f48deece648051503 Reviewed-on: https://chromium-review.googlesource.com/1106161 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568789}
-
Mikel Astiz authored
Sending the very same tab entity is wasteful: in most cases it will be caught by other layers (which will realize the proto is identical) but let's detect it in early stages, which also avoids unnecessary I/O to disk. Bug: 854493 Change-Id: Ia2ceaa4347bdf4dca1c5d0995b2466d07b41261a Reviewed-on: https://chromium-review.googlesource.com/1107060Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568788}
-
Egor Pasko authored
Sadly dskiba and mariakhomenko are moving on to work on something else. We are scraping really hard to fill the gaps. Updating the docs to the new harsh realities. Bug: None Change-Id: I2e8899ad975ba1279a95ce4f702d20756981ed47 Reviewed-on: https://chromium-review.googlesource.com/1106617 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#568787}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Iee653b8470c8aabd7eb14ed81ddf48e6411c472f Reviewed-on: https://chromium-review.googlesource.com/1106345 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568786}
-
Mikel Astiz authored
This logically reverts the precaution introduced in https://chromium-review.googlesource.com/843574 which prevented sync IDs from being vended when the browser itself was not running (no tabbed activity/window), effectively resulting in a partial unlaunch session sync for Custom Tabs. The reason to do this was UMA metric Sync.SesssionsDuplicateSyncId reporting many sync ID conflicts, now investigated in depth in crbug.com/843554. The suspicion was that duplicate IDs were produced by a race condition due to using two separate persistence databases (one for sync, one for session restore). We recently reworked the SyncedTabDelegate API to migrate away from sync IDs, which renders the above concern moot and makes it straightforward (as proposed here) to start syncing Custom Tabs even when no tabbed window exists. Bug: 840722,853459 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8a27e68faa79271a6058f00c3dd5355ef635f1a4 Reviewed-on: https://chromium-review.googlesource.com/1092536 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568785}
-
Jeremy Roman authored
This prevents the resolver from being prematurely collected. Bug: 852751 Change-Id: I9516c9cdb84133291008cb045108e41baa956272 Reviewed-on: https://chromium-review.googlesource.com/1106543 Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#568784}
-
Javier Fernandez authored
The Grid Layout code needs to run a pre-layout for some specific case, which include orthogonal and baseline aligned grid items. We decided to execute this logic as part of the PlaceItemsOnGrid function, aiming for a better performance and simpler and more elegant code. However, the PlaceItemsOnGrid function is not executed on re-layouts if no item has changed its position. Hence, there may be cases where we need to repeat the layout of the grid and some of the items involved in baseline alignment items are marked for layout as well. In those cases, like the one described in the bug this CL tries to fix, the grid item is assumed as not participating in baseline alignment, but we resolve that it actually participates during the layout phase. This CL tries to solve the issue my moving the pre-layout logic out of the PlaceItemOnGrid function, so we ensure both orthogonal and baseline alignment are laid out before running the intrinsic size and layout operations. Bug: 853427 Change-Id: I31d0357e647cccf728376a4abc12e8ea19983822 Reviewed-on: https://chromium-review.googlesource.com/1104425 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#568783}
-
Jerry Lin authored
The tests in components/autofill/c/b/password_generator_fips181_unittest.cc use a random source during tests and are thus non-deterministic. This patch adds a method of PasswordGeneratorFips181 called SetGeneratorForTest. It accepts a parameter generate_func so PasswordGeneratorFips181 will use this function to generate password to achieve deterministic unittesting. Unittest code uses this function to set generator for test to make test deterministic. R=vabr@chromium.org Bug: 847200 Change-Id: If2924ed0e59843336f0e642053eefaca4c353163 Reviewed-on: https://chromium-review.googlesource.com/1084392 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568782}
-
Sylvain Defresne authored
IdentityManager is the recommended API to access the Google account used by the user and SigninManager is deprecated. Convert PrivetPrinterHandler to the new API. Bug: 798408 Change-Id: I9cd18bd698f88ecda52d085ba661641d7c6fe06d Reviewed-on: https://chromium-review.googlesource.com/1100758Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#568781}
-
Joel Einbinder authored
Bug: 853439 Change-Id: Iea24e161de8fd82be7b1a6b3f4c5ffdf99425f14 Reviewed-on: https://chromium-review.googlesource.com/1107014Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#568780}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e5de0eb. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19931 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor TBR=robertma No-Export: true Change-Id: I8421a0ee11455014847ce071e0448e0ca4a6d693 Reviewed-on: https://chromium-review.googlesource.com/1107492 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568779}
-
Kush Sinha authored
This is a reland of 94c42a4f Original change's description: > Code Cleanup: Dedup usages of AccountManager's URL Context > > |InlineLoginHandlerChromeOS| and |ChromeOSOAuth2TokenServiceDelegate| > use the system URL context because they 'know' that AccountManager is > going to use the same. This is a leaky abstraction. > > Add a method in AccountManager that returns its URL Request Context. > This request context happens to be the system URL context for now. > > Bug: 820046 > Change-Id: I668769167893c995f73df63acc575eb410c0f986 > Reviewed-on: https://chromium-review.googlesource.com/1088617 > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566998} Bug: 820046 Change-Id: I614beba63f15ebe3a3db9a267ef8d747a7728a50 Reviewed-on: https://chromium-review.googlesource.com/1105777Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#568778}
-
Hayato Ito authored
A part of crbug.com/738794. trustedtypes are not related to DOM Standard. BUG=777761,738794 Change-Id: I56906a4ca41a3a3318b26cc52579661ed25f3c50 Reviewed-on: https://chromium-review.googlesource.com/1107519Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#568777}
-
Ramin Halavati authored
Flash permissions are on the way to become only persistent through current session. This CL adds an experimental flag for the required changes. Bug: 850062 Change-Id: Iccc22dbb2c9d63711e8b58c76e59a6939bd58d46 Reviewed-on: https://chromium-review.googlesource.com/1105986Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#568776}
-
Aleksei Loshkarev authored
Removes from ModelTypeController preferences dependent logic for purging sync metadata. Now ModelAssociationManager advises data type controllers when is it necessery to purge sync metadata. Bug: 823721 Change-Id: Ib4e73fde912accc6b84188d0f21c3df724000f5e Reviewed-on: https://chromium-review.googlesource.com/1008303 Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568775}
-
Ivan Sandrk authored
In public session, US international was the default keyboard layout for Brazilian Portuguese while the want is to have Brazilian as the default layout. The default is chosen as the first layout from the list, so fix the default by reordering the lists in (google_)xbk_manifest.json. More details at the linked bug. Bug: chromium:851625 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I524cf6bf0b625ae60c26820a1b224815b6d7d1cb Reviewed-on: https://chromium-review.googlesource.com/1102685 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568774}
-
Denis Yaroshevskiy authored
This function is never called. If there is ever a need to do this, chome_paths has a generalized mechanism for overriding file paths. Change-Id: I0822b22aed510492f88ecc0b4595649aee749583 Reviewed-on: https://chromium-review.googlesource.com/1102466Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Denis Yaroshevskiy <dyaroshev@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#568773}
-
stkhapugin@chromium.org authored
Update the location_bar_secure icon to a new one. Bug: 852787 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iea6784608548fd25463df21de3952dcdb87745b0 Reviewed-on: https://chromium-review.googlesource.com/1101199 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568772}
-
cathiechen authored
While ComputeInlinePreferredLogicalWidths ignore spaces after LayoutNGMarker. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9ced3a959c6f89412c82686ffe2fcee4f141737e Reviewed-on: https://chromium-review.googlesource.com/1102284 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568771}
-
Ivan Kotenkov authored
Update documentation and remove an unused variable. This is a cleanup after https://chromium-review.googlesource.com/c/chromium/src/+/935670 Bug: 651348 Change-Id: I6e974b282c61497a8e5fdc2ea092e48d32ee26ed Reviewed-on: https://chromium-review.googlesource.com/1105827 Commit-Queue: Ivan Kotenkov <kotenkov@yandex-team.ru> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568770}
-
Uladzimir Miniailau authored
Remove unnecessary "Enable" from a password manager feature name. Bug: 785953 Change-Id: I7c979dc97e34595db69976d673c0afe31aceb879 Reviewed-on: https://chromium-review.googlesource.com/1106377Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Cr-Commit-Position: refs/heads/master@{#568769}
-
Gauthier Ambard authored
This CL changes the vertical constraints of the collapsed toolbar to have the location bar displayed in the middle of the collapsed toolbar by changing the constraint to position its bottom anchor. Bug: 836817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I35ad32681a820b8480ecec76e825defc4c0aa2ef Reviewed-on: https://chromium-review.googlesource.com/1107061 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568768}
-
Hajime Hoshi authored
Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I15903843b0377c45db9caf3d54914ed942caf361 Reviewed-on: https://chromium-review.googlesource.com/1098742 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568767}
-
Christopher Lam authored
This CL removes all compiled_resources2.gyp files from ui/webui and third_party/polymer, and removes the script that generates them for Polymer Elements. TBR=jochen@chromium.org Bug: 632206 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1866d4e682e41c462958ac1185b6cb7e70cb7130 Reviewed-on: https://chromium-review.googlesource.com/1105677 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568766}
-