GitLab

Split SyncBackendHost into SyncBackendHost, SyncBackendHostImpl and
SyncBackendHostCore.

The SyncBackendHost class is now a pure virtual interface.  It is the
contains the interface exposed to the ProfileSyncService.

The SyncBackendHostImpl class implements the functionality of the
SyncBackendHost.  It contains most of the code that used to reside in
SyncBackendHost.

The SyncBackendHostCore is the old SyncBackendHost::Core under a new
name.  It's been moved out of the SyncBackendHost's .cc file and into
its own, publicly declared class.  This will hopefully enable better
testing in the future.

This is a pure refactoring change.  It should have no impact on program
behavior.

BUG=312999

Review URL: https://codereview.chromium.org/61183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233533 0039d316-1c4b-4281-b951-d872f2087c98

Icons loaded asynchronously needed to cause a relayout instead of just
a change to the layout manager.

R=jianli@chromium.org
BUG=315244

Review URL: https://codereview.chromium.org/61003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233532 0039d316-1c4b-4281-b951-d872f2087c98

The skia glyph cache can use up to 4 GDI handles per cache entry (1 HFONT,
1 HBITMAP, 2 HDCs). There's a global (session-wide) limit of GDI handles
at 10k on some version of windows, so we need to keep the per-process handle
count well below this limit to avoid exhaustion. This sets the limit at 64
cache entries so the skia glyph cache will stay under ~256 handles per process.

BUG=314387

Review URL: https://codereview.chromium.org/60933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233531 0039d316-1c4b-4281-b951-d872f2087c98

This adds "2-clause BSD" and "3-clause BSD" to whitelisted licenses.
This is only a wording issue, since "BSD 2-clause" and "BSD 3-clause"
are already whitelisted.

This makes third_party/mach_override pass webview license check, even
though that particular library is not used by webview.

BUG=315381
NOTRY=true
TBR=joth

Review URL: https://codereview.chromium.org/62663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233530 0039d316-1c4b-4281-b951-d872f2087c98

This CL centers the font height when cap height is not supported (actually it's CrOS and Linux).  This behavior is the same before http://crrev.com/54353002 .

BUG=314688
TEST=Test manually.

Review URL: https://codereview.chromium.org/59873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302696
R=darin@chromium.org, derat@chromium.org

Previously committed in r233414, but reverted in r233416 because it collided with r233347.

Review URL: https://codereview.chromium.org/52823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233528 0039d316-1c4b-4281-b951-d872f2087c98

There was a legitimate bug here, but it only occurred on non-aura builds.
On aura builds, the code was still incorrect but by luck exhibited the
correct behavior.

The confusion about this behavior comes from the fact that prior to
r232828, we allowed Desktop and Metro instances of chrome to run 
simultaneously, depending on which shortcut you clicked.  As of r232828, 
all shortcuts lead to the same browser experience, and we store the 
"stickiness" in the registry and the launch experience is based entirely 
off of the value stored in the registry.

As a result, the code here which was incorrect, and which is fixed in this 
patch, only matters for non-Aura.


BUG=314034

Review URL: https://codereview.chromium.org/60823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233527 0039d316-1c4b-4281-b951-d872f2087c98

For DEPS reasons (this file needs to reference the views directory in an
upcoming CL).

BUG=299250

Review URL: https://codereview.chromium.org/60323007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233526 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233525 0039d316-1c4b-4281-b951-d872f2087c98

git log 141ef86..e98b112 --date=short --format="%ad %an %s" | sed 's/@chromium\.org//'
2013-11-05 Marc-Antoine Ruel Make licensecheck.pl happy by tweaking the license header.
2013-11-05 Marc-Antoine Ruel Update copyright to the Swarming Authors and codereview.settings.
2013-11-05 Marc-Antoine Ruel Update colorama to 5a3100113a3a.
2013-10-30 vadimsh Report all swarming and isolate fatal errors in a consistent way.
2013-10-28 csharp Set the Swarm Test encoding to UTF-8

This removes the need to blacklist colorama for license check.

R=vadimsh@chromium.org,boliu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/59913006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233524 0039d316-1c4b-4281-b951-d872f2087c98

In ::OnXEvent(), we notify of a change in the window, even if the |state_| of the window stays the same. Checking that there was actually a state change would prevent some wasted calls.

BUG=None

Review URL: https://codereview.chromium.org/59873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=234078
TEST=none

Review URL: https://codereview.chromium.org/59863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233522 0039d316-1c4b-4281-b951-d872f2087c98

Input elements typed "text", "search", "tel", "url", "email"　 and "number" are text input field: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#attr-input-type

context.type should represent those types. 

BUG=311514

Review URL: https://codereview.chromium.org/47553010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302724

Review URL: https://codereview.chromium.org/61213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233520 0039d316-1c4b-4281-b951-d872f2087c98

It's empty on Blink side now. Rather than implementing it or leave it empty,
just stop calling it. In Chromium, content::NotificationProvider never goes
away.

BUG=none

Review URL: https://codereview.chromium.org/36073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233519 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates all references to the WebKit namespace outside of content,
chrome, and components.

TBR=darin@chromium.org
BUG=295096

Review URL: https://codereview.chromium.org/61553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233518 0039d316-1c4b-4281-b951-d872f2087c98

Remove RenderWidgetHost::AddCreatedCallback as part of removing that pattern. The tests which use this are disabled since a RenderWidget isn't used for AutoFill anymore according to the bug. So when the test is rewritten a new way will have to be found. In the meantime we should remove this so that more callers don't get added.

BUG=277617
R=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/63803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233517 0039d316-1c4b-4281-b951-d872f2087c98

BUG=301510
TEST=http://www.dbtv.no/?vid=2750870727001 plays
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/63643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233516 0039d316-1c4b-4281-b951-d872f2087c98

Addressed nit comments of http://crrev.com/59193005 .

BUG=315056
TEST=none

Review URL: https://codereview.chromium.org/59513006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233515 0039d316-1c4b-4281-b951-d872f2087c98

This match enables to initialize the input mode indicator when multiple input methods are available.

BUG=315007

Review URL: https://codereview.chromium.org/59413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233514 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates all references to the WebKit namespace in content.

TBR=darin@chromium.org
BUG=295096

Review URL: https://codereview.chromium.org/63253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233513 0039d316-1c4b-4281-b951-d872f2087c98

SmoothnessMetricUnitTest mixes testing of TimelineModel,
SmoothnessMetric, and RenderingStats. This patch adds a dedicated unit test
for RenderingStats only. It creates a TimelineModel directly, without using
TraceEventTimelineImporter (which has its own unit test). RenderingStatsUnitTest
verifies that RenderingStats extracts the correct events from the model.

This patch also fixes a bug in TimelineModel.FindTimelineMarkers uncovered
by the new test.

SmoothnessMetricUnitTest itself will be refactored in a separate CL.

R=nduca@chromium.org, tonyg@chromium.org
BUG=314877

Review URL: https://codereview.chromium.org/59403008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233512 0039d316-1c4b-4281-b951-d872f2087c98

The platform-specific implementations of NativeViewport have a bunch of
duplicated code. This CL centralizes that code in the cross-platform
controller class.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/59383011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/59343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233510 0039d316-1c4b-4281-b951-d872f2087c98

This is a repeat of https://chromiumcodereview.appspot.com/11553016/, using the
New Advanced Technology™ in https://chromiumcodereview.appspot.com/54373011/.

BUG=278554
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/58803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233509 0039d316-1c4b-4281-b951-d872f2087c98

("more" = "everything but the Android-only targets")

R=sky@chromium.org, sky

Review URL: https://codereview.chromium.org/63393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233508 0039d316-1c4b-4281-b951-d872f2087c98

The change to UMA aligns metrics for the data reduction proxy on
Android and iOS.

BUG=241518

Review URL: https://codereview.chromium.org/59113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233507 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up to r207709.

BUG=242944

Review URL: https://codereview.chromium.org/58993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233506 0039d316-1c4b-4281-b951-d872f2087c98

Ensure callback objects held by the Indexed DB dispatcher are released
before WebKit and V8 are torn down, since the callback objects hold V8
handles.

This is the same patch as crrev.com/50333004 which landed as r232620
but reverted as r232649 due to timeouts on XP - I just tweaked the
test constants slightly.

BUG=308988
TBR=marja@chromium.org,jamesr@chromium.org,dgrogan@chromium.org

Review URL: https://codereview.chromium.org/58113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233505 0039d316-1c4b-4281-b951-d872f2087c98

Introduce ExtensionHostFactory to hold Browser-specific ExtensionHost
creation.

BUG=313481
TEST=browser_tests, unit_tests

Review URL: https://codereview.chromium.org/57923009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233504 0039d316-1c4b-4281-b951-d872f2087c98

This measures the median of the decode time of all the frames.
VDA::Decode is called 30 times per second to simulate WebRTC.

VideoDecodeAcceleratorTest class is renamed to
VideoDecodeAcceleratorParamTest, which shows it is a
value-parameterized test. The common code is moved to a new
test fixture VideoDecodeAcceleratorTest, which is inherited
by VideoDecodeAcceleratorParamTest. The future new tests should
be based on VideoDecodeAcceleratorTest if they do not need to
test different combinations of the parameters.

BUG=292703
TEST=Run VDA tests.

Review URL: https://codereview.chromium.org/57663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=290974

Review URL: https://codereview.chromium.org/49003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233502 0039d316-1c4b-4281-b951-d872f2087c98

How this works is that we create a WebContents in the background to a Drive
endpoint that will take care of all the offline initialization for the app.
We succeed if a background page is opened; otherwise, we fail if the page does
not load or after a timeout.

BUG=307302
TEST=manual

Review URL: https://codereview.chromium.org/55423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233501 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309965
TEST=manually done on Win 8.1

Review URL: https://codereview.chromium.org/54173007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233500 0039d316-1c4b-4281-b951-d872f2087c98

This was already implemented for non-aura Win, this just makes it
work on Aura Win and Chrome OS too.

BUG=179892

Review URL: https://codereview.chromium.org/53503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233499 0039d316-1c4b-4281-b951-d872f2087c98

Introduce a way to call NavigationControllerImpl::ReloadIgnoringCache()
from the Java-side TabBase.

Also, consolidate reload() functions.

BUG=307333

Review URL: https://codereview.chromium.org/49353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233498 0039d316-1c4b-4281-b951-d872f2087c98

Caused "PluginPrefsTest.UnifiedPepperFlashState" failure on "Linux Clang (dbg)"

BUG=316017

> Prefer opening PDF downloads in the browser.
> 
> PDFs in particular are safer to open in the browser. This patch changes
> the handling of downloads to open such files in the browser by default
> instead of the system handler for the file type. A "Open with system
> handler" menu item will be available so that users can still use the
> system application if needed.
> 
> The determination that a file is safer to handle in the browser is done
> as follows:
> 
> a) DownloadTargetDeterminer determines whether the MIME type
>    corresponding to the target filename of the download is one which is
>    handled by the renderer or one that is handled by a sandboxed pepper
>    plugin. If so, then the file is considered safely handled by the
>    browser.
> 
> b) ChromeDownloadManagerDelegate determines whether opening in the
>    browser is preferred for the file type assuming the browser is able
>    to handle it safely. Currently this is true for .pdf files.
> 
> Opening behavior for a download will default to opening in the browser
> if both results from a) and b) are true.
> 
> BUG=148492
> 
> TEST=(1) Make sure Chrome PDF Viewer is enabled in chrome://plugins.
>      (2) Download a .pdf file.
>      (3) Download shelf context menu should show "Open" and "Open with
>          system handler" options.
>      (4) "Open" as well as clicking on the shelf icon and clicking on
>          the download in chrome://downloads should all result in opening
>          the file within the browser.
>      (5) "Open with system handler" should open the .pdf with the
>          application that's set up as the default handler for .pdf files
>          on the users' machine.
> 
> Review URL: https://codereview.chromium.org/55063002

TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/61623006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233497 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/46503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233496 0039d316-1c4b-4281-b951-d872f2087c98

plug-ins' memory for other browsers, when other browsers run.


BUG=273316
NOTRY=true

Review URL: https://codereview.chromium.org/38533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/23621037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233494 0039d316-1c4b-4281-b951-d872f2087c98