- 19 Nov, 2020 40 commits
-
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: I338ac32bf6de0d248a93506ccbe9c832ffea0430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532870 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829040}
-
Melissa Zhang authored
This relands commit 571bc134. This CL adds animation to Sharesheet appear and disappear. Appear has a opacity fade in from 0 - 100 in 100ms with linear curve and scale fade in 80-100% in 150ms with curve (0.4,0,0.2,1). Disappear is a 100-0 in 80ms linear opacity fade out. In this CL we also disable sharesheet close on deactivate when ShareActions have been selected. The original CL caused a crash when calling CloseBubble twice in quick succession. To prevent this we are adding a check if the bubble is already closing and do not try to close the widget a second time. Bug: 1148692 Change-Id: I19ebe2d34786d51b625bef670c3567f112c50671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548581Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829039}
-
Esmael El-Moslimany authored
Bug: 1076506 Change-Id: I167596f3b470adbd015ceb1a72ea25abfe6268e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542669 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829038}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d361e6028c27..2d31db0b3751 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6619f284224e6c21131b555b2822e7b163b4ccd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829037}
-
Alex Newcomer authored
Paste the html markup into the WebContents instead of loading it via a data URL. This ensures the markup is sanitized before rendering it. Bug: 1148077 Change-Id: I43e6a1607e73602a1d099b087b6db3da27ef2b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523647Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#829036}
-
Yicheng Li authored
The user display name will be used to managed credentials. Bug: 1150639 Change-Id: Ie7137255cc3e5450f71e0b74e56f8cfca5390860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547625 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829035}
-
Jeffrey Kardatzke authored
This adds usage of the protected media VAAPI APIs to VaapiWrapper. This is currently based on an upstream pull request located here: https://github.com/intel/libva/pull/457 That pull request will be patched onto the ChromeOS version of libva before this CL is merged. BUG=b:153111783,b:155509236 TEST=Builds, protected playback works w/ full set of changes, vaapi_unittest, also verified vaapi playback & vaapi_unittest on eve Change-Id: Id086dd33d692b86d810ea56645a63fb977d6bfc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526171 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#829034}
-
Nate Fischer authored
No change to logic. This adds bug numbers for all disabled tests so we can easily determine if these bugs are correctly triaged. This does not change which tests are disabled. I did the same search for @FlakyTest, but these seem to all have a bug number listed, so there was no work to do. Test: run_webview_instrumentation_test_apk Change-Id: I983e2ccc4addf51afe70724b69b9e96cde81beab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548182 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829033}
-
Tal Pressman authored
Change-Id: I08cc79651c2bfabcbaa64372bac54b732c33eae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538868 Auto-Submit: Tal Pressman <talp@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#829032}
-
Joel Hockey authored
This reverts commit 54e85384. Reason for revert: Reverting in order to create a patch for M88. Original change's description: > Support Arc, crostini, and Plugin VM in drag drop FileHelper > > The current code in FileHelper assumes all windows are Arc. We now > check the source and target aura::Window to detect and do the > appropriate path translations and share files when necessary with > crostini/pluginvm. > > For example, when crostini is the drag source, we will convert paths > such as: > > <homedir>/file => /media/fuse/crostini_<hash>_termina_penguin/file > > And do the opposite translation when crostini is the drop target. > > We also convert paths and share files such as: > > <cryptohome>/MyFiles/file => /mnt/chromeos/MyFiles/file > /media/removable/MyUSB => /mnt/chromeos/removable/MyUSB > > For PluginVM, the translation is > > <cryptohome>/MyFiles/file => //ChromeOS/MyFiles/file > /media/removable/MyUSB => //ChromeOS/removable/MyUSB > > Bug: 1144138 > Change-Id: I2bb38336537acf13c4797374d6dabe6e518d689e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517346 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Jason Lin <lxj@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827956} TBR=oshima@chromium.org,joelhockey@chromium.org,niwa@chromium.org,lxj@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144138 Change-Id: I212ae8759e9069e52837fd1bc324ea5f9046b6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547743Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#829031}
-
Thomas Phillips authored
The remaining tests in render_frame_message_filter_browsertest.cc are all cookie tests. Renamed the file: * Old name: content/browser/frame_host/render_frame_message_filter_browsertest.cc * New name: content/browser/frame_host/cookie_browsertest.cc R=boliu@chromium.org Bug: 1080786 Change-Id: If4e759a9f8f8a943c438cafbcee3f1144600c035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532766 Commit-Queue: Dominic Farolino <dom@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#829030}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ba982f47a9f..78d59130877b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dmazzoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141619,chromium:1146481,chromium:1146656 Tbr: dmazzoni@google.com Change-Id: I631ed41a073cc81d938d7d1eaed15c019d4c52ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548380Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829029}
-
James Cook authored
In most places in the code we check both for the base::Feature LacrosSupport and browser_util::IsLacrosAllowed(). In a recent code review I forgot one. Move the feature check into IsLacrosAllowed() and rename the function to IsLacrosEnabled(). This requires a small change to BrowserManager which also fixes a bug. If enterprise policy switches from allowing Lacros to not allowing Lacros we now clean up the binary in the component updater. Previously the binary would stay there forever. Follow-up to code review comment in: https://chromium-review.googlesource.com/c/chromium/src/+/2542678 Bug: none Test: manual, login with enterprise device, toggle flag Test: added to unit_tests Change-Id: I3938e6fed4af7831f41f947e9a30f03000f75cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547782 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829028}
-
Eugene Zemtsov authored
Before this change instances with outstanding flush() promises might have been collected and destroyed by JS GC. Bug: 1148159, 1146170 Change-Id: I4a49deab447ad79e4d2c4022968af6d5e6d4b5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546170 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#829027}
-
Alice Boxhall authored
Since we moved to primarily walking the DOM tree, we are automatically getting aria-hidden=false elements in the tree, so we don't need to specially add them. Change-Id: Id44b451dc47e3baa301258254d89edb7a2bbe14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545846Reviewed-by:
-
Alexander Timin authored
Add a pair of flow events connecting the place where the surface transaction callback was set and where it was invoked. This (together with other flow events) allows tracing the entire chain of events which generated a given frame. R=skyostil@chromium.org BUG=1142207 Change-Id: I6f41fd6627c3ac9b2799d5574ed98ca8c619a014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494814 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#829025}
-
Justin Cohen authored
Remove this for a milestone to see if hangs go down. Bug: 1150659 Change-Id: Ief95b225bceaeb9a565149f7a9ac4260e6b3cd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547328Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829024}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/259ce70939a8..060020166679 2020-11-18 zzyiwei@google.com Add baseline VK_EXT_device_memory_report support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6bec9c7fb5deca508f2ed5a4e19f03b9ef6f0950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548345Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605700503-d95dd16f6b81bc506b282993a455cc1291c6d3ef.profdata to chrome-win64-master-1605711541-e80691ca139e898c0a60a52d6d7a9fcb07e313a9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4887d976b1b9809d814c78eb4c4b96cd5b4f23c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547115Reviewed-by:
-
Mohamed Mansour authored
There seems to be a timing issue between the AX queries for GetText and when the model is updating. Looking at the model it seems not all TabDestroyed calls are informing the Observers that the model has changed. The TableView uses Virtual AX Children that depends on the observers to call. Moved the observer call to the Reset to satisfy all other cases where the Hung Pages Modal gets fired in: - RenderProcessExited - RenderWidgetHostDestroyed - TabDestroyed, - RenderViewHostChanged - WebContentsDestroyed Bug: 1140454 Change-Id: I4e5b375acb351f5338faff3f30b65b38fc834818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545050Reviewed-by:
-
Hwanseung Lee authored
There is dead code for translation in ContextualSearchPolicy.java due to translation handled by a separate translation class. This CL removes the dead code. Bug: 1137510 Change-Id: I60af0160aa24b81372038bc08cfb4ec8dcf4220a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546387 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#829020}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/738092aeadaf..8a58e38bfd26 2020-11-18 syoussefi@chromium.org Vulkan: Remove texture gather suppressions from khr deqp 3.1 2020-11-18 syoussefi@chromium.org Vulkan: Support format reinterpretation in imageBuffers 2020-11-18 ynovikov@chromium.org Remove Nexus 6P expectations 2020-11-18 syoussefi@chromium.org Vulkan: Fix aliasing format for non-layered image bindings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1148989,chromium:998503 Tbr: cnorthrop@google.com Change-Id: If6f86d0bd44cd32be0ff1b470e25282befc0962c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548341Reviewed-by:
-
Ahmed Fakhry authored
This is a reland of https://crrev.com/c/2538590, which was reverted by mistake. The actual failure was caused by another CL (https://crrev.com/c/2537939) which was also reverted. No changes were made in this CL from the original. TBR=jamescook@chromium.org Original CL description: In this CL, we handle: - Imminent suspends. - User switches in multi-profile sessions. BUG=1142994 TEST=Added new tests Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538590 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#828602} Change-Id: I2a7fa62844971c1874dd8266472717c09f365739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548272Reviewed-by:
-
Jinsuk Kim authored
The newly added SwipeGestureListener replaces the old EdgeSwipeHandler/SwipeRecognizer. A bunch of swipe gesture methods in Stack/OverlappingStack were apparently left unused. Deleted them for clean up. Bug: 1142475 Change-Id: I6691f08ba2b3d15e84083aa9f08f485ccbd90699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517237Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#829017}
-
John Palmer authored
BUG=1148093 Change-Id: Ib23c8bbc8ac1ad5b8c70a940693f14ad22acf1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530961 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829016}
-
Aleks Totic authored
TablesNG is a rewrite of tables. In Legacy code, LayoutTableSection inherits from LayoutBox. In new code, LayoutNGTableSection inherits from LayoutBlock This caused AXLayoutObject::IsLineBreakingObject to return false in legacy code, and true in new code. We should be consistent between legacy and new code. Naively, I'd think that LayoutTableSections are line breaking objects. But legacy code does not think so. This fix changes LayoutTableSection to be a line breaking object. Bug: 958381 Change-Id: I5a3408b4d5075af8b485238752a76b26e5d99c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538266Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829015}
-
John Palmer authored
Bug:1111135 Change-Id: Icf92171034328177cfe12e104b4cb872e81d1884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526647 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829014}
-
Sonny Sasaka authored
For Googlers, we set the default preference to enable verbose Bluetooth logs for feedback report. Googlers can still override this default in chrome://bluetooth-internals/#debug if they want to opt out. This feature is guarded by a Chrome flag. Bug: b:172273364 Change-Id: If6d8f77635f6f7adc03a6bc31cff7f46b1d0a312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542762 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829013}
-
Dave Tapuska authored
Move the implementations into base and protect with a DCHECK(ForMainFrame() as we don't expect setting the window rect to be an operation on a child local root. BUG=1097816 Change-Id: Ia2f6d3f735ad9cd91bbd507a26a54ff44e0a6133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543833 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#829012}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6e7e3279..7e050e9a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I060e10410610e067de11b44e96635299f4613811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548361Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829011}
-
Kent Tamura authored
This doesn't change rendering behavior, but changes |getComputedStyle(element)['appearance']| results. The new behavior matches to Firefox. Bug: 965432 Change-Id: Ia3d495a362381a6b057ec0df2b8d38e6765e1e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546395 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829010}
-
Elly Fong-Jones authored
This change removes all overrides of BubbleDialogDelegateView from LocalCardMigrationDialogView. A subsequent change will remove the inheritance relationship between these classes altogether, but that should be done separately to keep the lifetime changes clear. Bug: 1075649 Change-Id: Iebf843b682c2a9f3bc445ca11174efbc7ef3d9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545487 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#829009}
-
Dave Tapuska authored
This method can be easily moved into base. BUG=1097816 Change-Id: Ic10bea81566403eed038a4c93ed54998dc5a1c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542758 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Yulun Wu authored
Bug: 1147639 Change-Id: Ib9a7bc5cb7bcbc874704f0889f81989c8901e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530803Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829007}
-
Aaron Colwell authored
Refactor default SiteInstance code so that most of it is in SiteInstanceImpl instead of BrowsingInstance. This makes the code simpler and easier to follow. Bug: 1085275 Change-Id: I40eee7f12500616ff8b7d61e088fe1d717e7eeef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538363 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#829006}
-
Bruce Dawson authored
The headless_browsertests try to startup the crashpad-handler process but they don't do it properly. This causes some inappropriate sandbox code to be run, triggering a CHECK, and it means that the crashpad process is never actually set up correctly. This has been broken as far back as I could tell (back to April 2020 when the CHECK was added). This incorrect setup then leads to communications errors shown with these error messages on every test: ERROR:registration_protocol_win.cc(130)] TransactNamedPipe: The pipe has been ended. (0x6D) ERROR:registration_protocol_win.cc(102)] CreateFile: The system cannot find the file specified. (0x2) It is unknown whether this fails on other platforms so for now I am just disabling it on Windows where I know it does not work. Bug: 1147063 Change-Id: I1d02d00de6a5af3ccc73c3db213a822eeea1c2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543683Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#829005}
-
Yuly Novikov authored
Hardware overlays are disabled in this driver per crbug.com/1079393#c105 Re-enable some tests that pass with the new expectation Bug: 1079393 Change-Id: I53eda3767ed935ba3a01c7610812de3d6dae7da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548340Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#829004}
-
Nina Satragno authored
Disable PPAPINaClPNaClTest.* on MacOS. Tests are failing. Tbr: bbudge@chromium.org Bug: 1076806 Change-Id: I23b2c72b88e9f56c8f3f7c59b6f31e101d2b91ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548343Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#829003}
-
Roman Arora authored
Bug: 1149707 Change-Id: Icb6f5f0be7679eff8a6309554f2b24aa123cb6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542729 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#829002}
-
Ethan Jimenez authored
Previously,`NGGridItemContributionType` and `AutoPlacementType` were moved outside of `NGGridLayoutAlgorithm` to improve readibility of several helper functions, as referencing such enums from functions outside of the class resulted in much longer lines. This change returns these enums inside `NGGridLayoutAlgorithm` following the same pattern as `AxisEdge` to use them in external helper functions. Bug: 1045599 Change-Id: Iab68d75778858ba2f6d0a61329f56d49db6c6455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543205Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#829001}
-
