GitLab

This cl updates the following views and behaviors in Keyboard Shortcut
Viewer (KSV).
1. Remove the start search page.
2. Add Esc and Back key supports and update behavior with Backspace key.
3. Unbold text in no search results page.
4. Make the search bar 2px longer at both sides to align with text.
5. Update strings and tooltips of buttons.
6. Make the window 32px wider in order to put all shortcuts in one line.

Bug: 768932
Test: Tested on device.
Change-Id: Ief361b80b8326dfd8b3aea1b0cd17a42040be95d
Reviewed-on: https://chromium-review.googlesource.com/942687
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540372}

All call sites now use std::make_unique.

Bug: 755727
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I08adbff1480987b2c29bca8ad32b096a46d937ba
Reviewed-on: https://chromium-review.googlesource.com/944048
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540371}

I have a series of CLs in progress to allow StackLayout to support more than two
tab stacks. This CL switches mStacks and mStackRects from arrays to ArrayLists
to better support StackLayout variants where the number of open tab stacks can
change.

Bug: 648314
Change-Id: I6604760395bc32612a53f1667d3d574c081ccd9c
Reviewed-on: https://chromium-review.googlesource.com/940523
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540370}

Tbr: kojii@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id7f797b0c1804f030cb4fe142d514aab6b44ed92
Reviewed-on: https://chromium-review.googlesource.com/944503Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540369}

Ensure that element fetch time is only logged once per fetch request.

Bug: 228355
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I997115965c1548ed02b58c29cca6896607b3761d
Reviewed-on: https://chromium-review.googlesource.com/942608
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540368}

Add ScrollData and EventMomentumPhase mojo struct, enum, and traits.
Remove lossy ScrollEvent conversion code from PlatformDisplayDefault.
Generalize some EventDispatcher code to support non-pointer events.
Add a basic StructTraitsTest.ScrollEvent unit test.

Bug: 602859, b/73663094
Test: onemilescroll.com, Arc++ scrolls/flings with --enable-features=Mus
Change-Id: Ib6ba95fdd79aa67d5ad1b6b7c4ff9f4b38b3e45b
Reviewed-on: https://chromium-review.googlesource.com/940607Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540367}

This allows using asan_symbolizer.py to get improved stack traces with
line numbers even in non-ASAN, non-debug builds.

Change-Id: I047b7e936c54b79ab057616a9e6a4c013a94b1fc
Reviewed-on: https://chromium-review.googlesource.com/940771Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540366}

Bug: 788604
Change-Id: I8f8ea1b9a847c10b35bfa48e9320922a9bdb2afb
Reviewed-on: https://chromium-review.googlesource.com/944619
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540365}

The previous checkout contains a bug that would cause manifest update to
fail on Windows sometimes, so we are rolling a new version again to
include a high-priority fix:
https://github.com/w3c/web-platform-tests/pull/9737

Bug: 749879
Change-Id: I36495316d5ddea288c7422c2dbed30c1fed6106d
Reviewed-on: https://chromium-review.googlesource.com/944720Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540364}

This reverts commit 32778ae4.

Reason for revert: Likely culprit for ASAN crash.

Original change's description:
> [DIAL] Added a DialURLFetcher to handle Dial related HTTP requests
> 
> DeviceDescriptionFetcher and DialAppInfoFetcher have some common code.
> Create a DialURLFetcher class to get rid of some duplications.
> 
> The common URLFetcher class can also be used to launch and stop Dial
> apps when we implement DIAL launch at browser side.
> 
> Bug: 816628
> Change-Id: I26bdfbbf7e2d59a68e3bf5aeaba8b6e3664bf430
> Reviewed-on: https://chromium-review.googlesource.com/938158
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Commit-Queue: Bin Zhao <zhaobin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540242}

TBR=mfoltz@chromium.org,imcheng@chromium.org,rhalavati@chromium.org,zhaobin@chromium.org

Change-Id: Ibfc4a97935f88ac4520383e6b26cd2ebca9ecb2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816628
Reviewed-on: https://chromium-review.googlesource.com/944728Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540363}

Bug: 790648
Change-Id: I3b937866dec75cd62485f44cdd74a54dc78634f6
Reviewed-on: https://chromium-review.googlesource.com/944563Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540362}

Bug: 817979
Change-Id: I0a7ac6811306123f1bd55ef2def0f00283116b55
Reviewed-on: https://chromium-review.googlesource.com/944516Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540361}

Recent changes to the Process code trigger this, so allow it inside the
test license server.

BUG=817971
TEST=Widevine browser_tests pass locally

Change-Id: Ice5f89164413e7aab3095e9a767e411ff7e940d7
Reviewed-on: https://chromium-review.googlesource.com/944265
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540360}

Bug: 804528
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I84bee4638790a586b741edf67fe2cb781766a208
Reviewed-on: https://chromium-review.googlesource.com/944049
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540359}

Also, re-enable the tests which had been identified as flaky.

Bug: 810738, 810302
Change-Id: Ieafb9a09450f4a3a61f2e1e14d40dc93366a875d
Reviewed-on: https://chromium-review.googlesource.com/938362Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540358}

Initial set of unittests tests whether
the consumer protocol methods are called.

Bug: 804496
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib252da01784d407720b7980ee4ee1378cdb13c2d
Reviewed-on: https://chromium-review.googlesource.com/942696Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540357}

This reverts commit 2c1a1650.

Reason for revert: This is still flaking.

Original change's description:
> Fix flakiness in AutomationApiTest.DesktopHitTestIframe
> 
> At least one issue was that the loadComplete event was sometimes being
> received on a frame with an empty url.
> 
> Bug: 808343,622387
> Change-Id: I7040a75c91f409ba07d3b9ad4e4598805e94b6ce
> Reviewed-on: https://chromium-review.googlesource.com/938495
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540097}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: If3a4f36c64d2a2d2be04d7d520082344edcc1290
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 808343, 622387
Reviewed-on: https://chromium-review.googlesource.com/944768Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540356}

Needed for instantiating these pages with a custom shared page state
class in upcoming rendering benchmarks.

Bug: 760553
Change-Id: Idecad59778f1c7cd729f90bf9e67e67b8e538f9b
Reviewed-on: https://chromium-review.googlesource.com/942310Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540355}

Adds pyserial 3.4 to the .vpython file. This is currently only used
by the VR motion-to-photon latency test.

Bug: 812428
Change-Id: I56644689177394dfdba727be41bdf792386e0f2e
Reviewed-on: https://chromium-review.googlesource.com/943923Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540354}

Starting with gvr 1.13, GVR ignores the screen rotation and always
delivers poses as though the phone was in portrait orientation.
This CL applies the proper rotation to gvr-provided poses to account
for the screen rotation.

Bug: 817889
Change-Id: Ie705046439775b2a34d30b177db6191414acaa10
Reviewed-on: https://chromium-review.googlesource.com/944006
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540353}

Bug: 790648
Change-Id: I09bb0711c9a82ba5ca06ed64392288e04b87b4d6
Reviewed-on: https://chromium-review.googlesource.com/944707Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540352}

Bug: 783500
Change-Id: I9374ea004a0f776939c00279948ea5c1a21bc74f
Reviewed-on: https://chromium-review.googlesource.com/942320Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540351}

Bug: 790648
Change-Id: I2b24cb5c0baec19416d844ce95601dab69671b1a
Reviewed-on: https://chromium-review.googlesource.com/944567Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540350}

In some cases, at least when starting as a scheduled task, Windows
subprocesses are started with a very low priority. Therefore, force
normal process priority when starting a subprocess.

R=dpranke@chromium.org

Change-Id: Ib9e8f9bb1f6d06cffeeab3694508df9e755f8a19
Reviewed-on: https://chromium-review.googlesource.com/941229Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Cr-Commit-Position: refs/heads/master@{#540349}

Mac C++ compiler is not able to convert a base::ListValue
unique pointer object to a base::Value unique pointer object.

R=dpranke@chromium.org

Change-Id: I07072578bd432c1a6ea13ca9757c75c3da37107c
Reviewed-on: https://chromium-review.googlesource.com/941208Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Cr-Commit-Position: refs/heads/master@{#540348}

Deprecate Net.QuicSession.PublicResetAddressMismatch which is not in use due to https://codereview.chromium.org/294823002.

Change-Id: I9c51936f69fde5abd6b60de9ab1614607213f97a
Reviewed-on: https://chromium-review.googlesource.com/942239Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540347}

This CL changed the return type of
|URLLoaderFactoryGetter::GetNetworkFactory()| to
|scoped_refptr<SharedURLLoaderFactory>| in an effort to reduce the
usage of raw pointers.

The returned |SharedURLLoaderFactory| is basically a wrapper around
|URLLoaderFactoryGetter|, which holds a reference to
|URLLoaderFactoryGetter| and handles reconnection after crash.

It's safe to use the wrapper after the storage partition has gone, in
which case the url requests will be silently dropped.

Bug: 796425
Change-Id: Ie89b7f8933bc6e1c274cf42bc6bd2265c50c37d4
Reviewed-on: https://chromium-review.googlesource.com/935284
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540346}

Bug: 690696

Change-Id: I0ea4ad248a47ff29238344fdea6d1e7beb906743
Reviewed-on: https://chromium-review.googlesource.com/944050Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540345}

Add gstatic.cn to the Google certificate pin list.

TBR=nharper@chromium.org

Change-Id: I8a99c6a9c98c6b2f38b83050972a700953bb886b
Reviewed-on: https://chromium-review.googlesource.com/943824Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540344}

Bug: 776877, 790761
Change-Id: Ia64b43faaf21368eb44fbc85b1320c593291ad8a
Reviewed-on: https://chromium-review.googlesource.com/944259
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540343}

This is a reland of d13a7e92.

Safe to land; bad service deploy caused the original notification.

Original change's description:
> Add Windows Release CI builders to milo
>
> Adds the compile builder, and the tester.
>
> Bug: 790710, 790644
> Change-Id: I83de37258aadc8d8e79cde3c32baca9d7d994c98
> Reviewed-on: https://chromium-review.googlesource.com/940431
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540314}

Bug: 790710, 790644
Change-Id: Ia7d91fc3be49f7c0dbe32c8ac4424fb3ce71b124
Reviewed-on: https://chromium-review.googlesource.com/944727Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540342}

Keep them tagged as scoped_refptr. Returning a raw pointer sort of
works, but because some refcounts have already been acquired in the
process, we're relying on at least one of those refcounts sticking
around long enough for the raw pointer to be cashed in.

LoginHandler is rather a mess and really should get rewritten (move
UI/IO hop within //content, surface out of WebContentsDelegate,
get rid of NotificationRegistrar and ref-counting), but in the
meantime fix up this local issue.

Tagging with https://crbug.com/814334 in case it's related, but I
don't think it is. (This isn't turning an owned raw pointer to a
scoped_refptr. It's turning a quasi-borrowed raw pointer to a
scoped_refptr.)

Bug: 814334
Change-Id: I542799c20f7453b76f46c1cfad582a8de833a684
Reviewed-on: https://chromium-review.googlesource.com/940021
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540341}

Adds a flag (--cast-app-background-color) that changes the background
color used when displaying web apps. This color is often shown briefly
before Chromium renders a web app.

Bug: internal b/70181260
Test: use flag on ATV
Change-Id: I3bc0989aeabbf639116c1b30fffb11f66b56c4cd
Reviewed-on: https://chromium-review.googlesource.com/897466
Commit-Queue: Thoren Paulson <thoren@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540340}

changes:
According to the design doc: go/cros-persistent-window-bounds, add UMA
for recording the number of windows restored for persistent window
restore in multi-display scenario.

Bug: 805046
Test: tested on device, checked chrome://histograms and added test coverage
Change-Id: I4f8c815c1b88dd605a02b509b27311d567998da1
Reviewed-on: https://chromium-review.googlesource.com/942186Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#540339}

When we're using a button to trigger tab switches, we don't want the
description or icon hinting at switching, since the main suggestion
won't switch in this state.

In addition to these tiny changes, it adds a new icon for the button,
per the UI spec.

Bug: 780835
Change-Id: I01d0c913292852e6ecaf569c1feecccbebd0646d
Reviewed-on: https://chromium-review.googlesource.com/943831
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540338}

Bug: 817653
Change-Id: I29fed9cfc734439aa4a97cf591dafc440232de12
Reviewed-on: https://chromium-review.googlesource.com/943938Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540337}

Bug: None
Change-Id: Ie31654577b2270f83380b06f753bb48f2740a289
Reviewed-on: https://chromium-review.googlesource.com/943344Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540336}

Bug: 816826
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I56839874977fb0563b556e198a5252f4d5937ed7
Reviewed-on: https://chromium-review.googlesource.com/941971Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540335}

If, on a non-secure page, the user edits an INPUT TYPE=FILE field by
selecting a file, send a signal to the browser that a form field has
been edited. This will result in the "Not Secure" string in the
security chip for the page.

Change-Id: I80528eba22a6e590d98d81c7e26389705a340833
Reviewed-on: https://chromium-review.googlesource.com/850588Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540334}

If we evict a surface before the previous CompositorFrame activates with it
as a fallback, then we will attempt to add an invalid reference and we may
end up with missing surfaces in surface aggregator. This CL combats the issue
by avoiding evicting frames during resize.

We will still only update the primary surface ID if the tab is not hidden,
and we will clear the fallback surface ID if the tab is hidden.

Bug: 813157, 672962
TBR: samans@chromium.org
Change-Id: I9f35ef24597f0bc88e139b23a2994e8b32abbc70
Reviewed-on: https://chromium-review.googlesource.com/938678Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#539639}
Reviewed-on: https://chromium-review.googlesource.com/943725Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540333}