- 27 Jan, 2018 40 commits
-
-
Miguel Casas-Sanchez authored
This CL adds gl_unittests to chromium.gpu.fyi, hence making it run, among others, on the Mac nVidia bot that caused the original CL to be reverted. There's more information on the bug but, in a nutshell, the original CL was reverted due to a specific nVidia bug that manifested itself on the chromium.gpu.fyi mac bot; however, it doesn't show up in the mac_optional_gpu_rel. So, this CL has no specific nVidia provisions, just reenables the test, and we'll see what happens in the chromium.gpu.fyi waterfall :-) Bug: 803473 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I71c0451d2e3b53baa3bd24bafdf1f7a5f1210363 Reviewed-on: https://chromium-review.googlesource.com/886543Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#532136}
-
Nico Weber authored
Bug: 177475 R=oshima@chromium.org Change-Id: Id75257a2890576c0ff7c913fcb3daccf8296839a Reviewed-on: https://chromium-review.googlesource.com/889778Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#532135}
-
Kent Tamura authored
We're going to use blink::CreateElementFlags in more header files, and would like to avoid to include huge Document.h. This CL has no behavior changes. Bug: 805280 Change-Id: I64c89995cda3f76f1e75b6cf20af05f0e8eb2e24 Reviewed-on: https://chromium-review.googlesource.com/888191Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#532134}
-
Zhenyao Mo authored
They are no longer necessary now we move everything to GPU side. Also, remove process_crash_count from GPUInfo because this is valid in browser process only, but it's mis-used on renderer side. BUG=744658 TEST=bots R=kbr@chromium.org,piman@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I896c299e72554dae6c9698f56a808425a738c9be Reviewed-on: https://chromium-review.googlesource.com/887349Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#532133}
-
Jialiu Lin authored
Add 2 policy settings for PhishGuard. PasswordProtectionWarningTrigger controls if we show the model dialog warning. PasswordProtectionRiskTrigger controls if we do event logging for at-risk account. If there is no policy for these for settings, then PhishGuard works the same way as for non-enterprise users. With the exception that, for GSUITE users, PhishGuard warning and at-risk account flagging is off by default. Bug: 804490 Change-Id: I6ff1cc71222217c168ca0bbebf36dac4be946a43 Reviewed-on: https://chromium-review.googlesource.com/879429 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#532132}
-
Nico Weber authored
Bug: 177475 R=bajones@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0034f33d1d5b307d61bcc04dabb624bfe6a0bace Reviewed-on: https://chromium-review.googlesource.com/889819 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#532131}
-
Nico Weber authored
Bug: 177475 R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3048cd151bc720d0edbacbec698723f07b65842a Reviewed-on: https://chromium-review.googlesource.com/889760 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532130}
-
Nico Weber authored
Bug: 177475 R=palmer@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_mips_dbg;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: I361d9b71990cbb9870760709748d1928055b779c Reviewed-on: https://chromium-review.googlesource.com/889787 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#532129}
-
Toni Barzic authored
Fixes two issues with how incognito extension prefs changes are dispatched when the extension is in split incognito mode: 1. If an extension was incognito split, but not incognito enabled, the incognito prefs changes were dispatched to the the extension's original profile instance (even though extension in the original profile generally cannot access incognito prefs). This CL does not dispatch incognito pref changes to extensions that are not incognito enabled. 2. If an incognito pref change was dispatched to an incognito split extension when OTR profile was not around, in order to restrict the preference to the OTR profile, DispatchEventToExtensions() function would call Profile::GetOffTheRecordProfile which would create an OTR profile instance. This cl avoids this issue by dropping the events that are expected to be restricted to a non-existent OTR profiles (Note: if the pref value changed in the original profile, and there is no incognito specific pref value, the value change is reported for the incognito pref, too), BUG=796814,805480 Change-Id: I093949c9f9123e3baaab56932903f4f2be55903c Reviewed-on: https://chromium-review.googlesource.com/882508 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532128}
-
Nico Weber authored
Bug: 177475 R=miu@chromium.org Change-Id: I7aa7196b1b325b0741e6c7bb60822ac6d59dc295 Reviewed-on: https://chromium-review.googlesource.com/889780Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532127}
-
Jialiu Lin authored
Save sync password hash when user clicks "Sign in again" button in the account menu. This sync password hash is used to detect gaia password reuses. Bug: 790824 Change-Id: I420162773e03fb5b99341a6da6c96a49a2a1efba Reviewed-on: https://chromium-review.googlesource.com/879468Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#532126}
-
Moja Hsu authored
The interface is used from chrome os camera hal for jpeg decoding. For the compatibility issue between the Mojo versions of chrome os and chrome. Shared buffer handle serialization is not supported between the old version and the new version. We create a new DecodeWithFD in GpuJpegDecodeAccelerator Mojo interface. BUG=chromium:780009 TEST=Run gpu_jpeg_decode_accelerator_unittest to check Mojo interfaces. Decode a real jpeg image from chrome os by the Mojo interfaces. Run camera app. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8e7df9543dd532dc2457f334245593b6722a71fb Reviewed-on: https://chromium-review.googlesource.com/670541Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532125}
-
Pavel Feldman authored
Bug: 874525 Change-Id: I1da32dc0179563938875f8a740635a10287570a4 Reviewed-on: https://chromium-review.googlesource.com/877504Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532124}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iad8fde7df949176ce836671916de50db6fa7099e Reviewed-on: https://chromium-review.googlesource.com/882465 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#532123}
-
Vasilii Sukhanov authored
TouchSelectionForCrossProcessFramesTests/TouchSelectionControllerClientAuraSiteIsolationTest.BasicSelectionIsolatedScrollMainframe/1 fails on all the platforms. TBR=tdresser@chromium.org Bug: 805017 Change-Id: I1ea7c82a4c8fc2fa8e83c83ac47ef65f98cd985f Reviewed-on: https://chromium-review.googlesource.com/888753Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532122}
-
Matt Falkenhagen authored
Originally I planned to clone the request body for main resource requests, similar to subresource requests, but it looks unnecessary for now because main resource request bodies don't have data pipe getter elements. They are only created by the renderer when converting from a Blob, which doesn't happen for navigations. So this patch: - Adds a DCHECK to the main resource request handling code that there are no data pipe elements. - Adds a WPT test for network fallback with a request body (using just strings since we can't test uploading a file with WPT as far as a I can tell, it needs user interaction or a special test harness flag). - Adds a http/tests/local/ test case for file upload with network fallback. This test file was already passing, so the failing expectation is also removed. R=kinuko, shimazu Bug: 778878 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7a5f7a72ef9ac2ca3ffbe54549739ca6bcc8d071 Reviewed-on: https://chromium-review.googlesource.com/885684 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532121}
-
Nico Weber authored
See the top of the script for usage instructions. I tried a few different set of options. All: https://chromium-review.googlesource.com/c/chromium/src/+/888764 Proposed + properties: https://chromium-review.googlesource.com/c/chromium/src/+/888966 Proposed: https://chromium-review.googlesource.com/c/chromium/src/+/889359 The script currently replaces (id) with (instancetype) where appropriate, tries to infer NS_DESIGNATED_INITIALIZER and NS_RETURNS_INNER_POINTER, replaces objectAtIndex: and objectForKey: for arrays and dicts with subscripting syntax, and uses Objective-C literals where possible. The clang Obj-C rewriter can't add generic parameters to Obj-C containers, so that isn't done. It also can't move instance variables from @interface to @implementation. Bug: 324079 Change-Id: I3e095e6f7c6b2cbdc0c6d37b0c043044638ab2ba Reviewed-on: https://chromium-review.googlesource.com/888981Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532120}
-
Guido Urdaneta authored
This CL adds a heuristic to find associations between video-input and audio-input devices. The heuristic considers an association to exist if the label for the video device (minus the VID:PID suffix, if it exists) appears as a substring of the audio label. If zero or more than one association is found then the video device ID is used as its group ID. This also fixes the problem of having all video devices with empty group IDs. We expect this heuristic to have a relatively high false-negative rate and a low false-positive rate. Bug: 627793 Change-Id: Iebc9228ca6a8acd5f0e740f3120ef851fecc1cb1 Reviewed-on: https://chromium-review.googlesource.com/883534Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#532119}
-
Koji Ishii authored
This patch implements computing positions of overlines and 'text-underline-position: under' underlines. Computing consistent positions across boxes within a same decoration box is not implemented in this patch. In doing so, the code to computing font vertical position is moved to SimpleFontData. Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I27b471db76ae0c94b7cc01ce2eb9084fa06ff29b Reviewed-on: https://chromium-review.googlesource.com/886283 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#532118}
-
Nico Weber authored
Bug: 177475 R=mek@chromium.org Change-Id: I027380127953f6b24b406cc8d468446053bbd151 Reviewed-on: https://chromium-review.googlesource.com/889781Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532117}
-
Nico Weber authored
Bug: 177475 R=rsleevi@chromium.org Change-Id: I887321c9251529a6377eefa32fe3bb87638eb845 Reviewed-on: https://chromium-review.googlesource.com/889800Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532116}
-
Nico Weber authored
Bug: 177475 R=fs@opera.com Change-Id: Iad30ee0f79eb40b24395deefcded5419b8617e01 Reviewed-on: https://chromium-review.googlesource.com/889783Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#532115}
-
Nico Weber authored
Bug: 177475 R=rsesek@chromium.org Change-Id: I3c346f2eabb11468a66b331213dacdcde19d0b4a Reviewed-on: https://chromium-review.googlesource.com/889762Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532114}
-
Luigi Semenzato authored
An earlier commit needlessly ruined GenerateTimestampedName() making it indiscriminately remove extensions. The extension-chopping code is being put in the right place (at the caller site). BUG=chromium:781363 TEST=none Change-Id: Ic0edf8e082ce9af34b6679bec179e76e8f4797dc Reviewed-on: https://chromium-review.googlesource.com/838242 Commit-Queue: Luigi Semenzato <semenzato@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532113}
-
Nico Weber authored
Bug: 177475 R=pfeldman@chromium.org Change-Id: I8f9cf8c5f1c07eec6c9571b1c1e25d39b7e0f93a Reviewed-on: https://chromium-review.googlesource.com/889843Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532112}
-
Nico Weber authored
Bug: 177475 R=erg@chromium.org Change-Id: I13b6ae844b98768aaf35eda5e695993617eccb1f Reviewed-on: https://chromium-review.googlesource.com/889860Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#532111}
-
Nico Weber authored
Bug: 177475 R=engedy@chromium.org Change-Id: I38b363d9c53e7b1d1dbf8249838058df2f94fee2 Reviewed-on: https://chromium-review.googlesource.com/889841 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#532110}
-
Nico Weber authored
Bug: 177475 R=sadrul@chromium.org Change-Id: I165ce28b3358f76329f3b6ea2ef05c566ee6e411 Reviewed-on: https://chromium-review.googlesource.com/889799Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#532109}
-
Nico Weber authored
Fixes a bug where an extra GPU.ContextLost.Unknown was counted for each GPU.ContextLost.UICompositor. Bug: 177475 R=sadrul@chromium.org Change-Id: I5b6ee09b924602d641255a607b96d00e6569df49 Reviewed-on: https://chromium-review.googlesource.com/889720Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#532108}
-
Bence Béky authored
Also move FLAGS_chromium_http2_flag_h2_on_stream_pad_length from spdy/chromium/spdy_flags.{h,cc} to spdy/platform/impl/spdy_flags_impl.{h,cc}, and rename to h2_on_stream_pad_length. This CL merges server side changes 182949930 by jtoohill and 182975401 by diannahu. Bug: 488484 Change-Id: I1dc62b04a0529261bc72f498dd2987a8dd2f748c Reviewed-on: https://chromium-review.googlesource.com/887903Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#532107}
-
Nico Weber authored
Bug: 177475 R=jdoerrie@chromium.org Change-Id: I0e191e6b55f3063984bdba319d245bbec3bd55ab Reviewed-on: https://chromium-review.googlesource.com/889759Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#532106}
-
Nico Weber authored
Bug: 177475 R=meacer@chromium.org Change-Id: Iaa60724d160144a2aa74c49dca0be44229f29ccd Reviewed-on: https://chromium-review.googlesource.com/889818Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#532105}
-
Nico Weber authored
Bug: 177475 R=mgersh@chromium.org Change-Id: I5ed190e0471690772507ba5034154773987d7651 Reviewed-on: https://chromium-review.googlesource.com/889820Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#532104}
-
Nico Weber authored
Bug: 177475 R=estade@chromium.org Change-Id: I4f3b6133bb2c4ea46f3db57482c96351bdb3e551 Reviewed-on: https://chromium-review.googlesource.com/889763Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#532103}
-
Nico Weber authored
Bug: 177475 R=boliu@chromium.org Change-Id: I31d7cd6f12d989557283bf3d5004f5310aa813bb Reviewed-on: https://chromium-review.googlesource.com/889798 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532102}
-
Miguel Casas authored
GpuMemoryBufferVideoFramePool::CopyVideoFrameToGpuMemoryBuffers schedules copies to GMBs using a Pool thread, so the upload is sliced and run in parallel, reconvening after all sub tasks are finished. This CL adds an ASYNC TRACE to track the duration of the full copy cycle, encompassing all the parallel (and possibly heterogenous) uploads, to make it easy to reason about how much time the copy-to-GMBs take. Bug: 803975 Change-Id: Ied827b30b43931ca06996c97dd8f855b75c9ff7a Reviewed-on: https://chromium-review.googlesource.com/886962Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#532101}
-
Fredrik Söderquist authored
Pop all operators with greater/equal precedence rather than just the top-most. Bug: 803824 Change-Id: I5f106a0e82ed98ba2510c86ed157bf4b133cb5b8 Reviewed-on: https://chromium-review.googlesource.com/888919 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#532100}
-
Emil A Eklund authored
Add ikilpatrick as a core OWNER following successful nomination. NOTRY=true Change-Id: I05211c6dc88243a7d2f9bfcc00cb3a86fb8b1a66 Reviewed-on: https://chromium-review.googlesource.com/889622 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#532099}
-
Yoichi Osato authored
Since the argument |selection_start| is used to compute two LayoutPoints, this patch salvages them from IsVibisile to the caller CompositedSelectionBound which already has the LayoutPoints. Bug: 789870 Change-Id: I43e751d35268466e910ac826820010a719a8298e Reviewed-on: https://chromium-review.googlesource.com/888338Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#532098}
-
Yoichi Osato authored
CompositedSelectionBound.is_text_direction_rtl is assigned twice redundantly. This patch unifies it. Change-Id: I6bb3e2a4139de363ec76af03b54f8137f7e8e4fc Reviewed-on: https://chromium-review.googlesource.com/885679Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#532097}
-