- 12 Mar, 2020 40 commits
-
-
Samuel Huang authored
Previously SuperSize-archive focuses on section sizes and largely ignores section addresses. As a result, "** ELF Section" symbols all have address of 0. This CL refactors archive.py so that |section_range| (2-tuple of address and size) become a primary object of interest, and replaces widespread |section_size| usage. Details: * linker_map_parser.py: Changes to store and return section ranges. * Requires test output update. * archive.py: Extensive changes to use ranges throughout. * Add _ExtendSectionRange() helper. * _AddUnattributedSectionSymbols(): Add "** ELF Section" symbols in section name order, to make later sorting more predictable. * Not changed: CreateSectionSizesAndSymbols() params, to maintain .size format compatibility. "** ELF Section:" symbols can now have non-0 addresse (and better sort order). This required update of integration_test.py expected outputs. Other changes: * Add dbg.py to aid debugging (compatible with Python 3). Change-Id: Ife5a695a4d3d75a6c67dabae5de91c9bb9618100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099466Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#749544}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a7dad03fb178..484bb8a03b97 git log a7dad03fb178..484bb8a03b97 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3bc28c82..96fc083e (749350:749472) Created with: gclient setdep -r src/third_party/webrtc@484bb8a03b97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I04421ad6f864cab388e171348952eeaf5bf53411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749543}
-
Abigail Klein authored
Introduce a new elide behavior TRUNCATE_HEAD in which multiline text in a label is truncated at the beginning of the string. This will be used to display the last two lines of captions for the live caption feature. Captions received from the captioning service may be longer than two lines. So, the determination of what the last two lines to be shown should happen during the displaying of the text in the label. Bug: 1055150 Change-Id: If3c447ac50c29a3e2f7467af9ceeb668fcd01ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090501 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749542}
-
Jiewei Qian authored
This CL adds support so File Handling origin trial can be used for System Web Apps. Under the hood, SystemWebAppManager force enables file handlers after Apps are installed (in on_apps_synchronized event). FileHandlerManager treats force enabled file handling origin trial to never expire (technically, it expires at the max time that can be persisted in preferences). Fixed: 1045297 Change-Id: Iaa55601c3ecbe37c543beb1ee6f495b62fac6617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093959 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#749541}
-
Noel Gordon authored
After mitigation CL:2098140 lands, the breadcrumb flexbox layout starts to work as expected: it can flex. Add min-widths, pads to tune the flex eliding ... best we can, given we have no spec at all for this. No breadcrumb folder tooltip mentioned in the spec either. Bug: 1035691 Change-Id: I3fa47a1ffe5daf90a3cc8dfd741ec370117fd3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098168Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749540}
-
Hirokazu Honda authored
V4L2IP sets plane length to the area of coded size and offset. This is wrong if the width of coded_size is different from the stride of the underlying buffer. This CL corrects it by setting to the size of GpuMemoryBufferPlane. Bug: None Test: ip_test --gtest_filter=NV12* on kukui Change-Id: I3e49e6ecd2442e00b8d6705cfb3e333efad0a9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096427Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749539}
-
Koji Ishii authored
Following bot results are included. 1665 1668 1672 1673 1674 1675 1676 1677 1678 1679 1681 1683 1684 1685 1686 1688 1689 1690 24 lines were removed and 30 lines were deflaked by consecutive results since 1672. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iad2d61b2fdbed5b2b0a0a485e7866c0cfeb4df72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094904Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749538}
-
Johann authored
Also iwyu <utility>. Clears git cl lint warnings. Change-Id: I039424a37b54f7b6358232d6de5ed1836fa1ef4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098162Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#749537}
-
Xianzhu Wang authored
For invalidations, just dump the rects without the object names and reasons, to avoid rebaselines on insignificant raster invalidation changes. Developers can still use LAYER_TREE_INCLUDES_DETAILED_INVALIDATIONS to dump invalidations in the original format for debugging. Change-Id: I6ec6c2b38518033f766e83de09567bbfe617b4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097520 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#749536}
-
Wei Lee authored
Bug: 2087501 Test: None Change-Id: I2756eb7aa09f3e1d6ab3f4c08a9da7d2d3a9f75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097778 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#749535}
-
Hazem Ashmawy authored
Remove variation keys field from crash expandable list since it's mostly a bunch of numbers and characters with no direct benefit for the user. Note: that this only removes it from the UI, variation keys is still part of CrashInfo class and still collected from crashpad and written to logs. They will be removed in a following CL. Bug: 1052510 Test: Manually invoke crashes and observe the UI Change-Id: If96f67595c5feacb731579fe1a26e92af4308048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095575Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#749534}
-
Hirokazu Honda authored
This fixes a bug of V4L2ImageProcessor on output queue's storage type. The output queue's storage type is V4L2_MEMORY_DMABUF if import mode. But it should follow the configured storage type of output VideoFrame in import mode. Bug: None Test: ip_test --gtest_filter=NV12* on kukui Change-Id: I7606c27170631f710764826c1d008e74ff934f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096801Reviewed-by:
-
Christopher Lam authored
This CL is a speculative fix for flakes in OS Settings browser tests that were being caused by mojo-lite files erroring at runtime. The theorized mechanism of failure is that the build dependencies were not set up correctly, and the os_settings_resources target picked up an old version of the mojo-lite file before the chrome/browser:resources target had a chance to run. Bug: 1057389 Change-Id: Ib296133a4f90300b027c28205278fe79b3e55527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094913 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#749532}
-
Shakti Sahu authored
This CL : 1 - Creates feature and flag for query tiles 2 - Adds java interface for query tiles service 3 - Initialized query tiles section in NTP 4 - Added factory and bridge for TileProvider Bug: 1059409 Change-Id: I0f19ad10b233e15b24b7b32073ffaa9794f7181a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092204 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#749531}
-
Aaron Leventhal authored
Bug: None Change-Id: If1d43b693793dc7a6f2d0645e294e1cb0e1c1f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099333 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#749530}
-
Luciano Pacheco authored
Avoid dialog-header expanding its width, when the width expands it causes the parent container to be wider causing a horizontal scroll that makes the directory tree to be hidden and the file list to be wider and potentially having a horizontal scroll which isn't desired. The "overflow-y: hidden" will cause the content of the toolbar (breadcrumbs and buttons) to be out of the view port if the toolbar is too narrow, but using Tab key can focus these elements and bring them to the view port. This is a follow up on CL:2098140 which fixes the size of file list. Bug: 1059643 Change-Id: I9ab3410b978e942437c2d65aac460e7efcbd0bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098149Reviewed-by:
-
haozhe authored
This patch fixes the flakiness in getting running-animation order by making sure the animation is running before we make a measurement. This test passed all 500 repeated run. Bug: 1060216 Change-Id: I8b271e1e0d31dac0203aa3a7bb3359f7f1d1eec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099474Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#749528}
-
Eriko Kurimoto authored
This CL adds tests for subresource fetching from HTTP(S) scheme url dedicated workers and shared workers. Currently, we have subresource fetching tests from ONLY data: URL dedicated workers and shared workers. In this CL, we improve the test coverage by adding subresource fetching tests from HTTP(S) scheme url workers which are more normal. Dedicated workers inherit the parent document's CSP headers for inside settings, so worker scripts don't need to include policyDeliveries. On the other hand, shared workers use the CSP headers specified by worker scripts as inside settings, so worker scripts need to include policyDeliveries. Here, policyDeliveries means: Content-Security-Policy: block-all-mixed-content In this CL, tools/util.py is modified because |obj| is parsed from json as OrderedDict so type(obj) == dict is always false. Bug: 1056500 Change-Id: I1881a5609a08c96f8d358e26673efac0ad70e6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077319 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#749527}
-
Kenichi Ishibashi authored
These methods should be called only when |version->context()| points to |this|. This is a follow-up CL of crrev.com/c/2093971. Bug: N/A Change-Id: Iedf925b75c974097a3dd3ff692c533e62ea2b02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099344 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
arthursonzogni authored
Plumb the CrossOriginEmbedderReporter to CacheStorage. This add supports for COEP+reporting for: - RenderFrameHost Three are missing: - ServiceWorkerHost - SharedWorkerHost - DedicatedWorkerHost Bug: 1059727, 1031542 Change-Id: Ib836ed71559233fbd7a840f1edfccd0bf0a7bda4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096561 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#749525}
-
David Benjamin authored
Bug: 1048878 Change-Id: I02eb5d713deb4ebffb8066a5a3bddcc6a4c661ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098742Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#749524}
-
Livvie Lin authored
This feature param is no longer needed since the top sites based interstitial is fully launched. Bug: 1060247 Change-Id: I3599310225015a19f62017331bbd1f3361a99e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097331 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#749523}
-
Chih-Yu Huang authored
This CL adds a parameter "--use_vd_vda" to the video_decode_accelerator_tests and video_decode_accelerator_perf_tests to support VD-based VDA using VdVDA. Bug: b:136716838 Test: video_decode_accelerator_tests --use_vd_vda on Kevin and Eve Test: video_decode_accelerator_perf_tests --use_vd_vda on Kevin and Eve Change-Id: Ib515f97cef66412a3ff833686148d846148d6109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928519Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749522}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/21996bda4c52..276dc290d7ce git log 21996bda4c52..276dc290d7ce --date=short --first-parent --format='%ad %ae %s' 2020-03-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@276dc290d7ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia976c94270e2bb9f66b4d58a7063c9ccd3297720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100043Reviewed-by:
-
Ken Rockot authored
These tests haven't passed in a long time and a subsequent CL will make them pass. This CL formats them first to reduce noise in the subsequent CL. Files which are completely obsolete or not relevant to getting tests passing are also deleted here. No functional changes. Only file deletion or automated formatting from yapf --style=mojo/public/tools/.style.yapf Bug: 1060473 Change-Id: I312886956e74dd42f1f0deb474d44abeacdb61b5 Tbr: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100012Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#749520}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c9e9039771e..94794ec0383c Created with: gclient setdep -r src-internal@94794ec0383c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I31ac382483c3a0eb72813e37b41287857cdd9e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100031Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749519}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dbb6fcdf4353..83d503bc728e git log dbb6fcdf4353..83d503bc728e --date=short --first-parent --format='%ad %ae %s' 2020-03-11 thestig@chromium.org Force .evt files to have LF line endings. 2020-03-11 tsepez@chromium.org Convert CFXJSE_FormCalcContext static methods to anon functions 2020-03-11 thestig@chromium.org Make more members const in cxfa_ffpageview.h. 2020-03-11 tsepez@chromium.org Remove indexing in CFXJSE_FormCalcContext::DotAccessorCommon(). Created with: gclient setdep -r src/third_party/pdfium@83d503bc728e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I384ebbb36561c529b7558c69e08b98fc76ca05ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100034Reviewed-by:
-
Kelvin Jiang authored
IndexedRule now has request and response header lists. Indexing these via FlatRulesetIndexer will be done in a follow-up. Bug: 947591 Change-Id: I0855ce4a85310b0df4992dd4dd326d66ff41ba14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095861 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#749517}
-
Nicholas Verne authored
When the user has clicked the Restart button, there is a delay while Crostini is shutting down before we close the dialog. We disable the buttons in this state as feedback that something is happening and the user shouldn't proceed yet. Bug: 1060830 Change-Id: If0e654c6f63e182efc3e8d178cd2237db9a09807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099346Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#749516}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibcc9e8b07d971d208f1e7030e080d1a949fc5dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100039Reviewed-by:
-
David Staessens authored
Similar to crrev.com/c/2094521 this CL marks the new video encoder performance tests as test-only. This prevents the pre-submit checks from displaying warnings about non-test code depending on test-only code. Bug: 1045825 Test: built video_encode_accelerator_perf_tests target Change-Id: Ib91045b226e15896f6fa74bacde4e4f83a097722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096606Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749514}
-
Makoto Shimazu authored
CORP check happens before a service worker sends the response back to the client. This CL plumbs a reporter to notify a server of failures of the check. Note that the error is going to the COEP reporter for the client, not for the service worker because the check in FetchRespondWithObserver is considered for the network request is initiated by the client. Bug: 1056122 Change-Id: Id8b83f8c506a78e15653a993e9471d9eab0532b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094073 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#749513}
-
Victor Costan authored
This is a reland of 264654a0 The CL was reverted speculatively in https://crrev.com/c/2095733 to get the tree green. The compilation errors leading to tree closure did not seem related to the files changed in this CL. Original change's description: > WebLocks: Remove unused include from lock_manager.h. > > //content/browser/locks/lock_manager.h included > //content/public/browser/browser_context.h, despite not using > BrowserContext at all. > > Because lock_manager.h is included in storage_partition_impl.h, > browser_context.h was indirectly included in many files. This CL fixes > the IWYU violations highlighted by compiler errors. > > Change-Id: I46462b337d93a7ae1d60648cfd617b2e69662637 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093553 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Auto-Submit: Victor Costan <pwnall@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749082} Tbr: falken Change-Id: Iaa1527e4190a577d58355275f6badbd1c26ab44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100010Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#749512}
-
Joel Hockey authored
Bug: 1056983 Change-Id: Ic0671f0c06a9390346537343a94a28b75adbca63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096605 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#749511}
-
sauski authored
Previously link rows for content settings displayed one of two labels describing their current setting. This CL extends the capability of the cookies link rows specifically to express one of the four possible effective cookie settings. -Allow -Block Third Party only in Incognito -Block Third Party -Block To ensure that this label remains correct across both the preference and content settings changes that affect the effective cookie setting, an additional WebUI listener is created which pushes updates to JS for immediate display. This updated label is applied to both cookies link row locations when the privacySettingsRedesign flag is enabled, and applied to neither when it is disabled. Bug: 1032584 Change-Id: I11a984bce60878b6224506bfc1cd1a5cf3a2e63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095925 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:dpapad <dpapad@chromium.org> Reviewed-by:
-
Toni Barzic authored
BUG=1055688 Change-Id: I4279ac1eaef74107fa710648c47217f33ebab27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097837 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749509}
-
Andrew Comminos authored
To enable impl-side frame attribution, add an association between layers and their containing frames. This element ID may be used later to look up the document via its associated DOM node ID. Bug: 910421 Change-Id: I5a70d2f42f94d72f76d9c4eb49cd6ee691e1f0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077038Reviewed-by:
-
Peter Kasting authored
This is in preparation for basing AshTestHelper on AuraTestHelper. * AuraTestHelper will now create a context factory if one isn't provided. This will ultimately allow eliminating the same functionality from Ash and using the new GetContextFactory() method. * AshTestHelper no longer takes an optional ShellInitParams; instead the relevant arguments are added to InitParams. This will make it more obviously safe/correct for callers to supply a context factory alone or for the AshTestHelper to pass it to the AuraTestHelper. * Eliminated AshTestHelper::[set_]test_shell_delegate(). Since this needed to be passed in InitParams anyway, made all callers specify this directly at SetUp() time. This is more verbose in many cases, but prevents potential issues with incorrect downcasts, null derefs, etc. Bug: none Tbr: rdevlin.cronin Change-Id: I22d3c28bfdfb25327c5ebe25415de778558e815b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097462Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#749507}
-
Theresa Wellington authored
This reverts commit 782b48e7 Patchset 1 of 2 to introduce new target and switch upstream dependencies, temporarily breaking downstraem. Patchset 2 will update downstream build targets. Originally this was a 3-sided patch that attempted to keep downstream compiling, but it unfortunately broke upstream compilation instead. BUG=1052382 Change-Id: I5d3a64397e54ec3f6f1e3cac0619ecc796f710bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095371Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dafbf121a8b1..5082df1cf53e git log dafbf121a8b1..5082df1cf53e --date=short --first-parent --format='%ad %ae %s' 2020-03-11 jvanverth@google.com Remove need for gpu when unrefing managed resources. 2020-03-11 brianosman@google.com Remove GrDrawVertices fast path for simple matrix + colors + no local coords 2020-03-11 robertphillips@google.com Make TessellatingPathOp surface its programInfo at record time 2020-03-11 rmistry@google.com Add wrapper script to call tool to bulk abandon Gerrit CLs 2020-03-11 egdaniel@google.com Have GrVkUniformBuffers own their descriptor sets. 2020-03-11 mtklein@google.com remove -D_GLIBCXX_DEBUG 2020-03-11 fmalita@chromium.org [skottie] Power reduce trivial spatial Berzier Created with: gclient setdep -r src/third_party/skia@5082df1cf53e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Ic8b7d4924a86767f92d41d2a32263bc1cbda2186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099223Reviewed-by:
-
