GitLab

We only need to update the ScrollingCoordinator once at the root of the frame
tree. We shouldn't be poking at it at every level of the recursion.

This CL finally achieves my dream of controlling
RenderLayerCompositor::updateIfNeeded with just the CompositingUpdateType enum.

Review URL: https://codereview.chromium.org/330513002

git-svn-id: svn://svn.chromium.org/blink/trunk@176046 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8 has GN build files now, we don't need this stub any more.

Review URL: https://codereview.chromium.org/329813002

git-svn-id: svn://svn.chromium.org/blink/trunk@176045 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yurys@chromium.org, scroggo@google.com
BUG=361045

Review URL: https://codereview.chromium.org/336513006

git-svn-id: svn://svn.chromium.org/blink/trunk@176044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When resolving a protocol-agnostic URL against a base of 'about:blank',
the result would be an invalid (and empty) URL, because of missing special-
casing of 'about:blank' - which is present in
Document::completeURLWithOverride.
Fix by modifying SVGImageLoader::sourceURI to always resolve the URL using
Document::completeURLWithOverride to not miss out on this special-casing
logic for 'about:blank' base URLs.

BUG=379100

Review URL: https://codereview.chromium.org/329943003

git-svn-id: svn://svn.chromium.org/blink/trunk@176043 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink side of https://codereview.chromium.org/299043003/

BUG=354697

Review URL: https://codereview.chromium.org/310623004

git-svn-id: svn://svn.chromium.org/blink/trunk@176042 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383749
TEST=none
R=dglazkov@chromium.org, hayato@chromium.org

Review URL: https://codereview.chromium.org/330543007

git-svn-id: svn://svn.chromium.org/blink/trunk@176041 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The behavior once invoked by the SkPicture::kUsePathBoundsForClip_RecordingFlag is now the default so this flag is going away.
Skia 9f1c241e (Remove SkPicture::kUsePathBoundsForClip_RecordingFlag - https://codereview.chromium.org/316143003/)

Review URL: https://codereview.chromium.org/326953002

git-svn-id: svn://svn.chromium.org/blink/trunk@176040 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are always equivalent since the WinCE case was dropped over a year ago:
https://chromiumcodereview.appspot.com/13901012

BUG=383594

Review URL: https://codereview.chromium.org/325283002

git-svn-id: svn://svn.chromium.org/blink/trunk@176039 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
R=ojan@chromium.org,atwilson@chromium.org

Review URL: https://codereview.chromium.org/329873002

git-svn-id: svn://svn.chromium.org/blink/trunk@176037 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the accessibility, animation and css subdirs under core. There's one exception that css/CSSTokenizer-in.cpp didn't change because of a coding style issue.

BUG=381876

Review URL: https://codereview.chromium.org/331633003

git-svn-id: svn://svn.chromium.org/blink/trunk@176036 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The height of text and form control can vary slightly depending on
alignment and baseline. Explicitly set height for CSS tests that do not
test nor depend on text rendering.

BUG=378610
R=dglazkov@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/323293002

git-svn-id: svn://svn.chromium.org/blink/trunk@176035 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderStyle objects are not on the heap and they keep the CSSFontSelector
and its associated ResourceFetcher alive. We turned raw pointers to the
document in CSSFontSelector and ResourceFetcher into traced Members. That
will leak until we can also trace through the RenderStyle structure.

See crbug.com/383860 for details.

This fixed the leaks by using WeakMembers to the document in these two
places. We really should trace through all of this but that is going
to be a larger change and we should fix this leak now.

R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com
BUG=383860

Review URL: https://codereview.chromium.org/335633002

git-svn-id: svn://svn.chromium.org/blink/trunk@176034 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL renames the remaining methods in RenderObject which used repaint to
be paint invalidation.

BUG=338691

Review URL: https://codereview.chromium.org/332543002

git-svn-id: svn://svn.chromium.org/blink/trunk@176033 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is as per the the coding guidelines for blink, which disallows the
use of "using" declarations of any kind to import names in the standard
template library.

BUG=NONE

Review URL: https://codereview.chromium.org/329183002

git-svn-id: svn://svn.chromium.org/blink/trunk@176032 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If different overloads of a method have different [RuntimeEnabled]
extended attributes, check the runtime flags as part of overload
resolution instead of when configuring the prototype object template.
If the runtime feature is disabled, the overload resolution algorithm
will act as if the method did not exist.

If all overloads have the same [RuntimeEnabled] extended attribute,
it is checked when configured the prototype object template as for
regular non-overloaded methods.

BUG=339000

Review URL: https://codereview.chromium.org/299203002

git-svn-id: svn://svn.chromium.org/blink/trunk@176028 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383594

Review URL: https://codereview.chromium.org/328213002

git-svn-id: svn://svn.chromium.org/blink/trunk@176027 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/327323008

git-svn-id: svn://svn.chromium.org/blink/trunk@176026 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dmazzoni@chromium.org,haraken@chromium.org,tommi@chromium.org,tkent@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/315133004

git-svn-id: svn://svn.chromium.org/blink/trunk@176025 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It should be drawn using the layout rect instead of the canvas size rect.

BUG=382884

Review URL: https://codereview.chromium.org/327703005

git-svn-id: svn://svn.chromium.org/blink/trunk@176024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allow zoom/restore in a zoomed image document. It is a regression from the earlier fix:
http://src.chromium.org/viewvc/blink?revision=156402&view=revision

BUG=324086
R=levi, tony

Review URL: https://codereview.chromium.org/262053005

git-svn-id: svn://svn.chromium.org/blink/trunk@176023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

using named grid lines. We left unfixed the case of the author using non
existent named grid lines. The truth is that it was already partially fixed
by some previous changes.

Instead of forcing resolveGridPositionFromStyle() to return a non resolved
grid position (like 'auto') we try to detect the usage of a non existent
named grid line before trying to resolve the grid position.

Review URL: https://codereview.chromium.org/309393002

git-svn-id: svn://svn.chromium.org/blink/trunk@176022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This moves the following classes to the heap:
JavaScriptCallFrame
ScriptArguments
ScriptCallStack
ScriptProfile

BUG=340522

Review URL: https://codereview.chromium.org/325143002

git-svn-id: svn://svn.chromium.org/blink/trunk@176021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/335583003

git-svn-id: svn://svn.chromium.org/blink/trunk@176020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Source/core/dom/Node.h
  Replace TreeSharedWillBeRefCountedGarbageCollected with
  TreeSharedWillBeGarbageCollectedFinalized.
- Source/platform/heap/Handle.h
  Replace TreeSharedWillBeRefCountedGarbageCollected with
  TreeSharedWillBeGarbageCollectedFinalized.
- public/platform/WebPrivatePtr.h
  Introduce PtrStorageImpl<T, GarbageCollectedLifetime>::
  assign(const RawPtr<U>&) because matching RawPtr<U> value with
  assign(const RawPtr<T>&) and assign(T*) are ambiguous.

Leftover RefPtr:
- Source/core/dom/StyleEngine.cpp
- Source/core/dom/StyleEngine.h
- Source/core/fetch/FontResource.h

Remove |using| directives for T::ref and T::deref if ENABLE(OILPAN)
- Source/core/dom/Document.h
- Source/core/html/HTMLFormControlElement.h
- Source/core/html/HTMLObjectElement.h
- Source/core/svg/SVGSVGElement.h
- Source/core/svg/SVGViewElement.h

Simple replacement of adoptRefWillBeRefCountedGarbageCollected:
- Source/core/dom/Attr.cpp
- Source/core/dom/CDATASection.cpp
- Source/core/dom/Comment.cpp
- Source/core/dom/Document.h
- Source/core/dom/DocumentFragment.cpp
- Source/core/dom/DocumentType.h
- Source/core/dom/Element.cpp
- Source/core/dom/Element.h
- Source/core/dom/ProcessingInstruction.cpp
- Source/core/dom/PseudoElement.h
- Source/core/dom/TemplateContentDocumentFragment.h
- Source/core/dom/Text.cpp
- Source/core/dom/XMLDocument.h
- Source/core/dom/shadow/ShadowRoot.h
- Source/core/html/HTMLAnchorElement.cpp
- Source/core/html/HTMLAppletElement.cpp
- Source/core/html/HTMLAudioElement.cpp
- Source/core/html/HTMLButtonElement.cpp
- Source/core/html/HTMLDataListElement.cpp
- Source/core/html/HTMLDetailsElement.cpp
- Source/core/html/HTMLDocument.h
- Source/core/html/HTMLEmbedElement.cpp
- Source/core/html/HTMLFieldSetElement.cpp
- Source/core/html/HTMLFormElement.cpp
- Source/core/html/HTMLImageElement.cpp
- Source/core/html/HTMLInputElement.cpp
- Source/core/html/HTMLKeygenElement.cpp
- Source/core/html/HTMLLinkElement.cpp
- Source/core/html/HTMLMarqueeElement.cpp
- Source/core/html/HTMLMeterElement.cpp
- Source/core/html/HTMLObjectElement.cpp
- Source/core/html/HTMLOptionElement.cpp
- Source/core/html/HTMLOutputElement.cpp
- Source/core/html/HTMLProgressElement.cpp
- Source/core/html/HTMLScriptElement.cpp
- Source/core/html/HTMLSelectElement.cpp
- Source/core/html/HTMLStyleElement.cpp
- Source/core/html/HTMLSummaryElement.cpp
- Source/core/html/HTMLTextAreaElement.cpp
- Source/core/html/HTMLUnknownElement.h
- Source/core/html/HTMLVideoElement.cpp
- Source/core/html/HTMLViewSourceDocument.h
- Source/core/html/ImageDocument.h
- Source/core/html/MediaDocument.h
- Source/core/html/PluginDocument.h
- Source/core/html/TextDocument.h
- Source/core/html/forms/TextFieldInputType.cpp
- Source/core/html/shadow/ClearButtonElement.cpp
- Source/core/html/shadow/DateTimeEditElement.cpp
- Source/core/html/shadow/DateTimeFieldElements.cpp
- Source/core/html/shadow/DetailsMarkerControl.h
- Source/core/html/shadow/MediaControlElements.cpp
- Source/core/html/shadow/MediaControls.cpp
- Source/core/html/shadow/MeterShadowElement.cpp
- Source/core/html/shadow/PickerIndicatorElement.cpp
- Source/core/html/shadow/SliderThumbElement.cpp
- Source/core/html/shadow/SpinButtonElement.cpp
- Source/core/html/shadow/TextControlInnerElements.cpp
- Source/core/html/track/vtt/VTTCue.h
- Source/core/html/track/vtt/VTTElement.cpp
- Source/core/loader/SinkDocument.h
- Source/core/svg/SVGAnimateElement.cpp
- Source/core/svg/SVGScriptElement.cpp
- Source/core/svg/SVGScriptElement.cpp
- Source/core/svg/SVGUseElement.cpp

BUG=357163

Review URL: https://codereview.chromium.org/324073002

git-svn-id: svn://svn.chromium.org/blink/trunk@176019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The SpeechSynthesis may lose its observed execution context and still
be accessed by the platform. Check if present before accessing the
context.

R=haraken@chromium.org
BUG=345061

Review URL: https://codereview.chromium.org/330603002

git-svn-id: svn://svn.chromium.org/blink/trunk@176018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Methods are registered in one of three different ways on an interface's
prototype object;

 1) via an entry in a static array,
 2) via custom code in the interface's configure{{class}}Template(), or
 3) via custom code in its installPerContextEnabledMethods();

depending on whether the method is static and its extended attributes.
E.g., [RuntimeEnabled] leads to 2 and [PerContextEnabled] leads to 3.

The old method of setting flags on each method signalling how it ought
to be registered, and filtering the single list of methods in the
templates based on these flags, was becoming seriously unwieldy for
complicated cases such as overloaded methods.

To address this, change the logic to instead filter methods into three
lists in the scripts, one for each type of registration. The templates
simply use a different list of methods when generating the different
code blocks.

For overloaded methods, take the attributes of all overloads into
account, instead of looking at only one of them (the first in IDL file
order, as it were.)

Also introduce a compile-time check that a set of overloaded methods
doesn't contain methods with conflicting extended attributes that affect
how the method ought to be registered.

BUG=339000

Review URL: https://codereview.chromium.org/328663003

git-svn-id: svn://svn.chromium.org/blink/trunk@176017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderDetailMarker needs both left and right margin to get rendered with same margin. Updated with webkit-margin-end to get the same margin result for both ltr and rtl

R=eseidel, leviw, tkent
BUG=335075
TEST=Existing details-writing-mode covers test for showing text in RTL box, with the patch rtl box now shows margin which is currently missing.

Review URL: https://codereview.chromium.org/306923003

git-svn-id: svn://svn.chromium.org/blink/trunk@176016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It generalize the algorithm to find the surrounding text to be able to
work with a starting position and an ending position. The goal is to be
able to get the surrounding text arround the current selection.

BUG=330238

Review URL: https://codereview.chromium.org/323983006

git-svn-id: svn://svn.chromium.org/blink/trunk@176015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec:
https://svgwg.org/svg2-draft/painting.html#OrientAttribute
http://www.w3.org/TR/2012/WD-css3-values-20120308/#angles

BUG=377514

Review URL: https://codereview.chromium.org/303263008

git-svn-id: svn://svn.chromium.org/blink/trunk@176014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/294053006

git-svn-id: svn://svn.chromium.org/blink/trunk@176013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/333623002

git-svn-id: svn://svn.chromium.org/blink/trunk@176012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that EventTarget is on-heap, we don't need to use RefCountedGarbageCollected for classes that derive EventTargets.

Another reason why these classes have to be RefCountedGarbageCollected is that they derive ActiveDOMObject, and ActiveDOMObject::setPendingActivity calls ref(). However, they don't need to be RefCountedGarbageCollected unless they actually use setPendingActivity(), so this CL just removes RefCountedGarbageCollected from classes that derive ActiveDOMObject but don't use setPendingActivity().

BUG=340522

Review URL: https://codereview.chromium.org/329853004

git-svn-id: svn://svn.chromium.org/blink/trunk@176011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Undo command resets the selection to the previous position, but under some
conditions it may set the selection to a position in a document that is not
controlled by FrameSelection.

If this happens, a subsequent call of FindString command provokes an assertion
in TextIterator, as it does not expect the selection endpoints to be in another
document.

This patch fixes the issue and adds a layout test that reproduces the assertion
failure.

BUG=374904

Review URL: https://codereview.chromium.org/326323003

git-svn-id: svn://svn.chromium.org/blink/trunk@176010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is currently tested with HeapHashSet. Extending it to other hash
collections is postponed to a later change. To have your type removed from
collections when weak pointers in it no longer point to live objects you need
to give it two methods and a special hash trait. See WeakHandlingHashTraits in
Heap.h for details and PairWithWeakHandling in HeapTest.cpp for an example.

R=ager@chromium.org, haraken@chromium.org, wibling@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/319593004

git-svn-id: svn://svn.chromium.org/blink/trunk@176009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TypeConversions class needs to be GarbageCollectedFinalized because new String
member needs finalization.

BUG=
TBR=oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/326423006

git-svn-id: svn://svn.chromium.org/blink/trunk@176008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For saveImageAs, we want to save the latest frame that has 
been composited to the screen. So in this case, copy from the
frontBuffer in DrawingBuffer::copyToPlatformTexture.
    
BUG=374762

Review URL: https://codereview.chromium.org/309933004

git-svn-id: svn://svn.chromium.org/blink/trunk@176007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Background: Currently V8GC do not have idea of DOM memory usage retained by wrappers. A small set of unreachable wrappers may retain huge DOM, but v8 gc may not be triggered as it is not aware of DOM memory usage.

This CL introduces |V8GCController::reportDOMMemoryUsageToV8|
- DOM memory usage is tracked at partition{Alloc,Free}
- After each task run, |reportDOMMemoryUsageToV8| is called.
- |reportDOMMemoryUsageToV8| notifies V8 GC the partition memory size currently consumed by DOM.

After this CL, http://jsbin.com/nitobiru/18 will not crash.

BUG=365018, 368406

Review URL: https://codereview.chromium.org/301743006

git-svn-id: svn://svn.chromium.org/blink/trunk@176006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL deletes a bunch of state and code from GraphicsLayer that's not used.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/335453002

git-svn-id: svn://svn.chromium.org/blink/trunk@176005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
BUG=383741,383742

Review URL: https://codereview.chromium.org/329263003

git-svn-id: svn://svn.chromium.org/blink/trunk@176003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369451

Review URL: https://codereview.chromium.org/315043007

git-svn-id: svn://svn.chromium.org/blink/trunk@176002 bbb929c8-8fbe-4397-9dbb-9b2b20218538