- 10 Dec, 2020 40 commits
-
-
Liquan (Max) Gu authored
Behavioural changes: * Before the CL, JourneyLogger.recordTransactionAmount() was triggered only when Event.SHOWN or Event.SKIPPED_SHOW is recorded. This was different from the desktop's behaviour(read crbug.com/1149936#c5 for more context). * After the CL, the method is triggered whenever all of the following conditions are met: (1) show() has been called, (2) apps have been queried, (3) payment details has stabilized. Regardless of Event.SHOWN and Event.SKIPPED_SHOW, which are recorded when UI is shown or skipped. The new behaviour is consistent with the desktop one. Changes: * Moved the calling of recordTransactionAmount() into the hook onShowCalledAndAppsQueriedAndDetailsFinalized(). Bug: 1149936 Change-Id: I4fc72e2289ab95303165622e395f9d499ebf338d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581218 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835672}
-
Tim van der Lippe authored
During the module.json extensions migration, we discovered that these two tests were breaking on the sources/network migration. However, many other tests that use/interact with the sources and/or network panel are passing. A closer investigation of these showed that they are relying on an intricate loading order, which assumes the module.json loading. Since we are changing the loading order, these tests start failing. Taking a closer look at the intent of the tests, we realized that we already have existing e2e-test coverage in the DevTools frontend. Therefore, we propose removing the problematic tests to unblock the extensions migration, while we maintain coverage through our e2e-tests. R=aerotwist@chromium.org Also-By: andoli@chromium.org Bug: 1134103 Change-Id: I56a57d1c190897c8419b6c9c1a0b4c016966df52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584164 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#835671}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/59df85b5457e..9f89587dc4fc 2020-12-10 delphick@google.com Merge "docs: Fix text on span_join restrictions" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I28317e4cc5c1d885f29971dcf1fdddc9b9b5ca8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584344Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835670}
-
David Tseng authored
Update these fairly old tests, removing code that's obsolete. Try this change on bots and hopefully most if not all will stick. R=akihiroota@chromium.org Fixed: 754870, 622387, 892960, 894016, 833318 Change-Id: I345385f0c538346ea993f2a79a3196402857d020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582529Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835669}
-
Stephen McGruer authored
Upstream WPT is now Python 3-first. To minimize the likelihood of Chromium engineers writing incompatible tests*, we should run the WPT parts of blinkpy under Python 3. * Or, more likely, incompatible Python file handlers (https://web-platform-tests.org/writing-tests/python-handlers/index.html) Bug: 1135554 Change-Id: I9813a81543219ede80bb58de971d2e4509ef4b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558741 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#835668}
-
Jakob Ivarsson authored
Bug: chromium:949156 Change-Id: I55cb3a3680d3c0fc4c3ae92df0d4de4494ad3856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584005Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Jakob Ivarsson <jakobi@google.com> Cr-Commit-Position: refs/heads/master@{#835667}
-
Ioana Pandele authored
The help launcher is only called if the help button has a targeted help menu item id, but the menu contained the default help item id. Bug: 1157428 Change-Id: Ib6c3c25e4a71268c0c9afccbb84bf2e43dd3922e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584504Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#835666}
-
Jan Wilken Dörrie authored
This change replaces usages of Blacklist with Blocklist in the PasswordStore, LoginDatabase and fixes comments that were missed in other places. Note that this change does not yet rename the actual SQL columns in the Login Data database. Bug: 1147799 Change-Id: I3860001dc12c4a3dc7a80ef9ca6c250c751ac457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581935Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835665}
-
Kyle Horimoto authored
This class logs metrics when core Phone Hub functionality is used, which will be used to log our 28DA user count. Note that this class is not actually instantiated; a follow-up CL creates an instance of this class and calls its instance functions. Bug: 1150634, 1106937 Change-Id: I224a1dd25d5d7f48b601392843d1a31a72d6743c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576474Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835664}
-
Mario Sanchez Prada authored
Migrate this legacy IPC message to the media.mojom.MediaPlayerObserver mojo interface, implemented by MediaSessionController in the browser process, update its callers in the renderer process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I91069208d3c724ff82a8716163d3b443f6a53d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554541 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#835663}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81356f4bf38c..0443332fe2b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaf42916df60fa2ec66c50f37d3ef4f8939cbc81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584324Reviewed-by:
-
Anastasiia N authored
Move `InlineLoginDialogChromeOS::Source` to `account_manager::AccountManagerFacade::AccountAdditionSource`. `AccountAdditionSource` is used for UMA stats, which will be sent by `AccountManagerFacade`. Currently they are sent by `InlineLoginDialogChromeOS::ShowDeprecated`, but these methods will be removed. Note: `InlineLoginDialogChromeOSOnboarding` will keep sending the UMA stats because it is a different dialog. Bug: 1140469 Change-Id: I652fb807b3285181e8b43ad0560983d1e3a8764e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550668 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#835661}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/55b7f38f9036..32f1a8e81217 2020-12-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 84b9bb6621c7 to d94a77b304f4 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I384e0d414e7c6e4ea8aa9c474f166c5b4117e663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584084Reviewed-by:
-
Tom Anderson authored
* With X11EventSource::dispatching_event(), all XEventDispatcher needs is DispatchXEvent(). * XEventObserver::DidProcessXEvent() is unused. BUG=739898,1054581 R=sky Change-Id: I8a030cc6f16766a67316e9c6787b5e5ca6a143d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577887 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#835659}
-
Vladimir Levin authored
This includes a fix to the original patch and a new test Original change's description: > IO: Use pre-margin target rect for an empty check for intersection threshold > > This patch ensures that we use a pre-margin version of the target rect > if we are checking whether it was empty. This is to make sure that we > compute a "1" intersection ratio in cases where an ancestor of a > margin-padded target causes it to be empty. > > In this case, we should report 1 intersection, because we are intersecting > and target is an empty rect. However, because we padded the target > with a margin, we ended up doing the wrong check and ultimately compute > 0 intersection in a different conditional branch (before this patch). > > This patch restores correct behavior. > R=szager@chromium.org, chrishtr@chromium.org Fixed: 1156815 Change-Id: Icdc333dc60e6892783f59260d59eca682a3fc7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583083 Auto-Submit: vmpstr <vmpstr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#835658}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607568819-189005e62ee8b8bdd63cb408a8a785cae17219c4.profdata to chrome-win64-master-1607590477-d35f449faec99b40815e9d2dc99b7b8e79c372c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I64472470669b23af757ea4b855c6e18625844898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583421Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7e546be6..5aee2a07 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03700e10b72d19de6723526431b38ce6a14f2cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584042Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835656}
-
Francois Doray authored
Previously, the priority of the background worker was set via an asynchronous callback. With SimpleThread::handle() which was added in https://crrev.com/c/2578172, this can be simplified. Change-Id: Ia50abab5647ef13412488e40f1589ec9d263dc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578677 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Peng Huang authored
Bug: 1156801 Change-Id: Ib163666ea9d4a940e3da6e23037422bef814573b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580167 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835654}
-
Dave Tapuska authored
Now that RenderWidget is just a shell of what it was before we don't actually need it anymore. Blink currently owns the WebFrameWidgetImpl via a Member ptr on WebLocalFrameImpl so let it call Close on it. BUG=1097816 Change-Id: I102bdec3afe750345bb1474e6aae891518534b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567043 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#835653}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0443332fe2b9..59df85b5457e 2020-12-10 treehugger-gerrit@google.com Merge "metrics: Add test for real_power_by_rail_mode table" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0c1c308af07bdb5de4cecd6b4343ff296d51d392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584287Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 1100887 Change-Id: I000ab80315270109c59f0a80c4fbfac2addc77ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583209Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#835651}
-
Wojciech Dzierżanowski authored
The custom visibility handling was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1443011. The accessibility issue (tooltip shown for an invisible label) does not reproduce anymore. The issue of interfering with dragging is still there, so we keep the workaround for that. Bug: 985303 Change-Id: I2a8380aa68c7bebe837246b672625d21b774cdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575026 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#835650}
-
Colin Blundell authored
Most of what ChromeSubresourceFilterClient is currently doing is managing interaction between the per-navigation/per-tab objects (i.e., the throttles and throttle manager) and the now-componentized per-profile objects (e.g., content settings). All of this management is relevant for WebLayer as well. While I it would be possible to pull all of this code directly into the ThrottleManager, it lies outside the current core responsibilities of ThrottleManager and risks making that class too fat. This CL introduces a new ProfileInteractionManager class that lives next to the ThrottleManager. All of the places within the component that currently call into the client will call into the profile interaction manager class instead (with the exception of the very few methods that are actually on the client, e.g. actually showing the infobar). As a start, this CL moves the implementation of OnReloadRequested() into ProfileInteractionManager. With respect to unittesting of the new class, my suspicion is that most of the //chrome-level unittests are effectively going to end up being tests of ProfileInteractionManager and will be suitable for componentization as such once the dust has settled. During the process, test coverage will remain via those //chrome-level unittests as well as //chrome's browsertests. Bug: 1116095 Change-Id: Id64ca19cd1844cdc76b959679f5ad6ca0808f2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575077 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#835649}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ed854f3f20b..3c18d56820d2 2020-12-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80526e148e125901fa1ad858cc0071427ac71b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584282Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22f80a60b17f..2e9a03ec1170 2020-12-10 mtklein@google.com Revert "Cache text blobs computed by TextLine::paintText" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I6e23c295a3d036a5f525c9da288babf614c05430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584285Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607579988-31aafc9e6ecd14c47d53bc6af437bfedef1daa8a.profdata to chrome-linux-master-1607601127-f1e339917d2389833bdc9a06d67f5d834b6fad5c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibdced3043409c336dcb2451fe8a8772728193941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584284Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607547301-1c0b0723d82aa4adb619c24bc9fd155c854d2040.profdata to chrome-win32-master-1607568819-6e8c2579a56bcfb40b7d05eda1af5c54e41c853a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If3b9748756e8aeb06904098fed451ea09ee6344c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583866Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607579988-85272d8bbf93007898b77e84b51d31a40000a6a1.profdata to chrome-mac-master-1607601127-39be490f57372d47d2538fb844f282b5fe546632.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib240a5cad0a4b753fffd449d56c11ba4af8f79b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584184Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1243857485fc..2bfd1bbc8538 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: Ied206b90c2191bb3123716cf24a8ad35b1bf6055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584182Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835643}
-
Matt Menke authored
NetworkIsolationKeys include top frame origin and frame origin. The WPT SXG reporting tests load an SXG in a cross-site iframe, but learn reporting information in the top-level browsing context, so it had a different NIK. This CL fixes those tests to learn reporting information in an iframe, so they have the same NetworkIsolationKey as the signed exchange. With this CL, all SXG WPT tests should now pass with reporting data partitioned by NetworkIsolationKey. Bug: 1156951 Change-Id: I0f8aa3bc51a276a71c28e92a056e709721bffb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580587 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835642}
-
Alexander Hendrich authored
With our new handling of the pref that handles the force-installed login screen extensions (https://crrev.com/c/2561847), the LoginScreenStorageCleaner will be created before the policy is mapped to its pref. This causes the LoginScreenStorageCleaner to incorrectly clear all login screen storage entries since it believes that no extensions are installed. Simple fix is to remove the call to ClearPersistentDataForUninstalledExtensions() in its constructor and only apply this logic when the policy was applied. Bug: 1157435 Change-Id: Ie8203204c3706e3ffb4b3c0816e2c31e0f9a3036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584023Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#835641}
-
Ian Kilpatrick authored
Many sites use negative block-end margins to "pull" in the end padding. (This is likely because FF doesn't support this end padding, and "working" around this fact"). For webcompat this change allows negative margins for determining the inflow bounds, but only in the scrollable direction. While manual testing I found also that the simplified layout pass had a issue of not calling AddChild correctly with all the necessary information. Bug: 1157299 Change-Id: I90f24301a7015915b0cd0a4446940ee562876dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582625Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#835640}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 816e65bb. With Chromium commits locally applied on WPT: 01ceb784 "Fix a crash PaintWorkletImageProvider::GetPaintRecordResult" 2becd034 "[AspectRatio] Don't stretch grid items if they have an aspect ratio" e3aa6108 "CSP: Fix asserted violatedDirective in WPT CSP report" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ie9ba04104e0e3e798e164078a31e817b225bfeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583982Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835639}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81356f4bf38c..0443332fe2b9 2020-12-10 fmayer@google.com Document deobfuscation of heapprofd profiles. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I15f432ad0c6bae6eea6b8088d7591524085df056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584183Reviewed-by:
-
Anastasiia N authored
`AccountManagerUI` is used by `AccountManagerFacadeAsh` to show system UI (system dialogs, OS Settings etc.). `AccountManagerFacadeAsh` cannot show system dialogs directly because it is inside chromeos/components/ and can not depend on chrome/browser/. `InlineLoginDialogChromeOS::Show` methods will be private, so no one can call them directly. These methods will be called only by `AccountManagerUIImpl`. Also, `InlineLoginDialogChromeOS` will not send UMA stats anymore (they will be sent by `AccountManagerFacade` instead). Bug: 1140469 Change-Id: I5f204d2dfcae7e8c920af672f1d4d7109ae1c5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550741 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
-
Robert Sesek authored
Goma RBE only supports paths that are relative to the build directory, and the system Xcode typically resides outside of that, so all compilation requests fail. The solution is to put a symbolic link to the SDK in the build directory and reference that instead. In addition, any files in the SDK referenced as inputs to a GN action need to be listed as an output of some other GN action, as they are now considered to be build outputs by way of the symlink in the build directory. This creates a new //build/config/mac:sdk_inputs target for those actions to depend on, which lists those files as outputs via a dummy build rule. Bug: 1157103 Change-Id: I5f7a1926fc2714c10a8786e100371d3eb9888a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582409Reviewed-by:
-
Norge Vizcay authored
* Introduces new function insertPasswordEntryForTesting on PasswordManagerHandler that allows storing credentials into the password store for testing purposes. Bug: 1155675 Change-Id: I3cc8bd09d01b810da1ee95ed9fac93f4df63e407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574857Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Norge Vizcay <vizcay@google.com> Cr-Commit-Position: refs/heads/master@{#835635}
-
Moritz Firsching authored
Currently, when loading half scans of certain type of progressive jpegs, the last scan is not displayed correctly. We provide a fix and a test. Bug: 1156120 Change-Id: If6ab87bda49fddf28bdf2062fc155ac85f9290c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577498 Commit-Queue: Moritz Firsching <firsching@google.com> Reviewed-by:
Leon Scroggins <scroggo@google.com> Auto-Submit: Moritz Firsching <firsching@google.com> Cr-Commit-Position: refs/heads/master@{#835634}
-
Hiroki Nakagawa authored
Before this CL, there were 2 bugs in the Early Hints UMAs: (1) Calculation order of the time duration is wrongly reversed. (2) The current implementation assumes that `LoadTimingInfo::receive_headers_start` doesn't take informational responses (1xx) into account, but actually it does [1, 2] based on the Resource Timing spec (See the note on [3]). Therefore, `early_hints_for_final_request_time` is always equal to `final_response_start`. This means the duration between them is meaningless. For the issue (1), this CL corrects the calculation order (see changes in uma_page_load_metrics_observer.cc). For the issue (2), this CL introduces `LoadTimingInfo::receive_non_informational_headers_start`. This is similar to `receive_headers_start` but it captures the time only when the response is non-informational. This is propagated up to NavigationHandleTiming and used for calculating the duration instead of `receive_headers_start`. Other notes: - This changes HTTP/1.1 and HTTP/2 but doesn't change HTTP/3. This is because HTTP/3 doesn't support LoadTimingInfo yet. See also https://crbug.com/1096414. - UKMs for the Early Hints use a different calculation logic, so they don't have these issues. However, to measure the effectiveness of the Early Hints precisely, we have to record the new timing for non-informational responses in UKM as well. See the TODO comment in uma_page_load_metrics_observer.cc for details. [1] https://source.chromium.org/chromium/chromium/src/+/master:net/http/http_stream_parser.cc;l=876;drc=1066e389d45dd39f22f2daf582fc56948d5cc480 [2] https://source.chromium.org/chromium/chromium/src/+/master:net/spdy/spdy_stream.cc;l=415;drc=1066e389d45dd39f22f2daf582fc56948d5cc480 [3] https://w3c.github.io/resource-timing/#dom-performanceresourcetiming-responsestart Bug: 1093693 Change-Id: Id2f696669804c2763de4c21fe40689e3af05bd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521563Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
-
