- 07 Oct, 2019 40 commits
-
-
David Van Cleve authored
This patchset contains two changes to the referrer policy browsertests: 1. Refactor the "reduced referrer granularity flag" tests to use a parameterized test---this will allow easy expansion to test additional capping logic, e.g. the "no referrers at all" flag, which is currently missing test coverage. (This will be remedied by a follow-on CL.) 2. Add tests for subresource requests (by registering a test server callback to inspect the `Referer` headers sent along with the requests). R=jochen Bug: 1004486 Change-Id: I9bc13fe536f04829e69ba0443c6d724ffb113750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842005 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703444}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/99a209624835..7c06777ab088 git log 99a209624835..7c06777ab088 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 danilchap@webrtc.org Cleanup includes in modules/include/module_common_types.h 2019-10-07 saza@webrtc.org Delete voice_detection() pointer to submodule 2019-10-07 terelius@webrtc.org Add 100 ms network delay to the SupportsFlexFEC* tests. 2019-10-07 srte@webrtc.org Removes rtp_transport checks in AudioSendStream Created with: gclient setdep -r src/third_party/webrtc@7c06777ab088 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I1d9aa7d1a7c70eb1b7c32bb16ccd96571058ac80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845939Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703443}
-
Sigurdur Asgeirsson authored
This moves the performance manager and the graph implementation as well as the public API to a new component. Bug: 953031 Change-Id: Ie96011bbe615e31f183da8aae24a20b6e9c79228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829911 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#703442}
-
Aaron Colwell authored
This change moves some of the commit checks from RenderFrameHostImpl into ChildProcessSecurityPolicyImpl so that it will be easier to implement opaque origin checks in a follow-up CL. There should be no behavior changes introduce by this CL. Bug: 991607 Change-Id: Icda9b08ba5e08e153d028d64309f35da8ab68dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836596Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#703441}
-
dpapad authored
Bug: None Change-Id: Icb9652eca5eb06eb568a420758c12d601d83ed11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846031 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#703440}
-
Dave Tapuska authored
RevocableInterfacePtr is going away. Just use a mojo::Remote instead. BUG=978694 Change-Id: I61e9d334150822271ddc1e401e2c13c488482a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841236Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#703439}
-
Paul Lewis authored
Bug: 1011638 Change-Id: I4930f3a0b5fd3de08bcfd52f6f68777bdb28ed80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845224Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#703438}
-
Lukasz Anforowicz authored
The CL makes sure that FrameNavigationEntry::initiator_origin is persisted and restored by session restore. This means that the correct Sec-Fetch-Site is replayed after session restore (this was broken before this CL and is now checked by a new browser test). Bug: 976055 Change-Id: Ia655deb7b799e39e6ec240be914a65f9b6938e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679162 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Vladimir Levin authored
In the latest iteration of display locking, we use content-size and rely on size containment instead of DisplayLockInducesSizeContainment. This patch removes the unneeded code paths. R=chrishtr@chromium.org, ikilpatrick@chromium.org, cbiesinger@chromium.org Bug: 1011398 Change-Id: I8be4d32c82755b0033b4b6bf65cf2107d7d3b89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844060 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703436}
-
Oriol Brufau authored
Bug: 687946 Change-Id: Ia198f20b0640a2d4ee5fe0be6448be5fcc492683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844999Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#703435}
-
Peter Boström authored
Removes manual highlight-path setting for bookmarks_bar_view.cc and custom_tab_bar_view.cc. Bug: chromium:1007546 Change-Id: I6023231a9f8ae9871b00e673dda4647d11328240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842499Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#703434}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/036463457e5f..ae022faf53b9 git log 036463457e5f..ae022faf53b9 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 amaiorano@google.com Add support for configurable subpixel precision 2019-10-07 amaiorano@google.com Use correct values for sampleStandardLocations Created with: gclient setdep -r src/third_party/swiftshader@ae022faf53b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141676114,chromium:b/141380498 Change-Id: I97a8df103c68300a32606b4c347083244664454a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845654Reviewed-by:
-
Kyle Milka authored
Not launching. Bug: None Change-Id: I438edc1ba630f0b629e101c9d963981ac32cbcf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758829Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#703432}
-
David Dorwin authored
Change-Id: I8373457c77dfa0ebacb02e8aeaa8de8b2a328eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841670Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703431}
-
Hiroshige Hayashizaki authored
This CL avoids calling layered_api::ResolveFetchingURL() when built-in modules are disabled, to make the layered_api method only called with built-in modules enabled (and keep a DCHECK() for this). This CL also introduces a constructor for the empty ImportMap to avoid further adding extra parameters to ImportMap ctor call sites. Bug: 1010751 Change-Id: I12d124494b40a9f34c2a88d1e9a5a55198c92c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839429 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#703430}
-
Kurt Catti-Schmidt authored
Reverse the additions of IA2 localized_extended_roles for nodes without explicit aria-roledescription A number of changes to add UIA LocalizedRoleDescriptions (and fix other AAM mappings) for various elements, starting with https://chromium-review.googlesource.com/c/chromium/src/+/1713867, also opportunistically added matching IA2 localized_role_descriptions. This turns out to regress JAWS announcements for some element types, as JAWS does not expect these role descriptions to be present on nodes without an explicit aria-roledescription. The safest course here is to rewire things such that the new IA2 localized_role_descriptions are removed, while all the UIA changes are kept in place. Bug: 1005231 Change-Id: Ia268b2aae563b313590e10f1058b8f0454f168e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829768 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703429}
-
zhaoyangli authored
Extract constant files to a separate target from infobars_ui target. So that EG2 tests can include only the constants target to access the constants, without pulling app related targets. Bug: 917114, 987646 Change-Id: Ic79579d955e84f8c6ae0b6c524280f0b6893bd01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842613Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#703428}
-
Tommy Li authored
LocalHistoryZeroSuggestProviderTest uses a FakeAutocompleteProviderClient, but that class requires a very particular creation an destruction sequence. This CL fixes this problem, which was causing issues on ASAN bots. In the future we should fix the FakeAutocompleteProviderClient API to make it more obvious that it has special creation destruction requirements. Bug: 1010691 Change-Id: Ia5b11b548720fade377e1f9c573105213e71f975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845991 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703427}
-
Owen Min authored
Change machine_level_user_cloud_policy_register_helper.h|cc to chrome_browser_cloud_management_helper.h|cc. Change MachineLevelUserCloudPolicyRegistrar to ChromeBrowserCloudManagementRegistrar. Also change its memeber variable or function from *Policy* to *CloudManagement*. Bug: 1010704 Change-Id: I7852de8d53ea0ff2b508e8f2f0b9ef762ce79c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838332Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703426}
-
shrekshao authored
This is a temporary patch that is not well refactored but seems to make the following case work properly: * Init webgl context with low-power gpu, switch tab to one using high-power, and switch back. It renders correctly now before the os switch back to low-power. This patch doesn't work with: * Same tab switching case where user allocated multisampled buffer under a webgl 2 context * Same tab switching case with preseverDrawingbuffer: true. We'd better land this patch after the gpu pixel test is landed. Bug: 681341 Change-Id: I9c834d11ee0456545600819f2322dceb38f8a59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812102Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#703425}
-
Sebastien Marchand authored
Bug: 1008864 Change-Id: I992c7e31e4d31c0e815af6ec64812e7a76c2f1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832721 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#703424}
-
Jessica Tallon authored
There were some situations where list box options were not being deselected when the selection moved to a different option. This had the affect of screen readers getting the information which wasn't correct. This fixes that by marking the listbox as dirty to ensure the list box options remain in sync when the selection changes. Bug: 980368 Change-Id: Icff41b23218ce2db7ac5437be642371894a92b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821902Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#703423}
-
Huanzhong Huang authored
Screenshots: * before: screen/GHotFhVJu1t * after: screen/aV7D35oyJnx, screen/fszSEX5BcAV R=huanzhong@chromium.org Bug: 967668 Change-Id: Id766f0c655cb2dbf31c148fe0fd212370e5e787e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841743Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#703422}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4102985e1427..107c97c8377d git log 4102985e1427..107c97c8377d --date=short --no-merges --format='%ad %ae %s' 2019-10-07 raphael.kubo.da.costa@intel.com gclient_utils: Stop using execfile() Created with: gclient setdep -r src/third_party/depot_tools@107c97c8377d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I2d9b3e49f2161991f0daf1951f558e6bd6db220c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845653Reviewed-by:
-
Sergey Poromov authored
SCHEMA_ALLOW_INVALID_TOPLEVEL and SCHEMA_ALLOW_INVALID_TOPLEVEL_AND_ALLOW_UNKNOWN are not used. SCHEMA_ALLOW_UNKNOWN_TOPLEVEL is only used in Chromoting where it's a no-op to change it to SCHEMA_ALLOW_UNKNOWN as all Chromoting policies RemoteAccess* are either boolean or string policies. So, it's safe to delete these 3 strategies. The next step is to remove SCHEMA_STRICT. Bug: 969706 Change-Id: I9cc2f4e80840724afcd150d3cc0940a7160a6587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836194Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#703420}
-
Ce Chen authored
AsOmniboxEventProviderType. This is to fix crash in http://crbug/1011730. Bug: 1011730 Bug: 925072 Change-Id: I1cd11156505ce501fac45527b5c59af74e8b96cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844056 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#703419}
-
Peter Kasting authored
Bug: 82078 Change-Id: I43764c6f3b0682b16dc3822ff3ef7b0daa473579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844053 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Lorne Mitchell authored
DevTools: Modified Security.securityStateChanged to use types and data instead of pre-processed English strings This change modifies the shape of the Security.securityStateChanged (https://chromedevtools.github.io/devtools-protocol/tot/Security#event-securityStateChanged) CDP event to include the type of state that has changed along with the data needed to generate the details that are shown in the Security tool. The strings that are currently present in security_state_strings.grdp will be moved to the DevTools frontend. security_state_strings.grdp will remain in place, so that we don't break backwards compat with Security.securityStateChanged. This will come in a separate CL. Bug: 946860 Change-Id: I18a2ff879bf201d36cf02af88963dcb996c4811f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646792 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#703417}
-
Elly Fong-Jones authored
As far as I can tell this class has never had a user in chromium. This change also removes the ImageViewBase abstraction layer, which was added to support AnimatedImageView. Bug: None Change-Id: I9af55bfb0ef1b7a07a2d5a1db234b5e998a66c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842037Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#703416}
-
Andrew Grieve authored
Bug: 982762 Change-Id: Ia67f95207bc5c9f107ee1f42a4d151e25792178e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837198 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#703415}
-
Mostyn Bramley-Moore authored
https://chromium-review.googlesource.com/c/1423625 removed the third_party/closure_compiler/build directory, but left a reference to it in DEPS. Let's remove that too. Change-Id: I6a41677b8930025add9167c6c897060dbc14b1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844957Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#703414}
-
Patrick Monette authored
ServiceWorkerContextWrapper's observer methods are supposed to always be dispatched on the UI thread. This CL ensures this is true with additional DCHECKs and adds the DeleteOnUIThread custom deleter because observers are also notified in the destructor. Bug: 993029 Change-Id: I10c7baa6a908e61ea50a00486d0e3bae81e7e32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841765Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#703413}
-
Lukasz Anforowicz authored
user_gesture ============ NavigateParams::user_gesture field was manually copied from OpenURLParams::user_gesture field right after calling FillNavigateParamsFromOpenURLParams in 3 places: //chrome/browser/android/tab_web_contents_delegate_android.cc: TabWebContentsDelegateAndroid::OpenURLFromTab //chrome/browser/chrome_content_browser_client.cc: ChromeContentBrowserClient::OpenURL //chrome/browser/ui/browser.cc: Browser::OpenURLFromTab This CL moves the nav_params.user_gesture = params.user_gesture assignment into NavigateParams::FillNavigateParamsFromOpenURLParams This part has no intended behavior change and should be non-controversial. blob_url_loader_factory and href_translate ========================================== blob_url_loader_factory and href_translate were propagated from OpenURLParams into NavigateParams in //chrome/browser/ui/browser.cc (Browser::OpenURLFromTab), but not in the other 2 places. This CL moves the nav_params.blob_url_loader_factory = params.blob_url_loader_factory; nav_params.href_translate = params.href_translate; assignments into NavigateParams::FillNavigateParamsFromOpenURLParams This part changes the behavior of - //chrome/browser/android/tab_web_contents_delegate_android.cc: TabWebContentsDelegateAndroid::OpenURLFromTab - //chrome/browser/chrome_content_browser_client.cc: ChromeContentBrowserClient::OpenURL so that they propagate as much information from OpenURLParams as necessary (consistently with other callers of FillNavigateParamsFromOpenURLParams). Bug: 1007041 Change-Id: I042afe0b71e825a44c015c792514c820823258f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838976Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#703412}
-
Chandani Shrestha authored
This change makes Copy color in colorPicker keyboard accessible. Earlier, this was working only with mouseclick. This was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1686452 which has been broken down as below Make copy color in color picker keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817416 Make copy color in color picker screen-reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1818297 Gif showing color picker with this change https://imgur.com/9YxCQpc Bug: 963183 Change-Id: I03e1e1481ba74e816d86c100783d732329dc4e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817416Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703411}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f4389a6ddae5..603e7a0e5a97 git log f4389a6ddae5..603e7a0e5a97 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 nuskos@google.com Ensure that we generate a ChromeConfig that sets record_mode. Created with: gclient setdep -r src/third_party/perfetto@603e7a0e5a97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I500723777937607f055b64d1ce98e61f539f8d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845772Reviewed-by:
-
Chandani Shrestha authored
This change adds h1 because page must contain level one heading to make it accessible. More info https://dequeuniversity.com/rules/axe/3.0/page-has-heading-one This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1648916 which has been split into small changes. Bug: 963183 Change-Id: I107b87ed3bc4e182daba7c85f8af12bf68b84311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817415Reviewed-by:
-
Yves Arrouye authored
Bug: N/A Test: N/A Change-Id: Icf7a53ecf5e22a356478fb5cb754e38b0bfd5ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845851Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#703408}
-
Wei Li authored
There are cases that HaTS javascript library may not be loaded successfully, for example, when the browser is offline. In this case, we monitor the resource load complete call to make sure HaTS library is loaded. Otherwise, we don't proceed with showing the survey. BUG=1006674 Change-Id: Ibcd725728978ce96fbbe263fb0c5d5c894d1ced9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826291Reviewed-by:
-
Brian Cui authored
This PR fixes an issue with placeholder text in input fields showing as black against black when the dark theme is enabled, making them impossible to read. The fix simply assigns the ::placeholder CSS pseudo-element to all input fields so the placeholder text is always a shade of gray, compatible with both themes. The color value `rgba(0, 0, 0, 0.54)` was copied from the stylesSidebarPane rule that specified ::placeholder color (and hence, the sidebar was not affected by this bug). Before: https://i.imgur.com/iwiKvrU.png After: https://i.imgur.com/labeZzz.png The light theme appearance is unchanged. Before (Light): https://i.imgur.com/x8sXkWU.png After (Light): https://i.imgur.com/qp3zzzc.png Bug: 1011477 Change-Id: Ia418ce346defb134a7a4db57b83bc666f7f49056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841665 Auto-Submit: Brian Cui <brcui@microsoft.com> Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: Ibf7270ca6aa083864de74ddd8ca0e89731b006d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842957 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#703405}
-
