- 09 Oct, 2019 23 commits
-
-
meacer authored
Bug: 1009517 Change-Id: Ibc835b30a8e8f13dcbee1d07ea1dae17597b8f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846085Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703994}
-
Khushal authored
Using a color profile not supported by the platform results in fatal errors with SurfaceControl in the GPU process. The only case where we skip the platform check is if the color profile was forces through a command line flag. Ensure the check is done here as well to avoid noise from resulting crashes. R=boliu@chromium.org, oshima@chromium.org Bug: 997592 Change-Id: Ie442cb3eb594725ab71ecd4d10f8b161722d034e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847678 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#703993}
-
Irina Yatsenko authored
depends on https://chromium-review.googlesource.com/c/v8/v8/+/1838927 Bug: chromium:1010312 Change-Id: I400537daf428e46180f15444d92a3dedab6aca3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838265Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703992}
-
Samuel Huang authored
This CL adds options to pak_util.py {extract, list-id, print} so that the .pak.info for the given .pak is used to translate ID to textual ID, which is then used. Details: * data_pack.py: Add GrdInfoItem type and ReadGrdInfo(). * extract command: Add --textual-id/-t to use textual IDs as filenames for extracted resources. * list-id command: Add --textual-id/-t to print textual IDs, and --path/-p to print resource paths, formatted as: ID[ = textual-ID][ @ path] * print command: Add --textual-id/-t to print textual IDs instead of IDs. Change-Id: I2086efc69867e56c8312aaec9545113e9a869266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846728 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#703991}
-
Justin Cohen authored
Likely introduced in crrev.com/c/1002893, it is possible for a pending item to never commit (see steps to leak a WKNavigation in crbug.com/1010765). Normally this is a no-op, but if that pending item was copied into empty_window_open_item_ this can lead to a broken omnibox. Instead, simply clear the empty_window_open_item_ for all commits. Bug: 1010765 Change-Id: I24c8a3bc0d71ad3d96510a3fde8ed8c3941cf601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841618Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703990}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8fcfd612..b45c693f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0cfaa4a158331251da1324e079bdc4e1966fcb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847747Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703989}
-
Ted Meyer authored
If the experiment to disable chrome://media-internals is enabled, then we need to tell users what is up, and how to access the new version. Of course this is dependent on the new UI getting checked in. Bug: 794255 Change-Id: I84f71e6034c53be97a943d4c3cbc3dc2c0a9aca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767423 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#703988}
-
Daniel Murphy authored
These metrics are important for keeping track of leveldb error and corruption rates in the wild. R=mpearson@chromium.org Bug: 975513 Change-Id: Id88086bed09834c6a94a551f1174934230086e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846466 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#703987}
-
Fergal Daly authored
This makes the code in each test more linear and comprehensible. This also allows moving the call to stopWaiting into test-running code rather than in each test. Also clean up the code to reset the scroll position so that it is in the test-running code. Change-Id: I1874a56217bab3bbea4194cf67fc04af57dd839b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846626 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#703986}
-
Justin Cohen authored
Add test for restoring a placeholder URL. Because WebTestWithWebState uses a placeholder to hack LoadHtml into working with SlimNav, an extra ErrorRetryStateMachine state was needed to ignore this hack. Bug: 1010264, 1011758 Change-Id: Iab10f4bc2160307352de3ff33f2d80df281aedad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819301 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
John Budorick authored
This also updates the generic_android23 and generic_android28 images with locally-built versions w/ these changes & the correct names. I'll update them again to bot-packaged versions after this lands & android-avd-packager runs. Bug: 922145 Change-Id: I9630cde9550b59d0f1db1969454f7fc528546808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839436Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703984}
-
Patrick Monette authored
The ServiceWorkerContextWrapper now keeps the list of running workers so that it can be accessed synchronously on the UI thread by the ServiceWorkerTaskProvider via GetRunningServiceWorkerInfos(). In addition, the OnVersionStartedRunning() function now provides a ServiceWorkerRunningInfo instance so that it nicely integrates with GetRunningServiceWorkerInfos(). Change-Id: Iba0a8d81bf39846abecb7d7d81241d5f180cc246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842552 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#703983}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b7a7f1c05edb..cef11fda71f6 git log b7a7f1c05edb..cef11fda71f6 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@cef11fda71f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I8a705806ea3bd3a5c4c5309208b77a08f00b5ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703982}
-
Nick Harper authored
This error was between CERT_BEGIN and CERT_END. Errors in that range have special meaning (which does not apply to this one), so it is now in the -300s with the rest of the QUIC errors. Change-Id: Iaba8443cf74df3b9b1896938c1107f9c7bcb3841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848054 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#703981}
-
Andrew Xu authored
The current design does not leave space to show the ripple ring of the first/last app icon completely. This CL fixes such an issue by two ways: (1) Adding 2-pixel padding between the shelf container and the first app icon. It helps to show the first icon's ripple correctly. (2) Increases the scrolling upper bound by two pixels to show the last icon's ripple correctly. Bug: 1009368 Change-Id: I28210492f97f9c0ed33cdcaadced16bd00cfa72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842495Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703980}
-
Christy Chen authored
In the Console sidebar, the message titles are using concatenation depending on the number of the messages. This would cause the issue where the strings can not be properly translated since concatenation assumes word order, which can vary depending on the language, and the white spaces between words might not be needed in other languages. https://imgur.com/a/nC1Dbmt This change creates string maps for different cases (No message, 1 message, or more than one messages) to avoid concatenations. Grdp changes are generated automatically, with manually written descriptions Bug: 941561 Change-Id: Iad1803c3d3fadd76e9af3f7407a609e17cd708ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819648 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703979}
-
Lei Zhang authored
This scoper takes care of calling PrintRenderFrameHelper::IPCReceived() and IPCProcessed() in its ctor and dtor, respectively. This makes it easier to correctly balance the calls. To make the scoper even better, give it a base::WeakPtr for PrintRenderFrameHelper instead of a raw pointer. Then the scoper can avoid accidentally calling IPCProcessed() if PrintRenderFrameHelper has already been destroyed. Change-Id: I81172fe2c9510bad2cbc3d0bfb3efe6fd530a9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842555 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#703978}
-
Xiaohui Chen authored
Bug: 965415 Test: locally build and run Change-Id: I1748ab77bdb6b232225540a6e26ab8e3a439959c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847938Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#703977}
-
Trevor Perrier authored
Adding a 'Learn more' link to the Data Reduction FRE made <link> tags appear in the second run promo dialog. This change makes the 'Learn more' link clickable on the second run promo. Bug: 1010822 Change-Id: I82847539e30b419e59d0dcf44ec60c172182346a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845495Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#703976}
-
inglorion authored
crrev.com/c/1846084 temporarily added -Wno-error=bool-operation to prevent builds from failing on a newly introduced Clang warning. The code that triggered the warning has now been fixed, so we can stop suppressing the error. Bug: 1011810 Change-Id: I3d3818ae4805642e96bdcc19cff83a7ef5cf397f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845484Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#703975}
-
Avery Musbach authored
Test: manual Bug: 1012509 Change-Id: Ifd210885de279c26837f7b774ee0565b8d6d1237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848121Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#703974}
-
Adithya Srinivasan authored
To implement this, we reattach the DevToolsUIBindings for the current DevToolsWindow to the RenderFrameDevToolsAgentHost for the activated WebContents and reset the main connection in the frontend to reconnect with and enable the new agents. Bug: 992887 Change-Id: I0ca4e6cc7a6c633680bfd03d574a4030ab65d7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788122Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#703973}
-
Alexander Timin authored
Do not reset state associated with the page (e.g. offline_info_) in DidStartNavigation because the navigation can still be cancelled and we can stay at the same page. Note that provisional_offline_info_ still should be reset as it's associated with the navigation itself. R=carlosk@chromium.org CC=bfcache-bugs@chromium.org Change-Id: Ife590dc3a7f543d5b01bbcc28b3224ed4e7e1000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844828Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703972}
-
- 08 Oct, 2019 17 commits
-
-
Nate Fischer authored
This reverts commit e0b95885. Reason for revert: this broke downstream WebView compile (https://crbug.com/1012531) Original change's description: > Remove default startAllowlistLookup interface > > Bug: 995926 > Change-Id: I76ac44526fcf7241b800899810db81dbdd598ae3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846092 > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703911} TBR=vakh@chromium.org,xinghuilu@chromium.org Change-Id: I282a1a33cd92a79930d1b35e3fa42022472fa171 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995926, 1012531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848349Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703971}
-
John Budorick authored
This reverts commit 850e8d2b. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/5470 Original change's description: > Add withTextString, withDescString locators, and some refactorings. > > Refactorings include replacing *ByIndex with withIndex wrapper, renamed > locators that take variable number of resource ids to have "Any" in the name, removed > unnecessary params in the Page Controller tests build target. > > Bug: 924194 > Change-Id: I0a2b01c4d1d7ca52243988c8f028553135843441 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846480 > Commit-Queue: Andrew Luo <aluo@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703953} TBR=skym@chromium.org,jbudorick@chromium.org,aluo@chromium.org,wuwang@google.com Change-Id: Ib1a7b7ec8bb2ecce0e857a900218054266c41336 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848399Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703970}
-
yjliu authored
When screen width is below a certain threshold (600dpi), DesksBarView would switch to a compact small screens layout where DesksMiniViews and NewDeskButton will have smaller sizes and will not show labels. Bug:988525 TEST: Manually, Added a new test. Change-Id: I62f15f1016d8e26b4242499c097e521f4b7705eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834902Reviewed-by:
-
Meredith Lane authored
Intent to Deprecate: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer&pli=1#!msg/blink-dev/LS5I962Wlnk/ltR47OnICwAJ BUG=https://crbug.com/287607 Change-Id: Ieb42187d9794f8b607b27814e8757deb0e204076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833344 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#703968}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8a97436f7afd..139e88015cb5 git log 8a97436f7afd..139e88015cb5 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-08 jlavrova@google.com Bug fix (strut must be false by default) 2019-10-08 robertphillips@google.com Add GrProgramInfo to centralize management of program information 2019-10-08 jcgregorio@google.com Another attempt to fix vpython in Cloud Build. 2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 5c593bf702db..a52db47aa53f (1 commits) 2019-10-08 egdaniel@google.com Add bytes per pixel to metal format table. 2019-10-08 herb@google.com Use SkZip in SkGlyphRun 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 684790252fe2..5c593bf702db (1 commits) Created with: gclient setdep -r src/third_party/skia@139e88015cb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:993053,chromium:None,chromium:None Change-Id: Id8f7df288ee4752b6c2ef1b57f49db728b32b281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848472Reviewed-by:
-
Nektarios Paisios authored
This reverts commit 763fd8b4. Reason for revert: Broke VoiceOver navigation by heading, link, etc. when the object in question is scroll off the screen. Original change's description: > Default navigation in VoiceOver includes only visible elements > > Navigation with the VO cursor should not visit hidden elements. > This had regressed because we started including hidden elements > in the accessible object hierarchy on purpose, so that when > a page accidentally overused aria-hidden, that users would > still hear something useful when tabbing to focusable items. > With this CL, users will not generally be able to accidentally > navigate to aria-hidden items, but if they manage to actually > focus one with the keyboard, it will still announce what it is. > > Bug: 982408 > Change-Id: I19d5fe4947e5fb1c7493f0e67d7fe8e13d9a255e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761717 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689677} TBR=aboxhall@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982408 Change-Id: I3242ac4dc633d557a8ddc1d4125fbdfdd7990720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846180Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#703966}
-
Steven Bennetts authored
Bug: 853953 Change-Id: I58dc5bd2b62e8c5befe5a47bc02db7fc24473192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834404 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#703965}
-
Hiroshige Hayashizaki authored
When built-in module support is disabled, we reject non-string values according to the Step 2.3 of https://wicg.github.io/import-maps/#sort-and-normalize-a-specifier-map "If value is not a string, then ..." Bug: 1010751 Change-Id: I6f82e22b57a72ee8ea5ca388e213f5c9a1188171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841812 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#703964}
-
Scott Violet authored
LayoutBox::SizesLogicalWidthToFitContent() has special logic that returns true for -webkit-box. This makes it return true if flex-box is used for -webkit-box BUG=1010809 TEST=wpt/compat/webkit-box-vertically-centered.html Change-Id: Ibf6045234c0513e2c5d6cb686ecc0a1001b47fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845506Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#703963}
-
Khushal authored
This reverts commit 1ba39268. Reason for revert: Change was temporary to aid debugging. Original change's description: > viz: Add temp CHECKs for debugging. > > R=kylechar@chromium.org > > Bug: 992626 > Change-Id: If13d2f4c9660c49db82e586929b2686b54f3760a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797128 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Auto-Submit: Khushal <khushalsagar@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695430} TBR=khushalsagar@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 992626 Change-Id: I6388a12e22a85c8b24dacf9bb992eeeb933da101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848359Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#703962}
-
Tomasz Wiszkowski authored
This is the smallest possible change that makes it possible to re-use RCIV component with Suggestions. Bug: 1001209 Change-Id: Idce813441f9757e4084e0a44ca706fda1c701ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847898Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#703961}
-
Yuwei Huang authored
Dialog notifications now support "Don't show again" checkbox, and it is deemed nontrivial to implement toast with action button on Android, so the usefulness and maintenance difficulty of having the TOAST appearance is questionable. This CL removes the TOAST appearance and the appearance enum altogether. Bug: 1001291 Change-Id: I2fe082a80fd9f84dbda96faa453ef99d732e9dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848412Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#703960}
-
Aran Gilman authored
Specifically, this CL does the following: * Run `git cl format --full` over all files in the directory. * Replace deprecated base::Time::FromInternval() in TimeSoother's unit tests. See https://crbug.com/634507 for more information. * Remove 'default' case from switch statements in NavigationControllerImpl. These switch statements previously verified that a case was implemented for all enum values via runtime-checks. Removing the 'default' case lets the compiler verify this instead. Bug: 634507 Change-Id: I1763da53f0b445c5ccf9a5acee908292d956a8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845873 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#703959}
-
Nate Fischer authored
No change to production logic. This disables a new test which is failing on bots running with Network Service out-of-process. Since this is a very new test, it seems likely this test has always failed. TBR=alexclarke@chromium.org Bug: 1012479 Test: None Change-Id: I42d4892da5822e31a874cbaf82f766c934446da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845485Reviewed-by:
-
Xiaoqian Dai authored
In portrait mode, when dragging a window from top or from bottom, we should only show the bottom or top drag indicator. This CL ensures that the other drag indicator stays invisible when only one drag indicator is supposed to show up. Bug: 987031, 997885 Change-Id: I8644080741e0dfff8ae96c7f3888f55288ec18e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829643 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#703957}
-
Mitsuru Oshima authored
display size. Bug: 141898654 Test: manually confirmed that this produces the same size as android's Change-Id: I139479a615cd4aa0601b06874ad532df20141d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845487Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#703956}
-
Mandy Chen authored
Currently the 'Add pattern' link in the Request blocking tool is not keyboard accessible. Pressing enter or space doesn't open the add pattern box. See the bug for more info. This CL converts the link to a button that's more consistent with rest of the DT (examples: https://imgur.com/a/ZU2Xr0P) and makes it keyboard accessible. GIF of how it works now: https://imgur.com/HjDKRoo Bug: 1006125 Change-Id: Iff77cfeb744c6a0da87ea0182512deb7ba1f4bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817332Reviewed-by:
-
