- 13 Nov, 2019 40 commits
-
-
Simon Que authored
Bug: None Change-Id: Iaf6e3974a884e61b4edb7a8c0d7c2df06385f284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910981 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#715010}
-
Theresa Wellington authored
Move chrome/android/java/.../appmenu/ (excluding a handful of classes) to its chrome/browser/ui/android/appmenu/ and create a separate build target for the app menu. Also splits appmenu classes and resources between public and internal/ BUG=966644 Change-Id: I9d477981827078f2f0be1dc3929234ef3cdef958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903844 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#715009}
-
Vasilii Sukhanov authored
RemoveAllChildViews() deletes all the child views, thus, turning some members holding dangling pointers. The code should NULL them. Bug: 1023941 Change-Id: I642cff0f1a22e0c894fe4a46421a91182d662c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914364Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#715008}
-
James Cook authored
It runs in the browser_tests suite, so it should be named browsertest. Bug: none Change-Id: I795699ff791031218f4e63b1ab63fa6c13987517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913121 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#715007}
-
Matt Menke authored
Wire NetworkIsolationKey through ProxyResolverV8[Tracing]. ProxyResolver itself still doesn't support NetworkIsolationKeys. Bug: 1021661 Change-Id: Id82eee857606c593f924a6d7ac213898aeb64c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904606 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#715006}
-
Rakesh Soma authored
Add missing reauthcredential test as suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1900159 Bug: 990079 Change-Id: Id26862afc1c9977544d3ca72cc23d3df8d23de69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912890 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#715005}
-
Elly Fong-Jones authored
I missed this one incorrect call because it's not compiled when is_asan. Oops! Bug: 973128 Change-Id: I84346287759f13268cb97b1386463d2e363ae5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913873Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715004}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37becd02a08f..3f3aa545f7de git log 37becd02a08f..3f3aa545f7de --date=short --no-merges --format='%ad %ae %s' 2019-11-13 hablich@chromium.org [Docs] Fix email in design guidelines graphic Created with: gclient setdep -r src/third_party/devtools-frontend/src@3f3aa545f7de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: None Change-Id: I6224e4ac0713479cd28441ecb65b5f5eec44ad90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913800Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715003}
-
Nikita Podguzov authored
This will be used in chrome.printing API handler, so we need to get this out of print job manager implementation. Bug: 996785 Change-Id: I0feedff6fdd6cde4da66f5ef61a2fed7fa575b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906153 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#715002}
-
Gayane Petrosyan authored
Bug: 1022548 Change-Id: Ic367da17ca7e194d81f5bdab1291ff09c68e56ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904348Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#715001}
-
Victor Hsieh authored
This information will be used to prevent adbd being started, at least until we have well-defined policies to support managed use cases. TEST=see the value change the on reciver side corresponds to account's management status BUG=chromium:893332 Change-Id: I16bc10691dc1b150efc3803293504d82b9eb35bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907279 Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#715000}
-
Colin Blundell authored
This CL provides an initial implementation of displaying network errors in WebLayer on Android. This implementation is copied from that of WebView. Note that there is no attempt made to share the code as this CL will need to be merged to 79. This CL does not copy WebView's support for suppressing the showing of error pages (AWContentRendererClient::ShouldSuppressErrorPage()). This support is present in WebView for apps that want to display custom error pages, which is not a requirement in WebLayer at this time. To test: put your device into airplane mode and visit a webpage in WebLayer. You should get an error page with the upside-down Android icon. Change-Id: I4e63cb577e433e3a34db126110ada9b91c851e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906349 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714999}
-
Jasper Chapman-Black authored
Since deriving symbol full_name and template_name is too costly to do for all dex and native symbols, we derive lazily and cache. Bug: 1011921 Change-Id: Ic7e530d1fde8202566c7e5872550d7315a3ad772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913079 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#714998}
-
Alex Newcomer authored
This reverts commit 70693f1c. Reason for revert:1024334 Original change's description: > cros: Detect race when going to tablet mode with no windows > > When going to tablet mode ShelfWidget/ShelfConfig > gets updated before the AppListController gets to notify observers > that AppList will be visible. This means ShelfWidget will update > thinking that the AppList is not visible, when it actually is. > > To fix this race, check whether the AppList *should* be visible at > ShelfConfig::is_in_app(). > > > Change-Id: I7d82b6ca5bd8933146dad75c0c1edb3257e41a67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903595 > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714829} TBR=newcomer@chromium.org,manucornet@chromium.org Change-Id: Ica5f605de54f57cd9c51bcdecc9a86889343931b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912898Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714997}
-
Xianzhu Wang authored
The previous method of temporary option for SameSite affected flag-specific expectatations because the temporary option was treated as the flag-specific name. This broke local rebaselines of tests. Move the temporary option into Driver.cmd_line() to prevent it from affecting flag-specific feature. Bug: 961439 Change-Id: I1b2c30feebb42a0a701b2085b63b0fde4ab2ea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914196Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#714996}
-
Maks Orlovich authored
We would sometimes do it to a cached 301, and then get really confused trying to read a body that wasn't there. 200 and 206 responses are the only in-caches ones (wire could also have a 304) which could possibly result in a 206 to our client, so others should just have range handling dropped; we do that already for things gotten on the wire but not from cache. Bug: 1015829 Change-Id: I6ba127aec8e88a7cbf72d7a87b94e5e7f10a3973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899890Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#714995}
-
Liquan (Max) Gu authored
ScrollToExpandPaymentHandler can be enabled with a cmd flag, but not from about://flags. In order to make it possible for users to enable this feature from about://flags, this CL attaches this feature to PaymentsExperimentalFeatures, which is one of about://flags, so that enabling PaymentsExperimentalFeatures from either about://flags, or cmd, will also enable this feature. Bug: 999196 Change-Id: I28dae381fe2e4123db078f7b85addb6616ee24a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913163 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714994}
-
Javier Fernandez authored
After r701601 there is no call to such private function, as the logic has been refactored as part of that change. This CL removes the unused method. Bug: 1003184 Change-Id: Iac1b38c4812d2ee924af208dfe71a409b8dfa636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913248Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#714993}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/99e73fa8c1c5..ae01f620091b git log 99e73fa8c1c5..ae01f620091b --date=short --no-merges --format='%ad %ae %s' 2019-11-13 robertphillips@google.com Revert "Respect the max indexBuffer limits in the bulk texture draw API" 2019-11-13 jvanverth@google.com Put check for MTLTextureUsageShaderRead in available block. 2019-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 0e5f77218153..8d45badce994 (1 commits) 2019-11-13 robertphillips@google.com Respect the max indexBuffer limits in the bulk texture draw API Created with: gclient setdep -r src/third_party/skia@ae01f620091b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:b/143572065,chromium:None,chromium:b/143572065 Change-Id: Ic56228e47250f928a4757dd0cc437e95422e05b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914121Reviewed-by:
-
Dale Curtis authored
They don't work anymore with SkiaRenderer, have poor power characteristics, and haven't shown up in the wild. I.e., sites are only serving HDR content to HDR displays. This also fixes a compilation error with the SMPTEST2084 shader when not using GLSL. BUG=1023671,1015599 Change-Id: I855992d369364beb899dc145c1595d42aef3b5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913613 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#714991}
-
Zentaro Kavanagh authored
Bug: 1024113 Change-Id: I8b3633ac7620bb7deadcface77de0eb1cdf87def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913022 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#714990}
-
Eric Roman authored
Bug: 993499 Change-Id: I0d2f535ca6958d6e77ee9f854f30519a73ba57d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912823 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714989}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e156cb1e..b6857b74 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5a51610a2c086d6e9f1bb811389a1fca82431963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914194Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714988}
-
Piotr Zarycki authored
The feature shipped in M76, is safe to remove the related flags and switches. Bug: 1019233 Change-Id: I9d0379a358a146a4f62a24356bea738c229247ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903132Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714987}
-
Jun Mukai authored
This CL adds getting and setting the mouse state to autotestPrivate API. Although Tast / testing infra should have the feature to cause mouse events through device files, it turns out not quite helpful for the use of UI tests; the new APIs addresses to the situation; obtaining the current mouse status, and causing the mouse events exactly at a location. Bug: 1019000 Test: with Tast Change-Id: Iafacca190e057653565a685794cf3833a2411a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896385Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714986}
-
Bailey Berro authored
autofocus does not make sense for the edit-printer-dialog since the user is not filling out information but rather editing information that already exists Bug: 1015673 Change-Id: I2d4725ad42e4785f38c1ef1a8e559e6871016f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906255Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#714985}
-
Raymond Toy authored
Converting multi_channel_resmpler and sinc_resampler to use RepeatingCallback and BindRepeating. Bug: 1007799 Change-Id: Ic2d20e1d6880b47278b61e62ca5f3764a0feaba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907275Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#714984}
-
jongdeok.kim authored
This CL changes some classes in ui/views/accessibility/ and view_tracker.{h,cc} to use ScopedObserver. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=940796 Change-Id: Iee16691098fae2e3cba4f11a9d970181ca28f659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558558 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#714983}
-
Robert Liao authored
BUG=5027 Change-Id: Ie5c2b37de94b6614a8ed7e55b329da22bd672aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904311 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#714982}
-
Rune Lillesveen authored
When we mark the light tree ancestors child-dirty for style, we could not set a node inside a shadow scope as a style recalc root because slotted nodes could require traversal via the host light tree parent. With FlatTreeStyleRecalc enabled, we can now allow that. This affected performance for the perf_test below because the elements needing recalc where light-tree children of a shadow host high up the light-tree which were slotted deep into the chain of shadow hosts with slots. With the recalc root in the document scope, that made us traverse deep in the flat tree to reach the dirty nodes, while the light-tree traversal would skip the shadow trees and recalc the styles for the dirty nodes as part of the light tree children of the outer shadow host. It's not certain this makes all the perf regression recover, but local testing shows that it definitely improves. TEST=perf_tests/shadow_dom/v1-mutate-shallow-tree-then-re-layout.html Bug: 1023215 Change-Id: Id7143bf0e8fd7c298d6b683be8ead0fd23941f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912711Reviewed-by:
-
Bailey Berro authored
Previously, there were 3 navigation stops for Parental Controls: 1) Title of the row, 2) sub-text, and 3) Set Up button. With this change there are now two stops: 1) Title of the row with sub-text as description, and 2) Set Up button with sub-text as description. Bug: 1012565 Change-Id: I5ebe2afe3d8b43a0ad7e60aeffcc5ea35a28eaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912697Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/359bc80a7ee4..b5407bfb585e git log 359bc80a7ee4..b5407bfb585e --date=short --no-merges --format='%ad %ae %s' 2019-11-13 swiftshader.regress@gmail.com Regres: Update test lists @ 88632cac Created with: gclient setdep -r src/third_party/swiftshader@b5407bfb585e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I0def1413313352681965f9b2ad0247aa7ac2c826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913633Reviewed-by:
-
Matt Menke authored
Make HostResolverMojo take a NetworkIsolationKey. It now both passes the NetworkIsolationKey to the HostResolverMojo::Impl it wraps, and uses the NetworkIsolationKey as part of the key into its local HostCache. Bug: 1021661 Change-Id: Ib9fc433635933c0e0a587c762d4ce6e581bf7317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904487 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Fixes two errors in flag-metadata.json, both instances of: "owners": [ "foo,bar" ] where "owners": [ "foo", "bar" ] was meant. 2) Adds a new unit test, AboutFlagsTest.OwnersLookValid, that detects this mistake and another couple of common syntax mistakes in owner metadata. Bug: None Change-Id: I944efd9c95fcb6a2ccdce2b174b542ddf3e451d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912803 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#714977}
-
Ioana Pandele authored
The overhead of creating a proper ChromePasswordManagerClient instance is too big for unit tests and may lead to unexpected side-effects. Bug: 1007218 Change-Id: I98f02d64a513befa1cf22346ca94847fa7b1f75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912717Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#714976}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4e6d1590f29..57d0093ac901 Created with: gclient setdep -r src-internal@57d0093ac901 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib7e463cb7cb298c3d8037a377590bcc1060a9bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913654Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714975}
-
Azeem Arshad authored
This CL adds aria labels for the 4 custom name server input fields. The fields will be announced as "Custom name server 1", "Custom name server 2" etc. Bug: 1005944 Change-Id: I79eb275d5ad3ca60b1f29ea04c455fd8258d7939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913880Reviewed-by:
-
Jesse Schettler authored
This reverts commit 3af7932b. Reason for revert: ARC++ printing can pass CTS Original change's description: > Revert "arc: Enable print-spooler-experiment feature flag by default" > > This reverts commit c79e6751. > > Reason for revert: Fixing CTS for ToT > > Original change's description: > > arc: Enable print-spooler-experiment feature flag by default > > > > Also, enable the flag for all channels except stable. > > > > Bug: b:130798103 > > Test: android-sh -c getprop | grep ro.boot.arc_print_spooler > > Change-Id: I4ca45c248737bbc0e5c90ed679bfe2b77ec9ed12 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784006 > > Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org> > > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#693860} > > TBR=yusukes@chromium.org,elijahtaylor@chromium.org,jschettler@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: b:130798103 > Change-Id: I400c7050bbf4c82ffba230b1900d14daa309c628 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831273 > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701184} TBR=yusukes@chromium.org,elijahtaylor@chromium.org,jschettler@chromium.org Bug: b:130798103 Change-Id: I378ae1dee61231462f8588bd1303400b47158bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914479Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#714973}
-
Stephen Roe authored
This is a reland of 8db01995 after fixing https://b.corp.google.com/issues/143701391 It adds the parentheses changes from https://chromium-review.googlesource.com/c/chromium/src/+/1893190 Original change's description: > Add third_party/qemu-linux-arm64 to DEPS runhooks. > > qemu-linux-arm64 is from the /fuchsia/qemu/linux-arm64 CIPD package. > > Bug: 1015177 > Change-Id: Ie193d18e4b52059ad853cee07075979b1faea038 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865751 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Stephen Roe <steveroe@google.com> > Cr-Commit-Position: refs/heads/master@{#708478} Bug: 1015177 Change-Id: I27c848336a3466ef2aa2801d29b7b850fd0411d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913570 Auto-Submit: Stephen Roe <steveroe@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 265 266 269 270 271 272 273 275 30 lines were removed and 32 lines were deflaked by consecutive results since 253. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I4c914f77da1efc37c6305d97136d48893b8546d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912399Reviewed-by:
-
