- 07 May, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e8bf706d161d..071fe56ffe73 git log e8bf706d161d..071fe56ffe73 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 enga@chromium.org Support depth32float sampling on D3D12 Created with: gclient setdep -r src/third_party/dawn@071fe56ffe73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I823d2f5cd477ebede3edbf63a038cb8021ac673c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766501}
-
Jesse McKenna authored
Currently, autotest.py doesn't support the forward slash '/' as a path separator on Windows. For example: Succeeds: python3 tools/autotest.py -C out/bug base\at_exit_unittest --gtest_filter=*Exit* Fails: python3 tools/autotest.py -C out/bug base/at_exit_unittest --gtest_filter=*Exit* This is because RecursiveMatchFilename() considers a file a match with the requested filename if the requested filename is a substring of the file's full path. On Windows, file paths as returned by os.scandir() use '\\' as a path separator, so a path using '/' will never match (e.g. 'base/at_exit_unittest' is not a substring of 'C:\\src\\chromium\\src\\base\\at_exit_unittest.cc'). With this change, either type of path separator works on Windows. Change-Id: Ic21eff291d86e7ca994faeda807f6aeaff737562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181744 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#766500}
-
Andrew Xu authored
This CL creates a new attribute - HotseatWidget::is_forced_dense_ to indicate whether app icons should be scaled from the normal size (56 * 56) to the dense size (48 * 48). In detail, this CL does the following things: (1) Change kShelfAppScaling to a ash feature. (2) |is_forced_dense_| should be associated with hotseat widget because app scaling should handle multiple display issues (on one display app scaling may be triggered and on another one it may not). (3) Functions in ShelfConfig, which return the size of app button, the size of app icon and the hotseat size, should accept a boolean value as parameter which indicates whether app scaling is triggered. This CL should not introduce any noticeable difference. Bug: 1019397 Change-Id: I35f79059afd9e17b348253815f0db295f6a0253d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176101Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766499}
-
Aran Gilman authored
Bug: 1027612 Change-Id: Id22e86cb78ba35af83a46a27b46a01227fce2c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163328Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#766498}
-
chromium-autoroll authored
Roll airmont AFDO profile from 84-4103.6-1587379457-benchmark-84.0.4124.1-r1 to 84-4129.0-1588587148-benchmark-84.0.4136.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4a90bcf1b40d58bf376cd7198f87b3c1c6544c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188374Reviewed-by:
-
Mehran Mahmoudi authored
This fixes a problem where only the initial call to PlayerFrameMediator#setLayoutDimension was respected. We need to resize the view port when a call to this method is made, without altering the bitmap matrix. Bug: 1079352 Change-Id: I7fd64988028dfb0d9e170abbef5306fbb228d683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188211 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#766496}
-
Andrew Grieve authored
Using different extensions fixes an issue where files were not being rebuilt when toggling from ijar->turbine. Bug: None Change-Id: I1bc9a36bc296bdddc16a62e6d5ed5af80b5c0313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187199Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#766495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38dda5a415a4..dd424f385b69 Created with: gclient setdep -r src-internal@dd424f385b69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC iclelland@google.com,sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1043080,chromium:1065456 Tbr: iclelland@google.com,sinhak@google.com Change-Id: Ic83a180f8f9a7086c38ebd490fb4cda8a4fff86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187894Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766494}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3b6afeeed0a9..b8a9630e9e23 git log 3b6afeeed0a9..b8a9630e9e23 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 peah@webrtc.org Add a Release method for file wrapper Created with: gclient setdep -r src/third_party/webrtc@b8a9630e9e23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ide54ac367d8f2e56b4c44f63395b44d6f90ecf05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187905Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 84-4103.6-1587378376-benchmark-84.0.4124.1-r1 to 84-4129.0-1588586778-benchmark-84.0.4136.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3aa506f7d9bc08b615c5ef06ef8d4c886fe769a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188372Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 84-4103.6-1587376856-benchmark-84.0.4124.1-r1 to 84-4118.0-1588586006-benchmark-84.0.4136.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I69add865eee181870588c44fcdc0abaff5be8e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188373Reviewed-by:
-
Ken Rockot authored
Bug: 1059389 Change-Id: Ief6e325d1053efb0be2213508682e33b656e8dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182884 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#766490}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/21d330b76d4e..d08f1d8dc0e7 git log 21d330b76d4e..d08f1d8dc0e7 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 jmadill@chromium.org Perf tests: Add screenshot capture mode. Created with: gclient setdep -r src/third_party/angle@d08f1d8dc0e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I83cf229e806d648e991aba86c7bd97fd2c9c5fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187902Reviewed-by:
-
Jarryd authored
Bug: 1077116 Change-Id: I166f7c2edbb419cdb0d1184357ee66c6beec0f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185517Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#766488}
-
Jarryd authored
Bug: 1077116 Change-Id: I39b3f705d6cd247467d12148c780a4fc4c0d1013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185444Reviewed-by:
-
Jarryd authored
Bug: 1077116 Change-Id: I6d146d6ece5cdb42cd626af426f07de82dc386a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185415Reviewed-by:
-
Ian Barkley-Yeung authored
Add metrics to investigate two issues within ProducerClient::InitSharedMemoryIfNeeded: 1. Allocation failures (https://crbug.com/1059705) 2. ChromeOS eve boards are only getting DumpWithoutCrashing crashes from Crashpad, never Breakpad. (https://crbug.com/1074115) Bug: chromium:1059705, chromium:1074115 Test: Ran with tracing on, checked chrome://histograms. Change-Id: Ib865f79d113002d773241cc571f229073cf021d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166470 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#766485}
-
Jan Wilken Dörrie authored
Bug: 1049177 Change-Id: Ia233f566bbcda43944661cac8523f5ac4d27c9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178575 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#766484}
-
Anastasia Helfinstein authored
The Switch Access UI specification (see bug) indicates that the back button should have a perfectly round focus ring exactly around the back button. The general accessibility focus ring infrastructure is not set up to be round, or to draw exactly adjacent to a UI element, so the preferred approach is to modify the back button's appearance to include the focus ring, when the node should be focused. AX-Relnotes: n/a Bug: 973719 Change-Id: I80aaa036d13192ce8b60fb2abaeb573a3f8ac5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181428 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#766483}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8ce113cb322d..668e41db73f4 git log 8ce113cb322d..668e41db73f4 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 sigurds@chromium.org [e2e] Disable tests blocking the Chromium binary -> DevTools roll 2020-05-07 tvanderlippe@chromium.org Add sentence about running single tests in the e2e runner 2020-05-07 sigurds@chromium.org Roll browser_protocol.pdl from chomium Created with: gclient setdep -r src/third_party/devtools-frontend/src@668e41db73f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027752,chromium:1051163,chromium:1079328 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie47b605277e3260110eb22968f4644ecc080ca5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187901Reviewed-by:
-
Roman Aleksandrov authored
Bug: 1071005 Change-Id: Ic4bc5188f61f16de78fa58e485a6fe809e5fd5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179562Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#766481}
-
Anastasia Helfinstein authored
As part of the process of transitioning to using the new Switch Access menu, it was discovered that the menu would often appear blank. Some digging revealed that the root of the issue was that InvalidateLayout() was never being called. This change fixes that. AX-Relnotes: n/a Bug: 973719 Change-Id: I24a2f1a033bc1f11b8bea6296f774f210770577a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176258Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#766480}
-
Jesse Schettler authored
Now that the ArcPrintService has been removed, there's nothing in //chrome/browser/chromeos/arc/print except traits files. Move these files to //components/arc/mojom with the associated Mojo file. Bug: b:152519668 Change-Id: Ib5e441d74a4fa54da76b6da7eaa250dc038cda7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183488Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#766479}
-
Rune Lillesveen authored
Bug: 1078474, 1024156 Change-Id: Ie9d442b2edb292f4b2f679b056f6f1811b09f16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187632Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#766478}
-
Anupam Snigdha authored
A clusterfuzz bug showed that the conversion from double to int could lead to overflow while fetching the layout bounds in DomRect type and converting it to WebRect. This patch follows a similar approach in reporting the control bounds of the active element's bounding rect that selection bounds does when it tries to update the selection bounds in RenderWidget::UpdateSelectionBounds. We convert DOMRect to DoubleRect and then use the enclosing IntRect to fetch the layout bounds using the EnclosingIntRect API. Bug: 1078429 Change-Id: Iac11e8f4ef1259214f100819f0d5df2f9b6d5356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183202 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Donn Denman authored
The previous CL that parameterized tests did not actually test both the enabled and disabled states. Also set the state of two different features: longpress and translations. BUG=956277, 952401 Change-Id: Iaac96c7baf2bc676be7e36877c906bc36fa6fc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148822 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#766476}
-
Chege Gitau authored
Given an image whose shortest dimension is zero, |GetImageAspectRatioScore| would run into a division by zero, which leads to undefined behavior. This CL prevents that by returning early. We return zero because such an image is not desirable, and should rank lower than images with non-zero heights and widths. Change-Id: I80f3b9b3d832d8363994c11bdd073af011b963ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185835Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Chege Gitau <dagitau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#766475}
-
Patrick Monette authored
It turns out that it's not always true that the new controllee is not already in the clients map. This CL removes the DCHECK introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2151246 and restores the initial behavior. base::InsertOrAssign() is used instead of the former usage of the square bracket operator so that a default constructor for ServiceWorkerClientInfo is not needed. Bug: 1077372 Change-Id: I4ae7270cc8e757cb0b7662d5d41a7ea0ce3d1f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176287Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#766474}
-
Chris Harrelson authored
Change-Id: Ia7afc484470347d688c53083cb8118581bf7925c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186990Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#766473}
-
Dan Harrington authored
Fills out two request fields we were missing Bug: 1044139 Change-Id: Ic0ef906d1681bbc426f9d2e9ed6a699f258594aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169733 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#766472}
-
Chris Harrelson authored
This is because there is no spec text corresponding to this behavior, and the test is failing on other browsers. See also: https://github.com/web-platform-tests/wpt/pull/23453/ Change-Id: Ia2d4f0c75c3b295e19f1ffec3e2e0d0fb1882c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187174Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#766471}
-
Dylan Cutler authored
Bug: 973801 Change-Id: I61319729a0fd1938264370ee1359dff75cfcc225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171969Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#766470}
-
Andrew Grieve authored
Will be more relevant if we use more arsc filters. Even so, speeds up command on my machine: 10.3s -> 7.7s Bug: 636448 Change-Id: I9b3db23782282e3e13c613b0b64ff1375fb1422d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186756 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#766469}
-
John Z Wu authored
Also fix flakiness in unit test by consuming all metrics before test. Change-Id: Ic5911acc1b26e81dffb5a45a50c6a0ec3a8eed6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176288Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#766468}
-
Victor Costan authored
StoragePartitionImpl::QuotaManagedDataDeletionHelper receives the set of storage backends whose storage will be deleted using a StoragePartitionImpl-specific remove_mask, which is a uint32_t. It is responsible for converting this to a QuotaManager-specific quota_client_mask, which is an int. The conversion is done correctly when calling QuotaManager::DeleteOriginData(), but is skipped when calling QuotaManaegr::PerformStorageCleanup(). This CL ensures that the conversion is done consistently when transitioning into QuotaManager. This problem was discovered while moving the Quota subsystem to the Storage Service. The problem is fixed in a small independent CL to take advantage of Canary's ability to catch unexpected issues. Bug: 1016065 Change-Id: I165e2033d73b5d3458c50ed5a58117130daf9db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186178Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#766467}
-
S. Ganesh authored
Windows currently has a bug where it does not migrate Ole Automation Marshaler Interface/Typelib registrations that do not have a Version field declared. This change therefore adds a Version field to the registration as expected by the Windows OS Upgrade migration. Bug: 1078628 Change-Id: I72e265561ac3aaa79077488c110b18c45fb1e9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186462 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766466}
-
Etienne Pierre-doray authored
Metadata is applied on past samples for the stack sampling profiler once a long input delay is detected. As part of an investigation on jank (and more specifically long input delay) https://docs.google.com/document/d/1YTpnc7o8XH1KioJpPhWoZvi4Zkpo7cezDrGjQrKZmlQ/edit#heading=h.iohxee36df7p we're looking into UMA stack sampling profiler data. Currently, we can only detect jank caused by stalled stacks. Annotating stack frames with (long) input event will allow us to analyze "running" jank. Change-Id: I7914aebf4e14504b400f241d827bda56b6f84db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172214Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#766465}
-
Victor Costan authored
* Qualify std::make_pair everywhere. This matches standard practice. * Use standardized names for iterator variables. Bug: 1016065 Change-Id: Id758ae1ac9e98c479f55fae89e5d12888533c630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188051 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
-
David Bertoni authored
FileSystemApiOpenExistingFileWithWriteTest was disabled as flaky long ago, but it passed on the bots with flying color on 3000 iterations. Bug: 177163 Change-Id: Icfa48575d2c557afc9d4ce6ec8fb6a402a84ae82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173399Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#766463}
-
Nate Fischer authored
No change to logic, only docs. This updates the commandline docs to point to Developer UI in more spots and to remove a reference to the log verbosifier app. This removes a "new in M84" aside for a Dev UI feature which was cherry-picked to M83. This adds documentation for flag persistence and "check for WebView updates," both of which were added in M84. Fixed: 1058571 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia796cd84d3556fa15d6b251d18b55cde546d0609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186750 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#766462}
-
