GitLab

BUG=none
TEST=manual (made sure it pixel-matched the old find bar, in both normal and GTK+ theme modes)

Review URL: http://codereview.chromium.org/6992017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/6966018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86636 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82824
TEST=doesn't say anything on startup

Review URL: http://codereview.chromium.org/7066029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86635 0039d316-1c4b-4281-b951-d872f2087c98

. Crash when deleting via context menu. This was happening because
  BookmarkMenuDelegate didn't keep a handle to the menu item it added
  the items to.
. If other bookmarks folder is empty it wouldn't show a menu item for
  (empty).
. Deleting the last item in the other folder would prematurely close
  the menu.
. Hit DCHECK when adding empty menu (long standing issue).

BUG=83746
TEST=from the wrench menu on windows right click a bookmark, delete
     it, and make sure you don't crash.
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7066034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86634 0039d316-1c4b-4281-b951-d872f2087c98

Added an easy hook for enabling / disabling the tests as needed.

BUG= none
TEST= none


Review URL: http://codereview.chromium.org/7067037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86633 0039d316-1c4b-4281-b951-d872f2087c98

BUG=58437
TEST=go to <https://2029.globalsign.com> and verify the EV status

Unit Test (This test has been DISABLED because it fails
when "./netunittests" is run, though it passes individually.):
"net_unittests --gtest_filter=X509CertificateTest.GlobalSignR3EVTest"

Review URL: http://codereview.chromium.org/7037031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86632 0039d316-1c4b-4281-b951-d872f2087c98

PathProvider on the Mac always returned the FILE_EXE for FILE_MODULE,
which isn't necessarily correct.

BUG=NONE
TEST=BUILD


Review URL: http://codereview.chromium.org/7019041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15687
TEST=Disable / reenable wifi and check animation

Review URL: http://codereview.chromium.org/7067030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86630 0039d316-1c4b-4281-b951-d872f2087c98

Revert 86625 - This change implements a first pass in the effort to remove the dependency of PlatformDevice within Chrome.  The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends.

A new set of helper functions is provided for the PlatformDevice entry points.  Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData.  The new helper functions forward calls to the interface cached in the metadata.

BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7019013

TBR=twiz@chromium.org
Review URL: http://codereview.chromium.org/6987019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63545
TEST=Use contextMenus.create() with "page" context and targetUrlPattern; verify that menu does show.


Review URL: http://codereview.chromium.org/7057029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86628 0039d316-1c4b-4281-b951-d872f2087c98

media_matrix_data_public.csv for videos that are in
trunk/deps/avperf/{bear,tulip}. 

Bug fixes includes:
* CSV file abnormality
* the order of returned tuples in _GenerateMediaInfo and LookForMediaInfoInCompactFormByNickName was incorrect
* not recognize the second column of CSV as tag
* par_filename was not set in the case of matrix driven test. 

Added features:
* -c and -z option to control the number of tests


Review URL: http://codereview.chromium.org/6992026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83828
TEST=NONE

Review URL: http://codereview.chromium.org/7053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86626 0039d316-1c4b-4281-b951-d872f2087c98

This change implements a first pass in the effort to remove the dependency of PlatformDevice within Chrome.  The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends.

A new set of helper functions is provided for the PlatformDevice entry points.  Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData.  The new helper functions forward calls to the interface cached in the metadata.

BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7019013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86625 0039d316-1c4b-4281-b951-d872f2087c98

necessary.

BUG=none
TEST=none
R=brettw@chromium.org

Review URL: http://codereview.chromium.org/6992040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86624 0039d316-1c4b-4281-b951-d872f2087c98

TBR=battre

Review URL: http://codereview.chromium.org/6987016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:14543
TEST=File Manager should be on NTP.
Review URL: http://codereview.chromium.org/6912024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86621 0039d316-1c4b-4281-b951-d872f2087c98

Nu functionality change: virtual is only added to destructors
that are already implicitly virtual.

BUG=83408
TEST=chromiumos clang bot goes green
TBR=battre

Review URL: http://codereview.chromium.org/7031049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86620 0039d316-1c4b-4281-b951-d872f2087c98

Will be used to show extension unpack progress in the download shelf UI.

BUG=80010
TEST=manual

Review URL: http://codereview.chromium.org/7060014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86618 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7056011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86617 0039d316-1c4b-4281-b951-d872f2087c98

Ran through the import script in third_party/sqlite/README.Chromium,
including the SQLite test suite.  A few minor errors under
oserror-1.1.[123], I suspect my Linux reference machine is becoming
outdated.

SQLite changes are going to be hard/impossible to review.  It's a year
and a half of changes, might as well be a new package.

Removed patches which are no longer necessary:
  icu-regepx.patch is already present
  safe-tolower.patch is already present
  attach-integer.patch no longer relevant

For attach-integer.patch, the code has been refactored.  The failure
in http://crbug.com/38745 no longer occurs (ATTACH 12345 as db;
attaches the SQLite database "12345" rather than crashing).

Tweak test.patch for modern era.

Adjusted webdb.patch for new flag.

Clean up fts3.patch.  fts3 has been substantially refactored, so much
of the patch no longer applies.  Reviewed fts3_write.c and many of the
patches are now handled appropriately.  I found one issue in fts3.c,
and I'm still reviewing it.  This will be ongoing.

Disabled WAL (Write Ahead Log) and fts4 support for now as unknown
unknowns.

BUG=71731
TEST=*EVERYTHING* continues to work.

Review URL: http://codereview.chromium.org/6990047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86616 0039d316-1c4b-4281-b951-d872f2087c98

Nu functionality change: virtual is only added to destructors
that are already implicitly virtual.

BUG=83408
TEST=chromiumos clang bot goes green
TBR=battre

Review URL: http://codereview.chromium.org/6979010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=71097
TEST=no change

Review URL: http://codereview.chromium.org/7065038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86613 0039d316-1c4b-4281-b951-d872f2087c98

string_util.h is recursively included by one of the other includes in this file,
which is why we don't get a compile error, but it's best to always include what
you use.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7065044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compile with clang.
TBR=altimofeev@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86611 0039d316-1c4b-4281-b951-d872f2087c98

Current implementation of message_pump_glib_x uses both X event queue and GDK's g_main_context_iteration to read event messages.

If the first X event in the X event queue can be dispatched directly, it will be extracted and dispatched.
If the first X event in the X event queue can't be dispatched directly, g_main_context_iteration will be called to translate X events into GDK evnets.
If the first X event can't be dispatched directly and is followed by X events that can be dispatched directly in the event queue,
those events that can be dispatched directly will also go through GDK and may get lost if GDK does not recognize them (e.g. XInput2 events).

To fix this, a GDK event filter is setup to intercept all the X events before they are translated into GDK events.
In the filter if the X events are found to be wanted, they will get dispatched directly instead of translated into GDK events.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7050030
Patch from Yufeng Shen <miletus@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86610 0039d316-1c4b-4281-b951-d872f2087c98

Cause compile failure
484>WebViewHost.obj :error LNK2001: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ)
484>NotificationPresenter.obj :error LNK2019: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ) referenced in function "public: static bool __cdecl WTF::SimpleClassHashTraits<class WTF::String>::isDeletedValue(class WTF::String const &)" (?isDeletedValue@?$SimpleClassHashTraits@VString@WTF@@@WTF@@SA_NABVString@2@@Z)
484>TestShell.obj :error LNK2001: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ)
484>MockSpellCheck.obj :error LNK2001: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ)
484>LayoutTestController.obj :error LNK2001: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ)
484>C:\b\build\slave\Win_Builder__dbg__shared_\build\src\build\Debug\DumpRenderTree.exe : fatalerror LNK1120: 1 unresolved externals

BUG=none
TEST=none
TBR=dpranke

TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/7069011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86609 0039d316-1c4b-4281-b951-d872f2087c98

Nu functionality change: virtual is only added to destructors
that are already implicitly virtual.

BUG=83408
TEST=chromiumos clang bot goes green
TBR=battre

Review URL: http://codereview.chromium.org/7027006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86608 0039d316-1c4b-4281-b951-d872f2087c98

Nu functionality change: virtual is only added to destructors
that are already implicitly virtual.

BUG=83408
TEST=chromiumos clang bot goes green
TBR=battre

Review URL: http://codereview.chromium.org/6992062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83876
TEST=no
TBR=skerner@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83408
TEST=none

Review URL: http://codereview.chromium.org/7065027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83876
TEST=no
TBR=skerner@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86603 0039d316-1c4b-4281-b951-d872f2087c98

Fix extension_webstore_private_api calls to DefaultProfile. Instead of calling GetDefaultProfile in incognito mode, call GetOriginalProfile, which gives the non-incognito profile from which that profile was spawned. This makes things work with multi-profiles.

BUG=83792
TEST=existing tests still work.
Review URL: http://codereview.chromium.org/6992036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77477


Review URL: http://codereview.chromium.org/6979009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86601 0039d316-1c4b-4281-b951-d872f2087c98

R=altimofeev@chromium.org
BUG=chromium-os:11632
TEST=Check that network screen works as before. Run NetworkScreenTest.* browser tests

Review URL: http://codereview.chromium.org/7066020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15579
TEST=none

Review URL: http://codereview.chromium.org/7008010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86599 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dpranke

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86598 0039d316-1c4b-4281-b951-d872f2087c98

It's based on http://codereview.chromium.org/7029009/.

BUG=61676
TEST=QuotaTemporaryStorageEvictorTest.*

Review URL: http://codereview.chromium.org/7002024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83861
TEST=no
TBR=sky@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86595 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6992055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63656
TEST=host_content_settings_map_unittest.cc,content_settings_pref_provider_unittest.cc

Review URL: http://codereview.chromium.org/7064030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86593 0039d316-1c4b-4281-b951-d872f2087c98