- 27 Jul, 2018 40 commits
-
-
Weiyong Yao authored
Bug: 867003 Change-Id: I2ef56eeafcee60f23fbd2d67fb3193eb9cd360d4 Reviewed-on: https://chromium-review.googlesource.com/1148694 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#578863}
-
Scott Violet authored
This reverts commit ec2cd434. Reason for revert: Reverting in hopes of fixing unit_tests on chromeos bot. This one will hopefully take. Sorry for so many reverts here. The chain of patches made it difficult. Original change's description: > Misc. cleanup to browser_theme_pack_unittest.cc; no functional change. > > * Add GetDefaultColor() mapping function to make it easy to fix DCHECKs due to > this code using raw _INCOGNITO color constants but > ThemeProperties::GetDefaultColor() not expecting them. This is the change > that led me to get annoyed and do all the other stuff here. > * Convert typedefs to type aliases. > * Add TP = ThemeProperties type alias for brevity. > * Use =default. > * Mark functions that don't touch member variables "static". > * Fix wrapping issues. > * Because the class here is so long, split it into declaration and definition > pieces so it's easier to see what's the API and what's helper functions. > * Make the API protected; make helpers private. > * Make data members private. Add a const accessor for the one member tests use. > > Bug: none > Change-Id: I4cc058bb29747cfa84835edbc5ce765401e14527 > Reviewed-on: https://chromium-review.googlesource.com/1152108 > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578775} TBR=pkasting@chromium.org,estade@chromium.org Change-Id: I2407b13ff9c69c240bb7479e21a515c17c1388b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/1153991Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578862}
-
Scott Violet authored
This reverts commit 8c35e22c. Reason for revert: Reverting to fix unit_tests on chromeos bot. This is next in the chain. Ugh! Original change's description: > Add background tab colors and inactive images to the theme system. > > These will eventually be used for three purposes: > (1) To allow generating different background tab images from a common tint for > the inactive and incognito cases, thus allowing background tabs that blend > into the frame for custom themes. > (2) To allow autogenerating the background tab colors from the background tab > images, thus letting us autocalculate better tab text/separator/etc. colors. > (3) To allow theme authors to customize/override this behavior more precisely. > > Reasons (1) and (2) dictated the design here; reason (3) is basically a free > bonus. I thought about not making these resources overrideable by theme > authors, but there was some technical reason that turned out to not be easily > feasible, and there seems little reason to prevent it. > > This also allows us to read THEME_TAB_BACKGROUND_INCOGNITO on Mac (Views). > > This shouldn't result in a visual change on its own. > > Bug: 862664 > Change-Id: Icc57f78fd526d68b83c692fbac669a7371bb38ff > Reviewed-on: https://chromium-review.googlesource.com/1147869 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578790} TBR=pkasting@chromium.org,oshima@chromium.org,estade@chromium.org,bsep@chromium.org,kylixrd@chromium.org Change-Id: I6abe212768916890c11aec28aac5fc96891ac695 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862664 Reviewed-on: https://chromium-review.googlesource.com/1153990Reviewed-by:
-
Scott Violet authored
This reverts commit 3b7859cb. Reason for revert: Reverting in hopes of get unit_tests passing on chromeos bot. This appears to be next in the chain to revert. Original change's description: > Add background tab text colors for inactive and incognito windows. > > With the default behavior of Chrome being to not show a tab background, we want > to change themes to default to that as well, unless the theme author actually > supplies an image/color for this explicitly. To do this, we need to support > different tab text colors for the cases where the frame colors can vary. This > adds the framework for that support. > > Right now, the default is to use the same text colors in inactive windows as > active ones. > > This also gives themes that want normal and incognito windows to differ greatly > (as the built-in theme's does) the ability to implement that and still have > readable tab titles. > > Bug: 866672 > Change-Id: I032a72bc799d0675c517db10283513a30db23328 > Reviewed-on: https://chromium-review.googlesource.com/1152418 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578807} TBR=pkasting@chromium.org,estade@chromium.org,bsep@chromium.org Change-Id: I5e3a5772cea3f7a0d3f790d27dcccc66c51cb161 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866672 Reviewed-on: https://chromium-review.googlesource.com/1154067Reviewed-by:
-
Robert Kroeger authored
Ozone/drm/mojo contained a DCHECK only appropriate for legacy mash mode. This mode has been removed so remove the DCHECK as well. BUG=620927 TEST=by hand Change-Id: Ieb8c6b21ed79de2202ee06eedf47029d32183421 Reviewed-on: https://chromium-review.googlesource.com/1153968Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#578859}
-
Sammie Quon authored
Test: manual Bug: 866376 Change-Id: I5527ea59fadfd4ecdd1eb3a9473a72b618a1ab53 Reviewed-on: https://chromium-review.googlesource.com/1153970Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#578858}
-
Daniel Murphy authored
When PurgeUnusedAreas is called, the unbound areas are destroyed. If one of these areas was holding onto a data map that was cloned to another area in a different namespace, a re-bind to that area created a new map instead of using the already-existing one. This change allows the SessionStorageNamespaceImpl to look up maps that are already in use to possibly re-use a map that already exists. R=mek@chromium.org Bug: 866887 Change-Id: Ifdb14278bb223bbdcb877e4fddccd158968fb575 Reviewed-on: https://chromium-review.googlesource.com/1153770 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#578857}
-
Scott Violet authored
This reverts commit df84748a. Reason for revert: To fix unit_tests (I have to revert this before the earlier patch). Likely suspect for BrowserThemePackTest.HiDpiThemeTest failing on bots. For example, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11230 : [ RUN ] BrowserThemePackTest.HiDpiThemeTest ../../chrome/browser/themes/browser_theme_pack_unittest.cc:204: Failure Expected equality of these values: "" error Which is: "File doesn't exist." Stack trace: #0 0x0000026103ac testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x00000260fd89 testing::internal::AssertHelper::operator=() #2 0x000000fc9b98 BrowserThemePackTest::BuildFromUnpackedExtension() #3 0x000000fd22cc BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() ../../chrome/browser/themes/browser_theme_pack_unittest.cc:205: Failure Value of: valid_value.get() Actual: false Expected: true Stack trace: #0 0x0000026103ac testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x00000260fd89 testing::internal::AssertHelper::operator=() #2 0x000000fc9e0b BrowserThemePackTest::BuildFromUnpackedExtension() #3 0x000000fd22cc BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() Received signal 11 SEGV_MAPERR 000000000028 #0 0x000004d00e1c base::debug::StackTrace::StackTrace() #1 0x000004d00981 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f26bba79330 <unknown> #3 0x0000050f3e24 BrowserThemePack::WriteToDisk() #4 0x000000fd22db BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() #5 0x0000026161b2 testing::Test::Run() #6 0x000002616d30 testing::TestInfo::Run() #7 0x000002617247 testing::TestCase::Run() #8 0x000002622747 testing::internal::UnitTestImpl::RunAllTests() #9 0x0000026222bd testing::UnitTest::Run() #10 0x0000045565d1 base::TestSuite::Run() #11 0x000004557fca base::(anonymous namespace)::LaunchUnitTestsInternal() #12 0x000004557e7a base::LaunchUnitTests() #13 0x00000454e155 main #14 0x7f26b86c9f45 __libc_start_main #15 0x0000006fa82a _start r8: 0000000000000000 r9: 54656d6568546970 r10: 747365545f747365 r11: 0000000000000000 r12: 000024a8af0c0d20 r13: 00007fff447924e8 r14: 00007fff44792560 r15: 0000000000000000 di: 0000000000000000 si: 00007fff44792560 bp: 00007fff44792520 bx: 00007fff44792578 dx: 00000000000005e7 ax: 0000000000001fdd cx: 0000000000000023 sp: 00007fff44792490 ip: 00000000050f3e24 efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000028 [end of stack trace] Original change's description: > Compute colors for the frame and tabs from provided images. > > If theme authors explicitly provide values here, we'll use them; but if they > don't, but do provide images, set the colors to be the dominant colors of the > images, using an existing K-means algorithm (similar to what we use for > computing representative favicon colors etc.). > > This allows us to rely on those colors later when deciding what color to make > tab text, the new tab button, and similar tabstrip/window frame items. > > This also does a bit of cleanup to the theme pack code, e.g. moving a map used > in only one function into that function to make its provenance clearer. I can > try to split this apart into more CLs if desired. > > Bug: 862664 > Change-Id: I8c3f15893ad491a6fee8aa5f76ae162cecb2c6fd > Reviewed-on: https://chromium-review.googlesource.com/1152517 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578823} TBR=pkasting@chromium.org,asvitkine@chromium.org,estade@chromium.org Change-Id: I6a5a7f2916136ccf93101f36c34a17a4e5ef5d4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862664 Reviewed-on: https://chromium-review.googlesource.com/1153988Reviewed-by:
-
Johannes Henkel authored
I've renamed the enable* terminology a bit, since it's a two-phase enable here, so I think it's good to have enable_requested_ (persistent) and enable_completed_ (transient). For reference the PR that introduced the new InspectorSessionState / InspectorAgentState / Fields was https://chromium-review.googlesource.com/c/chromium/src/+/1149201. Change-Id: I0ec3e9a9b8c20e5200bc5932f514bfe873f74a2c Reviewed-on: https://chromium-review.googlesource.com/1153571 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#578855}
-
Peter Collingbourne authored
This relands commit 1ba5d611. Fixes chromeos build issue by checking whether we have a secondary toolchain before comparing it with the current toolchain. Original change's description: > build: Enable ThinLTO in official Android builds. > > With this change we start building Chromium with ThinLTO when targeting > Android. In 64-bit Monochrome builds, the 32-bit binary is also built > with ThinLTO. This change is expected to reduce code size significantly > (in local measurements it reduced the size of MonochromePublic.apk by 2.3MB) > and is a prerequisite for enabling control flow integrity in official > builds. > > Note that although this change enables ThinLTO, it does not enable > the cross-TU optimizations normally associated with LTO. Enabling > cross-TU optimizations is a separate project. > > On my local machine (a Lenovo P920) libmonochrome.so link times increase > as follows: > > before after (first link) after (incremental links) > 32-bit 18s 140s 50s > 64-bit 13s 107s 41s > > All known blockers have now been fixed. This CL is likely to uncover > unknown blockers. > > Bug: 469376 > Change-Id: I8981e17abd50bc5ca00440e0d74dda878c911749 > Reviewed-on: https://chromium-review.googlesource.com/1150870 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578195} Bug: 469376, 868426 Change-Id: Ie46ba0db0ac68130bc600415777de5c813b28ebd Reviewed-on: https://chromium-review.googlesource.com/1153612Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#578854}
-
Danyao Wang authored
When an error page is displayed in web view, the error retry state of the navigation item is never transitioned to kDisplayingWebErrorForFailedNavigation. This does not prevent the displaying of error page on the first failure, but subsequent back- forward navigation to this item starts with the incorrect state and can result in DCHECKs of unexpected error state, error view not being loaded and poor interaction with other types of errors, such as SSL interstitial. This CL refactors the state transitions for WebErrorPages so it is handled identically to native error. This also required web error load to not skip DidFinishNavigation callback to correctly update the ErrorRetryStateMachine. Also parameterized error_page_inttest.mm so both navigation manager implementations are tested on trybots. Bug: 837210 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4f63c3c9bae21158deb705a3da5ed3eeab59a8bb Reviewed-on: https://chromium-review.googlesource.com/1151542 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#578853}
-
Florin Malita authored
Removing this flag will allow skia to process text blobs using the new glyph run code. TBR= Change-Id: Ib834240778121f628ac2b966211703e7a69588ef Reviewed-on: https://chromium-review.googlesource.com/1153449Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#578852}
-
Klaus Weidner authored
The first frame of an immersive session may not yet have frame data including the expected frame_id and output buffer mailbox holder, don't treat that as an error. See also https://crbug.com/855722 BUG=868028 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icecd3ea8035ea783a625b11082e736d9609a15f8 Reviewed-on: https://chromium-review.googlesource.com/1153829Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#578851}
-
CJ DiMeglio authored
Before, we passed in dummy information that always assumed that the video was opaque. Now we correctly communcate this information such that the video can now be transparent. Bug: 863203 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic4617ef334f01d72ec4c5494d8d9c33accc581db Reviewed-on: https://chromium-review.googlesource.com/1141342 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578850}
-
Xiyuan Xia authored
Update DropTargetEvent ctor to take gfx::PointF instead of gfx::Point. No behavior change. Bug: None Change-Id: I0d38527bd73edc49a0dfb974a33ce95eec94af61 Reviewed-on: https://chromium-review.googlesource.com/1153433Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#578849}
-
Takuto Ikuta authored
This is a part of effort to remove /wd4018 warning suppression. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1152755 This CL was uploaded by git cl split. R=forshaw@chromium.org Bug: 868248, 588506 Change-Id: I6d0a6763d4afbe3fd51f9841b19adbe70209c68d Reviewed-on: https://chromium-review.googlesource.com/1152842Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#578848}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d72fd5888686..6146214d30ab git log d72fd5888686..6146214d30ab --date=short --no-merges --format='%ad %ae %s' 2018-07-27 npm@chromium.org Merge several methods into JBig2GrdProc::DecodeArithTemplateUnopt Created with: gclient setdep -r src/third_party/pdfium@6146214d30ab The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib69b3d66c1350be2f06380cb03bf852efa958a43 Reviewed-on: https://chromium-review.googlesource.com/1153291Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578847}
-
Takuto Ikuta authored
This is a part of effort to remove /wd4018 warning suppression. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1152755 This CL was uploaded by git cl split. R=pennymac@chromium.org Bug: 868248, 588506 Change-Id: Iba8b4516550b89b5acf534bc1fa11d959154550e Reviewed-on: https://chromium-review.googlesource.com/1152841Reviewed-by:
-
siyua authored
Bug: b/111843286 Change-Id: I9d198b12f7e3fc4c51146f91610eb1f00a19390e Reviewed-on: https://chromium-review.googlesource.com/1153303Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#578845}
-
Aga Wronska authored
Real usage of the offline setup on network list will be implemented separately. Bug: 862445 Test: Run DemoSetupTest and wizard_controller_browsertests. Change-Id: I67c0ca2862ca30fe2a2c2115d413fe0f7dae0191 Reviewed-on: https://chromium-review.googlesource.com/1151951Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#578844}
-
Joshua Peraza authored
This new implementation of GetProductNameAndVersion() will replace the existing one in the transition to Crashpad. GetSanitizationInformation() (for webview) will replace GetCrashKeysWhitelist() and the SanitizationInfo struct passed during crash reporter initialization. These new methods are currently unused. Bug: crashpad:30 Change-Id: Ic60d17cb3af8b4e7997009c23a44fcc8b94915a7 Reviewed-on: https://chromium-review.googlesource.com/1142511Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#578843}
-
Dale Curtis authored
BUG=864145 TEST=none Change-Id: I6bb241e52a2a6e8ef7841d4a0b76cb3dfa88b2c5 Reviewed-on: https://chromium-review.googlesource.com/1153618Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#578842}
-
Becca Hughes authored
Scale interstitial text with the video player size based on the modern controls spec. This uses a ResizeObserver to add a CSS sizing class to the PiP interstitial. This also contains a refactor to move the sizing calc to MediaControls so we can use the same sizing logic across Modern Media Controls and the PiP interstitial. BUG=853219 Change-Id: I46f7512e1a5fb8dc0c1a99e39af1a0d49756854c Reviewed-on: https://chromium-review.googlesource.com/1138977 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#578841}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e4db6a151806..e635e9807dab git log e4db6a151806..e635e9807dab --date=short --no-merges --format='%ad %ae %s' 2018-07-27 ouj@fb.com Fix compilation error of opensslutility.cc when compiling with OpenSSL. 2018-07-27 saza@webrtc.org Remove old temporary webrtc::PostProcessing typedef 2018-07-27 titovartem@webrtc.org Revert "Add framesRendered to StatsReport" 2018-07-27 mbonadei@webrtc.org Remove dependency between source_set and android_library. 2018-07-27 peah@webrtc.org AEC3: Increasing the transparency during call startup 2018-07-27 saza@webrtc.org Fuzz unfuzzed AEC3 killswitch field trials 2018-07-27 buildbot@webrtc.org Roll chromium_revision d340c5e1..75645bae (578434:578612) 2018-07-27 saza@webrtc.org Add unused AEC toggling config to API 2018-07-27 jbauch@webrtc.org Don't use explicit constructor in copy-initialization. 2018-07-27 titovartem@webrtc.org Fix android DEPS to unblock chromium roll 2018-07-27 oprypin@webrtc.org Don't specify Mac version for iOS real device tests 2018-07-27 titovartem@webrtc.org Fix chromium roll by manually rolling up to d340c5e1 2018-07-27 nisse@webrtc.org Delete logic to look for arch-specific resource files. 2018-07-27 nisse@webrtc.org Delete lsan and valgrind suppressions for deleted xmpp tests 2018-07-27 titovartem@webrtc.org Fix refered LICENSE file path in webrtc license notice 2018-07-26 joachimr@fb.com Add framesRendered to StatsReport 2018-07-26 qingsi@google.com Use "wildcard" instead of "unknown" for ADAPTER_TYPE_ANY in stats. 2018-07-26 buildbot@webrtc.org Roll chromium_revision 96177551..16fdc860 (578286:578405) 2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for call/ (part 1). Created with: gclient setdep -r src/third_party/webrtc@e635e9807dab The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:868329,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I85c516ab6a287e01072aa19a814098cad157abbd Reviewed-on: https://chromium-review.googlesource.com/1153512Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578840}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/227424b57d28..c3bc69f238f5 git log 227424b57d28..c3bc69f238f5 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 herb@google.com Rename MakeAsTextDraw to MakeFromText 2018-07-27 herb@google.com Make regenerateGlyphRunList on use the iterator 2018-07-27 csmartdalton@google.com Fix a crash in the clockwise gm 2018-07-27 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-27 bsalomon@google.com Remove unused kTexture2D_GrSLType and kSampler_GrSLType 2018-07-27 ziadb@google.com SkAR Java: fixed runtime bugs, better UI 2018-07-27 bsalomon@google.com Remove unused kBufferSampler_GrSLType 2018-07-27 csmartdalton@google.com sksl: Add a "sk_Clockwise" built-in 2018-07-27 herb@google.com Duplicate drawDFPosText into drawDFGlyphRun 2018-07-27 ethannicholas@google.com Fixed GLSL header line ordering 2018-07-27 ziadb@google.com SkAR Java: DrawManager dox and minor changes, removed unnecessary files 2018-07-27 robertphillips@google.com Fix TSAN bug in TransferPixelsTest 2018-07-27 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c3bc69f238f5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/111582212 TBR=benjaminwagner@chromium.org Change-Id: I43720e98305d3c8d8068840e17524d706b6847f4 Reviewed-on: https://chromium-review.googlesource.com/1153707Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578839}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0147f5d1..4f737a90 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1ff7863da100c40b04857e4ba2b072b91f3e12ed Reviewed-on: https://chromium-review.googlesource.com/1153597Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578838}
-
Scott Violet authored
This reverts commit eaeee48e. Reason for revert: broke generate build file step on some builders. See https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939809310924674512/+/steps/generate_build_files/0/stdout as an example: Traceback (most recent call last): File "C:\b\swarming\w\ir\cache\builder\src\tools\mb\mb.py", line 63, in Main ret = self.args.func() File "C:\b\swarming\w\ir\cache\builder\src\tools\mb\mb.py", line 299, in CmdGen vals = self.Lookup() File "C:\b\swarming\w\ir\cache\builder\src\tools\mb\mb.py", line 601, in Lookup config = self.ConfigFromArgs() File "C:\b\swarming\w\ir\cache\builder\src\tools\mb\mb.py", line 683, in ConfigFromArgs (self.args.builder, self.args.master, self.args.config_file)) MBErr: Builder name "Win" not found under masters[chromium] in "C:\b\swarming\w\ir\cache\builder\src\tools\mb\mb_config.pyl" step returned non-zero exit code: 1 Original change's description: > Rename main chromium builders > > Uses the bit.ly/chromium-build-naming naming scheme. > > Bug: 867725 > Change-Id: Id1d903c2a0d108c447a42919f3bfc72a917a4d18 > Reviewed-on: https://chromium-review.googlesource.com/1153616 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578829} TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org Change-Id: I1bc2dd5e461bdc8438a36e57a04ead43b5c0d76b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867725 Reviewed-on: https://chromium-review.googlesource.com/1153867Reviewed-by:
-
Nasko Oskov authored
This test was likely flaky due to a race condition in navigation code, which has now been fixed. Let's try to enable it and see if the fix has helped deflake this test. Bug: 477840, 746407 Change-Id: Ib1d449dd34c2d6044a60da38f03ac548179d475c Reviewed-on: https://chromium-review.googlesource.com/1153221Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#578836}
-
Nasko Oskov authored
There have been various fixes in navigation code that have helped deflake webNavigationApi tests. The goal of this CL is to enable the WebNavigationApiTest.UserAction test and see if it has benefited from these fixes and is no longer flaky. Bug: 662160 Change-Id: Ia463d32f425b9e366c5879d4f297a521c8c28260 Reviewed-on: https://chromium-review.googlesource.com/1153394Reviewed-by:
-
Derek Cheng authored
the Cast SDK. This patch also changes the XML parsing done by DIAL discovery to use the same batching ID so that the data_decoder service instance will be shared with the MRP. Bug: 808720 Change-Id: Ieed0aa79bfb35874d5bb68fc35690baeae54f561 Reviewed-on: https://chromium-review.googlesource.com/1147107 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#578834}
-
Ben Pastene authored
It screws with the host cmd for host-side tests: https://chromium-swarm.appspot.com/task?id=3ef65521090b3a10 R=jbudorick Change-Id: If903a70eeb5f6044ee888d436cbbc56848c5a6c3 Reviewed-on: https://chromium-review.googlesource.com/1153779 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#578833}
-
Marton Hunyady authored
For enterprise rollback, the "Reboot and reset" button should just reboot the device. Without this, the button behavior is broken (nothing happens when pressing it), because we don't generally allow powerwash for managed devices. The admin-initiated rollback is an exception to it. Bug: 868263 Change-Id: Iaa13429b35a52ef78d39e50ab42f17ac76a7eb33 Reviewed-on: https://chromium-review.googlesource.com/1152742 Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Reviewed-by:
-
Robert Ma authored
They don't need to (and shouldn't) be in the bloated TestExpectations. Most of these are related to idlharness.js and their corresponding bugs have been merged to crbug.com/856601, so update the bug links accordingly. Besides, two expectations were incorrectly removed in an import https://crrev.com/c/1152529; they are also added back in this CL. Bug: 856601 Change-Id: Idf3a58cd3a4b5ae9f149bbff7b5150bfda3ed645 Reviewed-on: https://chromium-review.googlesource.com/1153615 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#578831}
-
Mike Pennisi authored
This test is expected to cause unhandled promise rejections. Although the test harness reports an error when it detects unhandled promise rejections, they do not occur in this test until results have already been reported. In a forthcoming change to testharness.js [1], testing will pause until "cleanup" code has completed. This change will delay the reporting of results, and the previously-ignored unhandled rejections will interrupt the results. Ideally, the rejections could be handled with explicit code written for this purpose. The particulars of this test make this impossible. Instead, configure the test harness to allow unhandled promise rejections. [1] https://github.com/web-platform-tests/wpt/pull/8748 R=foolip@chromium.org, robertma@chromium.org Bug: 867708 Change-Id: I7ac53d88424e80b89e9969312f8cbfeb0922f579 Reviewed-on: https://chromium-review.googlesource.com/1150882Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
-
Stephen Martinis authored
Uses the bit.ly/chromium-build-naming naming scheme. Bug: 867725 Change-Id: Id1d903c2a0d108c447a42919f3bfc72a917a4d18 Reviewed-on: https://chromium-review.googlesource.com/1153616Reviewed-by:
-
Patrick Monette authored
The reason the tests were failling is that the chrome elf logs were always being drained but they contained bogus data from the stubs, messing with the test expectations. This CL changes ModuleDatabase so that it does not observe the load attempt log by default. The browser now triggers this explicitly during startup. Bug: 866871 Change-Id: I11d03141757fcb1c3ebb6e49d3fbb042056d1ede Reviewed-on: https://chromium-review.googlesource.com/1150976Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#578828}
-
Daniel Nicoara authored
If we don't have the GAMMA properties try the legacy path even when trying to disable GAMMA otherwise we could leave the GAMMA set to an undesirable value. BUG=868479 TEST=New unittest Change-Id: I61b7c576b4ae09f1a2ad6d8bf837fb01bcd49b79 Reviewed-on: https://chromium-review.googlesource.com/1153599 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#578827}
-
Vadim Shtayura authored
It is identical to the previous version (deployed in CL 1152103), except it has one bug fixed (https://chromium-review.googlesource.com/1152364). The bug shouldn't have any affect on vpython usage here. Updating it just to make vpython version be in sync with all other places. R=dpranke@chromium.org TBR=bsheedy@chromium.org BUG=821194 Change-Id: Iea7f380b4de2d01b649ce859ebf9bc222a3dd6da Reviewed-on: https://chromium-review.googlesource.com/1153586Reviewed-by:
-
Evan Stade authored
This relands commit 4480bf47. Difference to original: stop observing view on its destruction. Bug: 640365 Original change's description: > OopAsh: improve immersive fullscreen for app windows > > Immersive fullscreen for an app window almost works aside from the fact > that the normal frame remains when the app window is fullscreened. This > is a result of not updating the client area inset when the window show > state changes (e.g. from restored to fullscreen). The client area is > updated when the window bounds change, as they would when entering > fullscreen, but the bounds change comes through just before the state > change. Thus, when ClientSideNonClientFrameView checks fullscreen state > during layout, it still finds the widget is restored and calculates the > wrong bounds. The solution is to explicitly kick off a layout when > entering or exiting fullscreen. > > after launching with --enable-features=Mash --ash-dev-shortcuts > > Test: enter and exit fullscreen on an app window with ctrl+shift+F > Bug: 640365 > Change-Id: I499e29427ed072f3428de1f195ede1dc9892e71f > Reviewed-on: https://chromium-review.googlesource.com/1150618 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578353} Change-Id: I46b213a595e15d277f66cd77d1323dcf454ba8e1 Reviewed-on: https://chromium-review.googlesource.com/1153397Reviewed-by:
-
Stefan Zager authored
BUG=832498 R=davidqu@chromium.org Change-Id: I8325e427df62ed97627ba3090c70b5795a156ba8 Reviewed-on: https://chromium-review.googlesource.com/1153566 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578824}
-
