- 12 Jun, 2018 40 commits
-
-
Victor Costan authored
Add a blink analogue for net::CanonicalCookie. This is initially used by the CookieStore. Once the RestrictedCookieManager is ready, Document cookie/setCookie can be changed to it directly instead of a parallel pipeline to the browser with redundant security checks. A mojo type mapping is introduced. net::CanonicalCookie is not used directly due to std::string vs. WTF::String uncertainty, but we may revisit this in the future. Bug: 729800 Change-Id: I1492379bee98d44f13470e32da794616b905260b Reviewed-on: https://chromium-review.googlesource.com/1062599 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#566588}
-
Xiaohan Wang authored
These codecs are used to support HW_SECURE* robustness levels, and in KeySystemConfigSelector we already use "HwSecure" in many places. Note that "secure_codecs" on Android is not renamed because these correponds to ".secure" decoders. But a comment is added that all ".secure" decoders are hardware-based and support HW_SECURE* robustness levels. So they are translated to "HwSecureCodecs". Bug: 848532 Test: No functionality change. Change-Id: I7a73ff8de27e75bd3128b9e55e025db7d32e072e Reviewed-on: https://chromium-review.googlesource.com/1096681 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#566587}
-
Jacob Dufault authored
There have been a significant number of additional buttons added. Update the UI so every button is usable. Change-Id: I31b542c3e83adada2ba1c5613e5fd820df785deb Reviewed-on: https://chromium-review.googlesource.com/1086157 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566586}
-
Xing Liu authored
The current string for download location prompt didn't match the UI design, this CL changes the string. Bug: 852006 Change-Id: I69116729d5048f59ebfd82970d0b96fe8584d2b2 Reviewed-on: https://chromium-review.googlesource.com/1097563Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566585}
-
Robert Liao authored
BUG=841271 Change-Id: I39556cc73d4aa9705eed1d63e07a6e8a2c8eb726 Reviewed-on: https://chromium-review.googlesource.com/1095560Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#566584}
-
Owen Min authored
Refactor the class to move most of MachineLevelUserCloudPolicy related code into its own class. Bug: 846742 Change-Id: I7d548a1d1e96de7ebbecf48a7e4e29d1cc033c12 Reviewed-on: https://chromium-review.googlesource.com/1089922Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566583}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/82c730bf83c7..a3843c99e7a6 git log 82c730bf83c7..a3843c99e7a6 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 tsepez@chromium.org Remove some #ifdef XFA in favor of runtime checks. Created with: gclient setdep -r src/third_party/pdfium@a3843c99e7a6 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id886b5d57b0bd261c031b7d40123eceb69e0515b Reviewed-on: https://chromium-review.googlesource.com/1097381Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566582}
-
Katie D authored
The ARC++ voice is built-in, so it does not have an extension ID. It also lacks a default language. Handle voices without adefault language in the TTS settings page by adding a drop-down to select a default voice when no particular language is specified. Handle voices without extension ID by not making an empty extension ID in a voice something that keeps a match from occuring in tts_controller_impl::VoiceMatches. Bug: 850702 Change-Id: Ia06c485ee3e90b7bbb0c13bcae0a30d234e0abd6 Reviewed-on: https://chromium-review.googlesource.com/1092071Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#566581}
-
Emily Stark authored
Bug: 839969 Change-Id: Ib677bf13f737e5cc2fb5cd5b43466f2d6b796f69 Reviewed-on: https://chromium-review.googlesource.com/1096370Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#566580}
-
braveyao authored
Add waterfall config for IOSurfaceCapturer experiement. Bug: 840597 Change-Id: I7530ddb2a2b03ed8eb14a83065f197bfdfab7536 Reviewed-on: https://chromium-review.googlesource.com/1097510Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#566579}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/87386826a95f..37a0283b18a1 $ git log 87386826a..37a0283b1 --date=short --no-merges --format='%ad %ae %s' 2018-06-11 jianj vp9 svc: Denoise golden when it's a temporal ref. 2018-06-08 luc VSX Version of vp9_quantize_fp_32x32 2018-06-07 luc VSX Version of vp9_quantize_fp 2018-06-07 marpan vp9-svc: Fix to frames_since_golden update for SVC. 2018-06-08 jianj vp9 svc: clean up first_spatial_layer_to_encode. 2018-06-08 huisu Small speedup of ml_pruning_partition() 2018-06-07 jzern vp9_subtract_test,cosmetics: fix class order, casts 2018-06-07 marpan vp9-svc: Adjust some logic on gf temporal reference. 2018-06-06 lu_zero Implement subtract_block for VSX 2018-06-06 lu_zero Cast bsize as int to print a meaninful debug info 2018-06-06 lu_zero Speed test for subtract_block 2018-06-07 tomfinegan Add avx512 compile test. 2018-06-06 jianj vp9 svc: add control to set using second temporal ref. 2018-06-07 marpan vp9-svc: Allow second temporal reference for next highest layer. 2018-06-06 marpan vp9-svc: Modify choose_partitioning for second temporal ref 2018-06-06 jianj VP9 SVC: Write out svc src for all spatial layers. 2018-06-06 marpan vp9-svc: Enable use of second temporal reference for SVC. 2018-06-06 marpan vp9-svc: Add a buffer_idx is_used parameter for SVC. 2018-06-06 jingning Localize variable scope in vp9_rc_get_second_pass_params() 2018-05-24 jianj VP9: fix unsigned integer overflow in decoder. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I92492c45b6d7f13b5aa43305f5c45633a25a6191 Reviewed-on: https://chromium-review.googlesource.com/1097565Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#566578}
-
Eugene But authored
iOS 12 calls private undocumented method from NSHTTPCookieStorage, which needs to be stubbed in CRWFakeNSURLSessionTask in order to use fake task with NSHTTPCookieStorage. Bug: 851472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I59b676090786a65e902ccd98a5fea85e2b191fed Reviewed-on: https://chromium-review.googlesource.com/1097570Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#566577}
-
Andrew Luo authored
Bug: 838650 Change-Id: I40fd338c2c9586be3b780c469620dd6a741dafbc Reviewed-on: https://chromium-review.googlesource.com/1097737Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#566576}
-
Bernhard Bauer authored
Remove peeking card and other unused code. Bug: 805070 Change-Id: Ibef79b89907b6a33959d778cdd342c79db46edc9 Reviewed-on: https://chromium-review.googlesource.com/1097414Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#566575}
-
manuk authored
Inset size used to be 4 vertically and 4 horizontally, regardless of material design status. Inset size increased to 5 vertically and 6 horizontally when material design is active. Bug: 851571 Change-Id: Id53249484e69499ec3317d7ba1ced49ea8318369 Reviewed-on: https://chromium-review.googlesource.com/1097456Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#566574}
-
wutao authored
The default alignment of label was wrong. It should be always ALIGN_LEFT no matter it is RTL or LTR. The default behavior is to align left in LTR UI and right in RTL UI. Bug: 850390 Test: add new unittest: StyledLabelTest.*AlignmentInRTL* Change-Id: I058afab144acd46e221f889c57207340ef5aa26e Reviewed-on: https://chromium-review.googlesource.com/1094328 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#566573}
-
Sasha Morrissey authored
Check for canDelete capability when deleting files in the Files App. If it's blank or set to false, disable 'Delete' in the context menu for that entry. Add browser test fixtures to test capabilities are respected for the Delete option in the context-menu for read-only files. Bug: 719959 Test: browser_test --gtest-filter="Delete/FilesApp*" Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie3e604266a48223802e78f9d7255a8961ae535ce Reviewed-on: https://chromium-review.googlesource.com/1068645 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#566572}
-
Chris Blume authored
In a previous CL I accidentally removed the lines which set device_queue_. As a result, dereferencing it would cause a null pointer exception. This patch sets device_queue_ again and fixes our Vulkan tests. BUG=851749 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I69b5c8038e6b02e42a462bbaabdb24c238d184b0 Reviewed-on: https://chromium-review.googlesource.com/1096439 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566571}
-
CJ DiMeglio authored
This CL prevents VideoFrameSubmitter from accessing a bare ptr of |context_provider_| after it has been deleted by changing ptr to be a scoped_refptr. Bug: 845136 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia574a206519857ddb4169aaec281b64e3689e8ce Reviewed-on: https://chromium-review.googlesource.com/1087514 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#566570}
-
Sasha Morrissey authored
Added capabilities (canCopy, canDelete, canRename, canAddChildren, canShare) to the metadata cache for Files App. This is pre-work to grey-out drag/drop and context-menu operations based on file permissions. Bug: 719959 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If86cc407e1355aa01bd0fb1120c24da6eedee9b7 Reviewed-on: https://chromium-review.googlesource.com/1068768 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#566569}
-
mrefaat authored
WebStatePolicyDecider shouldAllowRequest needs more information to be able to determine if it should launch applications or not & to detect user intents. Created PolicyDeciderNavigationInfo and passed it from crw_web_controller DecidePolicyForNavigationAction to web_state_impl shouldAllowRequest This will make it easier to add more data through WebStatePolicyDecider::ShouldAllowRequest without changing all the places that it's used on. And it will also make the code more readable because i'll need to pass (LastUserInteraction, userRecentlyClicked and navigation_from_main_frame). bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I028b42936f3d74bae99596d31f8004db3b16ad73 Reviewed-on: https://chromium-review.googlesource.com/1092035 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#566568}
-
khmel@google.com authored
This allows to force OptIn UI show for some autotests regardless of profile/policy settings. TEST=cheets_AuthPerf.managed BUG=b/109698835 Change-Id: I82979b13924662a5dff718ef94b160291f225e33 Reviewed-on: https://chromium-review.googlesource.com/1097581Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#566567}
-
Danyao Wang authored
If a new navigation has started before |webView:didFinishNavigation| arrives, early exit and stop processing. Bug: 851708 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iea6ed9be60a547bc3fc2ee5bad6104b3a9eaef40 Reviewed-on: https://chromium-review.googlesource.com/1097564 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#566566}
-
danakj authored
It was virtual just for tests, but tests can simply call SetIsDrawble() to control the value of DrawsContent on a Layer. R=weiliangc@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I195ee17cbcc047d2baa288259f0ebcda0aed13a1 Reviewed-on: https://chromium-review.googlesource.com/1097544Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#566565}
-
Daniel Cheng authored
klast should be set to the value of the largest enumerator, not one larger. Rename it to kMaxValue as well so clang can automatically enforce this. Bug: 482580 Change-Id: Ia37ffb8bb55331f55a74832e42d146669b32e059 Reviewed-on: https://chromium-review.googlesource.com/1097584Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566564}
-
Jialiu Lin authored
For a small portion of Canary and Dev users, there maybe captured sync password hashes with no |is_gaia_passord| field. This CL finds all these entries, and set |is_gaia_password| to true, or remove them if if there's already a matching hashes with |is_gaia_password| set. This CL should not impact the behavior of Beta and Stable channel. Bug: 830998 Change-Id: I96f236a8275c8cc78316d962a4e130761a568377 Reviewed-on: https://chromium-review.googlesource.com/1096372Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#566563}
-
Kai Ninomiya authored
See gpu/GLES2/extensions/CHROMIUM/CHROMIUM_nonblocking_readback.txt for documentation. Bug: 828135 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I16d8aeb2b902629c12684317bd8cea321f2a71e4 Reviewed-on: https://chromium-review.googlesource.com/1043024 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566562}
-
Danyao Wang authored
crrev.com/c/1087640 changed |webView:didFinishNavigation| to use navigation item in NavigationContext instead of self.currentNavItem, but missed the fact that WebUI navigation didn't set navigation item in NavigationContext. This fixes a crash caused in loading WebUI. Bug: 851969 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I57278078fad7abc7e14548ca52c03a573afa2f75 Reviewed-on: https://chromium-review.googlesource.com/1097607Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#566561}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=stevenjb@google.com Change-Id: I019c01fabfab58858ef7fd031a7392573ac39067 Reviewed-on: https://chromium-review.googlesource.com/1097622Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#566560}
-
Xiaohan Wang authored
- Move KeySystemProperties::GetSupportedSecureCodecs() from being Android-only to being available on all platforms. This is in preparation of supporing hardware secure codecs on Windows. - Also make hardware secure codecs handling logic in KeySystems available on all platforms. - Add more test cases related to hardware secure codecs. Bug: 848532 Test: Existing test enabled on more platforms; new tests added. Change-Id: I6e6ceb6299f59f49483ca8cb1d287498aa97a7be Reviewed-on: https://chromium-review.googlesource.com/1096356Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#566559}
-
Daniel Rubery authored
Adds field "content type" to LoginReputationClientRequest, and populates it using the MIME type of the web contents. Bug: 799227 Change-Id: I9c09e3e143ba9aa331613c24482d742fa51d1bba Reviewed-on: https://chromium-review.googlesource.com/1096407 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#566558}
-
Will Harris authored
BUG=767906 Change-Id: I6ee1d00152a67f751f299ebc63ed912dc29aba5c Reviewed-on: https://chromium-review.googlesource.com/1091393Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#566557}
-
Navid Zolghadr authored
Add a new version of scrolling metrics with even higher maximum to accomodate for low end devices. Bug: 849735 Change-Id: I29296c7a2ce6fcfad831b9f5fe81a86cdb759e28 Reviewed-on: https://chromium-review.googlesource.com/1095416 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#566556}
-
Chris Blume authored
Different translation units were seeing different structs holding the Vulkan function pointers. This was because those different translation units may or may not have had the Vulkan platform define set. This means one translation unit saw a struct which contained an Android-specific function pointer. Another translation unit saw a struct which didn't have that function pointer. The function pointers were being clobbered as these different translation units attempted to fill in the struct. This patch will set the Vulkan platform define in BUILD.gn so all Vulkan translation units have that define set. BUG=851718 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idb56c9caaeaf9ac8351cd58fb9c70877cc909487 Reviewed-on: https://chromium-review.googlesource.com/1096373 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566555}
-
Niels Möller authored
Needed for webrtc cl https://webrtc-review.googlesource.com/c/src/+/81240, which replaces plain enum by enum class. Bug: webrtc:7660 Change-Id: I1063b6cfc136c1a83e8972736440b68c58eceab6 Reviewed-on: https://chromium-review.googlesource.com/1096771Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566554}
-
Xianzhu Wang authored
This is the first step of refactoring raster invalidator, before moving raster invalidation code out of PaintController into paint/RasterInvalidator. Bug: 843606 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0bd4b98b2ccd0e0bc6b7c87255ce81c33115a16b Reviewed-on: https://chromium-review.googlesource.com/1097507Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566553}
-
Yi Gu authored
Currently we have two paths for adding keyframe models in animation test. The one in animation_test_common.h is a legacy to accommodate for SingleKeyframeEffectAnimation. The other one is in animation_unittest.cc which supports for animations with group effects. This patch unifies the two so that we are able to test group effects. Bug: 767043 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icd839152eef6becc8aa34af3342544ae02d70f4c Reviewed-on: https://chromium-review.googlesource.com/1092871Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566552}
-
Victor Costan authored
Bug: 851064 Change-Id: I54d15696e0d676e902e7b60660536a492f67b406 Reviewed-on: https://chromium-review.googlesource.com/1093546Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#566551}
-
Mikel Astiz authored
We rename ActivationContext-->DataTypeActivationResponse to avoid confusion, and introduce a new struct (DataTypeActivationRequest) that bundles context information that is relevant during activation of a datatype. In this implementation, ModelTypeController pulls those bits from SyncService's public API, but it may make sense to instead explicitly plumb them through DataTypeManager, in future patches. Bug: 833483,820049,850428 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I91c5c3552dbd5db1c446dd6e00ef74389135af87 Reviewed-on: https://chromium-review.googlesource.com/1087062Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#566550}
-
Sebastian Amend authored
These methods aren't used anymore and are associated with types that were deleted in earlier commits: WebMediaSession was removed in 93b95f8b, WebSyncProvider was removed in c5b9f364. Change-Id: Ibbcb47cb350c2ee6be84d159c5d9be70212601da Reviewed-on: https://chromium-review.googlesource.com/1086935 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566549}
-