- 30 May, 2020 21 commits
-
-
dpapad authored
Specifically: - cr_policy_indicator_behavior_tests.js - cr_policy_indicator_tests.js - cr_policy_pref_indicator_tests.js Bug: 1000989 Change-Id: Iac363bccb89ca2508727ed8334b194dc867c60fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220280 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#773445}
-
Bryan Bernhart authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/61cddd6307ef..d385bf096f5d $ git log 61cddd630..d385bf096 --date=short --no-merges --format='%ad %ae %s' 2020-05-28 bryan.bernhart Prefer set/binding API 2020-05-28 post Document all CLI options. 2020-05-28 post Do not mask writes to remapped variables in all cases. 2020-05-27 bryan.bernhart HLSL: Add option to treat certain SSBO bindings as UAV, even with readonly. Created with: roll-dep src/third_party/spirv-cross/spirv-cross Change-Id: Id2a32278cb6ade04f96f6abbaecdc1cc69326a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223087 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#773444}
-
Albert Chaulk authored
Bug: b/156289509 Test: None Change-Id: I720b287c968e62e44f83c637be690e8e419e0b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220083Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#773443}
-
Sam Bowen authored
Bug: 1064751 Change-Id: I2c5f7b99860048359483a9a502980e5fa15651f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222731 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#773442}
-
Haiyang Pan authored
Also disabeld them in network_service_out_of_process_content_shell_test_apk The disabled tests are * org.chromium.content.browser.VideoFullscreenOrientationLockTest#testEnterExitFullscreenWithControlsButton * org.chromium.content.browser.MediaSessionTest#testShortVideoIsTransient * org.chromium.content.browser.ContentViewScrollingTest.testFling * org.chromium.net.AndroidProxySelectorTest#testSocksExplicitPort Bug: 10815149, 1081511, 1081509, 1054841 Change-Id: I84954700dbae32426f07e8e53c1676a6bc08a7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220808 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#773441}
-
Tommy Li authored
This CL simplifies the Android and iOS ZeroSuggest configuration. AFAIK, this is the desired behavior: 1. If there's a field trial setting ZeroSuggestVariant = RemoteNoUrl, and that mode is allowed, use RemoteNoUrl. 2. Default: On Android only, for the NTP, use RemoteNoUrl by default (if that mode is allowed). 3. Default: On Android and iOS, after that, fall back to MostVisited, except on the SERP. I think this CL achieves that desired behavior in a simpler way than the previous state. Bug: NONE Change-Id: I2d587653c7a23d1302820dc791e74aae54886a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174861Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#773440}
-
Sahel Sharify authored
This reverts commit 561f6a86. Reason for revert: Waiting for thread safety review of the following two classes: -PaymentDetailsUpdateService.java -PaymentDetailsUpdateServiceHelper.java Original change's description: > [Web Payments][Android] Delegation support for intent based apps [2/3] > > This cl introduces IPaymentDetailsUpdateService.aidl and > IPaymentDetailsUpdateServiceCallback.aidl interfaces so that the invoked > native app can call changePaymentMethod, changeShippingOption, and > changeShippingAddress methods to notify the browser about the user > choosing a different payment method, shipping address, or shipping > option. > > This cl implements the plumbing for sending the change events to the > merchant, but the plumbing for sending the updated payment details from > the merchant to the invoked app will be landed in a follow up cl. > > To test the feature enable "Experimental Web Payments API features" from > chrome:/flags or use the following commandline flag: > enable-features=AndroidAppPaymentUpdateEvents > > Bug: 1026667 > Change-Id: I799c9dfced15fe2fa916b8ca3634b91366cfc32f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168009 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773401} TBR=rouslan@chromium.org,mthiesse@chromium.org,rsesek@chromium.org,sahel@chromium.org,maxlg@chromium.org,bttk@chromium.org,agektmr@chromium.org Change-Id: I57a0b2a786a48af09cf8a13af23bf7efb3ffe51e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222531Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773439}
-
David Bertoni authored
These tests were disabled per crbug.com/177163, which has been fixed. These tests passed 3000 iterations on the debug bots without any issues. Bug: 177163 Change-Id: Id587800bf65b584c3563b2ad0958f5ad58d3aa84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212517Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#773438}
-
Mohsen Izadi authored
As a follow-up to r773242 which adds unit tests for Graphics.Smoothness.EventLatency UKM metrics, this CL adds similar unit tests for Graphics.Smoothness.Latency UKM metrics. Bug: 1054019 Change-Id: I69b1a8ce7c100f94806b4875a860ca278949290c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222900 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#773437}
-
Thomas Anderson authored
This reverts commit e4dbb92e. Reason for revert: Should no longer be needed after sysroot roll: https://chromium-review.googlesource.com/c/chromium/src/+/2219606 Original change's description: > Add -Wl,--allow-shlib-undefined to some executables. > > Due to https://reviews.llvm.org/D80059, a hack for unversioned libdbus symbols > no longer works. This adds --allow-shlib-undefined for the dependent > executables when llvm_force_head_revision is enabled to green the ToT bots. > > Bug: 1086636 > Change-Id: I78a5d1a56953c1a5cb5694f299080bdeee0726d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220350 > Commit-Queue: Amy Huang <akhuang@google.com> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772912} TBR=thakis@chromium.org,akhuang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1086636 Change-Id: I3e9bcea3eea6e881f66b4822e2750d1fccdd4516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223011Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#773436}
-
wutao authored
This scope is required to access backdrop service. Bug: b/148692733 Test: manual Change-Id: I2e9767cdae57b0164dd59ed6267752d2a033917d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222911Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773435}
-
Mitsuru Oshima authored
Bug: 1082989 Test: no functional change. Two tests were removed because test was wrong. Other tests should still pass. Change-Id: I8c296586914eb3f9ff713296cd741f30ad49d2c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216889Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#773434}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d5be5daff9f5..b19e1213cf6f 2020-05-29 iannucci@chromium.org [led] Update to latest version. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1015181 Tbr: agable@chromium.org Change-Id: Id16e7714cb576c9e1747bc4d04f7703b06487f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223122Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773433}
-
Thomas Guilbert authored
ImpressionFromCrossOriginSubframe_ReportSent is flaking on windows. TBR=johnidel Bug: 1087406 Change-Id: Id01ddb66951f3c1b6f509ba131eb38fc901afa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222917Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773432}
-
Joel Hockey authored
FilesApp does not currently refresh Linux files when there are changes since the sshfs fuse mount does not support inotify. These APIs will be used by FilesApp to fix this. Bug: 846190 Change-Id: I75ec05890a4e2a37341e831ab1b3caad06acd26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215395 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#773431}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f2ea618e6ba4..808557b0b09e 2020-05-29 jalyn@microsoft.com Fix sources sidebar expansion issue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1085399 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic499453be19aa5da54c80767b5679bfd84f2d65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223121Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773430}
-
Ben Pastene authored
Bots are old & unwatched, so I'm just removing them. Bug: 1088077 Change-Id: Ic5584f70854d42f060a63097e0c823bbd526b4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222973Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#773429}
-
Joel Hockey authored
FilesApp does not currently refresh Linux files when there are changes since the sshfs fuse mount does not support inotify. These APIs will be used by FilesApp to fix this. Bug: 846190 Change-Id: Ied65d88daaab7bc6e6723644a36c03385cbaf250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215783 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#773428}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/772196e5..6c4ceefd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If2083c84fa5d9694b0e1780ccf67044257c6f7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223023Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773427}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/4f220d625fab..9f4be0e52d52 $ git log f7fcc27f2..9f4be0e52 --date=short --no-merges --format='%ad %ae %s' 2020-05-25 joelhockey system_api: add AddFileWatch APIs and Signal for cicerone 2020-05-26 kerrnel debugd: Add core isolation policy for supported kernels. 2020-05-13 abhishekbh vm_tools: Add support for privileged containers 2020-05-27 akhouderchah shill: wifi: Remove unused "preferred device" functionality 2020-04-27 yichengli u2fd: Extend and reorder webauthn API error codes Created with: roll-dep src/third_party/cros_system_api Change-Id: I43ec8a25756291c226776c2690ffd97ef59d71cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222086Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773426}
-
Kyle Horimoto authored
This ensures it is the top Wi-Fi related result. Bug: 1088058 Change-Id: I7f61b43422de26923d769e9a8f24cbd06ca06fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223006 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773425}
-
- 29 May, 2020 19 commits
-
-
Yulun Wu authored
The shelf auto dim handler should observe the shelf's auto hide state to handle opacity adjustments and should not be done explicitly by ShelfLayoutManger::SetState(). Bug: 1086632 Change-Id: I719b08243ed560f7aa6fd886e639ad6904e7ab90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216698Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773424}
-
Muyao Xu authored
Parse universalAppId and appType in RECEIVER_STATUS and send data to the cast SDK Bug: b/152414652, 1081523 Change-Id: I70666c13eb47bff761b68fc1ef62ea63727621a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196806 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#773423}
-
Bo Liu authored
When fragment is retained by activity is recreated on rotation, ContentViewRenderView is recreated and the same WebContents is moved to the new CVRV. CVRV.setWebContents is called on the new CVRV before its first layout, which means it still has size 0x0. This causes a momentary resize of the WebContents to 0x0 before being resized again to the correct size. On complex websites, resize and relayout is expensive, and this extra step does add up to the latency on rotation. Just check for 0x0 in this case, and skip the resize here. Bug: 1084500 Change-Id: Idea96b8df53e29338af4c1d91851a69ddad8f45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213076Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773422}
-
Kelvin Jiang authored
This test was run at least 1000 times and no flakes have been observed. Since the test code has changed as well, the test has been re-enabled to see if it is still flaky on the trybots. Bug: 1070344 Change-Id: I5350fe9292dbcb77ea8ddc6c230c1cec3b4e0378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219368 Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773421}
-
Joey Arhar authored
This bug was caused by crrev.com/c/2212458 because it allows async form navigations to outlive the document which initiated them, because it is stored on the target frame instead of the initiating document. This means that crrev.com/c/2212458 did technically change this behavior, however, I don't think this is an issue because: 1. It is very racy to observe. The clusterfuzz test case appears to repeatedly reload the page very fast, and it takes several loads before the state where the async form task outliving the initiating document occurs. 2. This matches the behavior we used to have at the beginning of 2019 before sync form submissions, which means that it wasn't a problem for websites a year ago. The reason this null object deference was hit is because it was added after sync form submissions. If the sync form submission change never happened, then this same clusterfuzz bug would have been raised by http://crrev.com/c/2090095 You can see other uses of origin_document->GetFrame() in the same function check if GetFrame() is null before using it, probably because they were written before the sync form submission patch. Due to the racy nature of this bug, I couldn't think of a test case which would reliably reproduce it. Bug: 1088006 Change-Id: Iec2b182196a1d3adde57c23c65195def5d37a39a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223009Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#773420}
-
Alex Moshchuk authored
Somehow, we're providing both a main frame routing ID and a proxy routing ID to the CreateView IPC. Try to catch this condition earlier and add crash keys to understand this further. Bug: 1020957 Change-Id: Ie5cc34fd0c0540569e3bd5a806a80bf7b2d323b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222906Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#773419}
-
Kevin Marshall authored
Views for ScenicWindows are now initially transparent, and presentation of the window is deferred until page rendering is started. This gives embedders greater control over how web contents should be initially rendered. Bug: 1073445 Change-Id: I12799c9082d7df273c9918482f87b7ce6c271622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222907 Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773418}
-
Joel Hockey authored
Now that we support tabs in apps, FEATURE_TABSTRIP is the correct way to determine if a browser has tabs. Bug: 1078907 Change-Id: Ia977b9df45a63eb08156673db858c053513dfe18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222075 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#773417}
-
Clark DuVall authored
These are the last couple simple dependencies for the more complex classes in chrome/browser/ui/blocked_content. Bug: 1084013 Change-Id: Ie02279e4f879fdaf626379579e2c57eda7f2efe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219602Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773416}
-
Chong Gu authored
Bug: 1087298 Change-Id: I79e4de2422cf103e68a482752b75bccf56c9754f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222864Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#773415}
-
Regan Hsu authored
* On attached(), the subpage listens for any DLC state changes from DlcHandler, and if there are, will update the displayed DLC list * DlcHandler observes for any DLC state changes from DlcserviceClient, and if there are, it fetches the latest DLC list from DlcserviceClient and notifies DlcSubpage with the latest DLC list with updated metadata * Adds unit test for DlcHandler being notified and sending the dlc list * Modifies fake_dlcservice_client for testing purposes Bug: 1070712 Change-Id: I06722e0c443d479ab0267a626e60ca306563d98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220633 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#773414}
-
Mohsen Izadi authored
This CL adds all the remaining event types we are interested in except for gesture-pinch events: GestureDoubleTap, GestureLongPress, GestureLongTap, GestureShowPress, GestureTap, GestureTapCancel, GestureTapDown, GestureTapUnconfirmed, GestureTwoFingerTap. The metrics are added to both UMA and UKM. The UKM collection request has been approved here: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit# Bug: 1075725 Change-Id: I8c78c9dd9388306e1949276a66343414741cae9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194294 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#773413}
-
Ovidio Ruiz-Henríquez authored
This change updates the BluetoothAdapterWinrt::OnAdvertisementReceived() method to call BluetoothAdapter::Observer::DeviceAdvertisementReceived() in order to notify clients that want to know about device advertisements. Bug: 654897 Change-Id: I4805a00e4a7407bde9a613f3685dc0381ae3b425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187032 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#773412}
-
Dominic Mazzoni authored
Original: http://crrev.com/c/2211123 Reverted: http://crrev.com/c/2213553 The underlying issue that caused the crash was that we were trying to send a TTS event while a Profile was being deleted. In the first patch I tried to work around that and it added complexity. In this new patch, there's a simpler solution: just use PostTask to call Stop() - that way the Stop doesn't happen until the Profile/BrowserContext is fully deleted. Bug: 1081350 Tbr: jam@chromium.org Change-Id: I4ce09a2cde3ef5fec93f73d723d9ec585e4c5815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218725 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#773411}
-
Renjie Tang authored
Bug:1087646 Change-Id: If4e49aa2572ddc81c4487713368fbfb57689ae51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219603 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773410}
-
Kyle Horimoto authored
This ensures that it is higher than other device results. Bug: 1088058 Change-Id: Ie811c277a364470734f3f647cea4c849447d47eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223008 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773409}
-
Kyle Horimoto authored
Bug: 1088058 Change-Id: I4e4c72eca49035c4ad7bb1768b685b8fbbc0e67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222695 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773408}
-
Kyle Horimoto authored
This ensures it is displayed before the other Linux-related results. Bug: 1088058 Change-Id: Id71891982b9f83ae8a86e62825aeae1dc0ab990f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223004 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773407}
-
Alexander Cooper authored
Now that the XR Consent Flow has been removed, nothing checks this flag (disabling it for tests) anymore. Remove the flag and the only place that set it. Bug: 1064384 Change-Id: Ie8568324c45288d7055a510b211290d6e2696699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220227 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#773406}
-