- 05 Feb, 2020 40 commits
-
-
Adrienne Walker authored
This test has been disabled due to 747589, and so it was using deprecated RunLoop constructs that DCHECK when running. For now, this test is still deprecated because it might be flaky. I will followup and turn it back on separately in case it gets reverted again. I am trying to get this test running again to test changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2020533 Most of the changes are fairly straightforward to use RunLoop Quit() as callbacks to quit running instead of RunUntilIdle. The tricky part here is that this test now crashes because QuotaManager kicks off a task in NotifyStorageModified that runs after the test has been torn down: [204729:204736:0204/170817.027368:1900997872433:ERROR:database.cc(1584)] Quota sqlite error 1032, errno 0: attempt to write a readonly database, sql: INSERT INTO OriginInfoTable (used_count, last_access_time, origin, type, last_modified_time) VALUES (?, ?, ?, ?, ?) [204729:204736:0204/170817.027526:1900997872589:FATAL:database.cc(1597)] attempt to write a readonly database To avoid this, a new function to turn off the QuotaManager database is added for testing. Bug: 747589, 1015214 Change-Id: I98d07ffc62e0ff8047da3e994fbf40728f0972bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038133Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#738607}
-
Alex Khouderchah authored
This CL clarifies that {Included,Excluded}Routes can be used for any network Type and describes the default routing behavior for each Type. Bug: 1038601 Change-Id: Ibb1cf5fba164f416b31f3b22d81c4105639839da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037318 Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#738606}
-
Wenyu Fu authored
Update the HomepageSettings UI to the radio group style when homepage conversion flag is enabled. Change-Id: Ic5d707de0a32bb0715518953bbc6286c0ec0a2da Bug: 1036470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015552Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738605}
-
Alfonso Garza authored
params. crbug/1046559 Submitting without tests as emergency fix and bc the bridge does not have existing tests will take a little longer to get together. Bug: 1046559 Change-Id: I3a71ce1c772102940596643d657e9532a62423d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038170Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#738604}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ib43108417a9889af53b0550bc6c8d0dd5648dba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039091Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738603}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/51b5640863e8..a0eb8359beb5 Created with: gclient setdep -r src-internal@a0eb8359beb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049070 Tbr: jbudorick@google.com Change-Id: I217d90ed748acdea9279cd4f38809ddbd1fc13e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039002Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738602}
-
Mitsuru Oshima authored
* Fix EventGenerator so that GestureTapDownAndUp and Scroll methods works on external display. * Changed the test harness to use the EventGenerator which is much closer to how home button works. * Updated AppListTest to use MoveMouseTo and the global event generator. Bug: 1042754 Change-Id: I33e9696960cd990512847a54a7e487098d73d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008130Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#738601}
-
Adam Langley authored
M81 has now branched off, so this change is targeted for M82. There are known incompatibilities (see bug) and several sites have been contacted. Having the breakage be clearly obvious on dev and beta will help to demonstrate the issue. This change also adds a control in about:flags to make testing easier. Bug: 1028602 Change-Id: I306e28350e9dfaa0235c8f10e9b06e0cd9db93d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035861 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#738600}
-
Annie Sullivan authored
Change-Id: Ieb31ef6a9a4409f51547ba635244b4f8e2ecc787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036554Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738599}
-
Lei Zhang authored
Filter out potentially more potentially problematic characters and replace them with underscores. Bug: 1041897 Change-Id: Ib3286474f41212c9a4cf7607ca9485324fff3742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038254Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#738598}
-
Joe DeBlasio authored
This CL makes MIX-DL blocking check the appropriate site setting for permitting mixed content. This allows controlling MIX-DL blocking with the "Insecure content" site setting, which can be set with the InsecureContentAllowedForUrls group policy. Bug: 1041695 Change-Id: I6e20ddc827a4034259ea6790965232af860c2292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036639Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#738597}
-
Xing Liu authored
Recently there is an icon id change in modern_list_item_view.xml, which triggers a crash when opening the download location spinner. This CL adds a test to open the spinner. Bug: 1048216 Change-Id: Id6accd7ce72737e8e0ab36ffdd5e4fd2a1af1c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036938Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738596}
-
Julien Isorce authored
The signature of ui's gl::GLImageGLX has changed a little bit since "mplement GpuMemoryBuffers for EGL and GLX": https://chromium-review.googlesource.com/c/chromium/src/+/1984712 Bug: 1031269 Test: build with use_vaapi=true and run with --use-gl=desktop, see Change-Id: I80b07294b9abdfa8233aaf79f7d9ec4c58117090 https: //chromium.googlesource.com/chromium/src.git/+/refs/heads/master/docs/gpu/vaapi.md#vaapi-on-linux Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036494Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#738595}
-
Eric Seckler authored
The deprecated TRACE_EVENT_ASYNC* macros have been superseded by TRACE_EVENT_NESTABLE_ASYNC*. Part 2, another event was added recently. Bug: 1038710 TBR: vmpstr@chromium.org Change-Id: Ic8e1e8b2e479bbd5f7f590f5b30123d1e5dff63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038735Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#738594}
-
Christopher Cameron authored
It used to be that setting the contents of a CALayer to an IOSurface that has an HDR color space, and setting that the CALayer wants extended range content was sufficient to display HDR content. This was an undocumented behavior, and macOS has recently fixed it (made it not work). The documented way to get HDR is to use a CAMetalLayer. Unfortunately, one cannot call setContents (or provide a pre-existing IOSurface) to this API. As a consequence, we need to perform a copy from the IOSurface to the CAMetalLayer. Add HDRCopierLayer subclass of CAMetalLayer, which overrides setContents to blit the specified contents to the CAMetalLayer. Add tests for this. It appears that the test suite is not running, because most of the tests are broken. Fix all the tests (next step there is to add them to bots, but that will get a separate patch). This was previously landed as crrev.com/737885 and reverted because of failures on 10.10. This re-land links using -weak_framework. Bug: 976426 Change-Id: Ie3bf8438770dc58e19b1401a54356693fc22274a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038172Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#738593}
-
Austin Eng authored
virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html and virtual/android/fullscreen/video-scrolled-iframe.html are causing flaky timeouts. TBR=nator@chromiun.org Bug: 1049138 No-Try: true Change-Id: If30b1c39d7b73354e782458c924708bc820934c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039143Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#738592}
-
Ian Kilpatrick authored
Simplified layout DCHECKs save the day again! We need to clear all cached layout results when scrollbars change. As we now have the "measure" cache slot it was possible to keep around a layout result with the incorrect scrollbar state. The bug caught on the trybots manifested as layout result having "simplified" layout performed, but failing as the inline-size of the fragment changed during simplified layout. Clearing all layout results when scrollbars change fixes this class of issue. Bug: 845235 Change-Id: I627eab1be0adacad27668fc087fb64446a70b95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037729 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#738591}
-
danakj authored
Main frame RenderWidgets are now owned by RenderFrameImpl just like child frames' are. R=dcheng@chromium.org, haraken@chromium.org Bug: 419087 Change-Id: I4f02f1b4c71299cc2f37f9249b3cc84b3662ed11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038720Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#738590}
-
Changwan Ryu authored
Add an option to inspect system wide profiling (as opposed to profiling one app and one activity). Bug: None Change-Id: I4c1b5e98494216f3912932d141db9ae4a3433d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037023 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#738589}
-
dalyk authored
This change introduces a toggle and radio buttons that are shown when the toggle is enabled. Future cls will introduce a dropdown menu and text field alongside the second and third radio buttons, respectively. The visibility of the setting is controlled by a new param, ShowUi, associated with the DnsOverHttps feature. The new param currently defaults to false. Change-Id: I9d9322cbdf64f9d66cd744de01829300446b8896 Bug: 1040145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980480 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#738588}
-
Dave Tapuska authored
Move this binding into where the LayerTreeSink is created and pass the result in the callback along with the LayerTreeSink. Change-Id: I42ed0ae21316fda8974acbe85994bca62480b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036434 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#738587}
-
Michael Ershov authored
Bug: 1045895 Change-Id: Ide014c5da95fe20847ea226ca9590e8884026ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038694Reviewed-by:
Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
-
Leonard Grey authored
Turns out this actually matters in Mojave (but not Catalina). Bug: 1032704 Change-Id: I31dbf8fd0d7c6c1f99ab227a3c7158d8c64db89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962649 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738585}
-
Nazerke authored
This CL removes public properties for WebStateList, BrowserState and dispatcher values and updates the coordinators implementation to get them from self.browser. The refactored coordinators: - Adaptive Toolbar Coordinator - Primary Toolbar Coordinator - Secondary Toolbar Coordinator. Bug: 1029346, 1047873, 1048663, 1048674 Change-Id: I228ac98252cb315e84914bc5d5539168260b8faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013280 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#738584}
-
Rayan Kanso authored
The handler can now support checking for different types of digital asset links, including web targets. Also includes some minor stylistic improvements. Bug: 1043970 Change-Id: Icb651573a98201c810e53f74cea91a225a48cac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037673Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#738583}
-
Daniel McArdle authored
Also modifies DecodeBcd() to handle invalid inputs (and removes DCHECKs), since the inputs may come from an untrusted USB device. Change-Id: I387ec1fe51b6916fe7c097123936991d67f228aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033850 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#738582}
-
Stepan Khapugin authored
Moves the implementation of BrowserStateStorageSwitching to BrowserViewWrangler and inverses the dependency so that MainController now needs BVWrangler to switch contexts. This makes sense in multiwindow world where BVWranglers are per-scene. Bug: none Change-Id: Idd9b76480c425a3508a476438126b656bf362cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036007Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id796443dbafb55b857f04a2e3204e3ce58c2478d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038721Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#738580}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c631b7cc5f8c..c61d7e3d6e12 git log c631b7cc5f8c..c61d7e3d6e12 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 egdaniel@google.com Rename various getters related to GrSurfaceProxyView. Created with: gclient setdep -r src/third_party/skia@c61d7e3d6e12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I2175ef10442a2bf2c7c0cbdda033d470ad891d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738579}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f50e6be1c2a..51b5640863e8 Created with: gclient setdep -r src-internal@51b5640863e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045478,chromium:1049064 Tbr: jbudorick@google.com Change-Id: I6f3f2a830d1659c437f88bc18f9d5a9477e4b470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039033Reviewed-by:
-
David Tseng authored
Bug: 1047069 Test: manual (there isn't an easy stable way to test this in either js or interactive ui tests). Change-Id: Ia91a585ec314066a4cceea244e4872a15598cc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037731Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738577}
-
Zhenyao Mo authored
The data is then send back to browser process. This CL only adds mojo links. No data actually collected. Bug: 1039792 Change-Id: I11b1cb9876ebaff2b5fe164db476549e682412e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031857Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738576}
-
Paulo Warren authored
This CL incorporates new behavior into the wayland base client for testing udmabuf_create on the server side. If memfd_create succeeds, the client allocates a memory region using memfd_create instead of the chrome SharedMemoryRegion class. The returned buffer is page aligned, and sealed with F_SEAL_SHRINK due to the requirements of udmabuf_create on the server side. TEST=autoninja -C out_atlas/Release/ wayland_simple_client then scp the client to an atlas chromebook. To run add --use-dmabuf flag. BUG=None Change-Id: I27f6f04c1d577e172bbb68bd09718e6f0d6d65f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003267Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Paulo Warren <pwarren@chromium.org> Cr-Commit-Position: refs/heads/master@{#738575}
-
Elly Fong-Jones authored
This change moves these tests from Mac-only to all Views platforms, although they are currently disabled on Windows & Linux because of the linked bug. To do this, the tests are rewritten to use Views APIs rather than directly using NSWindow, and PermissionRequestManagerTestApi is modified to deal in Widgets rather than NativeWindows. This change also removes PermissionBubbleViewsInteractiveUITest, which was an incomplete copy of PermissionBubbleInteractiveUITest dating to the initial MacViews secondary UI work, and also has never run on any non-Mac platform. Bug: 866878 Change-Id: Id0cbf5e2e1ec54afed57fd74e2c4380c1003de40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038157Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738574}
-
Takuto Ikuta authored
This is to take crrev.com/c/2038910 Bug: 984869 Change-Id: Id41f3e6c499a6f9d0c849eb1447a6c9982399c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038911 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738573}
-
Liquan (Max) Gu authored
Context: PaymentRequestEvent.OpenWindow() promise should be resolved to be a window client. With ExpandablePaymentHandler enabled, OpenWindow is never resolved. This makes a payment app service worker fail to send a message to the payment app js since it relies on the resolved WindowClient. Before Change: With ExpandablePaymentHandler enabled, PaymentRequestEvent.OpenWindow() is never resolved. After Change: With ExpandablePaymentHandler enabled, OpenWindow is resolved upon initializing the WebContents of PaymentHandler. Change: Notify ServiceTabLaunch when Expandable PH UI has initialized WebContents, so that ServiceTabLaunch can resolve the OpenWindow() promise. Bug: 1045955 Change-Id: I3fae5f90d144d27e97044f175478072743de05aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037643Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738572}
-
Henrique Nakashima authored
Register it in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I809b408ce2d18a725cacfa876b7c906f471e6d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028122Reviewed-by:
-
Mark Schillaci authored
This CL addresses a regression that appeared as part of the change: https://chromium-review.googlesource.com/c/chromium/src/+/1998829 This CL fixes backwards navigation by granularity of line or word which was not announcing any traverse events due to a bug in the above CL. Bug: 1048246 Change-Id: I128f5e532bf6a6212daae41eb4d571fa7f10bdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037454Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#738570}
-
Tim van der Lippe authored
These need to be disabled for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2035936 to land Bug: 1006759 Change-Id: I021ce279a6bc4a586179eef36a2bfcc22972ec14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038730 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#738569}
-
ckitagawa authored
Adds support for paint previews to capture OOP subframes. This essentially mirrors the established path printing uses, but differs in that is uses Mojo and embedding tokens rather than IPC and routing ids. Part of landing: crrev.com/c/1786583 Bug: 1011828, 1014955 Change-Id: If1593ec23c66d9fd9e8b49aef6dde063e17ffa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985812Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#738568}
-
