- 03 Dec, 2020 40 commits
-
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=Diagnostics* Change-Id: I01ae7a5565df32b6ab555a9edbf7fcebdc298c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572000Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#833492}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30bf3b85f1d9..38f2fff09dac 2020-12-03 brcui@microsoft.com Fix bad XML in accessibility_strings.grdp 2020-12-03 vidorteg@microsoft.com [Loc] Migrate media panel to Localization V2 2020-12-03 patrick.brosset@microsoft.com Flex: Remove temporary support for non-baseline flex overlay backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1139949 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4ad2f9ba77cfe2607a8280899f58f80e6083aafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572126 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833491}
-
Karandeep Bhatia authored
This CL implements evaluation of session scoped rules. Follow-ups: - Shared rule limits with dynamic rules. - Raise error on regex rules which exceed memory limit. Skipping presubmit since this seems to be hitting crbug.com/956368. BUG=1043200 No-Presubmit: True Change-Id: I8ac39f3fba702896a2ff291e476285b49a37cce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548270 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833490}
-
Michael Bai authored
The query starts from AutofillHandler, there is no functionality change since WV/WL doesn't instantiate DownloadManager. Bug: 1151542 Change-Id: Ifccce22515ae2faef48fed6445a61bd415d51e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570307 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#833489}
-
Norman Rosas authored
and removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I973977578df209d21fab6983dbc3e09d02056453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573128 Commit-Queue: Norman Rosas <normando@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Norman Rosas <normando@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#833488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46092e95a4ec..ba66a670730d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbergquist@google.com,sebsg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tbergquist@google.com,sebsg@google.com Change-Id: Ifc61c20c9714f6152751f944b30ea034bacc891d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572360Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833487}
-
Nick Diego Yamane authored
R=sky@chromium.org Bug: None Change-Id: If56f5d55e63a1456c2c66ee476f1b14a4ee03e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571808 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#833486}
-
yilkal authored
This cl ensures that that the auth headers are sent only to the families.google.com servers for the EduCoexistence flow. Bug: 1155252 Change-Id: Ia07b16d32c865052d7c30f23401cbfafdd6f4e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572596Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#833485}
-
Peng Huang authored
Also set PresentationFeedback from CompleteNotifyEvent properly. Bug: 2561401 Change-Id: I0b77dcb6664860aac78e1187ae4faf599720e320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572043 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#833484}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9901ec70fa0e3ca748d50191af57e7a7e343b788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833483}
-
Joon Ahn authored
Bug: 1125150 Change-Id: Ic34f9545bceb90c6a2a0f8a63c0914a49870ca88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572678Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#833482}
-
Victor Vasiliev authored
Change-Id: I3cfb0db37a10d5e0d80c0b1103a4b2100f1878de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572198 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833481}
-
Victor Hugo Vianna Silva authored
This is a reland of d2746236 Original change's description: > Remove unused */render_tests/*.sha1 > > The associated render tests now use an online platform to check for the > expected image (https://chrome-gold.skia.org/). All these hashed images > are doing in the repository is confusing developers who are new to > render tests, so let's remove them. > > Bug: 1103836 > Change-Id: Iaa541f22e6ba9002fadaae99b99d9003e4b7f5c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566796 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833249} Bug: 1103836 Change-Id: Ic2a98dca027d5acfdb9b624045aefb5d24b8f135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569518 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#833480}
-
Robert Sesek authored
Bug: 1153883 Change-Id: I400faeb7b7c1684dfe7a64812ae446f7beaaf74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571800Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833479}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606996231-faa54c695225bf8f6afffc1841d10967281c359d.profdata to chrome-win64-master-1607007593-3407e023275e887982890e083190cec03a46fa25.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9eeb00a730f3bd94dc54b9005d4a19c3adca5ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833478}
-
Robert Sesek authored
Bug: 1153883 Change-Id: If50e63050b90f4a35b9c286180c6e1a91c10ca6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571639 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#833477}
-
Lin XInan authored
BUG=chromium:1153349 TEST=./main.star Change-Id: I83fc4424e3a111511f949cd68ba285b34e96d128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571809 Auto-Submit: Xinan Lin <linxinan@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#833476}
-
Robert Sesek authored
Bug: 1153883 Change-Id: I854f878aad5ee258c4dbfb851059d3bc3bfa58ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571811Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833475}
-
Gavin Williams authored
Show the dialog when a scan job fails. The app returns to READY state once the dialog is closed. http://screen/6CS5wL2BB7v429a Bug: 1059779 Change-Id: I937209ca0caf13bb00d0731248fe0d5bd991687c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570411 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#833474}
-
Fabian Henneke authored
Android's Autofill framework interacts with Chrome via an Accessibility- based compatibility bridge. In order to allow it to see (and thus offer to save) unmasked passwords, these need to be exposed to Accessibility services. However, since Android O the policy for password fields is to preserve their current masking state in all matters related to Accessibility. With this change, passwords will be exposed to Accessibility unmasked if the only consumer of Accessibility information is the Autofill framework's CompatibilityBridge. As the bridge hooks directly into the AccessibilityManager via an AccessibilityPolicy, this situation can be detected easily by checking that the ENABLED_ACCESSIBILITY_SERVICES setting is empty. As a result, third-party Autofill services can save passwords in Chrome if the user does not have any Accessibility services enabled. These services can reliably check for this situation in the same way as done in this change and thus selectively offer save flows when they now the password will be unmasked. Bug: 1151614 Change-Id: I4644c977f65bf31fa4e1daa76a1e5d55cd0adada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552791Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Fabian Henneke <fabian.henneke@gmail.com> Cr-Commit-Position: refs/heads/master@{#833473}
-
Piotr Bialecki authored
ArCoreDeviceProviderFactory & related classes are no longer needed & have been removed in this CL. This also simplifies provider installation logic. Change-Id: I6a8ea6004408ef55eddadcefe753d8fe8d869367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567502Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#833472}
-
minch authored
Add a "force-in-tablet-physical-state" switch to force tablet physical state so that auto rotation is on regardless of the actual physical state. Bug: 1122138, b/169636434 Change-Id: I7ab6f57bc670f5ba17f6fb2f08aea16e072f0fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524120Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#833471}
-
John Lee authored
- Add more gridcell elements to show that the grid has two columns: one for the bookmark metadata and one for the more actions button. - Move role="row" to the item so that when focus moves to it, the screen reader can read out its aria-selected attribute. - Add aria-multiselectable to the whole list to allow screen readers to read that the user can select multiple items in the list. These aria attributes seem to be very buggy on multiple screen readers, but this follows the accessibility spec's guidelines and has no regressions from the previous setup. Bug: 1142080 Change-Id: Iddb7eaa68dd357e2b8f48e5d33d9fdf9a93223c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566595 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833470}
-
Illia Klimov authored
This CL reduces call sites for ContentSettingsType::PLUGINS. Bug: 1149393 Change-Id: If59590e43aa54066fde60603c30b0cfec9c66658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569737 Commit-Queue: Illia Klimov <elklm@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#833469}
-
Titouan Rigoudy authored
This does not seem to have a bearing on the test results, but it does simplify my mental model of what requests are getting UseCounted. Bug: chromium:1142865 Change-Id: Ie3ff28dabb1e521df384f99ad12399c46a8d9273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517731 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833468}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3dba3ee4654f..5f9ba6953f8d 2020-12-03 reed@google.com fix debugger bindings 2020-12-03 mtklein@google.com add to_fp16/from_fp16 2020-12-03 mtklein@google.com add load64 2020-12-03 reed@google.com deprecate getTotalMatrix 2020-12-03 tdenniston@google.com [svg] Remove kInherit from several SVG types 2020-12-03 fmalita@google.com Revert "[skottie] Add image sampling and transform options" 2020-12-03 johnstiles@google.com Simplify InterfaceBlock by removing multi-dimensional array support. 2020-12-03 csmartdalton@google.com Plumb mixed samples through GrXPFactory::GetAnalysisProperties 2020-12-03 johnstiles@google.com Simplify VarDeclaration by removing multi-dimensional array support. 2020-12-03 johnstiles@google.com Disallow multi-dimensional arrays in SkSL. 2020-12-03 johnstiles@google.com Disallow returning array types in SkSL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Ib5f73226788ee9d9c50fb6e85c9514adc35391c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833467}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/877fbcb69179..8ddf5ae4b8a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ied6a0b0bb01499de329d0f1d2a14f07ec8e5895f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833466}
-
Kartik Hegde authored
Tests for successful UDP and TCP connections to a STUN server and whether several Google media hostnames are reachable. BUG=b/172994051 TEST=unit_tests --gtest_filter=VideoConferencingRoutineTest.* Change-Id: I64d2784c3b3ae111c9e924b1296a5463dcb7cea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535997 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#833465}
-
Titouan Rigoudy authored
This version tests each local scheme and root address space separately, which hopefully makes for more readable tests. The duplication of the inline scripts is unfortunate, though no worse than before, and might be the object of a follow-up cleanup CL. Replace uses of `auto` with explicit types along the way, to align with style guide recommendations. Bug: chromium:1136028 Change-Id: I697d2dac8ef82ac332b2564c753a1a338b520d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566940 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#833464}
-
Aleks Totic authored
LayoutNGTableColumns do not generate fragments. This triggered a DCHECK at LayoutObject::AssertClearedPaintInvalidationFlags when running with NGFramentation flags. Fix is not to trigger DCHECK for TablesNG column. Bug: 958381 Change-Id: Ic5a665228044c32e8e921d97792f7c1cffdf5d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570734 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833463}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1093185 Change-Id: I33b1825792b33cf0034513bf5ba3932fd5bbf6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568164 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#833462}
-
Gary Tong authored
Change-Id: I5d7699f0892b4236532536b770805711518cbfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570738 Auto-Submit: Gary Tong <gatong@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#833461}
-
Erik Chen authored
Linux-chrome (of which lacros is a variant) has its channel set as a runtime environment variable by the launcher script. For Lacros, we must set the environment variable from ash. For now, we always set "dev" for all builds of Lacros. Change-Id: I840286b6fd5772701c3f6d927986405697b82097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570448 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#833460}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/48b4a74d6b80..12b95e78a4d5 2020-12-03 jophba@chromium.org Add JSON schema validation (using valijson) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I9e8faf840da0f4fed3312a54a932cb2964a287e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833459}
-
Jeffrey Kardatzke authored
This adds handling of CENCv1 (full sample encryption) streams for H264 with the VAAPI accelerator. The decoder detects when this case occurs and then offloads slice header parsing to the accelerator. BUG=b:153111783,b:155508443 TEST=Unit tests pass, CENCv1 playback works Change-Id: Ieb913935269163d09d24b88a8ea987a6e8ffce33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552634 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833458}
-
Robbie McElrath authored
This is a fixed reland of a3349311 In the original CL, I removed the code that made Fragment.getActivity() non-final, as our approach no longer relied on overriding it. However, the PromptDialogDelegate interface in the hats20 library, which other Fragment subclasses in that library implement, defines an `Activity getActivity()` method. Fragment.getActivity() is considered the implementation of this method from a typechecking perspective, but javac still generates a getActivity implementation that calls the parent class's. This didn't cause issues before because the two methods returned different types, but now that Fragment.getActivity() returns an Activity, the bytecode verifier thinks the javac-generated getActivity from PromptDialogDelegate is extending Fragment's implementation, which it can't do because it's final. Making Fragment.getActivity() non-final again fixes the issue. Original change's description: > [WebLayer] Fix FragmentActivityReplacer with SupportLifecycleFragmentImpl > > This fixes a comilation error due to FragmentActivityReplacer's > interaction with SupportLifecycleFragmentImpl. > > Bug: 1152898, 1123216 > Change-Id: I81de8100f7ddd08310f8a36c8f1c9c62e82c0469 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566455 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832426} Bug: 1152898 Bug: 1123216 Change-Id: Ibf923570bbb27d5ffb0a337775aac449b59d5986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569950 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#833457}
-
Jan Wilken Dörrie authored
Following r833080 this change removes the explicit noexcept specifier from flat_tree's move operations, since the compiler will perform the expected outcome anyway [1]. Furthermore, this change adds tests to statically assert the correct behavior. [1] https://timsong-cpp.github.io/cppwp/n4140/dcl.fct.def.default#2.2 Bug: None Change-Id: I88cd95bf577899925dd8b07a2865b6d2c6f318ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567929Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#833456}
-
Jan Wilken Dörrie authored
This change removes password_manager::features::kWellKnownChangePassword from the codebase. The feature was fully launched in M86. Bug: 927473 Change-Id: Ib71caa03f794440aa415e175e3b9ea8514b7d03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569751Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#833455}
-
Mark Schillaci authored
This CL includes some small refactors to JNI calls for a11y Android code. We eliminate some trips through the JNI with the following updates: - announceLiveRegion checks empty strings before JNI call - Combine 4 populate AccessibilityEvent JNI calls to 1 - Combine 2 populate AccessibilityNodeInfo JNI calls to 1 - Update setting AccessibilityNodeInfo child ids to pass a vector once, rather than calling through JNI for each child AX-Relnotes: N/A Change-Id: Ic6c46b8316ebc954a20084844f5f072149a218d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569852Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#833454}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5d8a07143377..10cb17e079e1 2020-12-03 rharrison@chromium.org Disable unit tests with KI when Tint Inspector is being used 2020-12-03 dj2@everburning.com Remove tint context. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: If4d91424117577be0cda165aed9bb900d066920f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833453}
-