- 06 Nov, 2020 40 commits
-
-
Ewann authored
This CL fixes tests impacted by the EnableCloseAllTabsConfirmation feature before submitting the config. Bug: 1119319 Change-Id: I32c86bcc8f6132fbd93d04578e7cbc9d4460d543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443852 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824851}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I08e7c26feeba95600d7c98a67829cd06d9788e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824850}
-
Clemens Arbesser authored
This hopefully fixes/workarounds a test failure. The fix is to avoid using the bottom sheet in the UI test directly. I was not able to repro the originally reported test failure, so this is only a best guess effort for now. We will have to monitor if this has indeed fixed the problem. I have created b/172639096 to track the root cause of the test failure. Bug: 1146084 Change-Id: I6ef0cb4f05717805f4ba7dd36b6c0c682b89ef3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521817 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824849}
-
Antonio Gomes authored
... as well as kFrameRestoreLookKey. Dependency/include graph: - frame_util.cc uses kWindowManagerManagesOpacityKey and kFrameRestoreLookKey; - frame_utils.h is included by frame_header.cc; - frame_header.h is included by default_frame_header.h - browser_non_client_frame_view_ash.cc includes default_frame_header.h. So, in order to free browser_non_client_frame_view_ash.cc|h from including //ash/ headers, the items above will migrate step by step to //chromeos/ui. BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: If1ba34dca49f752ec3c9247e366879c10455a5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521691Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#824848}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0891c367b8b2..d57e268ce139 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1d7344bed6303d1ac2f9b7e9f916380525d19303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522590Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d57e268ce139..1e9cf1a8e1bd 2020-11-06 treehugger-gerrit@google.com Merge "protos: Use int32 instead of uint64 for ProcessSnapshot's pid field" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0b541402505a8806376808dbd72348a29269d843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522589 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41bb19c60930..9cde39469149 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:897470 Tbr: clamy@google.com Change-Id: I2225589c12002981314cc9098f89292f69915129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522586Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824845}
-
Mirko Bonadei authored
Instead of generating absl .def files at roll time, this CL switches the build config to generate the required .def file on the fly while building. The advantages are: 1. No need to re-generate .def files when something external to absl changes and affects .def files (e.g. when a new compiler optimization it enabled). 2. No need to hard-code supported build flavors in the .def generator script, resulting in multiple .def files checked-in. On the other hand, this makes the build slightly slower than it is today because reading all absl object files to generate the .def file can take a few seconds. Bug: 1046390 Change-Id: If3a8fb3dca0ed75dbd85655cff1263853dcc146a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270094 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#824844}
-
Sylvain Defresne authored
ChromeBrowserStateClient returned a hardcoded value of "1" when asked for the number of BrowserStates as using browser_state_info_cache.h would have introduced a circular dependency. Fix the circular dependency by moving browser_state_info_cache.h from the //ios/chrome/browser/browser_state:browser_state_impl target to the //ios/chrome/browser/browser_state target instead. Bug: 991575 Change-Id: I589fa36db8dc0e85d546982aaa096fd5a958b23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521001 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#824843}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb8e1e991bc9..3d5d22136720 2020-11-06 aerotwist@chromium.org [unit test] Isolate connection and environment helpers 2020-11-06 yangguo@chromium.org Add stack trace for assertion failures in e2e tests 2020-11-06 aerotwist@chromium.org Updates coverage config 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in developer_resources/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in security/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in layers/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in help/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in web_audio/ 2020-11-06 yangguo@chromium.org Introduce allow list for expected assertion failures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1132333,chromium:1145969 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I48cbe89c881e13a3498feee0019f72733d139059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522588Reviewed-by:
-
Hajime Hoshi authored
Before this CL, not-stored reasons are not recorded when the browsing instance is not swapped. This means we are missing records in these cases. This CL fixes this by adding an additional record at RenderFrameHostManager::ShouldProactivelySwapBrowsingInstance Bug: 1134847 Change-Id: Id683b7f94de4e8cb81da0b5779f56a496d040b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466002 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#824841}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a61d347b99c9..ccc9dd2835f5 2020-11-06 landrey@webrtc.org Log full diagnostic data during insertion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1146040 Tbr: skyostil@google.com Change-Id: I5fdaf1b7c52bed201b031381edd7441c205d3352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522587Reviewed-by:
-
Stephane Zermatten authored
Before this change, ElementPositionGetter would round each coordinate it got before computing the center, then rounding it. With this change, only the center is rounded. This was puzzling. This change is expected to have no effect, as all coordinates should be integer values to begin with. It's just a cleanup. Change-Id: Ib0ac75f6e08d825f1521e32325c87672eb9f9d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521734Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824839}
-
Kyle Horimoto authored
Bug: 1146224 Change-Id: Ie240478c901e1ed791f05002d4f9d906072b1b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522507 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824838}
-
Karandeep Bhatia authored
Follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/2419607. This documentation is not yet exposed on the docserver. BUG=113513 Change-Id: I164efcf67789e699b35322d1a5b6e519147944b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519041 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824837}
-
Illia Klimov authored
Bug: 1142861 Change-Id: Ia1f80f799a7b809316fb040d49d8cc3c99946453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503692 Auto-Submit: Illia Klimov <elklm@google.com> Commit-Queue: Illia Klimov <elklm@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824836}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b680e487. With Chromium commits locally applied on WPT: 9a749c24 "[scroll-animations] Handle implicit 'auto' offsets correctly" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I7ec9f31d4fc2153623d578c83184e3354404bd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522232Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824835}
-
Ewann authored
This CL replaces the font for the 'Tap to cancel' label. Bug: 1146347 Change-Id: I0e7922f7fb71c5e6d23c65781677f66b734a1810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523031Reviewed-by:
-
Jan Krcal authored
This reverts commit 6b7290b3. Reason for revert: memory regression on Mac (crbug.com/1146299) Original change's description: > [Profiles] Use new colored default avatars for taskbar badges > > Recently, all logic around profile avatars has been integrated into > ProfileAttributesEntry::GetAvatarIcon() incl. new features such as > colored default avatars. > > This CL updates code that generates taskbar badges on Windows to > delegate most of its logic to GetAvatarIcon(). Only the pieces needed > for obtaining ImageLoadStatus remained in this code. > > The only behavioral change is for non-GAIA avatars: high-res / > 2x windows old avatars are returned instead of low-res avatars. This > means more downscaling is needed than before. This will be addressed > by further CLs that will make GetAvatarIcon() respect preferred_size in > more cases. > > Bug: 1122559 > Change-Id: I5eecc7c6647dc78f9ff92d74edb64214a48e8e63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514153 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824494} TBR=droger@chromium.org,jkrcal@chromium.org Change-Id: I66f7b806a25b910d35b55f02805c4c8216049f55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1122559, 1146299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521118Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#824833}
-
Tanmoy Mollik authored
The sign in API uses CoreAccountInfo. So in the long run its better to use CoreAccountInfo for helper methods that interact with sign in API. This cl refactors AccountManagerTestRule so that the methods to add account and check signed in account return CoreAccountInfo. Bug: 1117006 Change-Id: I08245ea7b6325b1a62b3c27d53cc1f9877e9e75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521571Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824832}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia6afa428aa33860f425f2b934391fbdbfa3eceb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522432Reviewed-by:
-
Tanmoy Mollik authored
Updating the promo state forcefully is not required for these tests. This cl does not change the behavior of the tests. It changes how the environment is set up. This cl also enables testPersonalizedSigninPromoInBookmarkPage test. Bug: 1123478, 1133426 Change-Id: I4382f857ca1e91676404fce1a1c6e76c315e4493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517684Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8b665312ca15..0891c367b8b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I573f8984ef5f6aae3f7aa9990f4c29d492749962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522007Reviewed-by:
-
Friedrich [CET] authored
This reverts commit 264cfbbf. Reason for revert: The fix seems to be worse than the problem (see newly linked bugs). Original change's description: > [Desktop][PwdCheck] Even icon paddings > > With https://crrev.com/c/2260639, the paddings weren't distributed > evenly anymore (start/end padding) causing misalignments. > Additionally, the non-square icon dimensions caused rounding errors > increasing that effect. > > This CL ensures consistent paddings for RTL and LTR mode. Screenshots > are in the linked bug. > > Bug: 1144629 > Change-Id: Ied4af63de6d94abb2b6510cfd061a970f8f98da8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513600 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823262} TBR=jdoerrie@chromium.org,fhorschig@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144629, 1145943, 1145931 Change-Id: Ifa4e0cd1cb705dec80968392506582c4894edd50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521512Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#824828}
-
Yuki Shiino authored
It turned out that a single function collect_forward_decls_and_include_headers does the job for IDL callback functions, IDL callback interfaces, IDL dictionaries, and upcoming IDL unions, so moves the function into codegen_utils.py to be shared among them. Bug: 839389 Change-Id: Ieee0e75388a90367c04da9c2adb40ce4bfad072a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521873Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#824827}
-
Regan Hsu authored
Accessing an empty sessions::SessionTab's |navigations| vector is resulting in an out of bounds access, causing BrowserTabsMetadataFetcherImpl to crash. Fixed: 1142562 Bug: 1106937 Change-Id: I0ec890135f6acafd61a39a7d06b52ef1956bed96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522497 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#824826}
-
Jan Krcal authored
The test CreateSignedInProfileSigninAlreadyExists is flaky on multiple platforms. Bug: 1144065 Change-Id: I6382c9d8757de99c1e5575a1101bdae647dc0cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521184 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#824825}
-
Jan Krcal authored
This CL adapts terminology in the profile menu to the new terminology in the profile picker: namely replaces "people" with "profiles". It also removes two strings not used any more. Bug: 1063856 Change-Id: I467a6ee9a3e5c4eb2600fd47698ea74e6e3c4fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521510Reviewed-by:
-
Sigurd Schneider authored
DevTools CL: https://crbug.com/1057090 Bug: chromium:1057090 Change-Id: I95d92d1325db9c381a3423ca3abbdf7eb2cf924c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521814 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824823}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0891c367b8b2..d57e268ce139 2020-11-06 primiano@google.com Docs: add GitHub PR template and link to contributing docs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I84469c4a4e58475b3dedaead9ca7696e8710f645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522885Reviewed-by:
-
Bartek Nowierski authored
Bug: 11297512 Change-Id: I4d09c4705105e8ba66bbb4282cecebf2b33e56f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517351 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#824821}
-
Gauthier Ambard authored
This CL updates the way the SSLBlockingPage are detecting the page for which an exception is being added by using the URL passed in the initialisation rather than the URL of the page sending the JavaScript command, as it is a file:// URL when using the new error page workflow. Bug: 1139303 Change-Id: Ia27a656ecdca52c16503b3c5d1b9cbf594543b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509518Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824820}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for: - LayoutFlowThread - LayoutMultiColumnFlowThread - LayoutMultiColumnSet - LayoutMultiColumnSpannerPlaceholder This CL has no behavior changes. Bug: 891908 Change-Id: I5af2d59eeed6fde57c8eff80ae1904083e0d030c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521884 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#824819}
-
Fredrik Söderqvist authored
Also make sure dynamic changes are reflected earlier by calling AnimationAttributeChanged() when the parsed attribute value changes. Previously it would only refresh when moving to the next value range, or otherwise invalidating animation state. Fixed: 1145548 Change-Id: I8ff82c02e6bf8e3cb82ef4d21e2381cbc99bcd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520783 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#824818}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e9554189c71b..eb8e1e991bc9 2020-11-06 petermueller@chromium.org Increase contrast of pseudo-element syntax color 2020-11-06 szuend@chromium.org [markdown] Remove MarkdownView bridge 2020-11-06 wolfi@chromium.org Fix event propagation for link from FrameDetails to Network request If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1145525 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3b806aa24c74374b8934a0e8dcdf6d2a6dc51ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521205Reviewed-by:
-
Irem Uğuz authored
This CL moves CertProvisioningSchedulerUserServiceFactory to chromeos::EnsureBrowserContextKeyedServiceFactoriesBuilt() which is meant to initialize browser context keyed service factories for chrome on chromeos. Bug: 1142449 Change-Id: I494ec23d1f3357912ae1b43a0c76ee3fa4eb06b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517560Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Irem Uğuz <iremuguz@google.com> Cr-Commit-Position: refs/heads/master@{#824816}
-
Sylvain Defresne authored
When building for the "catalyst" environment, the selector -viewController is overloaded and the compiler is confused about the type of the value that is returned (as it can be either `UIViewController` or `NSViewController`). Add an explicitly checked cast to fix the compiler error about incompatible value type being stored in the array. Bug: 1138425 Change-Id: Ib5381993520bd1c2723439c6ad04c04d4d07f8e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521732 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Henrik Boström authored
Pixel buffers originating from a CVPixelBufferPool are recycled when no longer in use, previously only tested by releasing the last pixel buffer reference and not touching the IOSurface. This CL tests what happens when we are retaining not references to the pixel buffer, but references to a pixel buffer's IOSurface or incrementing its use count. Outcome: - Retaining references (base::ScopedCFTypeRef<IOSurfaceRef>) to an IOSurface does NOT prevent recycling. - Retaining use count (IOSurfaceIncrementUseCount) to an IOSurface DOES prevent recycling. This behavior is now documented in pixel_buffer_pool_mac.h. Bug: chromium:1132299 Change-Id: Ibdcd3752a4467bc495eba4b543ecd73da1b2f41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520829 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#824814}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3dfaeeb00271..dc515d41bba9 2020-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3c7580ad to 52d33a46 (441 revisions) 2020-11-06 lexa.knyazev@gmail.com Metal: Fix typo in TextureMtl::bindToShader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I30ef867a463bd59f13045a42a197b0833d2d7334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522620Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2b6b0f45ff05..973d145df865 2020-11-06 cwallez@chromium.org Make dawn_platform a component. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I2c1e7bcf2cf22a34f7d3fa8b24d25b180995803b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523091Reviewed-by:
-
![Friedrich [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich [CET]")
