- 11 Jan, 2017 40 commits
-
-
nyquist authored
Removes all the Android-code related to blimp from //chrome, and removes all the dependencies of the //blimp directory. This includes all hooks for the UI code, command line flags, resources, and the BrowserContextKeyedService. BUG=677556 Review-Url: https://codereview.chromium.org/2623023002 Cr-Commit-Position: refs/heads/master@{#443007}
-
twellington authored
If a quick action was shown, contextual cards data for a thumbnail/caption were not shown, so the histograms for whether contextual cards data was shown should log "false". BUG=680229 Review-Url: https://codereview.chromium.org/2621413003 Cr-Commit-Position: refs/heads/master@{#443006}
-
reveman authored
Texture must be bound before it has a valid mailbox. https://crrev.com/d40f03 accidentally broke this by accessing the mailbox before calling BindTexImage. BUG=679200 Review-Url: https://codereview.chromium.org/2627753003 Cr-Commit-Position: refs/heads/master@{#443005}
-
robertogden authored
methodname. Example: --test_filter=Hello.W* Matches classname='Hello' and methodname='W*' BUG=669956 Review-Url: https://codereview.chromium.org/2624133003 Cr-Commit-Position: refs/heads/master@{#443004}
-
sky authored
This is (mostly) the bare minimum to merge the two. Future patches will cleanup WmWindow usage. BUG=671246 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2620153003 Cr-Commit-Position: refs/heads/master@{#443003}
-
bnc authored
Rename and renumber enum entries to exactly match wire values defined in the HTTP/2 specification. In particular: * s/GOAWAY_OK/GOAWAY_NO_ERROR/ * s/RST_STREAM_INVALID_STREAM/RST_STREAM_STREAM_CLOSED/ * s/RST_STREAM_FRAME_TOO_LARGE/RST_STREAM_FRAME_SIZE_ERROR/ * Remove RST_STREAM_UNSUPPERTED_VERSION, RST_STREAM_IN_USE, RST_STREAM_ALREADY_CLOSED. Change string serialization values only used for log messages. RST_STREAM_INVALID_STREAM and RST_STREAM_STREAM_CLOSED were used interchangeably. Now RST_STREAM_INVALID_STREAM is removed in favor of RST_STREAM_STREAM_CLOSED. This CL also renames STATUS_CODE_INVALID_STREAM to STATUS_CODE_STREAM_CLOSED, and changes description in histograms.xml. Also add STATUS_CODE_COMPRESSION_ERROR to SpdyProtocolErrorDetails, to correctly log incoming RST_STREAMs with RST_STREAM_COMPRESSION_ERROR. This CL lands server change 143555862 by bnc. BUG=488484 Review-Url: https://codereview.chromium.org/2612293004 Cr-Commit-Position: refs/heads/master@{#443002}
-
qyearsley authored
This is the only test still listed in TestExpectations from http://crbug.com/662264; I believe that it only times out now; I think it makes sense to just put it with the other similar imported tests that time out. BUG=662264 Review-Url: https://codereview.chromium.org/2605363002 Cr-Commit-Position: refs/heads/master@{#443001}
-
malaykeshav authored
- Adds the circular throbbing touch point view that the user interacts with during touch calibration. - Adds the hint box view that contains the hint message as given in the UX specs. (https://drive.google.com/file/d/0B_2Uyb2Rhx2OU0FIbXUyMkhMZlE/view) - Adds required resource strings for hint box messages. Working protottpe(The video is the entire prototype. This change only involves adding the touch point and hint box.): https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1QVR0WFJYdUY2SmZTdWdUVFNSM0F5WDF4YlBn/view Screenshot of how it looks on different DPI screens: https://screenshot.googleplex.com/ND5d9v0799y.png Screenshot for RTL: https://screenshot.googleplex.com/Xd3PyAYbDTV.png BUG=634166 COMPONENT=Touch Calibration, ChromeOS, UI Strings Review-Url: https://codereview.chromium.org/2600213002 Cr-Commit-Position: refs/heads/master@{#443000}
-
twifkak authored
When specified, resources are only fetched over the network if they have an existing cache entry with revalidation headers. This serves as a lower-bound approximation of the efficacy of a client-only wifi precache mechanism, as it is limited to URLs that are only on the client AND in the manifests. BUG=679533 Review-Url: https://codereview.chromium.org/2614403003 Cr-Commit-Position: refs/heads/master@{#442999}
-
reveman authored
Update comments to reflect latest code and remove unncessary function and if-statements. BUG=675004 Review-Url: https://codereview.chromium.org/2625153002 Cr-Commit-Position: refs/heads/master@{#442998}
-
kylechar authored
The logic to track surface references for surface embeddings was built as part of FrameGenerator. Generalize the logic and remove from FrameGenerator, creating the class EmbeddedSurfaceTracker. EmbeddedSurfaceTracker keeps track of surface references from one client surface to many embedded surfaces. It also handles generating new references when the client surface changes. Includes unit tests. This simplifies FrameGenerator and should make it easier to use surface references in other clients. BUG=659227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2610063007 Cr-Commit-Position: refs/heads/master@{#442997}
-
reveman authored
If the window is still in the tree when Surface is destroyed then we need to remove the vsync observer in the dtor. BUG=679787 Review-Url: https://codereview.chromium.org/2627713004 Cr-Commit-Position: refs/heads/master@{#442996}
-
qinmin authored
We might need to consolidate java/native download status later Moving the java download status into a separate class so we can handle it without UI knowledge Review-Url: https://codereview.chromium.org/2625493004 Cr-Commit-Position: refs/heads/master@{#442995}
-
fdoray authored
The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2609743002 Cr-Commit-Position: refs/heads/master@{#442994}
-
rdevlin.cronin authored
Revert of [Extensions] Enable sideloading prompt on mac on canary (patchset #3 id:40001 of https://codereview.chromium.org/2623033002/ ) Reason for revert: Broke official mac compile Original issue's description: > [Extensions] Enable sideloading prompt on mac on canary > > BUG=669277 > > Review-Url: https://codereview.chromium.org/2623033002 > Cr-Commit-Position: refs/heads/master@{#442983} > Committed: https://chromium.googlesource.com/chromium/src/+/e7419b3ea146e6aa9ba26ec3fae255754f47cafb TBR=lazyboy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669277 Review-Url: https://codereview.chromium.org/2628993002 Cr-Commit-Position: refs/heads/master@{#442993}
-
peter authored
The SyncNotificationController is the only consumer of the GSNC, so we can simplify by merging the two classes together. In addition, remove displayAndroidMasterSyncDisabledNotification() which had no callers. The sync notifications do not appear to be tested. I filed https://crbug.com/679750 to track adding some. BUG= Review-Url: https://codereview.chromium.org/2621023002 Cr-Commit-Position: refs/heads/master@{#442992}
-
xianglu authored
This CL moves Shape Detection mojo interfaces to //services, which exposes them to public instead of just Blink. No new code added. Blocking: https://codereview.chromium.org/2460723003/ TBR=haraken@chromium.org (mechanical move) BUG=646083, 659139 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2620083002 Cr-Commit-Position: refs/heads/master@{#442991}
-
kbr authored
Rendering corruption is seen on this GPU, which is nearly 10 years old. Fall back to software rendering. BUG=676975 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2626973002 Cr-Commit-Position: refs/heads/master@{#442990}
-
alexclarke authored
Previously background web views had timer alignment throttling applied immediately and budget based throttling after 10s. It looks like even the timer alignment throttling on it's own is causing problems for new tabs where the visibility isn't initially known. To fix this we're changing the policy so we don't do any throttling at all until the web view has been in the background for 10s and then we turn budget based throttling & alignment on. Note this patch removes fast/dom/timer-throttling-hidden-page.html because the 10s grace period means this test would be too slow. Virtual time doesn't help because Date.now() (currently) isn't overridden. There's no support for using a mock time source in layout tests. In any event there's plenty of C++ unit test coverage for this so it's not too bad to remove the layout test. BUG=649942 Review-Url: https://codereview.chromium.org/2620743002 Cr-Commit-Position: refs/heads/master@{#442989}
-
sdefresne authored
In order to roll GN c99acd65..5c18ca83 (r439377:r442253) and pick up the following changes: 4ce240b3 Associate xctest files with corresponding xctest targets. 7e5894a9 Configure xctest build settings to prevent Xcode from linking objects. 043a15dd Add functionality to find xctest files under application target. d1316080 Stop propagation of dependent configs between toolchains. 0c1dd9de GN: Fix some typos in the documentation. 67e8c60e [Refactor Xcode Objects] Allow extra attributes for native targets. 8fb7d9d9 [Refactor Xcode Objects] Enable adding per file '--help' compiler flag. 898a56b7 [Refactor Xcode Objects] Decouple file references and indexing target. a8936b7a Fix a typo in GN documentation 889ccd0f Fix a typo in gn help. 7d886382 Support for source_target_relative expansion in GN 615f8527 Fix GN bootstrap. d48f4812 [Refactor Xcode Objects] Enable navigator paths for file references. 44dbd2f1 Clean up link references in //tools/gn/README.md. TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2619823002 Cr-Commit-Position: refs/heads/master@{#442988}
-
Dave Schuyler authored
Cr-Commit-Position: refs/heads/master@{#442987}
-
tonikitoo authored
Driven-by clean up past [1], where the only user of this switch was (re)moved. [1] https://codereview.chromium.org/2573283002 BUG= Review-Url: https://codereview.chromium.org/2619773003 Cr-Commit-Position: refs/heads/master@{#442986}
-
fdoray authored
The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2610503002 Cr-Commit-Position: refs/heads/master@{#442985}
-
samans authored
The sole purpose of SurfaceReferenceBase and SequenceSurfaceReference was to be able to return the reference later on, but the same goal can be achieved using closures with much less complexity. From now on, SurfaceReferenceFactory::CreateReference returns a closure that returns the reference once its called. TBR=sadrul@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2616403003 Cr-Commit-Position: refs/heads/master@{#442984}
-
rdevlin.cronin authored
BUG=669277 Review-Url: https://codereview.chromium.org/2623033002 Cr-Commit-Position: refs/heads/master@{#442983}
-
robertogden authored
R=sclittle BUG=679424 Review-Url: https://codereview.chromium.org/2624233002 Cr-Commit-Position: refs/heads/master@{#442982}
-
boliu authored
Move getSmallestDIPWidth to ChromeContextUtil in chrome. This removes the last usage of DeviceDisplayInfo, so finally remove it. BUG=625089 Review-Url: https://codereview.chromium.org/2623653002 Cr-Commit-Position: refs/heads/master@{#442981}
-
fs authored
The former should "win" over the latter. Fixed by https://codereview.chromium.org/2478233002. TBR=pdr@chromium.org BUG=415950 Review-Url: https://codereview.chromium.org/2621153005 Cr-Commit-Position: refs/heads/master@{#442980}
-
dcastagna authored
KMS now advertises per plane buffer modifiers. This patch uses that information to make an educated choice on which modifiers to use when allocating scanout buffers for a specific crtcs. patch from issue 2576263002 at patchset 60001 (http://crrev.com/2576263002#ps60001) BUG=chrome-os-partner:56407 Review-Url: https://codereview.chromium.org/2623963002 Cr-Commit-Position: refs/heads/master@{#442979}
-
maxbogue authored
Still lost as to why it would be null, but this should stop crashes. BUG=679657,673883 Review-Url: https://codereview.chromium.org/2622223003 Cr-Commit-Position: refs/heads/master@{#442978}
-
bzanotti authored
The first one should always be the default one. Updated switch case: http://screen/PTLfmU9H7h0.png BUG=660418 Review-Url: https://codereview.chromium.org/2614973002 Cr-Commit-Position: refs/heads/master@{#442977}
-
dimu authored
Cr-Commit-Position: refs/heads/master@{#442976}
-
pdr authored
Slimming paint invalidation (--enable-slimming-paint-invalidation) moves paint invalidation to a new "pre-paint" document lifecycle stage. This patch moves prePaint under the "Update Layer Tree" timeline category, and adds a comment to move this under "Paint" for slimming paint v2 (see discussion in https://codereview.chromium.org/2623613008). BUG=679403 Review-Url: https://codereview.chromium.org/2622983002 Cr-Commit-Position: refs/heads/master@{#442975}
-
siggi authored
This implements a fallback crash handler launcher. The launcher will be instantiated in the Crashpad handler process, where it pre-computes a command line to be launched on crash. This will be triggered off the UEF, under some form of single-instance locking. BUG=678959 Review-Url: https://codereview.chromium.org/2596463002 Cr-Original-Original-Commit-Position: refs/heads/master@{#442596} Committed: https://chromium.googlesource.com/chromium/src/+/d4e43bb5146c7a59123ff5f3b6e853d8e8c29130 Review-Url: https://codereview.chromium.org/2596463002 Cr-Original-Commit-Position: refs/heads/master@{#442698} Committed: https://chromium.googlesource.com/chromium/src/+/f87fdaa12b09ff286d873e7a3ea459507d7adb83 Review-Url: https://codereview.chromium.org/2596463002 Cr-Commit-Position: refs/heads/master@{#442974}
-
zakerinasab authored
Implement color management for ImageData as described in this proposal: github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE BUG=670712 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2555213002 Cr-Commit-Position: refs/heads/master@{#442973}
-
yzshen authored
It is convenient for debugging. Although console.log() is supported by chrome directly, mojo bindings currently are loaded using gin. Therefore, console.log() is not always available and needs to be defined as a module. After we move away from gin/AMD, we should be able to get rid of this. BUG=579646 TBR=jochen@chromium.org (deferring to eugenebut) Review-Url: https://codereview.chromium.org/2618693004 Cr-Commit-Position: refs/heads/master@{#442972}
-
fdoray authored
The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2608093002 Cr-Commit-Position: refs/heads/master@{#442971}
-
dtseng authored
Previously, accessibility extensions required content scripts to access locked screen UI. With the introduction of chrome.automation, this is no longer necessary. An extension running in the signed in profile can easily access locked screen UI. We therefore can: - remove enabling an extension in the locked screen ui's profile (e.g. adding ChromeVox as a component extension). - stop injection of content scripts into the locked screen's web ui. TEST=navigate to locked screen with ChromeVox on. Verify things work. Toggle ChromeVox off and on. Verify things still work. BUG=676467,611736 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2617633004 Cr-Commit-Position: refs/heads/master@{#442970}
-
krasin authored
BUG=678915 Review-Url: https://codereview.chromium.org/2621193003 Cr-Commit-Position: refs/heads/master@{#442969}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/76a44dea3180..8fa82794ffc2 $ git log 76a44dea3..8fa82794f --date=short --no-merges --format='%ad %ae %s' 2017-01-11 tsepez Annotation deleted while retrieving it in JS BUG=679642 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2623263002 Cr-Commit-Position: refs/heads/master@{#442968}
-