- 05 Jun, 2019 40 commits
-
-
Yoav Weiss authored
Change-Id: I54c65ebbd2f252a8050503e809f835c3b23ec4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643472Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#666179}
-
Kinuko Yasuda authored
This reverts commit 869062d9. Reason for revert: Msan crashing due to uninitialized value: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8911533900209194848/+/steps/browser_tests/0/logs/Deterministic_failure:_FeedbackTest.SubmissionTest__status_CRASH_/0 5:21315:0604/180329.553111:INFO:CONSOLE(193)] "Feedback: Sending report", source: chrome-extension://gfdkimpbcpahaombhbimeihdjnejgicl/js/feedback.js (193) ==21315==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x565429d9374f in Value ./../../base/values.cc:197:7 #1 0x565429d9374f in make_unique<base::Value, double &> ./../../buildtools/third_party/libc++/trunk/include/memory:3131:0 #2 0x565429d9374f in base::Value::SetDoubleKey(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, double) ./../../base/values.cc:435:0 #3 0x565429afadea in base::HistogramBase::WriteJSON(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, base::JSONVerbosityLevel) const ./../../base/metrics/histogram_base.cc:157:8 #4 0x565429b2e4dc in base::StatisticsRecorder::ToJSON(base::JSONVerbosityLevel) ./../../base/metrics/statistics_recorder.cc:170:16 #5 0x565422ce3e07 in extensions::FeedbackPrivateSendFeedbackFunction::OnAllLogsFetched(bool, bool, scoped_refptr<feedback::FeedbackData>) ./../../extensions/browser/api/feedback_private/feedback_private_api.cc:363:9 Original change's description: > Add browsertest for complete process of sending feedback report > > This adds a new browsertest which adds a hook into the feedback uploader > to catch it right before it does the actual report upload. This ensures > that clicking on the button to send a feedback report actually results > in the report getting queued to be sent. This covers a regression case > which is in crbug.com/954563. > > Bug: 955039, 954563 > Test: Browser tests pass, fail if prior regression was put back > Change-Id: I92762c1b6741ad057e78c8cafeb924f93995b249 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632534 > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666036} TBR=afakhry@chromium.org,jkardatzke@google.com Change-Id: I004940a9156698865fddd6152e298c49797aa3bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955039, 954563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644855Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#666178}
-
Jeevan Shikaram authored
This is a reland of 2fd01309 Original change's description: > [App Management] Enable App Management by default. > > Enable App Management by default. Current entry points are about:settings > and about:app-management. > > Bug: 906508 > Change-Id: I0118a4b51eda6e65bc72186e771fc2ede2acb45f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610658 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659341} Bug: 906508 Change-Id: I0fb9ced91a975afa7d0b94e0a863dccaca4bb247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642491Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#666177}
-
Dale Curtis authored
Now that AVDA is deleted, time to rename and remove lots of stuff! We no longer need synchronous codec creation w/o AVDA! BUG=none TEST=compiles R=liberato Change-Id: Iba492149c2e395c45d76a67b752916560ff8ad25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644161 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#666176}
-
Kinuko Yasuda authored
Its test expectation was changed recently by https://crrev.com/c/1642031 but it looks it just keeps failing on Mac. Sample failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20%28retina%29/15149 http://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/23650 http://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/23644 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/14224 TBR=szager@chromium.org Bug: 971031 Change-Id: Icf49dcfaaa6492d36725fd62b3e5e59ee904f884 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644913 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#666175}
-
Alexei Svitkine authored
This allows capturing much more execution during browser start up. This CL is based on the following earlier CL which was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/691239 Some changes from that previous CL: - Enables this for browser process only for now. - MainThreadStackSamplingProfiler added to chrome/common so it can be used from InProcessBrowserTest, as it does not run the code in chrome_main.cc. - Made thread_profiler.cc keep track of the main thread instance so that the task runner could be registered on it, as chrome_browser_main.cc otherwise doesn't have access to the object created in chrome_main.cc. Bug: 700083 Change-Id: Ifbff01eaa6e48e6e1daea8be381890337cab387d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618566 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666174}
-
rajendrant authored
Redirect cycle tests are in browser test with NetworkService. Bug: 968214 Change-Id: I27f6d659789fceaf3dc37ffe13204a5925573212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644322Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#666173}
-
Takuto Ikuta authored
This will be submitted after https://chrome-internal-review.googlesource.com/c/infradata/config/+/1358390 But test for linux-ozone-rel is still configured to use trusty due to https://ci.chromium.org/p/chromium/builders/try/linux-ozone-rel/283303 Bug: 954450 Change-Id: Ie2d93ccc409dbc494b15fdb4039aa1e7a44660c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642851 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#666172}
-
Dominick Ng authored
This CL adds a new method on app.mojom that allows Chrome OS to query ARC for whether a given package name is currently installable. BUG=969560 Change-Id: Ia525a92944b9b4afb4fd5f6a1ccb150e931a22ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640917Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#666171}
-
Yoshisato Yanagisawa authored
Bug: 954450 Change-Id: If978108b52b6e70cfe53c8364990b45e74081224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644713Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#666170}
-
Ramin Halavati authored
'PageLoad' user action was moved from stability_metrics.cc to 'navigation_metrics.cc' in Ib1d19c1ec82916da495c8cff5885152abb55822f. This had resulted in not counting unsuccessful page loads, sub frames, and ChromeOS pre sign-in page loads. The change is reverted. Bug: 912346, 971023 Change-Id: Ic18b6b5c4cfc7b5bf0fd75ed132ca97b83c08c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642628 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#666169}
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/events directory. [1] https://github.com/heycam/webidl/issues/365 The expected results of SecurityPolicyViolationEvent interface should be updated because the interface is exposed to Window and Worker. TESTS: http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt webexposed/global-interface-listing-dedicated-worker-expected.txt webexposed/global-interface-listing-shared-worker-expected.txt Bug: 963267 Change-Id: I34083358b19b16a069e84030d132aa82d939b859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641095Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#666168}
-
David Black authored
Previously, AssistantControllerObserver::OnUrlOpened would fire after we requested that a url be opened in a new browser tab but before our widget would lose focus. Now, due to the de-mojoization of the relationship between ash/browser, this is no longer the case. This causes our widget in standalone Assistant UI to lose widget activation state and become hidden before we receive the OnUrlOpened event. As a result, we don't know to close Assistant UI in OnUrlOpened because we are already in hidden state. To address this, I've added a new event that fires before the new browser tab is opened so that observers requiring early notification can continue to do so. Bug: b:134409807 Change-Id: I1c827102813fcdadddfe76a777880e4616bd38af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643537 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#666167}
-
Alexei Filippov authored
Change-Id: I1b21e69cab1c9e33bbf0591a91e4714cbf28a2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644438Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#666166}
-
John Abd-El-Malek authored
The old code path doesn't work anymore, but we still need the feature flag because WebView hasn't launched yet. Rename the flag on desktop, so that users with shortcuts that disable the feature still get it enabled. Bug: 970183 Change-Id: I089a17b0fced1fc0fa246fe91ddd37d49274c9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643416 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#666165}
-
Min Qin authored
This CL adds 3 UMA to record the interrupt reason and the interrupt count for the first background download. This allows us to understand why download are interrupted so often in reduced mode. The UMA for download start will allow us to check whether the service manager process is crashing a lot. BUG=969225 Change-Id: I7b6c4afb3c994578e9fc4af5c36980d4a966d174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639049Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666164}
-
Yoav Weiss authored
The WebResourceTimingInfo struct was not properly initialized. Beyond that, when copying values from the ResourceTimingInfo struct, is_secure_context remained uninitialized, as it does not exist on the other end. This CL initializes all of the above. Bug: 969770 Change-Id: I4c4c1f5161fc196b05d5a7d828ef1310a53d8597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643531Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#666163}
-
Khushal Sagar authored
Have the RasterDecoder yield to allow interruption after image transfer cache entry deserialization. Image uploads tend to be slow operations, its good to yield after them to allow higher priority UI work to proceed. R=enne@chromium.org, piman@chromium.org Bug: 970134 Change-Id: If0f488b7efc2c0eac559733333cf4de17882ab4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643087Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#666162}
-
Tsuyoshi Horo authored
Bug: 935267 Change-Id: I8800a415c1fffd0e59d37f1a65d122d17ab5e6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641017Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666161}
-
Yoshisato Yanagisawa authored
For mac builders the number of cores changes based on vm or not. Also, we expect xcode checkout would be kept for the builders. Having "ios" mixin is convenient to achieve that. Bug: 968784 Change-Id: I30d8377fcd944dcf134bb00efa98890fd97e5252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644593 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#666160}
-
Robert Liao authored
BUG=937566 Change-Id: Ie98a37e92c88c6e38376bd81c739696968093841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642741 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#666159}
-
Simon Que authored
Builders migrated (CI/CQ): - Dawn Linux x64 Builder / linux-dawn-rel - Dawn Linux x64 DEPS Builder / dawn-linux-x64-deps-rel - GPU FYI Linux Builder / linux-angle-rel - GPU FYI Linux Builder (dbg) / gpu-fyi-try-linux-nvidia-dbg - GPU FYI Linux Ozone Builder / linux_angle_ozone_rel_ng - GPU FYI Linux dEQP Builder / linux_angle_deqp_rel_ng - GPU Linux Builder (dbg) / gpu-try-linux-nvidia-dbg - Linux FYI GPU TSAN Release / gpu-fyi-try-linux-nvidia-tsn - Linux Viz - Linux remote_run Builder - Closure Compilation Linux - Deterministic Linux - Deterministic Linux (dbg) - Jumbo Linux x64 - Dawn Mac x64 Builder / mac-dawn-rel - Dawn Mac x64 DEPS Builder / dawn-mac-x64-deps-rel - GPU FYI Mac Builder / mac-angle-rel - GPU FYI Mac Builder (dbg) / ~ gpu-fyi-try-mac-amd-retina-dbg ~ gpu-fyi-try-mac-intel-dbg ~ gpu-fyi-try-mac-nvidia-retina-dbg - GPU FYI Mac dEQP Builder / ~ gpu-fyi-try-mac-intel-dqp ~ gpu-fyi-try-mac-amd-dqp - GPU Mac Builder (dbg) / ~ gpu-try-mac-amd-retina-dbg ~ gpu-try-mac-intel-dbg - Mac FYI GPU ASAN Release / gpu-fyi-try-mac-asan - Mac deterministic - Mac deterministic (dbg) - Jumbo Mac Bug: 950413 Change-Id: I57cd72dfba354ca64988dac678a4d1f9952de58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642242Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#666158}
-
Jun Cai authored
This CL implements revoking previously granted permission for Bluetooth Scanning API when a tab is switched to background. Design doc: https://docs.google.com/document/d/1k4WM56Dx7sCu2k2MjvOdXArNz2Dy8BA1vt2VYHA6v7A/edit Bug: 953075 Change-Id: I6690dcab7bfe8b41162cb3d1c98f8c18863955ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614423 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666157}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/e13c1f46dc1a..c949ab0757a2 git log e13c1f46dc1a..c949ab0757a2 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 apodtele@gmail.com Minor. Created with: gclient setdep -r src/third_party/freetype/src@c949ab0757a2 The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com Change-Id: I2f5e43969e40e33e9348a2cf74859d65db3253fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666156}
-
Robert Iannucci authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/779c4f0f8488..3190e3f43b04 $ git log 779c4f0f8..3190e3f43 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 maruel Revert "[client] Rename third_party/pyasn1-modules to third_party/pyasn1_modules" 2019-06-04 iannucci Fix logdog client library on windows. 2019-05-31 maruel [client] Throw a proper failure instead of crashing on failure 2019-05-30 leilei [client] Rename third_party/pyasn1-modules to third_party/pyasn1_modules 2019-05-28 maruel [swarming] Assume creationflags is never None 2019-05-28 maruel [swarming_bot] Make it use its own console Created with: roll-dep src/tools/swarming_client R=crouleau@google.com, martiniss@chromium.org, maruel@chromium.org Bug: 959887 Change-Id: I3504c6af672b19d425eb936bb00c33d82d222297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642679 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#666155}
-
Dale Curtis authored
Now that AVDA is deleted, time to rename and remove lots of stuff! Specifically for this change, we should follow the "codec_" naming style that the rest of our MediaCodec code uses instead of the now dead AVDA prefix. This also fixes some style issues with CodecSurfaceBundle acting as both a class and struct by making it a class w/ accessors and no public values. BUG=none TEST=compiles R=liberato Change-Id: I96e2091ec4736a8bfadf98334576dc316698c00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643951Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#666154}
-
Moe Ahmadi authored
- Adds unittests for the LanguageSettingsMediator. - Uses a PrefObserverBridge instead of a BooleanObserver to observe prefs::kOfferTranslateEnabled as it's more straight forward to stop during the shutdown and more consistent with the other observed prefs. - Adds a method to the data source to stop observing the model which is called during the test teardown as well as by the TableViewController when being shutdown. Bug: 957688 Change-Id: I003df740b56d611717c85193e0d61b592f1f90d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642812Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#666153}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3344e16e55cf..899f7e5389c4 git log 3344e16e55cf..899f7e5389c4 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 zmo@chromium.org Include GPU's driver info in the gpu_device string Created with: gclient setdep -r src/third_party/catapult@899f7e5389c4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967860 TBR=charliea@google.com Change-Id: I08626c7a030f9f9cc8baf2d114896f368f23211a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644612Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666152}
-
Zhenyao Mo authored
TEST=bots TBR=sunnyps@chromium.org Bug: 969117 Change-Id: I2c51dd368e331417d2e5d92fc53dc0eb6a423246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643238Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666151}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I1e57839dbe9ed8d1887a6f6ecc3686bf275df315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643683Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#666150}
-
Eugene But authored
It is common practice to allow everyone to review BUILD.gn files. Change-Id: I8639deb0ed5920948a9703e34fbf5991f105244e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643841Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#666149}
-
Will Harris authored
This reverts commit c3a6c5f3. Reason for revert: Causes bug 969624 Original change's description: > Moved last version cache from the origin-policy throttle to... > > ... the network service origin policy manager. > > This is step 4 of: > https://docs.google.com/document/d/1heiIgNdO7kbaU9BLOPO4wZ9maHScB87cGT5lyjeBVAM/edit#heading=h.4en9va43fgfj > > This also includes a second in memory structure for the actual policy > contents that was not present in the origin policy throttle. > > Bug: 950905 > Change-Id: I493e66f97c68263e1110d9ecfa724cee0ee8310f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627036 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Auto-Submit: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665427} TBR=dcheng@chromium.org,mmenke@chromium.org,vogelheim@chromium.org,alexmos@chromium.org,mkwst@chromium.org,andypaicu@chromium.org,carlosil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 950905, 969624 Change-Id: Iafe94a7ce9dceb1f073fa3ad9ffd5725a4c0fa30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644176Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#666148}
-
Richard Li authored
This CL change the type of DataElement::buf_ and bytes_ from char to uint8_t, which makes the conversion with its mojom type more convenience. Change-Id: I1c60db81e16137ffe2e0d98d6efbecd8427fa206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636969Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#666147}
-
Jon Mann authored
Adds an UNSPECIFIED entry to the 0 index for all enums within the WifiConfigurationSpecificsData proto. Bug: 966270 Change-Id: I7a6c97bb75463fd4a9346581b5a831003ceda687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642137 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#666146}
-
Shu Chen authored
Bug: 965908 Change-Id: I23bf5a3da2d31161fcbc3ef10385c5c916bebda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642608 Auto-Submit: Shu Chen <shuchen@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#666145}
-
Asanka Herath authored
Net.HttpAuthCounts measures the number of authentication sessions started and rejected by HTTP authentication scheme. But we don't have data on how many NTLM sessions that were started had NTLMv2 enabled. The numbers here will guide deprecation efforts for LM/NTLM protocols which will result in the removal of non NTLMv2 codepaths. Bug: 959402 Change-Id: I5263b32e97f97f1ef3fe3fba41067ec7ff779136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641992 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#666144}
-
Luciano Pacheco authored
Fix fakeTouchClick to only issue touch related events when emulating touch in the integration tests. The test helper function fakeTouchClick was issuing "mousedown" and "contextmenu" to make the only test using it to set the desired state. The actual problem in the test is that the fakeMouseRightClick helper function wasn't issuing "click" to trigger the correct event listener to set the desired state. Fix fakeMouseRightClick to issue all mouse events as it happens if real user interactions: * mouseover * mousedown * mouseup * click * contextmenu Refactor fakeMouseClick to receive an optional button to be able to re-use it for right-click. Test: browser_tests --gtest_filter="ContextMenu/FilesAppBrowserTest.Test/checkContextMenusForInputElements" Change-Id: I4eb6d93f46b5602256dc03fd49400b3e8e8aa6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642751 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#666143}
-
Justin Cohen authored
Updates various files with to conform to iOS13 SDK headers changes: Nullability and availability changes Updates security types Updated default values (modalPresentationStyle) Updates objc_zombie with IMP changes (as well as adding the accidentally-omitted tests) TBR=rohitrao Change-Id: I7d88a8c0fbb764484050be67dd33adcd11d343dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642508 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666142}
-
Chih-Yu Huang authored
Originally, we run VEA unittest to verify every Chrome OS board by autotest. We filter known-to-fail test cases at autotest implementation. However, we plan to switch Tast framework. Tast does not allow us to skip the test case according to the board at runtime. Therefore, we decide to skip the test cases inside the test binary. BUG=chromium:957475 TEST=run test binary at Kevin and confirm the test at blacklist is skipped Change-Id: I16e998b1ef89dab751b9e440e53d22dee831209b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635085 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#666141}
-
Daniel Rubery authored
When an Advanced Protection user sees a warning, we should send them to the AP-specific FAQ page, which will include details about what kinds of files show warnings for that population. Bug: 917190 Change-Id: I12156cb502c04c9bd826b112a692e979e4e4d0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635206Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#666140}
-