- 29 May, 2019 40 commits
-
-
Kyle Milka authored
This test didn't work properly as it was waiting for the MV tiles to be initialized with a single default shortcut but if the feature is enabled there should be two default shortcuts. Bug: 968073, 962558 Change-Id: Id69c1c4c6748067eacd776550aa87cd160cf7656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636391Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#664517}
-
Jacob DeWitt authored
Bring frame rate on debug builds for the input-selection.html webxr sample page with 2 controllers connected and the gamepad data table sections expanded from ~10fps to ~40fps by doing the following: 1) Update tables in-place instead of re-creating them on each frame. 2) Only update table data if something changed since the last update (instead of unconditionally updating the innerHTML every frame). 3) Only update tables once every 10 frames instead of every frame. 4) Don't create or update gamepad tables unless the related sections on the page are expanded. Those sections start as minimized. Bug: 967844 Change-Id: Ifb10fa3f20a781c5f01632c6b1e1d62e2dd0c04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634725 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#664516}
-
Ian Vollick authored
Dino tests have been moved to a separate DinoActivityTest. I've also disabled the currently broken safe browsing test. See crbug.com/947232 Bug: 968239 Change-Id: I546a464580a6b0d13fe9d568572486ab89ea62db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634426 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#664515}
-
Sam Goto authored
Handle the following scenarios: - One origin making multiple calls serially AND concurrently. - Two origins making multiple calls and SMSes being received out of order - SMSes timing out - Receiving unexpected SMSes To handle these scenarios, we introduce an observer list in SmsProvider which notifies OnReceive() and OnTimeout(). We make the SmsManagerImpl implement the mojom interface and an SmsObserver interface, keeping track of individual GetNextMessage() requests as well as observing events in the SmsProvider. A visualization of the architecture can be found here: Design Doc: https://docs.google.com/document/d/1TG7BzAPdt2DWNOmephxNf09kdzDKYq8l6Z126oSif8I/edit#heading=h.s84nhvrqhwl3 Bug: 670299, 960878 Change-Id: I71a3818e23dc620a2a762ac8e5d0583dbcdf9e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604055 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#664514}
-
Wez authored
Non-main threads now inherit the PT_GNU_STACK size by default, so DAV1D should be able to run correctly on them. Bug: 930300 Change-Id: I17dd7476dee7f839d5fd0c9035df2120377c9c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635970Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#664513}
-
Collin Baker authored
The new TabGroupId is backed by a base::Token so it can be meaningful across different sessions. This will simplify the sessions code. A new class is used for the ID instead of just a base::Token to avoid mixing it up with other base::Tokens and to avoid similar mechanical changes later on. Bug: 930991 Change-Id: Ib0869730bff26fe182a4cb9398f1bb643547b1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629043 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#664512}
-
Xianzhu Wang authored
In, https://chromium-review.googlesource.com/c/chromium/src/+/1614448, I mistakenly removed the TransformAccumulation parameter when TransformState::ApplyTransform() calls TransformState::Move() for 2d translations Bug: 968112 Change-Id: I1c628f3884f89f726a9fdc757e8db78469545c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635864Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#664511}
-
Tomasz Wiszkowski authored
This change updates the looks of the Answer- and Entity suggestions to match the design: http://docs/presentation/d/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk?pli=1#slide=id.g45b058cd36_0_146 http://docs/presentation/d/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk?pli=1#slide=id.g3ce78ec162_0_50 Bug: 930349 Change-Id: I7fa62d6349ee7b30b44a4c28a4a0dfd82e1f33ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632902 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#664510}
-
Sorin Jianu authored
A few changes to WTL were made, as described in the README.Chromium file. The changes include fixing compile-time issues such as semi-colon after the end of a namespace definition (error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]) and unused results due to calling ATLVERIFY in a couple of places (error: expression result unused [-Werror,-Wunused-value]). Also, changes in the include order in Chromium code were made to make WTL code compile by including base/win/atl.h before the ATL/WTL headers. I am landing the change without presubmit checks, as WTL code does not pass our presubmit checks. NOPRESUBMIT=true BUG=965788 Change-Id: I181f838d0ea2953dcffa3929ee833d4a8936dde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623506 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#664509}
-
Ryan Hansberry authored
Add crbug component OS>Systems>Network>Bluetooth. Bug: None Change-Id: I9bbb1d575d78b04a30db5123b8673bb34d0179dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629434Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#664508}
-
Mattias Nissler authored
BUG=chromium:967396 TEST=None Change-Id: Ic621fd170857a99c706bdc6f1e9987b71d1a3619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636349Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#664507}
-
sczs authored
- This will dismiss the Keyboard if the user taps outside of it. - If the user taps a view that takes a tap gesture (f.e. a button like Reveal/Hide password) the keyboard will not be dismissed since this touch will be handled by the view. Bug: 911864 Change-Id: I74c0e7098c95cb52e42925f647ce485f548bf43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627300Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#664506}
-
manuk authored
This is the 16th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. The historyQuick provider compares the user input and the suggestion text to find the corresponding matches during construction of the ScoredHistoryMatch precursor to the suggestion's AutocompleteMatch. The term matches are then used for both scoring and classifying. With this CL, historyQuick classification uses the 'FindTermMatches' and 'ClassifyTermMatches' methods that other providers use. This improves consistency with other providers at the cost of inconsistency with the historyQuick provider's scoring. The differences between current and this CL's classification: 1) Prefix matching. With this CL, if the input is an exact prefix of the suggestion text, subsequent matching words in the suggestion text are not bolded. E.g. for input 'x' and suggestion 'x x', before this CL, both occurrences would be bolded; with this CL, only the first will be. 2) Midword matching. Before this CL, midword matches were allowed for the URL host domain. E.g., for input 'x' and suggestion 'zxx.xx/xx', before this CL, the first 5 occurrences would be bolded, 'z[xx].[xx]/[x]x'; with this CL, only the 3rd and 4th will be bolded, 'zxx.[x]x/[x]x'. 3) Input word-break separators. Before this CL, the user input was not broken by symbols, though the suggest text was. E.g., for input 'x%x y' and suggestion 'x%x x y%y y', before this CL, it would bold as '[x%x] x [y]%[y] [y]'; with this CL, it will bold as '[x]%[x] [x] [y]%[y] [y]'. All 3 changes apply to suggestion classification (bolding) only; determining which suggestions to display and their ordering is unaffected. Re consistency with other providers: A user may see suggestions from different providers with similar texts. E.g., the user input 'the' could provide both search and historyQuick suggestions with texts 'the cake ate the moon'. It would be surprising if such suggestions with the same text were bolded differently; e.g. the search suggestion were bolded '[the] cake ate the moon', whereas the historyQuick suggestion was bolded '[the] cake ate [the] moon'. Re inconsistency with historyQuick's scoring. Scoring is consistent with the previous bolding; all previously bolded terms would either contribute (positively or negatively) to the suggestions score or disqualify the suggestion (e.g. 'm' disqualifies 'yahoo.com'). E.g., 'y hoo' would bold both terms in the suggestion URL '[y]a[hoo].com', and both would contribute to the score. With the classification changes, only 'y' would be bolded, suggesting the 'hoo' term did not contribute to scoring. Bug: 366623 Change-Id: I478a9d4fcc63abe7aa55dba4274e8896d6bdc388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593717 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#664505}
-
Owen Min authored
The class uploads report and retries in case of some errors. Bug: 956237 Change-Id: Icba6ae19684066bc9dcd2f95448f030015da1d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630984 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#664504}
-
jfwang authored
Add metrics to histograms.xml file. Each tab/iframe creates a new scheduler client. Many of them work independently and may contend each other for the underlying resources. Track the number of active scheduler clients to understand the severity of this problem. A resource scheduler client is active when there is at least 1 request in the pending request queue or in flight. Record the number of active resource scheduler clients when creating a new resource scheduler client. Bug: 964490 Change-Id: I059db88a6556f39241bb31334c50a0e5328ed03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630028Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Jianfeng Wang <jfwang@google.com> Cr-Commit-Position: refs/heads/master@{#664503}
-
Nate Chapin authored
Bug: 966975 Test: fast/loader/iframe-navigation-stealing-focus.html Change-Id: Ife6548f349e9cecca2ad13fcd549fa07ad01499d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627756Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#664502}
-
Alexander Hendrich authored
This CL adds a new extension API "loginScreenUi", which can be used to display custom UI on the login screen. The generated window will only be visible on the login and lock screen. This API will only be available to whitelisted extensions of type "login_screen_extension". API proposal: go/api-login-screen-ui Design doc: go/dd-login-screen-extension-ui Bug: 957573 Change-Id: Ie9f936af9fd21e9b324f5bbbd8448790f8d33c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556806 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664501}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2ee83757a109..96104d42dad1 git log 2ee83757a109..96104d42dad1 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 vadimsh@chromium.org [cipd] Update lucicfg 1.7.7 => 1.7.8. Created with: gclient setdep -r src/third_party/depot_tools@96104d42dad1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:966603 TBR=agable@chromium.org Change-Id: Ib9b73fa5cb42fcc8e6882a814df060eb82267585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635533Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664500}
-
Miyoung Shin authored
This is a follow-up CL for https://crrev.com/c/1597496 that updates manifest.mojom to make the start_url, icons, related_applications, splash_screen_url, and scope members non-optional in order to follow the web app manifest spec (https://www.w3.org/TR/appmanifest/#processing). Bug: 704441 Change-Id: I92c6d8c220e05c9394d62a06ca4450191f1c552d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633695 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#664499}
-
Ian Clelland authored
This allows all client hints to be potentially delegated to third-party requests. By default, no hints (Except for the simplified UA hint) are sent with any third party resource requests, but these can be enabled for specific origins through the use of Feature Policy. Bug: 968201 Change-Id: I60a94deb0e5553b85da351f08cbabfc8ae0f6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584400 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#664498}
-
Alex Moshchuk authored
This CL fixes a process model bug which resulted in an attempt to reuse the current process for cross-site navigations if the current frame's process died after starting the navigation but before receiving the response. The problem was in an IsRenderFrameLive() check in GetSiteInstanceForNavigationRequest(), which incorrectly led to picking the current SiteInstance in this case. This check was introduced in r377920 but it's not clear if there was a reason for adding it. This CL removes it. Bug: 968259 Change-Id: Ibf0dd6a6b6bf0c3a8c9192a2225ec2f5aa87c256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633591 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#664497}
-
David Benjamin authored
ClientCertStoreWin, if passed an explicit HCERTSTORE (used in //remoting), will perform all operations on the caller's thread. Replace this with a callback: - This makes ClientCertStoreWin a bit more uniform. - Matching Chrome, we avoid blocking the network thread in //remoting if the OS store is slow. - This keeps everything consistently on the SSLPlatformKey thread, which is sometimes necessary to avoid potential thread-safety bugs in smartcard drivers. Note this causes each GetClientCerts() call to call CertOpenStore() anew in //remoting. This aligns better with Chrome behavior (where we intentionally open "MY" anew each time) and is moot anyway because both Chrome and //remoting only use each ClientCertStore object once. We create new ones each time. Bug: none Change-Id: I2bb5db8f85735fec5d66dc22bda1aee663644c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626501Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#664496}
-
Robert Liao authored
BUG=897377 TBR=sky@chromium.org Change-Id: Id565623ba035da1bc3e57688a5740eeabf4b08d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634618Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664495}
-
Wez authored
Change-Id: I635209f6fd625c3f766200266146494e0d5bbc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628000 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664494}
-
Matt Menke authored
This method isn't used in production code. It is used by chromeos/services/assistant/default_url_request_context_getter.h, which isn't used anywhere, since the network service is being used instead. This CL also removes that class. Bug: 910366, 878582 Change-Id: If41cc48b1a65c68827a28224c4bf8073440503e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635202 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664493}
-
Clark DuVall authored
We set the cert verifier on network context unconditionally since the FeatureList is not set up at the time the MockCertVerifier is set up in the WebApkIntegrationTests. This should be fine if the network service is run OOP or if network service is disabled, since the cert verifier set as a global in the browser process for NetworkContext will just be unused in those cases. Bug: 917467 Change-Id: Id97f877c955959b88f05167c779abfcd3a10f831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635951Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#664492}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d15049dacabe..31adc7db3619 git log d15049dacabe..31adc7db3619 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 rkolchmeyer@google.com chromeos_config: Set paygen_skip_test=True for lakitu builders. Created with: gclient setdep -r src/third_party/chromite@31adc7db3619 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I725de8ee556b07762b0a29fcf1c82596acbb209f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664491}
-
Scott Little authored
This CL updates the fieldtrial testing config to reflect new LazyLoad parameters that have been added. These parameters reflect what will be launched. Bug: 937980 Change-Id: If5a9ebd4350d0f40989f890f939e4c1a4f826ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635362 Auto-Submit: Scott Little <sclittle@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#664490}
-
Jeffrey Cohen authored
This reverts commit fa4a217a. Reason for revert: failing the following tests on https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/13197 HeapCollectorCollectionParamsTest.ParametersOverride_Tcmalloc HeapCollectorTest.CheckSetup_Tcmalloc HeapCollectorTest.DumpProfileToTempFile_Tcmalloc HeapCollectorTest.IncognitoWindowDisablesSamplingOnInit_Tcmalloc HeapCollectorTest.IncognitoWindowPausesSampling_Tcmalloc Original change's description: > Make the new tcmalloc the default for Chrome OS > > The new tcmalloc has been enabled on three Chrome OS boards since R72, > and on ten additional boards accounting for over 50% of users in the > wild since R75. It has also been the default on Linux for over one month. > > BUG=chromium:724399,b:70905156 > > Change-Id: Id1f49f66a963c9a327edeee3e85d0d128c9de78c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630233 > Commit-Queue: Gabriel Marin <gmx@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664303} TBR=dpranke@chromium.org,halliwell@chromium.org,gmx@chromium.org,jasonroberts@chromium.org Change-Id: I1725b05e1c363b801e6ad7dac303ec3c6cb85c39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:724399, b:70905156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636589Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664489}
-
François Doray authored
With this CL, a task posted with: base::PostTaskWithTraits( FROM_HERE, {base::TaskPriority::BEST_EFFORT, ...}, base::BindOnce(...)); Will not be allowed to run before startup is complete. The signal used to know that "startup is complete" is the same as AfterStartupTaskUtils. It is not perfect. It will be improved in a separate CL. This CL aims to be the smallest change possible to allow seamless migration of BrowserThread::PostAfterStartupTask() to base::PostTaskWithTraits(). Bug: 887407 Change-Id: I83ef387b82496ece3ed10c0c2466f42a6a5b19b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631668 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#664488}
-
Becky Zhou authored
We introduced CompatibleAlertDialogBuilder to work around support library issue at https://crrev/c/1626009 + Modify the current presubmit check to check CompatibleAlertDialogBuilder + Add an error that CompatibleAlertDialogBuilder should be used instead of the AppCompat AlertDialog.Builder Bug: 966101 Change-Id: Ic3280f3c2b2ab99d72086eaa26cbe9f6c57c69b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625845Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664487}
-
Scott Violet authored
It turns out pepper expects a call to fullscreen to synchronously change the bounds. Recent changes to NativeViewHost meant that Attach() did not synchronously change the bounds, which broke pepper fullscreen. This patch makes WebView call Layout() right after Attach() to ensure the bounds are up to date for pepper. BUG=959118 TEST=none Change-Id: I35d4461347557735af9b19dab58c2bd2d71b733d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633830Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#664486}
-
Takumi Fujimoto authored
Make the get_sinks API return sink structs instead of sink name strings. Bug: 963963 Change-Id: Idb6b555544f29aaa308b8d289335073348c653f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615982Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#664485}
-
Brian Sheedy authored
Fixes the VrBrowserWebInputEditingTest#testTextSelection flakiness on Nougat devices (for real this time) by further decreasing the rate at which clicks are sent to the content node. TBR=billorr@chromium.org Bug: 953990 Change-Id: I016b3dc845df4d6c7fd461688a222bc16f4e4c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634724Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#664484}
-
Scott Violet authored
This removes services/ws/public from views DEPs as it's not needed. This also adds an explicit DEP from views onto ui/latency, and an explicit include from HWNDMessageHandler (which is using ui/latency). ui/events has a public_dep on ui/latency, but ui/latency is a source_set. Views was likely getting ui/latency via services/ws/public/public some how. With the services/ws dep removed, link errors results. As ui/latency is a source_set and views is directly dependencing upon ui/latency, views should have an explicit dep on ui/latency. BUG=964460 TEST=none Change-Id: I5bc159b7cfe8dd15089ff88200cad8692a5b1572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635772Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#664483}
-
about://gpumagchen authored
Some gpu bugs are related to the monitor refresh rate. Adding this display information will help us on gpu debugging. Bug:964095 Change-Id: Ieaea44502c14a0eba7b0f664d402474d3694616e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629176Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664482}
-
Steven Bennetts authored
This includes mojo support for: * ip address * mac address * RequestScan() Bug: 862420 Change-Id: I7070ec82f898ca01f94de72ecfbe608f5e803ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627894Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#664481}
-
Peter Kotwicz authored
This CL: - Decreases the WebAPK update check interval to 1 day. This makes testing less frustrating - Removes WebappDataStorage.RETRY_UPDATE_DURATION now that it is the same duration as WebappDataStorage.UPDATE_INTERVAL BUG=968252 Change-Id: I6db0e489427613f15d69b449efa3b3a2573e3014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635860Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664480}
-
Caroline Rising authored
While a tab hover card is animating between tabs the hover cards anchor view is in transition and the tab hover card's data is updated before the anchor is moved. Because of this, GetThemeProvider() was not using the correct tab, this cl gets the theme provider from the correct tab that the hover card is moving to. Bug: 968055, 910739, 928954 Change-Id: Ide4f109ea66c206da1c6fb9c8c785282694ccadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635857 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#664479}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/197827edb87e..0308a9a13261 $ git log 197827edb..0308a9a13 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 marpan vp9-rtc: Update overshoot_detection speed feature 2019-05-25 jzern Revert "Fix calculations in GF only group case" 2019-05-08 venkatarama.avadhani Exclude VP9 files from vpx_dsp.mk for VP8 build 2019-05-21 jingning Clamp for min_frame_target 2019-04-22 ravi.chaudhary Increase active best quality linearly 2019-04-26 deepa.kg Fix calculations in GF only group case 2019-05-14 deepa.kg Fix section intra rating for first ARF interval Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I330a76607a73f6aa4f11598b506b87410be36c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635829Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#664478}
-