- 18 Mar, 2020 40 commits
-
-
manukh authored
Enabled by default since m79 (crrev.com/c/1782674). Bug: 856335 Change-Id: I2842b63a13545725cf97aaa0cd156e8a87ea0e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065330Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751351}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e5c9f6d10689..4c07605f8d55 git log e5c9f6d10689..4c07605f8d55 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 hbos@webrtc.org [Adaptation] VideoStreamAdapter unit tests added. Created with: gclient setdep -r src/third_party/webrtc@4c07605f8d55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9ab3e2a1e341f689f8414a07fdc9e0d5f5fc90c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751350}
-
ckitagawa authored
In rare cases it was possible a renderer vanished taking the PaintPreviewDocumentData with it before the PaintPreviewClient was destroyed. This resulted in the invocation of an empty callback causing a crash. This CL audits all use of document_data to ensure it is safe. Bug: 1062434 Change-Id: Ie5e800755902f66d5c6b3a46f956fb522bde97f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106383Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#751349}
-
Mustaq Ahmed authored
This CL fixes/refactors existing tests to prepare for new WPTs for UAv2. - Fix a test name suffix. - Fix github issue number. - Make postMessage format consistent. - Clarify a child-frame name. - Replace parent refs to "top" to allow deep iframes. Change-Id: I9da97ee827d6556116eab9d592e44665dc71d4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106538Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751348}
-
Francois Doray authored
MessagePump::Delegate::DoWork/DoDelayedWork are being removed in favor of DoSomeWork. This CL updates MessagePumpFuchsia to use DoSomeWork to unblock that migration. Bug: 885371 Change-Id: Ibe7ca894ac866e3287f301f70505195a2b5d6d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068827Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#751347}
-
Delan Azabani authored
This CL migrates the remaining comparisons involving an ASCII literal from DeprecatedEqualIgnoringCase to EqualIgnoringASCIICase (except the comparisons being reviewed under <https://crrev.com/c/2106983>). These changes are potentially author-facing, but I’ve optimistically made them without any additional tests based on Rick Byers’ reasoning on blink-dev [1]. Please let me know if that’s not sufficient here. The engine changes are a curated subset of the following replacement under Sublime Text 2 (PCRE): Find: (?x-i) (?<escape>\\['"?\\abfnrtv]){0} (?<literal>"(?:(?=[ -~])[^"]|(?&escape))*"){0} (?<any>(?:[^(),]|(\((?:[^()]*|(?-1))\)))*+){0} DeprecatedEqualIgnoringCase (\s*\(\s*+(?: (?&literal)\s*,\s*+(?&any) |(?&any)\s*,\s*+(?&literal) )\s*\)) Where: *.cc,-/path/to/src/out/*,-/path/to/src/.clangd/* Replace: EqualIgnoringASCIICase$5 [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ Change-Id: If6e1963da8128e3044df38f1924d98089e7d215a Bug: 627682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108441 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#751346}
-
Yann Dago authored
Bug: 958893 Change-Id: I6d546ba5c5d88bbb1f525f5296e7f44c30c76b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093538 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751345}
-
Manu Cornet authored
Change-Id: I4b791af99d81f23f1fb257653f01513cd1f9b82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108088Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751344}
-
Mohamed Amir Yosef authored
This CL reverts most of [1] since a const override of GetPasswordFeatureManager() is actually required and will be used in a follow CL. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2030866 Bug: 1002000 Change-Id: I8a3978b3ab0312c50d2c3667ed90711c19f4cf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105379 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751343}
-
Alex Ilin authored
SigninViewController::ShowReauthPopup() will start showing a popup window with a reauth page if "SigninReauthPrompt" feature is enabled. This popup observes all navigations and reports success once a special reauth endpoint is successfully loaded. This endpoint is currently available only on test Gaia. The behavior of ShowReauthPopup() without the feature flag also has changed. Now Chrome will display a fake reauth dialog by default. ShowReauthPopup() is still in development and shouldn't be used without a flag anyways. There is no need to guard it behind another feature flag. The screen recording of the resulting flow is available at https://screencast.googleplex.com/cast/NTM5Njc2MjgxNjY3NTg0MHw0MTg2MGQ0OS02Yg Bug: 1045515 Change-Id: I8a685b593dadec3ec059c77a6a4eccb946f4c98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107840 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#751342}
-
Tom Anderson authored
BUG=None R=sky Change-Id: I46c44a85089ed1f2dd226c1e3df00991fad95864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097463 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#751341}
-
Omer Katz authored
Vector::Fill uses std::fill, which I believe is not safe for concurrent marking. Currently there are no usages of Vector::Fill for on-heap vectors. Disabling Vector::Fill for on-heap vectors will give a compile time error if anyone tries to use it. I think we can avoid introducing an atomic version of Vector::Fill and revisit it if and when such a usage is wanted. Bug: 986235 Change-Id: I7ac1cb95be3456d86e75f39e0aaf27120e388a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106057 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751340}
-
Elly Fong-Jones authored
It's not used or referenced anywhere. Bug: None Change-Id: Ie3a7716023cc79a22f22980d9c90f9b0609a31be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108621 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#751339}
-
Rainhard Findling authored
* Prepares the safety check UI to receive a pluralized string to show in the 'Change password[s]' button, depending on if one or multiple passwords are compromised. * Adds the C++ side string construction w/ tests. Bug: 1015841 Change-Id: I4cf1b2197536f2cd7fbc606f8f167976cfc74f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107549Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#751338}
-
Elly Fong-Jones authored
Bug: 27059 Change-Id: I135c1bbd498cf4d3769718f91ddd486d2cd4c9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106564 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#751337}
-
Johannes Kron authored
Bug: 1061376 Change-Id: I4f3e460dc971f76cb8ebb4f37b7bedb0a1cfc9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106581 Auto-Submit: Johannes Kron <kron@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#751336}
-
Domenic Denicola authored
Now that https://crbug.com/1060740 is fixed, we can add a test that parameters are ignored in the allowed=() inner list. Also this adds an additional failure case test that I came up with while working on https://chromium-review.googlesource.com/c/chromium/src/+/2106417. Bug: 1042036 Change-Id: I89ee5423aaafc9a48646e44a605f5bd326256306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106556Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#751335}
-
Domenic Denicola authored
Fixed: 1060184 Change-Id: I8e16621050b2a37d8126b7edc3d9c10d2442758b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106560Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
In this CL, we replace base::Bind() with BindOnce/BindRepeating. BindOnce is preferred, so here is the rationale for the BindRepeating cases: * In SearchBouncer, the base::Bind is used as a parameter of AddInterface(), which requires a repeating callback. It also makes sense to allow for multiple receivers. * In TranslateAgentBrowsertest, it is used as a parameter to SetBinderForTesting, which also requires a repeating callback. Both Repeating cases are associated to methods in Blink which are already marked as receiving repeating callbacks. Bug: 1007641 Change-Id: I03c1b25669a63e58ce5b384f301d2c5b1399e0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107716Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47d5b94b..56a118c8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1036be718b67a798d7aaccb9987cba4202687807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108640Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751332}
-
Jan Wilken Dörrie authored
The current migration to Polymer 3 mistakenly used `clang-format-on` instead of `clang-format on` after turning `clang-format` off via `clang-format off`. This resulted in clang-format effectively being disabled for affected files, this change fixes it. Steps: - sed 's/clang-format-on/clang-format on/g' - git cl format --js --full TBR=dpapad Bug: 1026426 Change-Id: I4364d325e3e7df1add0f83d93e8b18453f6014e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107591Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#751331}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/02d03f4ef2db..6d51bf00ea3c git log 02d03f4ef2db..6d51bf00ea3c --date=short --first-parent --format='%ad %ae %s' 2020-03-18 tvanderlippe@chromium.org Factor out Runtime to root/Runtime.js 2020-03-18 aerotwist@chromium.org [global] Remaps self.Bindings.debuggerWorkspaceBinding Created with: gclient setdep -r src/third_party/devtools-frontend/src@6d51bf00ea3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic721c20d78b05e596f55d4036258c474456fe812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108590Reviewed-by:
-
Danyao Wang authored
Bug: 1061969 Change-Id: I23cc1fe2900e52c501819c04a3840337cb6b2eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107543Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751329}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f98084edfc01..78a85f2c1856 git log f98084edfc01..78a85f2c1856 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 m.maiya@samsung.com Vulkan: Request device local memory for glBuffer with GL_STATIC* usage Created with: gclient setdep -r src/third_party/angle@78a85f2c1856 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Id4c5da081df650beecb1070ea4bb6a397d32a657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108589Reviewed-by:
-
Oriol Brufau authored
r745834 enabled LayoutNG for listbox SELECTs and updated the expectation of select-popup-appearance-basic.html since it's different in LayoutNG. But then it started failing in legacy layout. Bug: 1040826 Change-Id: I5f6a816fd9f40bb2625dbbfa462742e3dbf09f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107590Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#751327}
-
Yuly Novikov authored
This reverts commit b8530cca. Reason for revert: breaks compilation on ANGLE CQ https://luci-milo.appspot.com/p/chromium/builders/ci/GPU%20FYI%20Win%20x64%20dEQP%20Builder/52743 Original change's description: > Roll src/third_party/glslang/src f368dcbb7d8a..c7910056825a (1 commits) > > https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f368dcbb7d8a..c7910056825a > > git log f368dcbb7d8a..c7910056825a --date=short --first-parent --format='%ad %ae %s' > 2020-03-18 johnkslang@users.noreply.github.com Merge pull request #2130 from dgkoch/EXT_ray_tracing > > Created with: > gclient setdep -r src/third_party/glslang/src@c7910056825a > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/glslang-chromium-autoroll > Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com > Change-Id: Iaaa4eb244b12c3c8c56dc7ed62e95b1791f2d7be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108078 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#751320} TBR=courtneygo@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com,radial-bots+chrome-roll@google.com Change-Id: Icbebdee259a668a896b56f29501e5d4873dc0b5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106384Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#751326}
-
Hyunjune authored
This patch fixes up incorrect sizing of SVG Image with referred SVG image without the intrinsic size. So when referred image is SVG, it currently checks that referred image has aspect-ratio. If referred svg image doesn't have the aspect-ratio, set the concrete object size from the 'default object size'. Bug: 1045932 Change-Id: If979b3a9a7980bde9e2bee38ba2863cf223b4f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094055Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#751325}
-
Fredrik Söderqvist authored
The generic cycle solver should find (and break) these cycles as well. Bug: 1028063 Change-Id: Ic3773ae49f41b3c7e84f6aabe52d954cdf009374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108502Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#751324}
-
Liquan (Max) Gu authored
Before Change: The javadoc said the types "mirror" those in mojom, which is not precise. After Change: The javadoc says the types "correspond" to those in mojom, with minimally required fields. Change-Id: I5fd70662d7575f84cab63b1cad39ba94f3218b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105670Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751323}
-
Andrew Grieve authored
This reverts commit 0b8c0e6a. Reason for revert: Fixed runtime deps Original change's description: > Revert "Make java_deobfuscate not require being built first" > > This reverts commit 962e7030. > > Reason for revert: Failing on swarming > https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747 > > Original change's description: > > Make java_deobfuscate not require being built first > > > > Makes the tool easier to use, and easier to document how to use by not > > requiring it to be built first. We have only a single non-prebuilt .java > > file, so it's easy enough to just check in the .class file for it. Bug: 995290 Change-Id: Ib1f396e07d6b0737133f03f1bded1a2d312ebfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106972 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#751322}
-
Hiroki Sato authored
AccessibilityNodeInfoDataWrapper::PopulateAXRole assigns a Chrome role to each node, and the last logic to decide a role is using an Android class name. Some Android app disguise its class name to control what TalkBack announces. This is sometimes helpful, but may break ChromeVox navigation. Gmail has a header which ax tree looks like below: ++ textField [Search mail] ++++ button [Open navigation drawer] ++++ genericContainer [Compose] ++++ genericContainer [Open account menu] The root of this is assigned textField role from its className. Clicking the node opens the input field, so that role should not be textField. (Note that these four nodes are all clickable.) This change deletes EditText from the map of className to Chrome role. Even after changing this, as normal textFields have editable property, their role is populated correctly. Bug: b/150827734 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open Gmail, and OpenSearchBar is correctly focused. Change-Id: I7d0f867ba842585d7c222b9f96edfd958e5ad90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104743Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#751321}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f368dcbb7d8a..c7910056825a git log f368dcbb7d8a..c7910056825a --date=short --first-parent --format='%ad %ae %s' 2020-03-18 johnkslang@users.noreply.github.com Merge pull request #2130 from dgkoch/EXT_ray_tracing Created with: gclient setdep -r src/third_party/glslang/src@c7910056825a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Iaaa4eb244b12c3c8c56dc7ed62e95b1791f2d7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108078Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f297c2cef4e4..64472dfcc5d1 Created with: gclient setdep -r src-internal@64472dfcc5d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010568 Tbr: jbudorick@google.com Change-Id: I8f544a9b6eb291ad38dbc0daecb7304924007a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108585Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751319}
-
Maxim Kolosovskiy authored
client The field should be initialized with nullptr. Bug: 1057608 Change-Id: I6d5eb00858f4998f0b67f87ab219646c3eaa9681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106069 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#751318}
-
David Van Cleve authored
This change gives URLLoader an optional std::unique_ptr<TrustTokenRequestHelper> argument. This will be provided by URLLoaderFactory whenever the request at hand has been configured for a Trust Tokens operation (see design doc, below). - A TrustTokenRequestHelper is responsible for executing two parts (outbound, via |Begin|, and inbound, via |Finalize|) of a single protocol operation. - Each request will have at most one associated protocol operation. In the long run, perhaps a handful of requests per page load will have associated protocol operations. (Initially, this number will be lower, as the current version of the API is a prototype to be used for limited experimentation.) The outcomes of a protocol operation are: - Begin (executed on outbound request) fails -> the entire request should fail immediately with ERR_TRUST_TOKEN_OPERATION_FAILED - Begin finds that the protocol operation's desired result is already stored locally -> the request should fail immediately with ERR_TRUST_TOKEN_OPERATION_CACHE_HIT - Begin succeeds, Finalize ("inbound" operation executed on the response) fails -> the request should fail with ERR_TRUST_TOKEN_OPERATION_FAILED - Begin and Finalize both succeed -> the request should succeed if it would otherwise succeed This change also adds a TrustTokenOperationStatus field to URLLoaderCompletionStatus; this will subsequently be used to propagate operation results back to the corresponding Trust Token API method return value in Blink. Trust Tokens design doc: https://docs.google.com/document/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit Bug: 1042962 Change-Id: I402a2d8c63cf726a9f27b135c7df575a94d77afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062869Reviewed-by:Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751317}
-
Mark Cogan authored
As part of preparing for multi-window, the URLLoadingService needs to be migrated to be a BrowserAgent instead of a KeyedService. That change is itself fairly large, but as an additional complication URLLoadingService is used in downstream code. This CL is the sixth in a series of changes needed to complete this refactor: 1. (crrev.com/c/2089687) Add a new provider API upstream that passes both a Browser and temporary URL loading shim to CreateLogoVendor. 2. Implement this new API downstream and add support for initializing the LogoController with both Browser and the loading shim. Use the loading shim for loading URLs if it is present. 3. (crrev.com/c/2089785) Upstream, call the new CreateLogoVendor() API. 4. Downstream, remove support for the old CreateLogoVendor() API and update LogoController to only be initialized with a Browser and the shim loader. Remove downstream use of the URLLoadingService. 5. (crrev.com/c/2105314) Upstream, refactor URLLoadingService to be URLLoadingBrowserAgent, updating the upstream implementation of the loading shim passed downstream in CreateLogoVendor(). 6. Upstream, add a new provider API that no longer passes the loading shim into CreateLogoVendor(). Delete the now-unused provider API that was removed downstream in step 4. 7. Downstream, remove use of the loading shim from LogoController and have it fetch the URLLoadingBrowserAgent from its Browser parameter. Implement the new shim-less CreateLogoVendor() API. Have the old shimmed API call the new shimless one. 8. Upstream, call only the new shimless API. Remove the shim implementation in calling code. 9. Downstream, remove the shimmed API. 10.Upstream, remove the shimmed API, including the shim definition. Bug: 1046374 Change-Id: I12874b8c0d6674b03cee22141b67bc32788fa4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106182 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751316}
-
David Van Cleve authored
Blink will want to be able to interpret TrustTokenOperationStatus values since it will be providing them to Trust Token API clients; mojoifying the status enum makes this easier, and also allows sending the status values for Trust Tokens operations executed via Mojo (like "hasTrustToken," which is currently being implemented). R=asanka Bug: 1042962 Change-Id: I2b04de491b212208bd76f501f5b9e8225f9439b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102633Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751315}
-
Aya ElAttar authored
1. Added Host permissions to trigger the full warning 2. Switched the login screen warning of the managed-guest session to be decided using ExtensionsPermissionsTracker 3. Modified 3 browser tests related to the old logic Bug: 1015378 Change-Id: Icd8cf9a72a6a2cbed58e4d72260e2f62bc79c30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090418 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751314}
-
Hiroki Sato authored
Currently WebView nodes are explicitly not ignored and not sorted in ARC accessibility. This rule should be applied to nodes from AccessibilityNodeProvider, too. This CL adds is_virtual_node in accessibility_helper.mojom and AccessibilityInfoData.IsVirtualView(), replacing current IsWebViewNode(). Bug; b:145262470 Bug: b:151130475 Bug: crbug:1053397 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Nodes from WebViews, Pickers, and Amazon Kindle app are correctly populated, works with Android side change (http://ag/10662400). Change-Id: I216bf6f26cb8e911ce0fe899400d503db6073be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102288Reviewed-by:
-
Dominique Fauteux-Chapleau authored
The tests now check every policy values of BlockLargeFileTransfer, AllowPasswordProtectedFiles and BlockUnsupportedFiletypes to catch more accidental regressions. Change-Id: I51b0f8f36655f8d4972e5cc2740cbfb287f78fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105615Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751312}
-
