- 10 Jun, 2020 40 commits
-
-
Ankit Kumar authored
This CL ensures that current focused annotation is scrolled into view if not already in view on key events. This ensures that user can see the annotation in the viewport while performing key events on the same. Bug: 1085614 Change-Id: I41162be9a096219e04682ec5240508819a5baf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228250 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776902}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c3062efcb3b..2d27b1ab0c85 2020-06-10 handellm@webrtc.org Mutex: Temporarily add re-entry CHECK. 2020-06-09 danilchap@webrtc.org Add av1 structures for 3 spatial and/or 3 temporal layers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idea6a33fcbd71f44cae3e60c68bb239f5ea1c80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239655Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776901}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d80d9044857e..277f64ca79c3 2020-06-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7c213720bb46 to c01f826bc67f (1 revision) 2020-06-10 syoussefi@chromium.org Vulkan: Fix RTs attached to textures with non-0 mip If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Iada81a17a092789e8f5b6b2c5883fcf2091bd0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239653Reviewed-by:
-
Nigel Tao authored
Bug: 1086733 Change-Id: If2f08ecb345051677ec5dc249fa5e5922229e633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235253 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#776899}
-
Javier Ernesto Flores Robles authored
Bug: 1066803 Change-Id: I4311c1010a1a7b0f6c061d2f0c17dfcb4a917481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235793 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#776898}
-
Alexey Baskakov authored
Sometimes last_committed_nav_entry_unique_id != entry->GetUniqueID() in WebAppDataRetriever::OnGetWebApplicationInfo() which resulted in kGetWebApplicationInfoFailed. And kGetWebApplicationInfoFailed is a showstopper: generated icons. WebAppDataRetriever::GetWebApplicationInfo() should return some initial info to unblock CheckInstallabilityAndRetrieveManifest() stage. This CL doesn't introduce significant behavior changes. It returns non-nullptr info for the `entry->GetUniqueID() != last_committed_nav_entry_unique_id` edge case. Bug: 1093251 Change-Id: Ia3bbcbdf229a3c74fc93f173892ebec404a2fc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239727 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#776897}
-
Sergey Poromov authored
While the feature is launched on the client side, it's currently in GA process to launch on server side for 100% customers, so the first metrics would be still useful there. Also changing the owners. Bug: 1089609, 1089611, 1089615, 1089617 Change-Id: I94aea37ac182b688db5a6b0e197b393b45f74e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224263Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776896}
-
Rune Lillesveen authored
The 'no-preference' value was removed from the spec per CSSWG resolution. Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ragu5Is6vCw Bug: 1091806 Change-Id: I6410f99badd26ad18fddadf014115dd754ca6aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232922Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#776895}
-
Hitoshi Yoshida authored
CheckForTypeError returned a String, and it is non-empty if TypeError is expected. This style is not obvious. This CL makes it to return what canShare() returns, and do not process URL if |data.url| is not present. Bug: 839389 Change-Id: Ie7eede5e33b16947aeffcb5c144f95940bb5d82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237213 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#776894}
-
Illia Klimov authored
This patch fixes a bug that prevents displaying incognito origins in Category Settings. Bug: 1073942 Change-Id: I4c7e95dcabc492c947149bc11ce74749e7253656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237971Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#776893}
-
Rainhard Findling authored
* Adds tests to check for the existence of the Chrome cleaner child if the platform requirements are fulfilled and if the corresponding flag is enabled. * Adds a mock of an incoming Chrome cleaner event from the safety check backend to the existing safety check page test. Bug: 1087263 Change-Id: I89f04c03c1bcca59b72120b4379f7ad03fe7d572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236139 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#776892}
-
Arthur Hemery authored
The current logic is implemented in the RenderFrameHostManager, but it would make more sense to have decisions taken in the NavigationRequest. This allows us to both clarify logic, as explained below, and to remove one mutator from the NavigationRequest interface. One single block of code that was doing a number of things is now split in three different logical parts, with some redundancy: - When we start a navigation, we do some coop inheritance heuristic to make sure the special case of instantly committing a speculative RFH in a sad tab does not mess up with attributes and proxy clearing. - When we hit a redirect, we recompute the COOP decision given the redirect headers. - When we receive the final headers, we compute the final COOP decision and do reporting if necessary. This clarifies the different bits of the COOP puzzle of setting require_browsing_instance_swap. Bug: 1076879 Change-Id: Ibf96084b59b5aa62e2241df1abbdb24b2c20e1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218092 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776891}
-
Leszek Swirski authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9912e35d..00a045e4 Manual roll due to autoroller issues (internal link: b/158587039) CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I22346ba4d8fe72d5591300e9ee57aa2e4a4a2915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238148Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#776890}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I2a3eb2d34b91f7c2349d38e2ba9abd11de286fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239651Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7c213720bb46..c01f826bc67f 2020-06-10 vasniktel@gmail.com spirv-fuzz: Add support for OpSpecConstant* (#3373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I5cfad05d6e3ecfee98207fa60b3a4ac13771a815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239652Reviewed-by:
-
Matt Giuca authored
Directory was empty except for an obsolete OWNERS file. Change-Id: I76483c1665466c06ffba813fc2cb2f4cf5f853c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237538 Auto-Submit: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#776887}
-
Maksim Sisov authored
This is a reland of 2fb9ab54: FIX: change test type from windowed to console for midi_unittests Original change's description: > xvfb: Wait for ReparentNotify before executing tests. > > X11 tests can fail because start up of OpenBox is not > synchronous and it is unknown when exactly it starts up. > > That results in a client that uses X11 missing events > and flakiness of tests. > > Thus, to avoid that issue, use a small program that > creates a dummy X11 windows and waits for the > ReparentNotify event. That is, OpenBox decorates > all the windows once it is initialized that results > in that event. Once the event is received, we can > be sure that the WM is up and running, and tests > can be executed. > > Bug: 1078771 > Change-Id: Ic6fae30a706a6b9c32e4670da56457c833b4b7f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214526 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#775001} Bug: 1078771 Change-Id: I500da8725f1c2d51788fd529d7c45318e5f93a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230463 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#776886}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae07c9b0fa7d..735f964fa54d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ksakamoto@google.com Change-Id: I25dca564ec276be454146b13e8ca76f8e91a4f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239649Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776885}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/22c55b7e85c0..5165a7a61b1d 2020-06-10 mathias@chromium.org Replace usages of whitelist/blacklist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie3990c9365333be3c443ed5ac41c30a010486de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239650Reviewed-by:
-
Jérôme Lebel authored
Replacing -[GoogleServicesSettingsMediator isSyncDisabled] by -[GoogleServicesSettingsMediator isSyncEnabled]. |isSyncEnabled| is now used by the sync toggle button and to know if "Manage Sync" should be enabled or not. Therefore "Manage Sync" is always enabled at the same time than the sync toggle. Fixed: 1045290 Change-Id: I04cfc52cf7ae1288e2d5f9c9b555089369f8b1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225904 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#776883}
-
Mirko Bonadei authored
This placeholder target (that will become a "component" in a follow up CL) will make it possible to switch both WebRTC and OpenScreen to depend on //third_party/abseil-cpp:absl (see for example [1]). This will then allow to create a CL to transform //third_party/abseil-cpp:absl into a "component" without having to change anything in WebRTC and OpenScreen. [1] - https://chromium-review.googlesource.com/c/openscreen/+/2173190 Bug: 1046390 Change-Id: I7870826edd2a34765bcdbd6a9adb0fe9c20c1dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234258 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1082264, 958905 Change-Id: I684beca2e49496e46e41673d5aa5781ebd7df9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218088Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776881}
-
Andy Paicu authored
https://testtracker.googleplex.com/testplans/details/33023?revision=10 The link above describes the currently existing manual tests related to the permission prompts. As part of the review process, I've implemented the tests from section 1.2 all of which could be automated and are related to the "protected content" settings page. Bug: 1063164 Change-Id: Icf47d0b48d3ff9135419ad9902bee965836e8180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225407 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776880}
-
Takashi Sakamoto authored
Add //third_party/blink/public/common/privacy_budget:privacy_budget to third_party/blink/common/privacy_budget/privacy_budget deps. The missing dependency causes flaky compile failure. E.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8877912291953186800/+/steps/compile/0/stdout In file included from ../../third_party/blink/common/privacy_budget/identifiability_metric_builder.cc:5: ../../third_party/blink/public/common/privacy_budget/identifiability_metric_builder.h:16:10: fatal error: 'third_party/blink/public/mojom/web_feature/web_feature.mojom-forward.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Change-Id: I1341844ccf5ed4e7c496fa60125204b67e631ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239129 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Takashi Sakamoto <tasak@google.com> Reviewed-by:
-
Alan Cutter authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/2134089 our sync install flow for bookmark apps was changed to fetch the app manifest from the start_url where previously we used sync data and only fetched icon URLs. The new flow is significantly more prone to install failure (due to network, site config, CPU load). In the event of failure the app won't be installed with any icons. This CL adds the legacy "only fetch icons" code path back in the event of failure to lessen the user impact of install failure. This CL only affects bookmark app sync install. BMO sync install will come via unifying the sync install process to use the same code. Bug: 1090227 Change-Id: I063b0d087ab482fe625a8f37850212e99b9d35bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226006 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#776878}
-
Sergey Ulanov authored
Fuchsia x64 bots started flaking on 6/04 due to a pkgfs issue. https://fuchsia-review.googlesource.com/c/fuchsia/+/396849 was landed in fuchsia to workaround that issue. That fix is included in 0.20200609.1.1 SDK. After that roll pkgfs stopped failing, but tests were still flaking with about the same frequency. The flake may be related to femu issue introduced about the same time, see fxbug.dev/53770, but the root cause is unknown. Temporarily revert to 0.20200604.2.1 which is expected to be stable. TBR=wez@chromium.org Bug: 1092054 Change-Id: Ib14a67f0efe9cbf01962d703cb9b1870298534c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239038Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776877}
-
Rushan Suleymanov authored
This patch removes Sync.Entities.PositioningScheme histogram from code and marks it as obsolete. Bug: 1089540. Change-Id: I43155064094bbcea207fcdc3ea9fc558b18a7990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235833Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#776876}
-
Koji Ishii authored
This patch changes marking lines dirty only when |HasInlineFragments|, not when |FirstTextBox|, which is always nullptr with LayoutNG. |DirtyLinesFromChangedChild| is supposed to do nothing for |NGPaintFragment|, but actually marks items dirty when |FragmentItem| is enabled. Also code for |InlineTextBox| was moved to inside of an if block not to run at all for LayoutNG. Bug: 982194 Change-Id: Icd933a1c3b6ad76b9437900bf104fc526d332dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237491 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776875}
-
Min Qin authored
When a query is kicked off by tiles, user could modify it multiple times, before hitting the enter button or clicking on a suggestion to finish the query. This CL adds a field in OmniboxLog to indicate whether the query is kicked off by a tile. So that the field can be passed to OmniboxEvent proto later on. To do this, whenever the omnibox is focused or autocompletion flow starts, a flag is turned on to check whether the focus or the flow is caused by query tiles. And the flag is later passed to OmniboxLog when a suggestion is selected. BUG=1090911 Change-Id: If0d9eab92b3073e7d209359efc20544aa9691a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229882Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776874}
-
Peter E Conn authored
Bug: 1087108 Change-Id: Ibf1775d96ea5600a1c2d73ee31ef4db8fbe307e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228617Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#776873}
-
Shakti Sahu authored
Bug: 1092953 Change-Id: Id2c700001e561d5ba69f69bd998a5715b0ac6048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238268 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
David Bertoni authored
This CL adds testing for Service Worked-based extensions through parameterized test fixtures. Bug: 1093066 Change-Id: Ie94d9eaa00a15e3a48be91505e02b04796055b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238947 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776871}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2234a98502c3..22c55b7e85c0 2020-06-10 mathias@chromium.org Include Unconfirmed issues in triage guidelines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1022301 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I21dde0c96f69ff7da547b652c0d0f88366d9146c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238862Reviewed-by:
-
Maria Kazinova authored
returned an invalid value. Spotted a bug, that kNotSetRendererId value was treated as valid in Objective-C part. Bug: 1075444 Change-Id: Id81c7057075ca4388952248d3f480b504817f1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238166Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#776869}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 27659, 1092519 Change-Id: Ia0b763544724202c95dcc87e124ad62ed642c869 Tbr: futhark@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239591Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#776868}
-
Fredrik Söderqvist authored
When an element is removed from the priority queue, we move the last element into it's position and adjust the position of the element to "fix" the heap invariants. When fixing the invariants we were only considering the children of the former element and not the parents. The last element however is not guaranteed to have a priority/key that is greater or equal to that of the removed element (may for example be from the other subtree of the common ancestor of the two element), so the ordering with regards to the parent elements need to be considered. Try to percolate the last element up first in case it is less than the removed element. This makes Remove() essentially the same as Update() (except for the removal of the element). We now also need to specially consider the case where it's the last element that is removed. Bug: 1092074 Change-Id: I2ebbb4880f582fb32de75da0f5e7b03c2a963c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237786Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#776867}
-
Harald Alvestrand authored
- Allow codecType to be missing in CodecStats - Allow address to be null (not missing) in iceCandidateStats - Allow url to be missing (it is only supposed to be present for STUN and TURN generated candidates) Exceptionally allow address to be missing in order to work around a bug. Bug: chromium:1092721 Change-Id: Ib6d290a177b3c1be4c6238d346cba17ac0c18ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236477Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#776866}
-
Francois Beaufort authored
This CL makes some UI changes to how ptz is presented to the user: - camera is hidden in page info if ptz is granted or blocked - any change to ptz is reflected on camera - users see one permission for both camera and ptz when requested - bubble strings are adjusted when ptz is granted Screenshots: https://imgur.com/a/tlR4KRr Test: https://ptz.glitch.me/ w/ Experimental Web Platform Features flag Change-Id: Ia94c23ae0a79feb6f0744cfd0bc5bc0771604af6 Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224214 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776865}
-
David Munro authored
Test: Browser tests Bug: None Change-Id: I9b310580aa6b64649b72607019dac01862c711f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232252 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#776864}
-
Omid Tourzan authored
It adds a Speedometer to Task and get updated when new progress update comes to the task. The average window is set to 20, based on some experiment update rate is not consistent but it showed about per sec, so the average is for about 20 seconds. It would be updated through more experiments. It only works with CopyTask as the task types like Zip or Move don't report processed bytes. The following new fields dispatched to FE as part of task status: - currentSpeed - averageSpeed - remainingTime All the times unit to pass to FE is in second and speed is in B/s. FE supposed to polish it how to arrange magnitute. Bug: 953308 Change-Id: Idccb0385dc10ff5a6cee83c55f49b1cc0b39da5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217921 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#776863}
-
