- 18 May, 2019 35 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I7f5cfe75c18f2b0abfb8b1950101de148f922a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618511Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#661143}
-
Xiyuan Xia authored
Bug: 958134 Change-Id: I3e5651c7469300d14131f916543ba5c82fc3556b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616969 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#661142}
-
Emily Stark authored
LoginHandler currently handles two tasks when showing an interstitial: running the request through extensions and then showing a login prompt. When converted to committed interstitials, we need to run the request through extensions before the navigation commits, and then show a login prompt on top of a committed error page. This CL adds a "mode" argument to LoginHandler. When committed interstitials are enabled, the "mode" argument determines whether we should just run the request through extensions and then cancel it (pre-commit mode), or show a login prompt (post-commit). The post-commit mode is currently not reachable; we'll use it once we add the WebContentsObserver that observes the committed error page (https://crbug.com/963313). Note: this "mode" design is kind of messy and we'll probably want to come back and clean it up later. For now, it's the simplest way to leave LoginHandler intact for when committed interstitials are disabled, and use the parts of it that we need before+after commit when committed interstitials are enabled. Once committed interstitials land and we clean up the old code, we will probably want to split LoginHandler into two classes rather than having one class that can operate in two different modes. Bug: 963311 Change-Id: I1efddb3eca3a6b822135bd721db05f2f47561a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616943Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#661141}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b0f423a33189..85a0dd07188c git log b0f423a33189..85a0dd07188c --date=short --no-merges --format='%ad %ae %s' 2019-05-17 khokhlov@google.com Trace Processor: move Variadic class to a separate file Created with: gclient setdep -r src/third_party/perfetto@85a0dd07188c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:132682848 TBR=perfetto-bugs@google.com Change-Id: I422e6423bd2a4def7d5e4e1ae076d90f03e0f70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661140}
-
Johannes Henkel authored
New revision: 8ec18cf0885bef0b5c2a922c5dc3813cbf63e962 Change-Id: I49b072bb7922647b5cb24d439671ff760be70a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617648Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#661139}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a7a23c078a9b..cf6269b441f1 git log a7a23c078a9b..cf6269b441f1 --date=short --no-merges --format='%ad %ae %s' 2019-05-18 dcheng@chromium.org [git-cl] Handle non-HTTPS repositories gracefully in EnsureAuthenticated Created with: gclient setdep -r src/third_party/depot_tools@cf6269b441f1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8e47ff37702d9bc53ff7d2f8f7f02138cbfa40a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617317Reviewed-by:
-
Kevin Marshall authored
Defines the abstract BindingsManager API, which generically defines the interface used by bindings modules to communicate scripts and and MessagePorts with the CastRunner. Implements BindingsManagerFuchsia, which bridges the BindingsManager and chromium.cast.ApiBindings FIDL interfaces. Add BindingsManagerFuchsia to Fuchsia's gn_all metatarget, so that it's discoverable by the Chromium build waterfall. Bug: 953958 Change-Id: I21fd818096d47e0c5d67dc0fb10a6dcf284800a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613965 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#661137}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/35993b267671..1e3222332c96 git log 35993b267671..1e3222332c96 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 hliatis@google.com Fix mismatched alloc/free in Swapchain 2019-05-17 hliatis@google.com VkPhysicalDevice should use Instance allocation scope Created with: gclient setdep -r src/third_party/swiftshader@1e3222332c96 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132451407,chromium:b/132451407 TBR=swiftshader-team+autoroll@google.com Change-Id: I0dd3a6ff69411b69c061a68957749b3e8a0072e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618074Reviewed-by:
-
Michael Giuffrida authored
Minor refactor to make an upcoming CL easier to read. Change-Id: I3984252128505f7c655cb87b1728168e26498513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597908 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#661135}
-
jchen10 authored
This stores program LINK_STATUS to the GL_QUERY_RESULT of GL_PROGRAM_COMPLETION_QUERY_CHROMIUM. WebGL useProgram checks the status before using it. By caching this status, useProgram no longer stalls on the round-trip to the GPU thread. Bug: 962337 Change-Id: Ifcc15044b1e6e6813e0599d90a76556b2401396a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607573 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#661134}
-
Ryan Hansberry authored
Caching FeatureState as was done previously may have been introducing subtle bugs. In any case, this refactor is cleaner and more direct. Bug: 883100 Change-Id: Ife296e88bf561c228cd34c6cb80714a4c9767ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618561 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#661133}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1584db48bcf3..a3e2759ffa0b Created with: gclient setdep -r src-internal@a3e2759ffa0b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ib75055efb606d4e76ed0a4737e34de669ab25772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618530Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661132}
-
Jordy Greenblatt authored
Now that all the CrOS only sections are behind the flag, the test can be simplified to just check that the attached sections are exactly the browser settings sections. Note that in this context "browser settings section" means a section that should show up in the browser and may (e.g. "people") or may not (e.g. autofill) show up in CrOS settings. The browser settings section list in the test excludes the changePassword section, which is only attached when triggered by a special WebUI event. Change-Id: I9dbd6e38fb23f0d3046067e152c3a08f77730491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617638Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#661131}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7dae5d770f4c..4d850033271b git log 7dae5d770f4c..4d850033271b --date=short --no-merges --format='%ad %ae %s' 2019-05-17 benjhayden@chromium.org Add alert-detail, bisect-dialog for spa 2019-05-17 benjhayden@chromium.org Add lit-element to package.json for spa. Created with: gclient setdep -r src/third_party/catapult@4d850033271b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865515,chromium:893189,chromium:950011 TBR=simonhatch@google.com Change-Id: Ia6d32835d35e56639fd2714d6980d897dca0001f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618075Reviewed-by:
-
Martin Kreichgauer authored
This aligns it with e.g. PublicKeyCredentialUserEntity. Change-Id: I907d97d03e529eb44fcc14e9cf5ce0cd9ab77f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610656Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#661129}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a86225ee247d..a7a23c078a9b git log a86225ee247d..a7a23c078a9b --date=short --no-merges --format='%ad %ae %s' 2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a7a23c078a9b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6f25fd932a0098658058b7d28098cdec69b60cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618428Reviewed-by:
-
Findit authored
This reverts commit 69ec73d0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 660918 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjllYzczZDBmYWJjZTViMzM5YjBiMTI1ZmM2MGY2NzIyZTdlOTU4ZAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/12979 Sample Failed Step: viz_content_browsertests Sample Flaky Test: PortalBrowserTest.NavigateToChrome Original change's description: > Portals: Restrict portal navigations to HTTP family. > > This is also enforced with a renderer kill in case the browser receives > a non-HTTP navigation request. > > Bug: 962500 > Change-Id: Id7c122ba80ef1cc00620d07d5ecdb1f268b04d79 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615499 > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660918} Change-Id: I3322c1b1721eca98d08ce9b39f2363cf23b424b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 962500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618315 Cr-Commit-Position: refs/heads/master@{#661127}
-
Yuke Liao authored
check_static_initializers is constantly failing on coverage bots, so remove it for now, will add it back once the issue is fixed. Change-Id: I885f98174893f8e69943b11dadabf8a0a7830514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618049Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#661126}
-
Mustafa Emre Acer authored
This CL adds U+0138 to the list of blocked characters. As a result, any domain with this character will always be displayed as punycode. Bug: 964002 Change-Id: Iac63cb94bde9d8d668094c12b5042d55e8e44162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618562 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#661125}
-
Abhishek Arya authored
Revert "blink_web_tests: Ensure content_shell window is created and initialized before logging #READY" This reverts commit 9e8ae362. Reason for revert: Shutdown crash when using --run-web-tests, breaks ClusterFuzz fuzzing bots. Original change's description: > blink_web_tests: Ensure content_shell window is created and initialized before logging #READY > > Sometimes, especially on Windows, initial creation of the content_shell window > takes multiple seconds to complete. Tests then result in flaky timeouts. This change > ensures the window is initialized before logging #READY. The run_web_tests harness has > code to not count the time between launching content_shell and logging #READY. > > Bug: 953991 > Change-Id: I50c2449e204cdb2d66996bcb4c553a2f083604f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584476 > Commit-Queue: Austin Eng <enga@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658594} TBR=peter@chromium.org,dpranke@chromium.org,pdr@chromium.org,robertma@chromium.org,enga@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 953991, 964522 Change-Id: Ief50f7a4da3e459056c31f5d12a526987591309b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618542Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#661124}
-
Donn Denman authored
Rewords the description of the chrome://flags feature to call it the "preview tab" instead of the Ephemeral Tab. Internally we'll keep using the term Ephemeral, but this user-visible name is now changed to avoid confusion with an Ephemeral Profile. BUG=894619 Change-Id: Ief87a1a87093f5f767109c56314552abff998f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617913 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#661123}
-
Collin Baker authored
This reverts commit 63ac6323. Reason for revert: base_unittests failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/43060 Original change's description: > Promises: Implement Promise<> handle with Then and Catch > > Implements Then and Catch on top of AbstractPromise as well as > ManualPromiseResolver<> which is needed for testing at this > stage (PostTask doesn't yet return a promise). It's also > necessary for promises to interface with old style callback > based libraries which are extremly common in Chromium. > > Design: https://docs.google.com/document/d/1l12PAJgEtlrqTXKiw6mk2cR2jP7FAfCCDr-DGIdiC9w/edit > > Bug: 906125 > Change-Id: Id7206698f37c59cfc201f3970cbf66a2ef89ee4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599620 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661045} TBR=fdoray@chromium.org,alexclarke@chromium.org,etiennep@chromium.org Change-Id: I52dc57a8ba9515ea68101f5e16b1f92a926e594d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618077Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#661122}
-
David Grogan authored
RecalcVisualOverflow might be trying to read a cell that's been removed from the tree. I've not been able to get this to repro on android or linux. Bug: 956625 Change-Id: I1353bd537245fc458e9eeec48bd8861b70364cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617559Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661121}
-
chrome://omniboxOrin Jaworski authored
This CL makes it possible to use chrome://omnibox as a batch query processing tool, transforming an input set of queries to an output set of exports. This is currently done by detecting the type of import data, but the functionality can easily be wired into dedicated UI elements if we want it to be more discoverable. This CL also fixes a bug in generated export filenames: it was including extra spaces due to code formatting, but now the spaces are removed and the date/time text is shortened to the essentials. Bug: 964528 Change-Id: I09036af82aaf9c4ade9f7dc929c338c85159e77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614711 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Darwin Huang authored
Bug: 962055, 962083 Change-Id: I374f86ba980484aa7471bdded7dad2b36e0d78fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618155 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661119}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a777e434. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iaf0a8b32cfae9968bebe23e2d6a084527dcdc71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618153Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661118}
-
Kyle Milka authored
Bug: None Change-Id: I7e3aff5d30853dd8c38ab1c7f74c554b76faeef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618144Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#661117}
-
Ravi Chandra Sadineni authored
Notification reporter intends to treat notification as user activity for screen dim and idle timeouts. Thus it notifies powerd whenever a new notification (priority > DEFAULT) is drawn or the one that is already shown is updated. When a notification of system priority is drawn, chrome keeps updating the notification until is cleared by user which results in regular HandleWakeNotification calls to powerd. Thus this can result in screen staying on forever. Let us not do this. In the follow up CL, I intend to notify powerd directly where the notification is created. This way we do not use notification priority that is already overloaded to determine if the screen should stay on. BUG=chromium:964470 TEST=Connect external monitor and make sure screen turns off. Change-Id: I616926994f66982ecb5886f17af85813ee34efe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618047 Commit-Queue: Ravi Chandra Sadineni <ravisadineni@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Auto-Submit: Ravi Chandra Sadineni <ravisadineni@chromium.org> Cr-Commit-Position: refs/heads/master@{#661116}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79b19c11139f..1584db48bcf3 Created with: gclient setdep -r src-internal@1584db48bcf3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Iae23373dd45e7c8f333a6652bb76768e177f7924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618072Reviewed-by:
-
Antonio Gomes authored
This is a reland of 81046e57 This is exactly the same as the original CL (crrev.com/c/1594114) that was reverted in [1] but turned out not to be the culprit of the flakiness on the Mac ASan bot. [1] crrev.com/c/1616857 TBR=haraken@chromium.org,guidou@chromium.org,hiroshige@chromium.org Original change's description: > Migrate blink::MediaStreamVideoSource to WTF::Bind > > This CL is the 3rd out of n CLs to convert modules/mediastream/ > away from base::Bind{Once,Repeating} to their respective Blink/WTF > counterparts. > > In this particular CL, a weak reference of MediaStreamVideoSource is > passed to VideoTrackAdapter ctor to avoid double-bind methods with > CrossThreadBind -> ConvertToBaseCallback -> CrossThreadBind. > > R=dgozman@chromium.org, guidou@chromium.org > CC=blink-reviews-vendor@chromium.org > > BUG=923394 > > Change-Id: Ibd75c5fef80bef1a4328c4abb007fb07efbcc095 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594114 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660725} Bug: 923394 Change-Id: I8368328d8a57da0145b96e4c24d8469061952ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618381Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#661114}
-
Sunny Sachanandani authored
WaitForVBlank can fail if D3D11 device is lost. Also use InMillisecondsRoundedUp in fallback Sleep() call to match PostDelayedTask() behavior. Bug: 953970 Change-Id: I129a93b41be553f184682e09b21f83ca8d3aedb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618264Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#661113}
-
Zhenyao Mo authored
1) Only check NV12/YUY2 overlay support. 2) Get rid of g_supports_scaled_overlays and g_overlay_format_used. 3) Get rid of OverlayFormat enum class and use DXGI_FORMAT instead. BUG=909827 TEST=gl_tests, bots R=sunnyps@chromium.org Change-Id: I01d0c60b7131b56fbbea599da733b9f68a6233b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616386Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661112}
-
Tony de Luna authored
This CL: - Refactors HelpAppTestHelper::Waiter to a general dialog window waiter. - Renames HelpAppTestHelper to ScopedHelpAppForTest. - Adds a test fixture that sets up a kiosk session for error screen tests. - Adds a test that verifies that clicking on the "Manage certificates" button in the error screen opens a certificate manager window. Bug: 959340 Change-Id: I92a9121872ff28d9c1752c222343cfc643f18501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612599 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#661111}
-
Avery Musbach authored
In tablet mode, if you start to drag a window from the top of a nonprimary display, before the present CL, the functionality is completely broken. You do not even see the window. If you try to drag a window from overview on a nonprimary display, before the present CL, the drop target is created on the primary display. After the present CL, dragging a window (either from the top or from overview) on a nonprimary display shall be similar to dragging a window on the primary display. Future work will address functionality where a window is dragged from one display to another. Test: ash_unittests OverviewSessionTest.* Bug: 916856, 964063 Change-Id: Iddbafc7b289ab2f711db47ebaf18bfcfcda2539c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617906 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#661110}
-
Rakib M. Hasan authored
Bug: chromium:948891 Change-Id: If35daa4956139bc61c3cc4829dbbf35f3061bee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618020 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
- 17 May, 2019 5 commits
-
-
Lucas Tenório authored
Bug: 958995 Change-Id: I115ba68ed9b58a6c0d50d1d94d52b1070f3837db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600133 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
-
Nikita Podguzov authored
Bug: 960274 Change-Id: I01aa63287ecd9b492a112eafe7f2d5b8186418dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609907Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#661107}
-
Esmael El-Moslimany authored
Bug: 960564 Change-Id: Ied93550b6f591e64404ebed7324d2ac6ed3c08d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618056Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
This depends on https://crrev.com/c/1595292 to actually release the memory of the Bitmap. On Pixel 2 XL, before this CL, there can be up to 8 (visible or to-be-visible cards) + 5 (recycled in the view pool) thumbnail Bitmaps in the memory after GC when GTS is visible. After hiding GTS, there are still 5 Bitmaps in the recycled views after GC. This CL addresses the recycled views in the pool. Bug: 959054 Change-Id: I601417e5d2e67eafd69aee36fe00614beb046aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595128 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661105}
-
Esmael El-Moslimany authored
Bug: 960564 Change-Id: I5a5e083a9fa3ff43dcf252ea7faaa508dfd8bd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618053Reviewed-by:
-
