GitLab

This reverts commit c453ae08.

Reason for revert: As previously noted here (https://bugs.chromium.org/p/chromium/issues/detail?id=929040) this CL creates a flaky test. My fix for the flaky test just got reverted, so this CL needs to be reverted too.

Original change's description:
> SafeBrowsing: Send FULL_PINGs for PDF downloads.
> 
> Bug: 927515
> Change-Id: Id50577de69b38df4d99bec89228eb6e8f98cbed0
> Reviewed-on: https://chromium-review.googlesource.com/c/1458919
> Commit-Queue: Daniel Rubery <drubery@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630074}

TBR=vakh@chromium.org,drubery@chromium.org

Change-Id: Ia1cd02022dffe19610d1e9c9dad84dbf0015545b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 927515
Reviewed-on: https://chromium-review.googlesource.com/c/1460064Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630092}

In QUIC, when processing timestamps in ACK frame, close connection if delta_from_largest_observed is too high.

Merge internal change: 232664362

R=rch@chromium.org

Bug: 928821
Change-Id: Ie3efa2514b40aa20797717cb23deeaef8d238670
Reviewed-on: https://chromium-review.googlesource.com/c/1459064Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630091}

This reverts commit 053ca6cc.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 630043 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDUzY2E2Y2M2ZjJhZTZhNGE3M2E5YzczZDgxNDNlYjlmMWYxNzFiMww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/33780

Sample Failed Step: unit_tests on (none) GPU on Mac on Mac-10.11

Sample Flaky Test: DownloadProtectionServiceTest.DoesNotSendPingForCancelledDownloads

Original change's description:
> Don't send download pings if the download is cancelled
> 
> There's a small race condition where, if the download is cancelled
> before we send a download ping, when we notify the
> IncidentReportingService, we'll fail a DCHECK, since the
> IncidentReportingService expects us to only send pings for IN_PROGRESS
> or COMPLETED downloads.
> 
> Change-Id: If9e5647f2e60f19f0469f51709990ae8226cd5ee
> Reviewed-on: https://chromium-review.googlesource.com/c/1457672
> Commit-Queue: Daniel Rubery <drubery@chromium.org>
> Reviewed-by: Nathan Parker <nparker@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630043}

Change-Id: I6c21ce34cdebe86bbf7c877f774e9d3f2ff0f59e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1459794
Cr-Commit-Position: refs/heads/master@{#630090}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/93c01741f610..f2c1116f97a6


git log 93c01741f610..f2c1116f97a6 --date=short --no-merges --format='%ad %ae %s'
2019-02-07 dgarrett@google.com workspace_stages: Create WorkspaceDebugSymbolsStage stage.


Created with:
  gclient setdep -r src/third_party/chromite@f2c1116f97a6

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ibf0bbcfeb6e06f992844fd7e730c4caebecbfa6e
Reviewed-on: https://chromium-review.googlesource.com/c/1458426Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630089}

Rather than relying on an empty origin ID to indicate failure to
initialize, return a bool parameter that specifies it properly.
This will allow future changes that support pre-provisioned origin
IDs to handle the case where an empty origin ID is used temporarily.

BUG=917527
TEST=components_unittests pass

Change-Id: I1ee06f60af49ffa08dc16ed0d5def5fc0be7351e
Reviewed-on: https://chromium-review.googlesource.com/c/1453100
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630088}

Changes:
Use ax::mojom::Event::kFocus instead of ax::mojom::Event::kSelection
since the latter will trigger duplicate vox announcement.

Bug: 929762
Change-Id: I6757daa139cefac303f607de0346a70cb3138d08
Reviewed-on: https://chromium-review.googlesource.com/c/1459056Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630087}

https://webrtc.googlesource.com/src.git/+log/710f3d3e4483..59ab1cf08196


git log 710f3d3e4483..59ab1cf08196 --date=short --no-merges --format='%ad %ae %s'
2019-02-07 nisse@webrtc.org Move ownership of RTPSenderVideo and RTPSenderAudio one level up
2019-02-07 nisse@webrtc.org Add owned data buffer to EncodedImage
2019-02-07 titovartem@google.com Add missing operator= and extra methods to the SamplesStatsCounter.


Created with:
  gclient setdep -r src/third_party/webrtc@59ab1cf08196

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib7c76197ecfdcb460a6b454c9a3160c0952c8a69
Reviewed-on: https://chromium-review.googlesource.com/c/1458424Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630086}

This is a reland of 8e4cf155

This CL includes the following changes:
1. when fuzzing, PFFFT is compiled disabling SIMD
2. SIMD is also disabled on fuchsia and android because PFFFT only checks __arm__
3. unit test to validate the output of PFFFT (compared against that of FFTPACK)

The first change fixes the problem due to which the original CL has been reverted;
however, it makes fuzzing slower and reduces the coverage since SIMD cannot be used.

Similarly, the second change is a temporary solution to allow landing this CL.
SIMD will be re-enabled in a follow-up CL.

Original change's description:
> Add build file for PFFFT
>
> - fuzzer corpus generator and fuzzer targets
> - fftpack isolated as private test only target (only needed for the benchmark)
>
> Bug: webrtc:9577
> Change-Id: Idc904bc4b05f945a7461a14893518551bbe34b84
> Reviewed-on: https://chromium-review.googlesource.com/c/1452000
> Commit-Queue: Ale Bzk <alessiob@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629627}

Bug: webrtc:9577
Change-Id: Icfbb4b966c3ad866e9e2970b63363e0e258b1fea
Reviewed-on: https://chromium-review.googlesource.com/c/1458076
Commit-Queue: Ale Bzk <alessiob@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630085}

This fixes the GCC build. GCC seems to be stricter with the position of the
linkage specification, so just swap the terms to prevent an error that looks
like:

In file included from ../../base/allocator/allocator_shim.cc:333:
../../base/allocator/allocator_shim_override_cpp_symbols.h:39:30: error: expected unqualified-id before string constant
 #define ALIGN_LINKAGE extern "C"
                              ^~~
../../base/allocator/allocator_shim_override_cpp_symbols.h:99:20: note: in expansion of macro ‘ALIGN_LINKAGE’
 SHIM_ALWAYS_EXPORT ALIGN_LINKAGE void* ALIGN_NEW(std::size_t size,
                    ^~~~~~~~~~~~~

Bug: 819294
Change-Id: I0aa16ea88cead42e83796a1c86afad8b447ddc50
Reviewed-on: https://chromium-review.googlesource.com/c/1458256
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#630084}

The gles2_cmd_decoder receives untrusted commands from the client and must
validate that the MultiDrawManager is always used with a valid sequence of
commands.

Bug: 923282
Change-Id: Ic61e8d61fce61431d7aa939261608f5f4f06792d
Reviewed-on: https://chromium-review.googlesource.com/c/1423422
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630083}

Create a logarithmic scaled delay based on tab width for tab hover cards to show.

Bug: 910739
Change-Id: I00b4d4de57cea75b837b7cadc81dea4bb5023c6e
Reviewed-on: https://chromium-review.googlesource.com/c/1455057
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630082}

The removed DCHECK didn't make sense. User could
hit Ctrl+Tab to switch tabs while scrolling is in
progress.

TBR=emaxx@chromium.org
BUG=929784

Change-Id: Icd9c26a3650cec610de8c61499e32595347e2e4d
Reviewed-on: https://chromium-review.googlesource.com/c/1459517Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630081}

Prior to crrev.com/c/1409844 we have one global scope per animator and
the animator's name gets synced to main thread upon registration. With
the support of multiple global scopes, the sync should be done only when
the name is registered on both global scopes.

Change-Id: If2b1768fbafda96c92084db45c0ba3e14a5bb01c
Reviewed-on: https://chromium-review.googlesource.com/c/1440502
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630080}

This change adds a base::Feature for editing passwords in the Desktop
settings. This feature will be disabled by default until the Polymer
implementation is completed.

Bug: 377140
Change-Id: Iff7289f6dc0889c2ba3aee6c98899d4f21dfa3b4
Reviewed-on: https://chromium-review.googlesource.com/c/1458194Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630079}

Bot is being deleted, but was deleted from some repos too quickly.

TBR=jbudorick
NOTRY=true

Bug: 893662
Change-Id: I479a6a55b45a23fec796c4bdc14805bbce1bce56
Reviewed-on: https://chromium-review.googlesource.com/c/1459980Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630078}

https://pdfium.googlesource.com/pdfium.git/+log/82105494f27a..762247be1246


git log 82105494f27a..762247be1246 --date=short --no-merges --format='%ad %ae %s'
2019-02-07 thestig@chromium.org Move most CPWL_Wnd::CreateParams member initialization to the header.


Created with:
  gclient setdep -r src/third_party/pdfium@762247be1246

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I583caa7267d7e08692aafad7393806ca77d01b1e
Reviewed-on: https://chromium-review.googlesource.com/c/1458425Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630077}

Bug: 771478
Change-Id: I4454ca4a174775647546432c69bf213bc1b69789
Reviewed-on: https://chromium-review.googlesource.com/c/1455337Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630076}

https://skia.googlesource.com/skia.git/+log/c877ea265759..a29dd9d0cb8b


git log c877ea265759..a29dd9d0cb8b --date=short --no-merges --format='%ad %ae %s'
2019-02-07 bsalomon@google.com Pin the quad index buffer in GrResourceProvider.
2019-02-07 reed@google.com Revert "Hide setDrawLooper -- deprecate loopers"
2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-02-07 brianosman@google.com Remove duplicate entry in harfbuzz GN file
2019-02-07 bsalomon@google.com Use different classes for client side arrays and GPU buffer objects.
2019-02-07 abarth@google.com [fuchsia] Update path to fuchsia.fonts
2019-02-07 robertphillips@google.com Add support for Mtl backend to DeferredDisplayListTest
2019-02-07 fmalita@chromium.org [skshaper] Add per-line callback
2019-02-07 jvanverth@google.com Set correct uniform size for Metal.
2019-02-07 fmalita@chromium.org [skottie] Use SkShaper for text
2019-02-07 mtklein@google.com move Reporter::reportFailedWithContext() out of line
2019-02-07 benjaminwagner@google.com Upgrade NVIDIA driver on Ubuntu18 QuadroP400 bots.
2019-02-07 egdaniel@google.com Add support for importing AHardwareBuffers into SkSurfaces.
2019-02-07 scroggo@google.com SkWuffsCodec: Initialize memory when incomplete
2019-02-07 kjlubick@google.com Add a k8s cheat sheet to trooper docs


Created with:
  gclient setdep -r src/third_party/skia@a29dd9d0cb8b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: Ic4d1ea606b693170c1b7d37c10b9c9015edae0bb
Reviewed-on: https://chromium-review.googlesource.com/c/1459199Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630075}

Bug: 927515
Change-Id: Id50577de69b38df4d99bec89228eb6e8f98cbed0
Reviewed-on: https://chromium-review.googlesource.com/c/1458919
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630074}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be531eda4378..ff3805a63456


Created with:
  gclient setdep -r src-internal@ff3805a63456

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:891313
TBR=mmoss@chromium.org

Change-Id: I37a948c429007f14825cbbca6d87d63db5b399bf
Reviewed-on: https://chromium-review.googlesource.com/c/1459198Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630073}

This tool stopped working when comments ({#..#}) were added to the
manifest Jinja templates.

Change-Id: I54a0fce1907b55671787a9dd57f62d2f2e958d2e
Reviewed-on: https://chromium-review.googlesource.com/c/1459062
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630072}

Records apps that have been launched by a user using the device during Demo
mode. The sample is recorded when each app is launched. For any given app
id, the metric is recorded only once.


Also:
- Fixed bug where kBrowser enum wasn't resolved from its app id.
- Fixed description of when the UniqueAppsLaunched metric is recorded.

Bug: 900261
Change-Id: Icee9c834a4e76432184307433aa96e54cc9df832
Reviewed-on: https://chromium-review.googlesource.com/c/1444694
Commit-Queue: Danan S <danan@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630071}

This patch modifies the behavior that Back() from assistant_page should
be to the search_result_page.

Bug: 924624
Test: manual
Change-Id: Iba644fee5426ab8b36f47ad4b2e459b1286bd50d
Reviewed-on: https://chromium-review.googlesource.com/c/1455519Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630070}

Change-Id: Ib42849852e32348385fcb4389e7ddcfb0085cdf3
Reviewed-on: https://chromium-review.googlesource.com/c/1456010Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630069}

This is a step in the process of making the IceTransportAdapter
use interfaces from webrtc/api rather than interfaces from cricket::

Bug: chromium:864871
Change-Id: Ibd402232d29949e4aa50d01fd3ff510b950099c1
Reviewed-on: https://chromium-review.googlesource.com/c/1458176
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630068}

The CL adds a general-purpose feature flag, and creates
DevToolsBackgroundServicesContext which is part of the StoragePartition.

The context will be responsible for logging the events from the relevant
features (BackgroundFetch/BackgroundSync), and will be accessible from
the soon-to-be-added DevTools protocol handler (via the StoragePartition)
to perform the reads/writes.

Bug: 927726

Change-Id: I7c48a1bac742b9e6e8eaed52f8e69eace6c25f1b
Reviewed-on: https://chromium-review.googlesource.com/c/1407077
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630067}

This reverts commit dcea6896.

Reason for revert: The underlying change causes failures in the
headless_browsertests on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=929873

Original change's description:
> Add GWP-ASan hook to macOS crashpad handler
> 
> Add the GWP-ASan UserStreamDataSource to the macOS crashpad handler.
> The GWP-ASan hook determines when an exception is related to GWP-ASan
> and reports additional debug information.
> 
> Bug: 912286
> Change-Id: I1cd0227ca8aade1bd17e25b83832cdb8f3e58d5e
> Reviewed-on: https://chromium-review.googlesource.com/c/1457461
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629881}

TBR=mark@chromium.org,vtsyrklevich@chromium.org

Change-Id: I9557c90e7ef6db6cf68e0b518538409783762395
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912286
Reviewed-on: https://chromium-review.googlesource.com/c/1459595Reviewed-by: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630066}

This re-enables the onion-soup codepath, which was disabled due to
crashes (hangs) on stable. There is now more debugging info being
collected, so when we see crashes on Canary, we can figure out the
cause.

R=mek@chromium.org

Bug: 927534
Change-Id: I6f12acfd074e9931d1654e66a6a17e8ee002166e
Reviewed-on: https://chromium-review.googlesource.com/c/1456652Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630065}

Propagates a status code from MHTMLArchive::Create back to the browser so that
OfflinePageTabHelper can report the result of trying to load the archive along
with the page's offline namespace.

Bug: 905409
Change-Id: I75df2dc65498598a6c3ce676899b8b9dab872822
Reviewed-on: https://chromium-review.googlesource.com/c/1336216Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630064}

Updates all of the tests in VrBrowserDialogTest to be actual
RenderTests instead of just capturing an image and doing nothing with
it. Also moves the majority of them out into different test classes
that are more appropriate for what they are testing since most aren't
actually for permission dialogs.

Bug: 887505, 864775, 862182
Change-Id: If65738034d49558f48d89ab26dda8aacc15c4774
Reviewed-on: https://chromium-review.googlesource.com/c/1414192
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630063}

Passing NULL for mime-type here is valid and indicates that the drop
destination does not support dropping at the current location.  We
were creating a std::string from a nullptr when calling
DataOffer::Accept() and that called strlen on nullptr.

BUG=b:120240161
TEST=exo_unittests

Change-Id: I00cfe116f01383cc94f3f93f4b8ca4af7587db2e
Reviewed-on: https://chromium-review.googlesource.com/c/1436469
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630062}

https://android.googlesource.com/platform/external/perfetto.git/+log/af5e7a520e64..413f0052c89e


git log af5e7a520e64..413f0052c89e --date=short --no-merges --format='%ad %ae %s'
2019-02-07 lalitm@google.com Merge "trace_processor: improve trace processor testing infra"
2019-02-07 taylori@google.com Merge "perfetto-ui: Add border on selection"
2019-02-07 eseckler@google.com Merge "service: Write a trusted PacketSequenceID with each packet."
2019-02-07 lalitm@google.com trace_processor: add missing ref type on instants table
2019-02-07 fmayer@google.com Merge "Add SharedRingBuffer"


Created with:
  gclient setdep -r src/third_party/perfetto@413f0052c89e

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ia1db71323c04a496969232f1f1d3428ace2e7c0f
Reviewed-on: https://chromium-review.googlesource.com/c/1459197Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630061}

Record how many pages and how many ad iframes would be affected by a
size intervention on frames without user activation, that exceed a size
on 1050 kilobytes. This defines size as the sum of all cached resource
sizes and all network bytes used to load a frame and all of its
subresources.

Bug: 878393
Change-Id: I4ea1ba03f6b348f83a02d7f22650e1b38a46a28e
Reviewed-on: https://chromium-review.googlesource.com/c/1440912
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630060}

Not sure how this can happen. ScrollbarsFor somehow returns a nullptr in
the ScrollbarSet. This must mean ToScrollbarLayer returns nullptr. This
method returns nullptr in the base and this in the
ScrollbarLayerImplBase override. Therefore the LayerToId muse be
returning a non-scrollbar layer.

The only time we add anything to element_id_to_scrollbar_layer_ids_
though is from LTI::RegisterScrollbar which is necessarily a scrollbar
layer. I think this means the Layer with the scrollbar layer's ID at
some point changes to a different layer. The ID-to-Layer mapping is
cleared when a layer is destroyed and the scrollbar layer clears the
element_id_to_scrollbar_layer_ids_ mapping in its destructor so I'm
speculating that we might be registering a new non-scrollbar layer with
the same id. I've converted the DCHECK to a CHECK at that location to
see if it comes back with any crashes from the wild.

Bug: 924068
Change-Id: I9bb15812aeda0a2c92d2547a52af9fbdbacc65b0
Reviewed-on: https://chromium-review.googlesource.com/c/1435686Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630059}

This CL changes how SharedWorkers create their URLLoaderFactory:

1. Ad-hoc creation code is replaced with a call into
   RenderProcessHost::CreateURLLoaderFactory, which
   1.1. Sets |request_initiator_site_lock| to the right origin,
   1.2. Sets |is_corb_enabled| to true.

2. Code is integrated with URLLoaderInterceptor (at least if the
   NetworkService is enabled) which helps test the changes wrt
   their impact on CORB behavior.

This CL also tweaks RequestInterceptor used by various CORB tests, so
that it forwards the actual headers / body / error-code of the response
(previously the renderer was always told that the response errored out
with ERR_NOT_IMPLEMENTED code).

Bug: 927849
Change-Id: Ic4c673d2f9c74fd89b8482552b7b72346f783c44
Reviewed-on: https://chromium-review.googlesource.com/c/1450430
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630058}

The Chromium build system doesn't generally care, but warnings pop up in
several ides when projects have duplicate source files.

Change-Id: I4f747246dde1736799f85faa4ae97c0bf6eb8b7e
Reviewed-on: https://chromium-review.googlesource.com/c/1459036
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630057}

BUG=907125

Change-Id: Icf032038eb14d9df65da9d1bc39870c63a1db944
Reviewed-on: https://chromium-review.googlesource.com/c/1458370Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630056}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d6d7c729..dd39fc4a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8be285c26d621f540ae91b57b9b600277afd772c
Reviewed-on: https://chromium-review.googlesource.com/c/1458476Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630055}

Previously LocalSurfaceId's for top-levels came solely from the window-service.
This patch allows clients to generate ids as well. Generation is handled by
a MusLsiAllocator subclass. The TopLevelAllocator makes use of
Compositor/LayerTreeHost to handle generation of client local surface-ids.

BUG=921129
TEST=covered by tests

Change-Id: I8d9fefdf6168c358510232fb9e43ab72253c66c4
Reviewed-on: https://chromium-review.googlesource.com/c/1450040Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630054}

Changes:
Avoid announcing search box focus when opening or closing a folder.

Bug: 921189
Change-Id: Id9b3096534b1b1196d41ce290bbc4617d9ddc2a9
Reviewed-on: https://chromium-review.googlesource.com/c/1457413
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630053}