- 28 Sep, 2019 32 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/69d781151b8a..39058571f71e git log 69d781151b8a..39058571f71e --date=short --no-merges --format='%ad %ae %s' 2019-09-27 ehmaldonado@chromium.org Reland "gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3." Created with: gclient setdep -r src/third_party/depot_tools@39058571f71e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1008202 Change-Id: I8b2c95163d6d26e64cc9f808feec8267636cb64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829926Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700932}
-
Julie Jeongeun Kim authored
This CL converts OfflinePageAutoFetcher to new mojo types using Remote, PendingRemote, ReceiverSet, and PendingReceiver. Bug: 955171 Change-Id: I1747f4bd5830a1a077fba86466e372807171f939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828757Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700931}
-
Alex Moshchuk authored
Bug: 425335 Change-Id: I4556bb5b1ef2e58b6599746de13b37af22adf5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830358 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#700930}
-
Julie Kim authored
This reverts commit d6027891. Reason for revert: Suspect for crbug.com/1008178 Original change's description: > Convert nacl.mojom to new Mojo types > > This CL converts NaClRendererHost and NaClExitControl > to new Mojo types. > > It also updates ProvideExitControl from nacl.mojom > and methods and members which implement it. > > Bug: 955171 > Change-Id: Ie6b875e07796b08818825474e8493e5f48072c3f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810509 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697852} TBR=dschuff@chromium.org,bbudge@chromium.org,sammc@chromium.org,oksamyt@chromium.org,jkim@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 955171,1008178 Change-Id: I8bdeb5bdd842ffa95ca41fd009717d46c843c3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829619 Commit-Queue: Jeongeun Kim <je_julie.kim@chromium.org> Reviewed-by:
Jeongeun Kim <je_julie.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#700929}
-
Alex Newcomer authored
Just add the padding when the drag starts. Bug: 1009120 Change-Id: Ia7e2216b3030b6bf2835a591a5fc1312b3eb9a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829554 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#700928}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dca6b5fe9a32..8ab1530cd3cd git log dca6b5fe9a32..8ab1530cd3cd --date=short --no-merges --format='%ad %ae %s' 2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8ab1530cd3cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: If33a4f52ef9190e3f741811021e0101b28ca737d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830377Reviewed-by:
-
Nick Harper authored
Change-Id: Ia284fcb130320088dc1269c986c2244d5b267536 Bug: 1008898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830363Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#700926}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ed74a5890e50..5f4659d6f7a8 git log ed74a5890e50..5f4659d6f7a8 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 zmo@chromium.org Add SubSysId and Revision as part of a GPU device identification. Created with: gclient setdep -r src/third_party/catapult@5f4659d6f7a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1006960 Change-Id: I18bd2a13b2557d03d4e5dc04e6eda70e4af6bc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830200Reviewed-by:
-
Manu Cornet authored
Change-Id: I02cfd0ad68407b54c681a88505eaf12e84a14753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830357 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#700924}
-
Frank Liberato authored
This reverts commit 1ccd84e0. Reason for revert: Many test failures due to static_cast @ rfhi.973 e.g.,: see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8901140067480428272/+/steps/app_shell_unittests/0/logs/Deterministic_failure:_RootWindowControllerTest.AppWindows__status_CRASH_/0 Original change's description: > Lower priority of processes hosting exclusively ads. > > This change adds a variable to ChildProcessPriorityLauncher to > indicate whether the associated process is only used to run tasks for > ad frames (low priority frames). That variable is then used by the > RenderProcessHost to background the frame in those cases. Notification > happens in the RenderProcessHost via new UpdateFrameWithPriority. > > Note: Identification of ad frames is done as per the AdTagging project. > Frames that have been marked as ads remain ads, and thus the > RenderProcessHost will remain low priority if the frame is navigated > to any other non-ad URL within the same process (same domain). > > Currently this is behind a feature which is off by default. > We will be experimenting with this to determine its impact on > both ads and in the browser as a whole. > > Bug: 979234 > Change-Id: I33d33bc9c1af16b04db211fda25217bd0b2fa85f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645978 > Commit-Queue: Eric Robinson <ericrobinson@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700786} TBR=dcheng@chromium.org,gab@chromium.org,jkarlin@chromium.org,alexmos@chromium.org,pbos@chromium.org,altimin@chromium.org,ericrobinson@chromium.org Change-Id: I5bd5742486245825babecd9eb53a54e0ad4adeac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 979234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830323Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#700923}
-
Guohui Deng authored
CastSystemMemoryPressureEvaluator can accept requests from apps to relax memory pressure thresholds. Normal memory pressure thresholds can be restored when those apps quit. Bug: internal b/141100797 Test: Build and run with eureka-internal/316737. Merge-With: eureka-internal/316737 Change-Id: I6752297ef1ea25e5e28965f00ad6cb04db194a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816729Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#700922}
-
Kyle Milka authored
Bug: 1009124 Change-Id: Idae33b2a04cb9dbf90c03b6dd707311ac981cc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830015 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700921}
-
Pavol Marko authored
The bots are deterministically failing on bots that have libassistent. TBR=antrim@chromium.org Bug: 1005454 Test: none Change-Id: Ic783f307a346bb3a1f2cb8865aef4a9d93234e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829344Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#700920}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b04334392d99..68c8fdf8f27c git log b04334392d99..68c8fdf8f27c --date=short --no-merges --format='%ad %ae %s' 2019-09-27 saklein@chromium.org artifacts_unittest: Cleanup the Bundle test cases. Created with: gclient setdep -r src/third_party/chromite@68c8fdf8f27c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3e241848c1601ca6ef2abf0fc4c34ded8a1c46f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829924Reviewed-by:
-
Lei Zhang authored
On Windows, GetFontData() calls from within sandboxed processes have to use the font_cache mechanism to work correctly. This requires a correctly patched GetFontData(), which broke in M76. https://crbug.com/980577 broke Import Address Table patching for gdi32.dll. This eventually got fixed, but the final fix in https://crrev.com/686696 tried to minimize the amount of patching necessary, and did not get it 100% correct for printing use cases. As a result, sometimes utility processes used for printing did not get patched. This fix by patching utility processes in InitializePDF(). Rearrange the function and update comments along the way. The font_cache mechanism in the Cloud Print service process also broke around the same time due to https://crrev.com/660952, but that just got fixed in https://crrev.com/700317. Bug: 1005867 Change-Id: I0bb691d8208fbbb9bf885767a959119a388def09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826197Reviewed-by:
-
Nate Fischer authored
No change to logic, this just removes redundant imports to clarify this class's dependencies. Bug: 994839 Test: autoninja -C out/Default chrome Change-Id: I579d9f1b3b24135fa729af3ca063eb3023a2d83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828497Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700917}
-
Xiaohui Chen authored
Bug: None Test: flags unittests Change-Id: I38ca60403e7ee50291a6685b1ab1c0e54e07d25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829246Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#700916}
-
Maggie Chen authored
This test collects supports_dx12 and supports_vulkan from GPU info and compares them with the expected values according to the test bot configurations. Bug:977034 Change-Id: I12969114f8af72b0f6e90c37b219ec7d04b85299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828121Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#700915}
-
Min Qin authored
The use-after-free is introduced in the following call sequence: 1. DataObjectImpl::GetData() calls DragDownloadFile::Wait(), which starts nested runloop and wait for download to complete. 2. DragDownloadFile::DownloadCompleted() is called, and it calls DataObjectImpl::OnDownloadCompleted(). 3. OnDownloadCompleted() creates a new StoredDataInfo object, that clears up the scoped_refptr of DragDownloadFile in the StoredDataInfo. As a result, DragDownloadFile is deleted. 4. The nested runloop started in DragDownloadFile::Wait() should finish now, but the return statement touches the state_ member variable on the deleted object, This CL breaks the above sequence by checking the weakptr in 4 first before accessing the state_ member variable BUG=968303 Change-Id: Ie1266d344fe102f73451bda9f996e29d9bd00a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827488Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700914}
-
Ben Pastene authored
Blocked on crrev.com/c/1829543 Bug: 1007498 Change-Id: I961224ec3532cd42a9e1b7ad3048eeafc9d1a4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827672Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#700913}
-
Sammie Quon authored
Focus the beginning of the title for overview items, the center for all other tabbable desks items. Test: added test, manual Bug: 436147 Change-Id: Ieb3f78b29ebcae881bcd4f4bf04098d18bdd0bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829558 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#700912}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Icaafad4aa18a55a7d8e721f221ee5c0653b5cfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826199Reviewed-by:
-
Xiaohui Chen authored
* Create |new_display_connection_| instance when starting new libassistant instance to make it consistent and safer * Add lock region to guard the background thread * Fix chrome_http_connection.cc file ordering Bug: None Test: locally build and run Change-Id: I6ae24148dc3c3fe1f5a40863beabd10707b1edb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830014 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Kristi Park authored
Prevent the "Send" animation from starting right after navigating from an NTP using the omnibox. Depending on when navigation completes, this would either cut off the animation, show it entirely, or not show it at all. Subsequently focusing the omnibox would not show the "Send" animation. Before: https://drive.google.com/open?id=1dKBDF2fmAPIVazi_wGUO_C9MosWwF8Uu After: https://drive.google.com/open?id=1Y9Rp6mn4aI15LxEeMGfBGMHqdg3l-ps9 Bug: 1005014 Change-Id: I5812763780426a86acd605a0afaf08113d805c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818606 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Darwin Huang authored
As a follow-up to https://crrev.com/c/1827244, remove the exception to allow ui/gfx/codec use in DataTransfer, as there are no longer any uses of gfx::PNGCodec in the renderer clipboard. Change-Id: Ic5ee757b24c0c881e8c978255096b1daf0c1f4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827651Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#700908}
-
Xianzhu Wang authored
We support custom scrollbar buttons in reversed direction (e.g. the backward scroll button at the bottom of a vertical scrollbar with -webkit-scrollbar-button:decrement:end). Count it to see if we can remove it to reduce complexity of custom scrollbars. Bug: 1009063 Change-Id: If54d8c0deaae44cc9e40a21c55dfbe0e6c3b48a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830217 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700907}
-
Kelvin Jiang authored
Change link from https://developer.chrome.com/optionsV2 to https://developer.chrome.com/options To reproduce locally, start up the docserver using: python chrome/common/extensions/docs/server2/preview.py then navigate to the getting started page Bug: 968489 Change-Id: I114d503290abe7ad564d3d13d1c57ebcab058c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827511Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#700906}
-
Xiaohui Chen authored
This reverts commit 5072afda. Reason for revert: Breaks long press animation Original change's description: > Remove AssistantState::VISIBLE > > Remove the VISIBLE state and use AssistantVisibility instead. > Also remove obsolete handling for AGSA animations. > > Bug: b/140823590 > Test: Run existing tests > Change-Id: Id64c5e536dfe6d3e10c9b003c135e76c96a9fee1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802819 > Commit-Queue: Yue Li <updowndota@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696936} TBR=xiyuan@chromium.org,sammc@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org,wutao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/140823590 Change-Id: I4e5114bc64f459b0854433405027df3490d4b8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829492Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#700905}
-
ssid authored
This reverts commit 19397af3. Reason for revert: Fixed tests Original change's description: > Revert "Add metadata at beginning of trace for discard buffer mode" > > This reverts commit 1d2c953e. > > Reason for revert: > This is somewhat speculative, but ever since this change was introduced, bot "Builder Linux Tests (dbg)(1)" has been failing on every run. The CL for the failing test talks about Perfetto and tracing, so this CL seems like a likely culprit. > > [12707:12707:0924/154115.904192:FATAL:privacy_filtering_check.cc(48)] Unexpected field in TracePacket proto. IDs from root to child : 8 > #0 0x7f66c614a14f base::debug::CollectStackTrace() > #1 0x7f66c5e7cecd base::debug::StackTrace::StackTrace() > #2 0x7f66c5e7ce88 base::debug::StackTrace::StackTrace() > #3 0x7f66c5ece649 logging::LogMessage::~LogMessage() > #4 0x5651bc1aac57 tracing::(anonymous namespace)::VerifyProtoRecursive() > #5 0x5651bc1aa9da tracing::(anonymous namespace)::VerifyProto() > #6 0x5651bc1aa7d2 tracing::PrivacyFilteringCheck::CheckProtoForUnexpectedFields() > #7 0x5651bbb57f38 content::ProtoBackgroundTracingTest_ProtoTraceReceived_Test::RunTestOnMainThread() > #8 0x5651bd505564 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > > > > Original change's description: > > Add metadata at beginning of trace for discard buffer mode > > > > Trace metadata is almost always discarded in discard buffer mode of > > perfetto tracing. For this case, add metadata at beginning of the trace. > > Handles cases when generators are added while tracing. > > > > Change-Id: I911794fba1e7b460ca1a7a3a54599a8c05678d75 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812248 > > Commit-Queue: ssid <ssid@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#699493} > > TBR=oysteine@chromium.org,ssid@chromium.org,eseckler@chromium.org > > Change-Id: I98fdb75be1a0582ab1a196c66dd74213aeced90b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823861 > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699689} TBR=finnur@chromium.org,oysteine@chromium.org,ssid@chromium.org,eseckler@chromium.org Change-Id: I7be7f143caca44862d9eff298389b79fff2b70fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825539Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#700904}
-
Francois Doray authored
Change-Id: I4bd4701f88cf0c266e136b641501800bc98be1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829477 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#700903}
-
Tao Bai authored
- Moved UseCounterPageLoadMetricsObserver to components. - Integrated WebView with page load metricts. - Added integration test for UseCounter metrics. Bug: 995880,994453 Change-Id: Ib5e6b1cb9baff249b711b46c6b1558d4041aee46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823981 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b1db4712..a90c7a97 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idd9260bec68a34f5c7172deae2b2646b81e53436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829505Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700901}
-
- 27 Sep, 2019 8 commits
-
-
Marijn Kruisselbrink authored
By storing mojo::Remote<Blob>s rather than UUIDs we don't have to block resolving the sync Register IPC on resolving the UUID, so this lets us unblock the renderer faster. Actually resolving the Blob to a UUID (and eventually BlobDataHandle) is now done only when the URL is actually loaded. Even that we might be able to get rid of by rewriting BlobURLLoader on top of the mojo Blob interface, but that's an improvement for another time. This makes the Mojo URL.createObjectURL code ~25% faster (or at least did when I was working on this CL more than a year ago). Bug: 849737 Change-Id: I9581b4fce1ec7b3d8c3a1ba635c6185906e49ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1112740 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700900}
-
Ken MacKay authored
This simplifies the implementation. Merge-With: eureka-internal/318940 Change-Id: I9fda9de4432e67ad4d4ad82823ed57654aca8328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829764 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#700899}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3787f51c65c3..dca6b5fe9a32 git log 3787f51c65c3..dca6b5fe9a32 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-27 bsalomon@google.com Remove vestiges of 32 float texture format support 2019-09-27 jvanverth@google.com Add gpu programmatic frame capture routines 2019-09-27 fmalita@chromium.org [skottie] Minimize top layer size 2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-27 reed@google.com Revert "add explicit src and dst colorspaces to filterColor4f" 2019-09-27 nifong@google.com Make move-assets obey SKIA_INFRA_ROOT 2019-09-27 benjaminwagner@google.com Switch to device_type dimension for iOS devices 2019-09-27 egdaniel@google.com Don't execute OpsTask which will have no effect on their target. 2019-09-27 mtklein@google.com add alternate gather() impl. 2019-09-27 reed@google.com add explicit src and dst colorspaces to filterColor4f 2019-09-27 fmalita@chromium.org [skottie] Fix skottie_tool anim null check logic 2019-09-27 herb@google.com Introduce SkIota a wrapper that adds an index 2019-09-27 bsalomon@google.com Use SW backend as ref for AsyncReadPixels unit test. 2019-09-27 brianosman@google.com Interpreter: Lots of minor cleanup/refactoring Created with: gclient setdep -r src/third_party/skia@dca6b5fe9a32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: Ieaf010645fb149897eeedc97a47f99860ad0cd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830198Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the cloud_print::mojom::CloudPrint interface. Bug: 955171 Change-Id: I7644ec5d0902cbf00c7b04a6c15a45eeff5e57e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816546Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Stefan Zager authored
These are instances where we don't actually need to remove an element from its tracking document's IntersectionObserverController, because it wasn't being tracked anyway. BUG=1007334,1006957 Change-Id: Ia14165402e2a3774a180d0215145d3d46338942c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828358 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700896}
-
Gyuyoung Kim authored
This CL applies pending_receiver to CreateCdm function in CdmFactory interface. Additionally, this CL converts mojo::StrongBindingSet to mojo::UniqueReceiverSet. Bug: 955171 Change-Id: I4bc983708e394800c3a31d3d6a598a39381fa3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826755Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#700895}
-
Christopher Thompson authored
We want to have a more semantically correct long term SecurityLevel for conditions where we want to show the warning (but not Dangerous) security indicator. This is a mechanical change to use a new enum value and replacing references to WARNING in comments. This also migrates metrics to use the new enum by updating Autofill and Security metrics to use WARNING in their suffixes instead. TBR=parastoog@google.com Change-Id: Ia86eef12cc231c6d7eac3b93b778a7f32f8d4571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815544 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#700894}
-
Will Harris authored
BUG=None Change-Id: I694f9560b119171d2fd51cde9cd84fab61f2e910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813398Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700893}
-
