- 05 Apr, 2011 12 commits
-
-
commit-queue@webkit.org authored
Unreviewed, rolling out r82876. http://trac.webkit.org/changeset/82876 https://bugs.webkit.org/show_bug.cgi?id=57816 Caused a lot of test crashes (Requested by tkent on #webkit). * JavaScriptCore.exp: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: * wtf/FastMalloc.cpp: (WTF::tryFastMalloc): (WTF::fastMalloc): (WTF::tryFastCalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::tryFastRealloc): (WTF::fastRealloc): (WTF::fastMallocSize): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::TCMalloc_PageHeap::signalScavenger): (WTF::TCMallocStats::malloc): (WTF::TCMallocStats::free): (WTF::TCMallocStats::fastCalloc): (WTF::TCMallocStats::tryFastCalloc): (WTF::TCMallocStats::calloc): (WTF::TCMallocStats::fastRealloc): (WTF::TCMallocStats::tryFastRealloc): (WTF::TCMallocStats::realloc): (WTF::TCMallocStats::fastMallocSize): * wtf/FastMalloc.h: (WTF::Internal::fastMallocMatchValidationType): (WTF::Internal::fastMallocMatchValidationValue): (WTF::Internal::setFastMallocMatchValidationType): (WTF::fastMallocMatchValidateFree): * wtf/Platform.h: git-svn-id: svn://svn.chromium.org/blink/trunk@82905 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Add a case label which was unexpectedly removed in r82899. https://bugs.webkit.org/show_bug.cgi?id=50661 * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): git-svn-id: svn://svn.chromium.org/blink/trunk@82904 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/7709452mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=49334 Reviewed by Simon Fraser. Source/WebCore: Tests: fast/ruby/overhang-horizontal.html fast/ruby/overhang-vertical.html This is a first cut at ruby overhang. It allows ruby text to hang over other text of equal or smaller size. Two notable omissions are that max preferred width computation was not patched, so it will overshoot, and that overhang ignores the width of the adjoining text runs. * rendering/RenderBlock.h: * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust margins of ruby runs for overhang. (WebCore::RenderBlock::fitBelowFloats): Maintain the increase in line width to compensate for overhang. (WebCore::RenderBlock::findNextLineBreak): When encountering a ruby run, increase the line width to account for the fact that overhang will be collapsed. * rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::getOverhang): Added. Allows ruby to overhang if the adjoining renderer is text with equal or smaller font size. * rendering/RenderRubyRun.h: (WebCore::toRenderRubyRun): LayoutTests: * fast/ruby/overhang-horizontal-expected.checksum: Added. * fast/ruby/overhang-horizontal-expected.png: Added. * fast/ruby/overhang-horizontal-expected.txt: Added. * fast/ruby/overhang-horizontal.html: Added. * fast/ruby/overhang-vertical-expected.checksum: Added. * fast/ruby/overhang-vertical-expected.png: Added. * fast/ruby/overhang-vertical-expected.txt: Added. * fast/ruby/overhang-vertical.html: Added. * platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: * platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: * platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: * platform/mac/fast/blockflow/english-lr-text-expected.checksum: * platform/mac/fast/blockflow/english-lr-text-expected.png: * platform/mac/fast/ruby/ruby-beforeafter-expected.checksum: * platform/mac/fast/ruby/ruby-beforeafter-expected.png: * platform/mac/fast/ruby/ruby-beforeafter-expected.txt: * platform/mac/fast/ruby/ruby-length-expected.checksum: * platform/mac/fast/ruby/ruby-length-expected.png: * platform/mac/fast/ruby/ruby-length-expected.txt: * platform/mac/fast/ruby/ruby-run-break-expected.checksum: * platform/mac/fast/ruby/ruby-run-break-expected.png: * platform/mac/fast/ruby/ruby-run-break-expected.txt: * platform/mac/fast/ruby/ruby-runs-expected.checksum: * platform/mac/fast/ruby/ruby-runs-expected.png: * platform/mac/fast/ruby/ruby-runs-expected.txt: * platform/mac/fast/ruby/ruby-runs-spans-expected.checksum: * platform/mac/fast/ruby/ruby-runs-spans-expected.png: * platform/mac/fast/ruby/ruby-runs-spans-expected.txt: * platform/mac/fast/ruby/ruby-trailing-expected.checksum: * platform/mac/fast/ruby/ruby-trailing-expected.png: * platform/mac/fast/ruby/ruby-trailing-expected.txt: * platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum: * platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png: * platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt: * platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum: * platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png: * platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt: * platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum: * platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png: * platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt: * platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum: * platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png: * platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt: * platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum: * platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png: * platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt: * platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum: * platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png: * platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt: * platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum: * platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png: * platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82903 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
Unreviewed, Chromium expectations update for tests broken after r82899. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82902 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
morrita@google.com authored
Unreviewed expectations update following r82899. * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: * platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: * platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82901 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
http://webkit.org/b/57384ddkilzer@apple.com authored
Reviewed by Alexey Proskuryakov. Source/WebCore: * WebCore.exp.in: Export wkSetHTTPPipeliningMaximumPriority(). * platform/mac/WebCoreSystemInterface.h: (wkSetHTTPPipeliningMaximumPriority): Added function pointer declaration. * platform/mac/WebCoreSystemInterface.mm: (wkSetHTTPPipeliningMaximumPriority): Added function pointer. * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost): Call wkSetHTTPPipeliningMaximumPriority() to set the maximum HTTP pipelining priority. * platform/network/cf/ResourceRequestCFNet.h: (WebCore::toResourceLoadPriority): Renamed from mapHTTPPipeliningPriorityToResourceLoadPriority(). Updated to to handle Unresolved case. (WebCore::toHTTPPipeliningPriority): Renamed from mapResourceLoadPriorityToHTTPPipeliningPriority(). Updated to handle Unresolved case. * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): Switched to use toResourceLoadPriority(). (WebCore::ResourceRequest::doUpdatePlatformRequest): Switched to use toHTTPPipeliningPriority(). Moved shouldForceHTTPPipeliningPriorityHigh() check into the argument of toHTTPPipeliningPriority() instead of hard-coding a now-incorrect value. Source/WebKit/mac: * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added initialization for wkSetHTTPPipeliningMaximumPriority(). Source/WebKit2: * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added initialization for wkSetHTTPPipeliningMaximumPriority(). WebKitLibraries: * WebKitSystemInterface.h: (WKSetHTTPPipeliningMaximumPriority): Added declaration. (WKExtractWordDefinitionTokenRangeFromContextualString): Added missing declaration from r81890. (WKShowWordDefinitionWindow): Ditto. (WKHideWordDefinitionWindow): Ditto. * libWebKitSystemInterfaceLeopard.a: Updated. * libWebKitSystemInterfaceSnowLeopard.a: Updated. git-svn-id: svn://svn.chromium.org/blink/trunk@82900 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
morrita@google.com authored
Reviewed by Kent Tamura. Convert <meter> shadow DOM to a DOM-based shadow. https://bugs.webkit.org/show_bug.cgi?id=50661 Updated expectations due to shadow structure chagne. Also updated meter-styles.html pixel result because the render tree is now laid out as normal flexboxes and its layout result is actually different, especially if there are non-zero borders on shadow elements. * fast/dom/HTMLMeterElement/meter-styles.html: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Kent Tamura. Convert <meter> shadow DOM to a DOM-based shadow. https://bugs.webkit.org/show_bug.cgi?id=50661 Eliminated a large part of <meter> custom layout code, which is replaced by a shadow tree. Note that the shadow tree is created on construction time and will remain during the host HTMLMeterElement lifecycle. * Android.mk: * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): * css/CSSMutableStyleDeclaration.h: * css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType): * css/CSSSelector.h: * css/html.css: (meter): (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimum-value): (meter::-webkit-meter-even-less-good-value): * html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::~HTMLMeterElement): (WebCore::HTMLMeterElement::parseMappedAttribute): (WebCore::HTMLMeterElement::attach): (WebCore::HTMLMeterElement::valueRatio): (WebCore::HTMLMeterElement::didElementStateChange): (WebCore::HTMLMeterElement::createShadowSubtree): * html/HTMLMeterElement.h: * html/shadow/MeterShadowElement.cpp: Added. (WebCore::MeterShadowElement::MeterShadowElement): (WebCore::MeterShadowElement::meterElement): (WebCore::MeterShadowElement::rendererIsNeeded): (WebCore::MeterBarElement::shadowPseudoId): (WebCore::MeterValueElement::shadowPseudoId): (WebCore::MeterValueElement::setWidthPercentage): * html/shadow/MeterShadowElement.h: Added. (WebCore::MeterBarElement::MeterBarElement): (WebCore::MeterBarElement::create): (WebCore::MeterValueElement::MeterValueElement): (WebCore::MeterValueElement::create): * rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::valueRatio): * rendering/RenderMeter.h: (WebCore::RenderMeter::renderName): (WebCore::RenderMeter::isMeter): (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation): (WebCore::RenderMeter::canHaveChildren): git-svn-id: svn://svn.chromium.org/blink/trunk@82899 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Antti Koivisto. Stop JSCell.h from including Structure.h https://bugs.webkit.org/show_bug.cgi?id=57809 * runtime/GetterSetter.h: * runtime/JSAPIValueWrapper.h: * runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject): * runtime/JSString.h: * runtime/ScopeChain.h: * runtime/Structure.h: (JSC::JSCell::isObject): (JSC::JSCell::isString): (JSC::JSCell::classInfo): (JSC::JSCell::createDummyStructure): (JSC::JSValue::needsThisConversion): (JSC::MarkStack::internalAppend): * runtime/StructureChain.h: git-svn-id: svn://svn.chromium.org/blink/trunk@82898 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kevino@webkit.org authored
Move to using FrameView::resize to handle changes in view size. https://bugs.webkit.org/show_bug.cgi?id=57805 git-svn-id: svn://svn.chromium.org/blink/trunk@82897 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
andersca@apple.com authored
Reviewed by Darin Adler. Send NPCocoaEventFlagsChanged events https://bugs.webkit.org/show_bug.cgi?id=57811 <rdar://problem/9215600> * Shared/WebEvent.h: (WebKit::WebEvent::capsLockKey): Add CapsLock modifier and getter. * Shared/mac/WebEventFactory.mm: (WebKit::modifiersForEvent): Check for NSAlphaShiftKeyMask and set the CapsLockKey modifier. * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::modifierFlags): Check for CapsLockKey and set NSAlphaShiftKeyMask. (WebKit::isFlagsChangedEvent): Return whether a given event is a Cocoa flags changed event. (WebKit::initializeKeyboardEvent): If this is a flags changed event, set the event type to NPCocoaEventFlagsChanged. git-svn-id: svn://svn.chromium.org/blink/trunk@82896 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Build fix for GTK+ after r82876. * Source/autotools/symbols.filter: Update the symbol filter to include new symbols from WTF that DRT uses. git-svn-id: svn://svn.chromium.org/blink/trunk@82895 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
andersca@apple.com authored
Reviewed by Darin Adler. Don't discard the backing stores of WKViews in the key window https://bugs.webkit.org/show_bug.cgi?id=57808 <rdar://problem/9110793> <rdar://problem/9194284> <rdar://problem/9222216> * UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::setBackingStoreIsDiscardable): Add empty stub. * UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_isBackingStoreDiscardable to true. (WebKit::DrawingAreaProxyImpl::setBackingStoreIsDiscardable): Set m_isBackingStoreDiscardable and schedule or stop the discard backing store timer. (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon): Don't start the timer if m_isBackingStoreDiscardable is false. * UIProcess/DrawingAreaProxyImpl.h: Add m_isBackingStoreDiscardable. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange): Mark the backing store as discardable if the view is hidden or if the containing window is not active. git-svn-id: svn://svn.chromium.org/blink/trunk@82894 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 04 Apr, 2011 28 commits
-
-
enne@google.com authored
Unreviewed, rolling out r82879. http://trac.webkit.org/changeset/82879 Trying to fix 10.6 layout test expectations broke 10.5 * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Added. * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added. * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added. * platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added. * platform/chromium-mac/fast/html/details-open1-expected.png: Added. * platform/chromium-mac/fast/html/details-open2-expected.png: Added. * platform/chromium-mac/fast/html/details-open3-expected.png: Added. * platform/chromium-mac/fast/html/details-open4-expected.png: Added. * platform/chromium-mac/fast/html/details-open5-expected.png: Added. * platform/chromium-mac/fast/html/details-open6-expected.png: Added. * platform/chromium-mac/fast/html/details-position-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added. * platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added. * platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Added. * platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Added. * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added. * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added. * platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added. * platform/chromium-mac/fast/multicol/nested-columns-expected.png: * platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Added. * platform/chromium-mac/fast/repaint/list-marker-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@82893 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tony@chromium.org authored
Reviewed by Ojan Vafai. [chromium] don't write .checksum files if a fallback platform has an embedded checksum https://bugs.webkit.org/show_bug.cgi?id=57783 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: git-svn-id: svn://svn.chromium.org/blink/trunk@82892 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dglazkov@chromium.org authored
Reviewed by Adam Barth. Introduce EventDispatchMediator abstraction, which encapsulate all non-trivial logic around firing a specific type of an event. https://bugs.webkit.org/show_bug.cgi?id=57562 Refactoring, covered by existing tests. * dom/Event.cpp: (WebCore::EventDispatchMediator::EventDispatchMediator): Added. (WebCore::EventDispatchMediator::~EventDispatchMediator): Added. (WebCore::EventDispatchMediator::dispatchEvent): Added. (WebCore::EventDispatchMediator::event): Added. * dom/Event.h: Added decl. * dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Changed to use EventDispatchMediator. * dom/EventDispatcher.h: Updated decls. * dom/KeyboardEvent.cpp: (WebCore::KeyboardEventDispatchMediator::KeyboardEventDispatchMediator): Added. (WebCore::KeyboardEventDispatchMediator::dispatchEvent): Added. * dom/KeyboardEvent.h: Updated decls * dom/Node.cpp: (WebCore::Node::dispatchEvent): Changed to use EventDispatchMediator. (WebCore::Node::dispatchKeyEvent): Changed to use KeyboardEventDispatchMediator. git-svn-id: svn://svn.chromium.org/blink/trunk@82891 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Reviewed by Xan Lopez. [Cairo] Memory leak in RefPtrCairo https://bugs.webkit.org/show_bug.cgi?id=57758 No new tests. This just fixes a memory leak. * platform/graphics/cairo/RefPtrCairo.cpp: (WTF::derefIfNotNull): Deref should unref the cairo_font_fact_t, not reference it. git-svn-id: svn://svn.chromium.org/blink/trunk@82890 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
Unreviewed, rolling out r82880. http://trac.webkit.org/changeset/82880 https://bugs.webkit.org/show_bug.cgi?id=50661 Meter elements not rendered in Chromium Linux layout tests. * fast/dom/HTMLMeterElement/meter-styles.html: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: 2011-04-04 Adrienne Walker <enne@google.com> Unreviewed, rolling out r82880. http://trac.webkit.org/changeset/82880 https://bugs.webkit.org/show_bug.cgi?id=50661 Meter elements not rendered in Chromium Linux layout tests * Android.mk: * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * css/CSSMutableStyleDeclaration.cpp: * css/CSSMutableStyleDeclaration.h: * css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType): * css/CSSSelector.h: * css/html.css: (meter): (meter::-webkit-meter): (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimal-value): (meter::-webkit-meter-even-less-good-value): * html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::create): (WebCore::HTMLMeterElement::parseMappedAttribute): (WebCore::HTMLMeterElement::attach): * html/HTMLMeterElement.h: * html/shadow/MeterShadowElement.cpp: Removed. * html/shadow/MeterShadowElement.h: Removed. * rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): (WebCore::RenderMeter::updateFromElement): (WebCore::RenderMeter::layoutParts): (WebCore::RenderMeter::styleDidChange): (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valueRatio): (WebCore::RenderMeter::barPartRect): (WebCore::RenderMeter::valuePartRect): (WebCore::RenderMeter::valuePseudoId): (WebCore::RenderMeter::barPseudoId): (WebCore::RenderMeter::detachShadows): (WebCore::RenderMeter::updateShadows): * rendering/RenderMeter.h: (WebCore::RenderMeter::renderName): (WebCore::RenderMeter::isMeter): (WebCore::RenderMeter::shadowAttached): git-svn-id: svn://svn.chromium.org/blink/trunk@82889 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@82888 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dpranke@chromium.org authored
Unreviewed, expectations change. Adjust the list of flaky tests based on NRWT on webkit mac using a 35 second timeout by default. * platform/mac/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@82887 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Ryosuke Niwa. setContentEditable with true/false/inherit string is not working properly https://bugs.webkit.org/show_bug.cgi?id=52058 Updated expected results after this patch fixes the set contenteditable issue. * fast/dom/HTMLElement/set-false-expected.txt: * fast/dom/HTMLElement/set-false.html: * fast/dom/HTMLElement/set-inherit-parent-false-expected.txt: * fast/dom/HTMLElement/set-inherit-parent-true-expected.txt: * fast/dom/HTMLElement/set-true-expected.txt: * fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt: 2011-04-04 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. setContentEditable with true/false/inherit string is not working properly https://bugs.webkit.org/show_bug.cgi?id=52058 Move isContentEditable from HTMLElement to Node. Thus, Node provides two functions for checking editability: rendererIsEditable and isContentEdiable. The former is a fast path, which does NOT trigger layout and only checks the render style of usermodify. The latter updates the layout first to make sure the render style syncs with DOM contenteditable attribute. Certain call sites that need to call isContentEditable rather than rendererIsEditable are also updated in the patch. But a complete fix will follow up in bug 57244. This patch fixes all the failed layout tests related to set contenteditable. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly): * dom/Node.cpp: (WebCore::Node::isContentEditable): (WebCore::Node::shouldUseInputMethod): * dom/Node.h: * html/HTMLElement.cpp: * html/HTMLElement.h: 2011-04-04 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. setContentEditable with true/false/inherit string is not working properly https://bugs.webkit.org/show_bug.cgi?id=52058 Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable as rendererIsEditable is for WebCore internal use. * src/WebNode.cpp: (WebKit::WebNode::isContentEditable): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition): 2011-04-04 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. setContentEditable with true/false/inherit string is not working properly https://bugs.webkit.org/show_bug.cgi?id=52058 Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable as rendererIsEditable is for WebCore internal use. * WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent): 2011-04-04 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. setContentEditable with true/false/inherit string is not working properly https://bugs.webkit.org/show_bug.cgi?id=52058 Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable as rendererIsEditable is for WebCore internal use. * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): git-svn-id: svn://svn.chromium.org/blink/trunk@82886 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kevino@webkit.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@82885 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@82884 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
Reviewed by Csaba Osztrogonác. Symbian build fix. https://bugs.webkit.org/show_bug.cgi?id=54977 * config.h: git-svn-id: svn://svn.chromium.org/blink/trunk@82883 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rolandsteiner@chromium.org authored
Reviewed by NOBODY (OOPS!). Bug 57689 - Extract scoping functionality from Document https://bugs.webkit.org/show_bug.cgi?id=57689 Moved selfOnlyRef (renamed to guardRef), element ID, image map and accesss key functionalities from Document to a new base class TreeScope. TreeShared: made removedLastRef protected No new tests. (refactoring) * Android.mk: * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::destroyScope): (WebCore::Document::getElementById): (WebCore::Document::childrenChanged): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::attach): (WebCore::Document::detach): * dom/Document.h: (WebCore::Node::Node): * dom/DocumentOrderedMap.cpp: (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName): * dom/DocumentOrderedMap.h: * dom/DOMAllInOne.cpp: * dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): * dom/Node.h: * dom/TreeScope.cpp: Added. * dom/TreeScope.h: Added. * platform/TreeShared.h: (WebCore::TreeShared::removedLastRef): made protected git-svn-id: svn://svn.chromium.org/blink/trunk@82882 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
beidson@apple.com authored
* win/WebKit2Generated.make: Rubberstamped by Adam Roben. git-svn-id: svn://svn.chromium.org/blink/trunk@82881 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
morrita@google.com authored
Reviewed by Dimitri Glazkov. Convert <meter> shadow DOM to a DOM-based shadow. https://bugs.webkit.org/show_bug.cgi?id=50661 Updated expectations due to shadow structure chagne. Also updated meter-styles.html pixel result because the render tree is now laid out as normal flexboxes and its layout result is actually different, especially if there are non-zero borders on shadow elements. * fast/dom/HTMLMeterElement/meter-styles.html: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: 2011-04-04 MORITA Hajime <morrita@google.com> Reviewed by Dimitri Glazkov. Convert <meter> shadow DOM to a DOM-based shadow. https://bugs.webkit.org/show_bug.cgi?id=50661 Eliminated a large part of <meter> custom layout code, which is replaced by a shadow tree. Note that the shadow tree is created on construction time and will remain during the host HTMLMeterElement lifecycle. * Android.mk: * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): * css/CSSMutableStyleDeclaration.h: * css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType): * css/CSSSelector.h: * css/html.css: (meter): (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimum-value): (meter::-webkit-meter-even-less-good-value): * html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::~HTMLMeterElement): (WebCore::HTMLMeterElement::parseMappedAttribute): (WebCore::HTMLMeterElement::attach): (WebCore::HTMLMeterElement::valueRatio): (WebCore::HTMLMeterElement::didElementStateChange): (WebCore::HTMLMeterElement::createShadowSubtree): * html/HTMLMeterElement.h: * html/shadow/MeterShadowElement.cpp: Added. (WebCore::MeterShadowElement::MeterShadowElement): (WebCore::MeterShadowElement::meterElement): (WebCore::MeterShadowElement::rendererIsNeeded): (WebCore::MeterBarElement::shadowPseudoId): (WebCore::MeterValueElement::shadowPseudoId): (WebCore::MeterValueElement::setWidthPercentage): * html/shadow/MeterShadowElement.h: Added. (WebCore::MeterBarElement::MeterBarElement): (WebCore::MeterBarElement::create): (WebCore::MeterValueElement::MeterValueElement): (WebCore::MeterValueElement::create): * rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::valueRatio): * rendering/RenderMeter.h: (WebCore::RenderMeter::renderName): (WebCore::RenderMeter::isMeter): (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation): (WebCore::RenderMeter::canHaveChildren): git-svn-id: svn://svn.chromium.org/blink/trunk@82880 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
Unreviewed, update Chromium Snow Leopard image baselines. These were all minor font-related image differences. * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed. * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed. * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Removed. * platform/chromium-mac/fast/html/details-no-summary1-expected.png: Removed. * platform/chromium-mac/fast/html/details-no-summary2-expected.png: Removed. * platform/chromium-mac/fast/html/details-no-summary3-expected.png: Removed. * platform/chromium-mac/fast/html/details-no-summary4-expected.png: Removed. * platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed. * platform/chromium-mac/fast/html/details-open1-expected.png: Removed. * platform/chromium-mac/fast/html/details-open2-expected.png: Removed. * platform/chromium-mac/fast/html/details-open3-expected.png: Removed. * platform/chromium-mac/fast/html/details-open4-expected.png: Removed. * platform/chromium-mac/fast/html/details-open5-expected.png: Removed. * platform/chromium-mac/fast/html/details-open6-expected.png: Removed. * platform/chromium-mac/fast/html/details-position-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed. * platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Removed. * platform/chromium-mac/fast/html/details-writing-mode-expected.png: Removed. * platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Removed. * platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Removed. * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed. * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed. * platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Removed. * platform/chromium-mac/fast/multicol/nested-columns-expected.png: * platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Removed. * platform/chromium-mac/fast/repaint/list-marker-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@82879 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Reviewed by Gustavo Noronha Silva. [GTK] WebGL support https://bugs.webkit.org/show_bug.cgi?id=31517 * configure.ac: Update configure.ac to ensure that GL/GLX headers exist. 2011-04-04 Martin Robinson <mrobinson@igalia.com> Reviewed by Gustavo Noronha Silva. [GTK] WebGL support https://bugs.webkit.org/show_bug.cgi?id=31517 Add WebGL support for the GTK+ bits of WebCore. No new tests. This will be covered by the existing WebGL tests once the bots are capable of running WebGL tests. * GNUmakefile.am: Added new files required for WebGL support. * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Extend #ifdef to cover GTK+ as well, which does not yet support accelerated compositing. * platform/graphics/ANGLEWebKitBridge.h: Update to reflect the fact that ANGLE isn't compiled as a framework for GTK+. * platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::platformTexture): Added a declaration of this method for Cairo. (WebCore::GraphicsContext3D::paintsIntoCanvasBuffer): Ditto. * platform/graphics/cairo/GraphicsContext3DCairo.cpp: Added. (WebCore::GraphicsContext3D::getImageData): Added. (WebCore::GraphicsContext3D::paintToCanvas): Added. * platform/graphics/cairo/OpenGLShims.cpp: Added. This file controls loading of GL extension functions dynamically. They have different names across the different vendors' GL implementations. (WebCore::lookupOpenGLFunctionAddress): Added (WebCore::openGLFunctionTable): Added (WebCore::initializeOpenGLShims): Added * platform/graphics/cairo/OpenGLShims.h: Added. * platform/graphics/gtk/DrawingBufferGtk.cpp: Added. (WebCore::DrawingBuffer::DrawingBuffer): Very generic implementation for Cairo. (WebCore::DrawingBuffer::~DrawingBuffer): Ditto. (WebCore::DrawingBuffer::didReset): Ditto. (WebCore::DrawingBuffer::platformColorBuffer): Ditto. * platform/graphics/gtk/GraphicsContext3DGtk.cpp: Added. (WebCore::GraphicsContext3D::create): Initial implementation. (WebCore::GraphicsContext3D::GraphicsContext3D): Ditto. (WebCore::GraphicsContext3D::~GraphicsContext3D): Ditto. (WebCore::GraphicsContext3D::makeContextCurrent): Ditto. (WebCore::GraphicsContext3D::platformGraphicsContext3D): Ditto. (WebCore::GraphicsContext3D::isGLES2Compliant): Ditto. * platform/graphics/gtk/GraphicsContext3DInternal.cpp: Added. (sharedDisplay): Added this shared display which is required by some display drivers. (WebCore::activeGraphicsContexts): This method keeps track of all active GraphicsContext3D contexts, in order to clean them up at exit. This prevents crashes on certain OpenGL drivers. (WebCore::GraphicsContext3DInternal::addActiveGraphicsContext): Ditto. (WebCore::GraphicsContext3DInternal::removeActiveGraphicsContext): Ditto. (WebCore::GraphicsContext3DInternal::cleanupActiveContextsAtExit): Ditto. (WebCore::GraphicsContext3DInternal::create): Figure out the best way to create an OpenGL context given the current environment. (WebCore::GraphicsContext3DInternal::createPbufferContext): Pbuffer context initializer. (WebCore::GraphicsContext3DInternal::createPixmapContext): Pixmap context initializer. (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): Initial implementation. (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): Ditto. (WebCore::GraphicsContext3DInternal::makeContextCurrent): Ditto. * platform/graphics/gtk/GraphicsContext3DInternal.h: Added. * platform/graphics/opengl/Extensions3DOpenGL.cpp: Added generic implementation. (WebCore::Extensions3DOpenGL::ensureEnabled): Ditto. * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::reshape): Test for the context using the public API rather than the private bits that are specific to the Apple port. 2011-04-04 Martin Robinson <mrobinson@igalia.com> Reviewed by Gustavo Noronha Silva. [GTK] WebGL support https://bugs.webkit.org/show_bug.cgi?id=31517 Add support for toggling WebGL at runtime when it's enabled. * webkit/webkitwebsettings.cpp: Add the enable-webgl property. When ENABLE_WEBGL is not enabled, it's a no-op. (webkit_web_settings_class_init): Update to support enable-webgl. (webkit_web_settings_set_property): Ditto. (webkit_web_settings_get_property): Ditto. * webkit/webkitwebview.cpp: (webkit_web_view_update_settings): Ditto. 2011-04-04 Martin Robinson <mrobinson@igalia.com> Reviewed by Gustavo Noronha Silva. [GTK] WebGL support https://bugs.webkit.org/show_bug.cgi?id=31517 Add support to the DRT for turning on WebGL when a layout tests requests it. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): Allow turning on WebGL from tests. git-svn-id: svn://svn.chromium.org/blink/trunk@82878 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ggaren@apple.com authored
Reviewed by Oliver Hunt. Fixed a weak-handle-related leak in RegisterFile https://bugs.webkit.org/show_bug.cgi?id=57793 * interpreter/RegisterFile.cpp: Nixed leaky GlobalObjectNotifier. * interpreter/RegisterFile.h: (JSC::RegisterFile::GlobalObjectOwner::finalize): (JSC::RegisterFile::RegisterFile): Replaced GlobalObjectNotifier with a per-RegisterFile weak handle owner, which does not leak. * runtime/WeakGCPtr.h: (JSC::WeakGCPtr::set): Allow set() to take a context argument, since RegisterFile now needs this. (Seems like it was an accidental omission all along.) git-svn-id: svn://svn.chromium.org/blink/trunk@82877 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Geoffrey Garen. Make malloc validation useful https://bugs.webkit.org/show_bug.cgi?id=57502 This patch changes FAST_MALLOC_MATCH_VALIDATION with a general corruption check that tags the beginning and end of all allocations to check for write overflows and overwrites the contents of memory on free in order to (hopefully) show up use-after-free issues sooner. We also turn it on by default for debug builds. * JavaScriptCore.exp: * wtf/FastMalloc.cpp: (WTF::tryFastMalloc): (WTF::fastMalloc): (WTF::tryFastCalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::tryFastRealloc): (WTF::fastRealloc): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::TCMalloc_PageHeap::signalScavenger): (WTF::TCMallocStats::malloc): (WTF::TCMallocStats::free): (WTF::TCMallocStats::fastCalloc): (WTF::TCMallocStats::tryFastCalloc): (WTF::TCMallocStats::calloc): (WTF::TCMallocStats::fastRealloc): (WTF::TCMallocStats::tryFastRealloc): (WTF::TCMallocStats::realloc): * wtf/FastMalloc.h: (WTF::Internal::fastMallocValidationHeader): (WTF::Internal::fastMallocValidationSuffix): (WTF::Internal::fastMallocMatchValidationType): (WTF::Internal::setFastMallocMatchValidationType): (WTF::fastMallocMatchValidateFree): (WTF::fastMallocValidate): * wtf/Platform.h: git-svn-id: svn://svn.chromium.org/blink/trunk@82876 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ggaren@apple.com authored
Reviewed by Oliver Hunt. Renamed clearWeakPointers => updateWeakHandles and removed misleading comment https://bugs.webkit.org/show_bug.cgi?id=57790 * collector/handles/HandleHeap.cpp: (JSC::HandleHeap::updateWeakHandles): Updated for rename. * collector/handles/HandleHeap.h: Removed comment claiming that this function should only be called during teardown, because it's actually called after every GC pass. * runtime/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots): Updated for rename. git-svn-id: svn://svn.chromium.org/blink/trunk@82875 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ggaren@apple.com authored
Reviewed by Oliver Hunt. Standardized handling of handles for immediate values https://bugs.webkit.org/show_bug.cgi?id=57788 * collector/handles/HandleHeap.cpp: (JSC::HandleHeap::clearWeakPointers): Don't check for null or non-cell values here, because our write barrier guarantees that such values are not in the weak list. (JSC::HandleHeap::writeBarrier): Standardized on checking for null before checking for cell, and on using early return instead of if/else. * collector/handles/HandleHeap.h: (JSC::HandleHeap::deallocate): (JSC::HandleHeap::makeWeak): Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@82874 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
andersca@apple.com authored
Reviewed by Dan Bernstein. Get rid of WebContext::process() in more places https://bugs.webkit.org/show_bug.cgi?id=57787 Migrate calls to WebContext::process() over to sendToAllProcesses and sendToAllProcessesRelaunchingThemIfNecessary. Add FIXMEs for things that need to be fixed in order to support multiple web processes. * UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::cancel): * UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData): * UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): * UIProcess/WebApplicationCacheManagerProxy.cpp: (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries): * UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::getHostnamesWithCookies): (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy): * UIProcess/WebDatabaseManagerProxy.cpp: (WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin): (WebKit::WebDatabaseManagerProxy::getDatabaseOrigins): (WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin): (WebKit::WebDatabaseManagerProxy::deleteAllDatabases): (WebKit::WebDatabaseManagerProxy::setQuotaForOrigin): * UIProcess/WebGeolocationManagerProxy.cpp: (WebKit::WebGeolocationManagerProxy::providerDidChangePosition): (WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition): * UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): (WebKit::WebIconDatabase::didFinishURLImport): * UIProcess/WebKeyValueStorageManagerProxy.cpp: (WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries): * UIProcess/WebMediaCacheManagerProxy.cpp: (WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache): (WebKit::WebMediaCacheManagerProxy::clearCacheForHostname): (WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames): * UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::getCacheOrigins): (WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin): (WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins): git-svn-id: svn://svn.chromium.org/blink/trunk@82873 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ggaren@apple.com authored
Not reviewed. Removed a redundant variable from HandleHeap https://bugs.webkit.org/show_bug.cgi?id=57786 Forgot to commit the file that actually removes the data member! * collector/handles/HandleHeap.h: git-svn-id: svn://svn.chromium.org/blink/trunk@82872 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ggaren@apple.com authored
Reviewed by Oliver Hunt. Removed a redundant variable from HandleHeap https://bugs.webkit.org/show_bug.cgi?id=57786 We don't need a specific variable to indicate that we're in the middle of the finalization phase, since m_nextToFinalize already does this. * collector/handles/HandleHeap.cpp: (JSC::HandleHeap::HandleHeap): (JSC::HandleHeap::clearWeakPointers): (JSC::HandleHeap::writeBarrier): git-svn-id: svn://svn.chromium.org/blink/trunk@82871 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ap@apple.com authored
REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2 https://bugs.webkit.org/show_bug.cgi?id=51230 <rdar://problem/8780989> <rdar://problem/9015250> REGRESSION (WebKit2): Key events not fired for modifier keys * UIProcess/API/mac/WKView.mm: (-[WKView flagsChanged:]): Ported from WebHTMLView. (-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]): AppKit isn't happy about attempts to interpret NSFlagsChanged, but WK2 lacked the check. git-svn-id: svn://svn.chromium.org/blink/trunk@82870 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sfalken@apple.com authored
* WebCore.vcproj/WebCore.vcproj: Exclude EventQueue.cpp in Debug_All build. git-svn-id: svn://svn.chromium.org/blink/trunk@82869 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
* WebCore.exp.in: Export PlatformCALayer::setGeometryFlipped. Also resorted some symbols. git-svn-id: svn://svn.chromium.org/blink/trunk@82868 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aestes@apple.com authored
* WebCore.exp.in: git-svn-id: svn://svn.chromium.org/blink/trunk@82867 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ggaren@apple.com authored
Reviewed by Oliver Hunt. Renamed Finalizer => WeakHandleOwner (in preparation for adding a reachability callback) https://bugs.webkit.org/show_bug.cgi?id=57775 Also renamed noFinalizer => emptyWeakOwner, since this is really an optimization for a weak owner with empty callbacks. * collector/handles/HandleHeap.cpp: (JSC::HandleHeap::clearWeakPointers): Updated for renames. Removed redundant initialization of m_nextToFinalize. Moved deletion check inside weak owner check, since the weak owner can't delete the node if there is no weak owner! * collector/handles/HandleHeap.h: (JSC::WeakHandleOwner::~WeakHandleOwner): (JSC::HandleHeap::makeWeak): Updated for renames. (JSC::HandleHeap::hasWeakOwner): Changed getFinalizer to hasWeakOwner, to clarify this function's role in assertions. (JSC::HandleHeap::Node::Node): (JSC::HandleHeap::Node::makeWeak): (JSC::HandleHeap::Node::isWeak): (JSC::HandleHeap::Node::weakOwner): (JSC::HandleHeap::Node::weakOwnerContext): (JSC::HandleHeap::Node::emptyWeakOwner): * interpreter/RegisterFile.cpp: (JSC::RegisterFile::globalObjectCollectedNotifier): * interpreter/RegisterFile.h: * runtime/WeakGCMap.h: * runtime/WeakGCPtr.h: (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::set): Updated for renames. git-svn-id: svn://svn.chromium.org/blink/trunk@82866 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-