GitLab

Previously, it is possible that before the newly created Core object is added ref by PepperFlashSettingsManager, Initialize() on the IO thread has caused the ref count to drop to 0 and destroy the object.
This change makes sure that PepperFlashSettingsManager holds 1 ref before doing the initialization.

BUG=132818
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10690146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146307 0039d316-1c4b-4281-b951-d872f2087c98

AndroidCommand object will root the device when it is created. 
If this happened before the device is online, error will appear.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10695170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146306 0039d316-1c4b-4281-b951-d872f2087c98

- intialize the V8 callbacks first thing, otherwise, the counters disable themselves
- don't use inline event handlers in the presence of a CSP
- on linux, the child processes need to use the parent's parent pid to derive the table name (the parent is the zygote, the parent's parent is the browser)

BUG=none
TEST=run chrome with --enable-stats-table, you should see lots of V8 stats, and you should be able to filter for e.g. V8


Review URL: https://chromiumcodereview.appspot.com/10690137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146305 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compile

Review URL: https://chromiumcodereview.appspot.com/10735068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146304 0039d316-1c4b-4281-b951-d872f2087c98

This change disables allocator_shim on Windows memory builders because it causes a linker error with the latest ANGLE code as reported by Erik (*1). Allocator_shim is disabled on shared builds and it happens only on memory builders, which use static builds. (All the other Windows debug builders use shared builds.)

(*1) https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/4197e93c6f5814ef/330ea8d9d31141e1?lnk=gst&q=base%2Fallocator+#330ea8d9d31141e1

BUG=none
TEST=build unit_tests.exe on the "Windows Tests (tsan)" bot and the "Chromium Windows Builder (DrMemory)" bot.
Review URL: https://chromiumcodereview.appspot.com/10704178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146303 0039d316-1c4b-4281-b951-d872f2087c98

Now mock_gdata_file_system includes gdata_file_system_interface.h.
This is for preparing another filesystem using the file system interface.

gdata_file_system_interface.h is extracted from gdata_file_system.h, and removed the following unused callback typedefs:
 - GetJsonDocumentCallback
 - GetDocumentResourceIdCallback

BUG=chromium:127728
TEST=compile, all tests run

Review URL: https://chromiumcodereview.appspot.com/10696190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146302 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146301 0039d316-1c4b-4281-b951-d872f2087c98

set from arguments. This enables debug other pieces such as base_unittests_apk

For example, to debug native tests, run with:
 gdb_apk -p org.chromium.native_test -l $CHROME_SRC/out/Release/lib.target -r


BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10736027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146299 0039d316-1c4b-4281-b951-d872f2087c98

- add new browser test which access to a page which requires client cert

BUG=136950
TEST=browser_tests

Review URL: https://chromiumcodereview.appspot.com/10541168

TBR=toyoshim@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10692184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146298 0039d316-1c4b-4281-b951-d872f2087c98

The ant building base dir is the same as the output directory. In SDK
r20, mergemanifest task will use the same file to do copying. As a
result, it will empty the manifest file - AndroidManifest.xml.

For the backward compatibility, fix it by copying input manifest file
into a new directory so the output manifest file is still in the ant
building base directory which could be used later by other tasks.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10694128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146296 0039d316-1c4b-4281-b951-d872f2087c98

This should make the API a little more clear.

BUG=114148
TEST=browser tests and sample extension still work

Review URL: https://chromiumcodereview.appspot.com/10716003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146295 0039d316-1c4b-4281-b951-d872f2087c98

- add new browser test which access to a page which requires client cert

BUG=136950
TEST=browser_tests

Review URL: https://chromiumcodereview.appspot.com/10541168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146294 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146293 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10692181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146292 0039d316-1c4b-4281-b951-d872f2087c98

This is for preparation for adding new Drive V2 API parser.

BUG=chromium:127728
TEST=compile

Review URL: https://chromiumcodereview.appspot.com/10692152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146291 0039d316-1c4b-4281-b951-d872f2087c98

Created CanvasImageSource utility class to simplify the image creating using canvas.

BUG=122992
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10702136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146290 0039d316-1c4b-4281-b951-d872f2087c98

Make eventArgumentMassagers asynchronous so custom bindings don't need to override chrome.Event.prototype.dispatch.


BUG=121479


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146038

Review URL: https://chromiumcodereview.appspot.com/10704073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146289 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a yet another suppression rule for the leak in PosixDynamicThreadPool::AddTask(). (As written in Bug 16089, PlatformThread::CreateNonJoinable() does not delete WorkerThread objects created by PosixDynamicThreadPool::AddTask().)

TBR=dhollowa
BUG=16089
TEST=make the "Linux Tests (valgrind)(4)" bot and the "Chromium OS Tests (valgrind)(5)" bot green.
Review URL: https://chromiumcodereview.appspot.com/10700181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146288 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146287 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10703161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146286 0039d316-1c4b-4281-b951-d872f2087c98

This file will be used in an end to end test for client cert auth.
Firstly, submit this binary file to avoid try bots failures.

BUG=136950
TEST=none (new items will be added to browser_tests)

Review URL: https://chromiumcodereview.appspot.com/10702140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146285 0039d316-1c4b-4281-b951-d872f2087c98

Previously a pyauto functional test tries to restart itself with a correct version of python(i.e. 2.6) if it finds out the current python version is not 2.6. 
Make changes to pyauto_functional.py so that it will check the value of an environment variable DO_NOT_RESTART_PYTHON_FOR_PYAUTO when the test starts.
If DO_NOT_RESTART_PYTHON_FOR_PYAUTO is set (to any value), it will not try to restart itself regardless what the current python version is.

This is to allow users to run PyAuto with python 2.7. Users of python 2.7 can now run PyAuto functional tests by setting this environment variable (to any value).

BUG=None
TEST=Ran test_basic.py with DO_NOT_RESTART_PYTHON_FOR_PYAUTO set and unset.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10694077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10694127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146283 0039d316-1c4b-4281-b951-d872f2087c98

R=akalin@chromium.org
BUG=108171
TEST=


Review URL: https://chromiumcodereview.appspot.com/10689157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146282 0039d316-1c4b-4281-b951-d872f2087c98

This is the cache miss equivalent of r118386. We were unnecessarily posting a task to restart the HTTP request on a cache miss. On pages with heavy activity this can delay the load until the task can get executed.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10700125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146281 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for replacing GDataCacheEntry
with a proto.

BUG=136921
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10736045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136629
TEST=
TBR=aa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10703158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146279 0039d316-1c4b-4281-b951-d872f2087c98

Adds logic to transfer the waiting-for-next-keyframe state to the split range
if necessary.

BUG=NONE
TEST=media_unittests


Review URL: https://chromiumcodereview.appspot.com/10703125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146274 0039d316-1c4b-4281-b951-d872f2087c98

Convert PyAuto's NavigateToURL, GetActiveTabIndex, Refresh, RefreshActiveTab, and AppendTab to the JSON interface.

BUG=132794
TEST=chrome/test/functional/browser.py, chrome/test/functional/navigation.py


Review URL: https://chromiumcodereview.appspot.com/10692067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146273 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118109
TEST=Manually verify that all monitors are remoted when connecting to a multi-monitor Windows host, even if one or more monitors are configured to the left or above the primary monitor.


Review URL: https://chromiumcodereview.appspot.com/10699046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146272 0039d316-1c4b-4281-b951-d872f2087c98

TEST=added
BUG=132616


Review URL: https://chromiumcodereview.appspot.com/10695161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146271 0039d316-1c4b-4281-b951-d872f2087c98

Non 7-bit ASCII characters confused the hell out of try bots and scripts
and led to hard to track bugs.

BUG=
TEST=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10696187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101244


Review URL: https://chromiumcodereview.appspot.com/10762006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146269 0039d316-1c4b-4281-b951-d872f2087c98

This change updates the suppression rule for Bug 111186 <http://crbug.com/111186> to catch up with r140100 <http://crrev.com/140100>.

TBR=dhollowa
BUG=111186
TEST=make the "Linux Tests (valgrind)(5)" bot and the "Chromium OS Tests (valgrind)(5)" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10704177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146267 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135258
TEST=Manual, made sure that the tab background was fully tinted with several themes

Review URL: https://chromiumcodereview.appspot.com/10690115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10692141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146265 0039d316-1c4b-4281-b951-d872f2087c98

We saw a Chrome crash on changing the device volume in Guest mode if Accessibility has been turned on. This automation test will catch this type of crash.

TEST=None
BUG=129218
Review URL: https://chromiumcodereview.appspot.com/10696169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146263 0039d316-1c4b-4281-b951-d872f2087c98

Relanding with improved tests and support for cleaning up partial nigori.

The original patch was reverted due to users who needed to download a new nigori
node, but who had since been migrated. We do not handle migration before the
backend is initialized, so we now go ahead and detect+delete partial nigori
nodes before redownloading them. By blowing away the old progress marker,
we're no longer at risk of receiving the migration done response.

In order to test this the SyncBackendHost unit tests have been substantially upgraded.

original review at: https://chromiumcodereview.appspot.com/10483015

BUG=129665,133061,133219
TEST=unit/integration tests

Review URL: https://chromiumcodereview.appspot.com/10701085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146262 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses a leak in base::PlatformThread::SetName() shown in the heapchecker bots. (Even though this std::string is created by tracked_object and it may be a duplicate of Bug 102327 <http://crbug.com/102327>, I do not have any ideas why this stack does not include tracked_objects.)

TBR=dhollowa
BUG=136936
TEST=make the "Linux Heapcheck" bot and the "Chromium OS Heapcheck" bot green.
Review URL: https://chromiumcodereview.appspot.com/10694149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146259 0039d316-1c4b-4281-b951-d872f2087c98

R=erg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146258 0039d316-1c4b-4281-b951-d872f2087c98