- 10 Oct, 2019 40 commits
-
-
Jeevan Shikaram authored
Hide the uninstall button for system apps and remove the description for Chrome apps. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=415747&signed_aid=gwLp8IV1DTB8pINqUZ3Twg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=415748&signed_aid=klGiEUGbTUYNh9P4-D_3HA==&inline=1 Bug: 1013034 Change-Id: I34a271d52eef8c0ed66b7fa7010d27fce3376968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851786 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#704521}
-
Justin Cohen authored
Bug: 1010765 Change-Id: I5aaf239b0cae1cfc0ca1600d89b6bdc6893e52c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849131 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#704520}
-
Johannes Henkel authored
It turns out we may not need to have a deeply nested hierarchy, so this PR attempts to flatten this hierarchy as we're creating child session instances. This avoids a crash that would happen for grandchildren when they're trying to use their parent's socket to send messages. BUG=chromedriver:3165 Change-Id: I4fb22a7aeaf67321a062deb831ebc68ace904b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851227 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704519}
-
Justin Cohen authored
On iOS13, WebKit started changing the URL visible webView.URL when opening a new tab and then writing to it, e.g. window.open('javascript:document.write(1)'). This URL is never committed, so it should be OK to ignore this URL change. Bug: 1012718 Change-Id: Id7f24384f3146ecad3af0fbfabfdfa02a9bb63f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849993 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:Ali Juma <ajuma@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d65a3ffb5ea1..01cfdcb21734 Created with: gclient setdep -r src-internal@01cfdcb21734 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I829fbf3f67531b090133be282092d9397777e42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851824Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704517}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe23b1de9ed0..0fc9b3829b47 git log fe23b1de9ed0..0fc9b3829b47 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 309b078c..92809357 (414 commits) Created with: gclient setdep -r src/third_party/skia@0fc9b3829b47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None Change-Id: I795a8ab228cd6d9a3e5268576de740362f94fa89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851726Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704516}
-
Abhijeet Kandalkar authored
This CL converts usage of |ConsumerHostRequest| to mojo::PendingReceiver<mojom::ConsumerHost> Bug: 955171, 978694 Change-Id: I5ce130f32d6c1af7662e239e47046d8f2187250d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843992Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#704515}
-
Julie Jeongeun Kim authored
This CL converts AlertBridgeRequest and AlertBridgePtr to new Mojo types using PendingReceiver, Remote and Receiver. Bug: 955171 Change-Id: I24ef7e3f521e7967c75ad7ed8dedb80e3e0e1a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846632 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#704514}
-
Miyoung Shin authored
This CL converts ImmersiveOverlay{Ptr, Request} in chrome and device to the new Mojo type, and use pending_receiver<ImmersiveOverlay> in isolated_xr_service.mojom. Bug: 955171 Change-Id: I6bffe1a07b9e2240834e69d2ebcada64b8fdd7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847452 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#704513}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d7323cf7f12d..c5e0ac757a11 git log d7323cf7f12d..c5e0ac757a11 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 kbr@chromium.org Conditionalize DeviceCGL implementation. 2019-10-10 nazabris@microsoft.com Add D3D11on12 device option Created with: gclient setdep -r src/third_party/angle@c5e0ac757a11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ie3cbf8a645de49ff7d95f99cc70d2a167efe507f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851326Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3864d00ebe05e8395157369cc04effb7b79050e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851684Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/992c5b481bab..5224ac45e460 git log 992c5b481bab..5224ac45e460 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 jclinton@chromium.org Disable release HW tests for more betty and novato boards 2019-10-10 tbosch@google.com cros_setup_toolchains: Also copy .elf file from noccache version 2019-10-10 achuith@chromium.org Revert "chrome_chromeos_lkgm: Temporarily skip the betty trybot on the CQ." Created with: gclient setdep -r src/third_party/chromite@5224ac45e460 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Icca68167f2ae3fd431de543de875e326ad7023bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851385Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for ActivatedShape enum class is more type safety. Bug: 940736 Change-Id: I377b57af89eb29199f31496b310d7adea414e711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850677 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#704509}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8374dec2..ef91f895 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I138bd6449eec23313f7438e783b19fb30ebe0e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851404Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704508}
-
Jay Harris authored
Bug: 860581 Change-Id: I3536dfbae57e9141a5f6fdbcb6c1722252a60d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850686Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#704507}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/71681bf1e84a..3481902904a9 git log 71681bf1e84a..3481902904a9 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-09 ehmaldonado@chromium.org depot_tools: Remove depot-tools-auth Created with: gclient setdep -r src/third_party/depot_tools@3481902904a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001756 Change-Id: Ifaa8e95da25f86900a46170c1664340a4216e0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851153Reviewed-by:
-
Gyuyoung Kim authored
This is a reland of 43c06dab Include manifest.mojom-blink.h in push_messaing_client.cc Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 11 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I467c6ee86c44e581a6fee3cdcb8a5fdf6ed29aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847599 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#704455} Bug: 1001360 Change-Id: I394b286c39adbb80356ed84e10ac466750d3164a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851368Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704505}
-
Ken MacKay authored
Merge-With: eureka-internal/323312 Bug: internal b/127963522 Change-Id: Ic5a57c0c673d167bb7c56f9c5f5f41a8c64cfa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848941 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704504}
-
Hiroshige Hayashizaki authored
Intent to deprecate and remove: https://groups.google.com/a/chromium.org/d/topic/blink-dev/KyB2mwOmjrk/discussion This CL also removes crash tests that require executing scripts moved between documents. Code paths related to scripts moved between documents will be covered by e.g. https://github.com/web-platform-tests/wpt/pull/5911 Bug: 721914 Change-Id: I6acb7182c4a62accd5e5285adb6a77a2cd891465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843508Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#704503}
-
Maggie Cai authored
This CL adds fields in IntentInfo to allow Chrome to send more flexible intent to ARC. This allows ARC to create the URI rather than Chrome. BUG=853604 Change-Id: Ib908039e079109e5d72c31d8c5822b8bcd2b10bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839751 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#704502}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a9ec07ff393..fe23b1de9ed0 git log 0a9ec07ff393..fe23b1de9ed0 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-09 herb@google.com Revert "Draw perspective text as paths." Created with: gclient setdep -r src/third_party/skia@fe23b1de9ed0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I4e8f95f75266c9826ccd7fc590ab3148d5c640ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851151Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/05b285760e40..65adcb504d02 git log 05b285760e40..65adcb504d02 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 rharrison@google.com Add in shaderc_features.gni to support build time flags (#837) Created with: gclient setdep -r src/third_party/shaderc/src@65adcb504d02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ie3f59dd445730236da5d3a3ea30392f0417f4e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849636Reviewed-by:
-
Shuo-Peng Liao authored
ImageProcessor stores input and output's configuration with VideoFrameLayout object and VideoFrame::StorageType. However, VideoFrameLayout is unable to represent proprietary format, e.g. MT21, so it is not suitable to represent IP's input/output config. Instead of storing individual configuration properties (format, visible_size, color_plane_layout, storage_type), we modify an existing class, ImageProcessor::PortConfig, to store ImageProcessor's input/output configuration. BUG=1004727, 1005636 TEST=Run VDA test on elm and kukui Pass image_processor_test Change-Id: I720b8ba41db8c5d4e0d1c42ea41f3d4ba27d3ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817858Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Shuo-Peng Liao <deanliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704499}
-
BUG=762641 TBR=satorux@chromium.org Change-Id: I6e032bfdc68a841676c7ee19f2ac19470a031586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851388Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704498}
-
Peter Kotwicz authored
This CL renames ActivityTabTaskDescriptionHelper and ActivityTaskDescriptionIconGenerator to be CCT specific BUG=989912 R=pshmakov TBR=twellington (as files are being moved from chrome/browser) Change-Id: I8f07a043663178a26405d26e69ab7dfbf37104bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849943Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704497}
-
Alex Moshchuk authored
This CL fixes the undesirable behavior where manually enabling password site isolation from chrome://flags didn't take effect if the user's device was below the site isolation memory threshold. The same also affected strict origin isolation, which is also fixed. (Strict site isolation and IsolateOrigins are not affected because they map to cmdline switches rather than base::Features.) Bug: 1009828 Change-Id: Ibdfbca5ed1e2216e347e15a18c71ceaeafe2da03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845667 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#704496}
-
Kenichi Ishibashi authored
This CL is a preparation for passing outside fetch client settings object. This CL plumbs outside fetch client settings object from browser process to renderer process but its fields aren't set correctly yet. Follow-up CLs will fill them correctly. This CL does not have behavioral changes. Bug: 967265 Change-Id: I83b9bc6644c2bf33a0516f869166cc639fe61683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846220Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704495}
-
Bo Liu authored
Do a complicated dance to avoid visual artifacts during transition: 1) Allocate new SurfaceData, and insert it into view hierarchy below the existing SurfaceData, so it is not yet showing. 2) When Surface is allocated by new View, swap chromium compositor to the new Surface. |markForDestroy| is called on the previous SurfaceData, and the two SurfaceDatas are linked through these to variables. Note at this point the existing view should is still visible. 3) Wait until new SurfaceData decides that it has content is visible to be shown. * For TextureView, wait until TextureView.invalidate is called * For SurfaceView, wait for two swaps from the chromium compositor 4) New SurfaceData calls |destroy| on previous SurfaceData. * For TextureView, it is simply detached immediately from the view tree * For SurfaceView, to avoid flicker, move it to the back first before and wait two frames before detaching. 5) Previous SurfaceData runs callbacks on the new SurfaceData to signal the completion of the transition. Other related changes: * Update CompositorImpl::SetNeedsComposite to force a new frame to be produced. * Allow java to control caching and releasing the back buffer. * To complete the steps above, chain the two SurfaceDatas so new one calls destroy on old one, and old one calls runCallbacks on the new one. * Add TextureViewWithInvalidate to listen to when it is invalidated. * Implement moveChildToBackWithoutDetach with calls to bringChildToFront since android does not have a moveChildToBack method. * Send an artificial surfaceDestroyed signal in destroy to control back buffer caching. Change-Id: Ie43485304c1c08df5ae11cd7756767d29e84e112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836605 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#704494}
-
Kenichi Ishibashi authored
Conversions between WebFetchClientSettingsObject and mojom::FetchClientSettingsObject will be needed for shared/service workers in addition to dedicated workers. Introduce a helper function to avoid duplication of these conversions. This CL does not have behavioral changes. Bug: 937177 Change-Id: I6cef87d510b41ae31087c71a90c6b704049bb20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846622 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Roger Tawa authored
Bug: 1012865 Change-Id: I83e03782d6975b1b5a7b53c994476f933f451536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849984 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#704492}
-
tby authored
When a FilesTaskNotifier is not available (which happens sometimes in guest mode), the |files_ranker_| object in ZeroStateFileProvider never gets initialized, crashing Chrome the next time it is used. Bug: 1012911 Change-Id: Ic1d2231d4d3e9810fd16a7425a98faf94c65115e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850672 Auto-Submit: Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#704491}
-
Joel Hockey authored
Updated FileManagerDialogBase.shown to be set to false immediately when hide() is called. Previously, when one dialog spawns a second, the second fails to show since FileManagerDialogBase is setting its static 'shown' property to false async. The call to show the second dialog is ignored since the dialog believes it is still showing the first. Bug: 1010371 Change-Id: I96d5b9fad72c1c7a87520fdc92604494b5b7a9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849474 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#704490}
-
Mugdha Lakhani authored
We currently wake the browser up and call FireReadyEvents() to fire any ready sync events, and then call the passed |callback|. Before this change, we were invoking the callback once all sync events had been fired. This CL waits till all those sync events have completed before running the callback. This will have the effect of keeping the browser awake until all sync events complete, and will add a few minutes to how long we hold the wakelock. It will give the browser a chance to finish processing (Periodic) Background Sync registrations and reduce the number of times we need to wake the browser up. This CL adds a new parameter to BackgroundSyncParameters to enable this functionality, so that we can run experiments using the existing 'BackgroundSync' field trial before it's enabled everywhere. A unit test has also been added to verify the functionality. Bug: 933849, 932591 Change-Id: Ica68f6bdb262dea2365334296ae825d91126c65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807194 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#704489}
-
Manas Verma authored
Whenever card suggestions are shown, and the user has server cards and is eligible for FIDO authentication, a preflight call is made to retrieve authentication details. Logging the number of times this call is made. Also includes a bug fix, something that was caught by the metrics test. Bug: 949269 Change-Id: Ic1067de5a137598c0758f787a41d7a311f7d0a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783858Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#704488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9514a2a7642d..d65a3ffb5ea1 Created with: gclient setdep -r src-internal@d65a3ffb5ea1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3c8006113e04707aa93ea29744f2d41920f0c81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851152Reviewed-by:
-
Yu Han authored
Previous to this CL, hitting CTRL-A inside a TextArea containing text that ends with a newline would cause the selectionEnd property to be incorrect. selectionEnd returns a number that's 1 pass the end of text. This is because TextControl automatically inserts an BRElement at the end when the last child is a carriage return. And the inserted node is taken into consideration when calculating the selection range. The fix is to ignore this last child if it's a BRElement. Tested with carriage return inserted into the beginning, middle and end of text to make sure there's no regression. Bug: 882614 Change-Id: Idc7a1f098556fc74b89f3041e3f5f35e127eed78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838549Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
This is a reland of bc1f6367 Original change's description: > [fuchsia] Add wildcard support for hosts filtering. > > Add wildcard-based filtering for hosts in UrlRequestRewriteRules. > > Bug: 1011156 > > Change-Id: I982b2241e622194dbf39ccd8519af8f92ee593c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838706 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704406} TBR=wez@chromium.org Bug: 1011156 Change-Id: Iee15c86f44a6f6a1d2496f79483add4ea12d2799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851324Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#704485}
-
Jay Harris authored
This CL is just the boilerplate of creating new classes and wiring them up to WebAppProvider. Eventually, the functionality from web_app_extension_shortcut should be migrated into this class. A WIP CL for beginning this is available here: https://crrev.com/c/1846422. The motivation for beginning this now is file handling on Linux, as registering and unregistering file handlers in the OS is tightly coupled to shortcut management. Bug: 860581 Change-Id: I3e28018d6fd6656fccd3c22ed62b9576db43f51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847708 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Navigation Sheet should be closed when its Tab is closed. In most cases the sheet is close prior to Tab, but the opposite can happen if incognito tabs are closed via Android notification. This CL ensures the sheet gets closed upon tab closure. Bug: 1011073 Change-Id: Id9729c2d8987bfe37ff81f47a8070d40a86e00e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842134Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#704483}
-
Alexey Baskakov authored
This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. - Implement WebAppSyncBridge::MergeSyncData and ApplySyncChanges. - Implement "Local changes" propagation to change_processor. Unit tests and browser tests will be added later in a follow up CL. An MVP implementation of the bridge needed first. This CL follows Chrome Sync's Model API doc https://chromium.googlesource.com/chromium/src/+/HEAD/docs/sync/model_api.md In next CLs: Implement sync-initiated installs and uninstalls. TBR=alancutter@chromium.org Bug: 860583 Change-Id: I65d3cae6f47dd8fc8fdbe2c7cfb2ed13012f90f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830494Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#704482}
-
