- 05 Aug, 2019 40 commits
-
-
Alex Cooper authored
Add self as test-related owner, add KlausW to subdirectory to guarantee two OWNERS per file. Change-Id: I6cfc7ec5b2486006829abf5784a5250f4a9bc4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731775Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#684147}
-
Jeremy Chinsen authored
Currently PDFiumEngine::Paint() takes a region of space, |leftover|, that needs to be redrawn and iterates through the visible pages, drawing them. A part of this process is recomputing the region of space that needs to be redrawn. In two-up view, a page does not span the whole width of the document so subtracting the page's area from |leftover| does not result in a rectangle. This CL makes PDFiumEngine::Paint() only recompute |leftover| if |two_up_view_| is false, allowing PDFiumEngine to properly draw two-up view layouts. Bug: 51472 Change-Id: Ia7175d3182bd208e1b20c6ffe0a7f510ba2cff26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731925Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#684146}
-
Darwin Huang authored
Removes some remaining mus-specific code and comments. Follow-up of https://crrev.com/c/1729060 Change-Id: Ia51339c768a9965273f073c4695ec710e3be908d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730651 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#684145}
-
David Benjamin authored
Both fields are std::vector<uint16_t> which is copy-assignable. Bug: none Change-Id: I4f770d790abbdc8086d0b809dd8f1ff90475ad23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737369 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#684144}
-
Mike Frysinger authored
Copied over from swarming_client/third_party/six/. We'll rely on it to help with porting to Python 3. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Ie195d79ea07bba3a6bcfb76b2520440a30fa439e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700503 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#684143}
-
Raphael Kubo da Costa authored
Make things less confusing by defining it closer to where it is used. The only other place using CallbackWrapper is orientation-sensor.html, where it was easier to just enclose the calls in a try-catch block. Bug: 987639 Change-Id: I1d27c7ace977f456f7e6b3b604b87a7b0246b845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718707Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#684142}
-
Morten Stenshorne authored
Only create block break tokens if we have more work to do for the node in the next fragmentainer. The concept of finished break tokens was really only sufficient to prevent us from re-laying out a node in the very next fragmentainer, but not enough to prevent us from restarting layout in any fragmentainer after that. A node may overflow into more than one additional fragmentainer, while a subsequent sibling may finish way earlier. Correct and simplify the block child iterator, by first processing all the break tokens in order, and then continuing with unstarted siblings at the sibling after the last break token. We can only perform this second step (unstarted siblings) if we actually have unstarted nodes, though. This isn't something we can tell by examining the child break tokens, so, when we have managed to get to ("see") the last child of some parent node when laying out a fragmentainer, mark the resulting parent break token as such. Note that this change is only for block break tokens. Inline layout still creates finished break tokens (but maybe we could change that as well?). Bug: 829028 Change-Id: I0ce7973b94f1a73720aef943a5fcb3ce82ad5e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733596 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#684141}
-
Ken Rockot authored
Eliminates all Service Manager dependencies from //chrome/services/file_util/. Adds a LaunchFileUtilService() call to //chrome/browser/, which launches a dedicated service process for file utilities that can be controlled by the returned Mojo remote. Adapts client library call sites to use LaunchFileUtilService instead of a Connector. Bug: 977637 Change-Id: Ie3e3a583fd00a6d9f77137d0febbccf6a086ff0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732679Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#684140}
-
Findit authored
This reverts commit 4020c38f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 684103 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQwMjBjMzhmZmVkOWIzYWRhMWMyMTZjYjM0NTE2NDQwNWQ1ZmNlOGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/49342 Sample Failed Step: content_unittests Original change's description: > Remove ByteStreamInputStream class > > This class was previously used by DownloadRequestCore in > non network service code path. We no longer need this now. > > BUG=934009 > > Change-Id: I827d2f644eed739fd95f544b3f402e1bc7e957f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733420 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684103} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=934009 Change-Id: I3defc99d39a42b49118f38196956911fa78e2c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737626 Cr-Commit-Position: refs/heads/master@{#684139}
-
Tom Sepez authored
Minimal code change to get new behaviour so that tests can be updated. Code cleanup in a subsequent CL. The third_party/blink/web_tests/http/tests/security/xssAuditor directory is removed entirely. Three other files outside this directory are removed which also triggered the auditor. Bug: 968591 Change-Id: I6374a4c381c8a5210eaff97c8f031a789c7059b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723805 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#684138}
-
Raymond Toy authored
When a setTargetAtTime event has converged (10 time constants), we basically hold the value. However, if there's a setValue event after convergence, and this setValue is within the current render quantum, the current_frame was not getting updated, so when this event and the next are getting processed, the currentTime has the incorrect value. Update current_frame appropriately in this case. Bug: 990393 Test: the-audioparam-interface/set-target-conv.html Change-Id: I4b364d3972e1f5acb454916fdb6455fb75b7e7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736173Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#684137}
-
Luke Zielinski authored
Bug: 937369 Change-Id: Ief48c90e41affaf469ef80a9e2fd2e86c8f29ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731909 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#684136}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/444cccdb2cdd..cc4114d75878 git log 444cccdb2cdd..cc4114d75878 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 levarum@google.com Revert "chromite: Temporarily move betty-arcnext-pi-android-pfq to experimental" 2019-08-05 tcwang@google.com afdo: Fix OWNERS files. Created with: gclient setdep -r src/third_party/chromite@cc4114d75878 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I40611a64e019799d9a56a1e61ccfc393d19535e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736520Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684135}
-
Xinghui Lu authored
The current implementation in Chrome shows "Security Error". The title should be "Page may charge money" instead. Bug: 913889 Change-Id: I8655217cadc4e481d149ad5a80520367148dc2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732309Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#684134}
-
Vincent Boisselle authored
Give more information about what/why demographic data is used and how to avoid reporting that data. Bug: 990822 Change-Id: I79237d6f5ce0522709a311a86f57e1e855881fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735975 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#684133}
-
Kristyn Hamasaki authored
Change-Id: Ic62f3e022d648bcfb9e23d0928d6efd118d78bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726814Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#684132}
-
minch authored
Bug: 988513 Change-Id: Icae273a3e57abbf09f154bc89ba8a37e7017fdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737347Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#684131}
-
minch authored
Bug: 988517 Change-Id: I3643af0ada3f390440e9a65c28990bc43f92ae80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737328Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#684130}
-
dpapad authored
Also porting cr-icons style module, which is a transitive dependency of cr-input. Bug: 965770 Change-Id: I6e5ec4fdf33a5b0f48a51e66e772254638200982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733855 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#684129}
-
Stefan Zager authored
LocalFrameView::UpdateViewportIntersectionsForSubtree already has a (!NeedsLayout()) check to prevent it from computing intersections if layout is dirty. This patch uses the same logic to avoid recomputing the intersection of an iframe with its embedding document if the embedding document's layout is dirty. It's not clear why NeedsLayout() would be true if the document lifecycle is >= kLayoutClean, although I suspect it has something to do with the way LocalFrameView::has_pending_layout_ is used. I've been unable to construct a test case which reproduces the condition. I added a TODO to figure out how this can happen. BUG=989637 R=chrishtr@chromium.org Change-Id: I3ed84f7ccc3736e495efcd4cf945d44379086d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732335Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#684128}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1138888e7ce..0e03cdf09226 git log f1138888e7ce..0e03cdf09226 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 benjaminwagner@google.com [infra] Manually roll godeps after infra fix 2019-08-05 egdaniel@google.com Revert "[skottie] Add onTextProperty support into PropertyObserver." 2019-08-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-05 bsalomon@google.com Pass size and GrPixelConfig to GrSurface/Texture/RenderTarget constructors 2019-08-05 aparchur@google.com [skottie] Add onTextProperty support into PropertyObserver. Created with: gclient setdep -r src/third_party/skia@0e03cdf09226 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: I4ff1b25963a8b16c6eea7af48b9f8d624944a857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684127}
-
Bret Sepulveda authored
Previously group headers were sized the same width as tabs, which would give them lots of extra margin around the title chip when the tabs were big and not enough margin when the tabs were small. This patch allows tabstrip layout to use a different TabSizeInfo for each View, and gives group headers a fixed width based on their title chip size. Bug: 905491 Change-Id: I8705581633c1e6bf4a71fd4522a55391e8a4f54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721559 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#684126}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0453b000cc33..f399ecdef769 Created with: gclient setdep -r src-internal@f399ecdef769 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:790463,chromium:790452,chromium:790443,chromium:790442,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: If11fa921aa17f0efc24f5865ea28d84e179b709a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737393Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684125}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=jamesr@chromium.org Change-Id: I6c82de2bdf0d0c819c5c185788f727b0be5dbe87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733590 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#684124}
-
Alexis Menard authored
If the GPU works with MSAA we should use it. However the current code will always fallback to CMAA on desktop GL because GL_EXT_multisampled_render_to_texture is only available on ES profile. While CMAA could be used by other GPUs than Intel, currently Chromium only provides support for CMAA on Intel GPUs. This patch aligns with the behavior of DrawingBuffer which is used to render the WebGL content. Bug: 990923 Change-Id: Ie3a94a68a685fa0b34d573d48f6d4853d553be64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730624Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Menard <alexis.menard@intel.com> Auto-Submit: Alexis Menard <alexis.menard@intel.com> Cr-Commit-Position: refs/heads/master@{#684123}
-
Kristi Park authored
When required, compress the height of the background tiles section in order to keep the dialog within viewport boundaries. Before: http://screen/hiFC5HwrFsG.png After: http://screen/Ras1KXOdR69.png http://screen/QZzwKp7BnF3.png http://screen/aZeonNGjBEV.png Bug: 990803 Change-Id: I6c83124e5490729b14fb7e8fb68da106af6c8caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736892 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#684122}
-
Wez authored
This reverts commit 510e0f76. Reason for revert: The GN rules are missing a dependency on the FIDL package for fuchsia.cdm, so the build flakily fails, depending on whether ninja happens to have generated the C++ bindings before or after building components that happen to be using it, e.g. see https://ci.chromium.org/p/chromium/builders/ci/fuchsia-arm64-cast/46713 Original change's description: > [Fuchsia][EME] Basic skeleton for EME support on Fuchsia > > In renderer process, FuchsiaCdmFactory initiates the request to Fuchsia > CDM service. The request is passed to browser process via new mojo > FuchsiaCdmProvider. FuchsiaCdm implements > media::ContentDecryptionModule by calling Fuchsia CDM APIs directly from > renderer process. > > In browser process, FuchsiaCdmManager will complete the provision flow > (if needed) and setup the channel between Chromium and the remote CDM > service. > > Bug: 966191 > Test: Shaka Player WV audio only test (with other CLs). > Change-Id: I401e581214d945a2acbefa926f73fdb2ca84d780 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715908 > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Yuchen Liu <yucliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684087} TBR=dcheng@chromium.org,wez@chromium.org,xhwang@chromium.org,jam@chromium.org,jrummell@chromium.org,sergeyu@chromium.org,yucliu@chromium.org Change-Id: Id572ae4feadf1b87fe58601eb83601da07d61b8b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737487Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#684121}
-
Brian Sheedy authored
Fixes a race condition in XR tests that use the test_gamepad_button.html test page. It was possible for finishJavaScriptStep() to be called multiple times before the Java/C++ code could ack the first one, leading to test failures. Bug: 990843 Change-Id: I6e1a92c9cc3512862fb6441a1bad5efecff3a83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736801 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#684120}
-
Brandon Walderman authored
The new command line switch allows users to disable high frequency timers on Windows. Normally the browser will set a system-wide timer resolution of 1ms on AC power, and 4ms on battery. The period used when on battery power can be increased to 8ms if the experimental SlowDCTimerInterrupts feature is enabled. The switch is intended for use with headless browser processes running on a server or VM, which is likely to be on AC power at all times. The switch allows these processes to opt-in to the slower timer interrupt frequency, acting as if they are running on battery. This should reduce the amount of context switching and reduce CPU usage, which can be helpful when attempting to run many headless browser processes in parallel. Bug: 986338 Change-Id: I8580f486aca3400fb51e0c4932c3783332a3a11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715566Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Cr-Commit-Position: refs/heads/master@{#684119}
-
Maksym Onufriienko authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. EarlGrey2 has multiprocess architecture, where Chrome Test and Chrome App are separate processes Change-Id: If2dc2115f5c11c906806edacef567bc6f1d02204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733891 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#684118}
-
Xing Liu authored
This CL adds test to cover all functions in NotificationScheduler. Bug: 963304 Change-Id: I9f63cd4ec9e1e3ed761c10ac7f2e0539294e026c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732289 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#684117}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 985386 Change-Id: I3667a7881cc5c9b2046217a647603777593de0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730865 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#684116}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cdbaeeb73767..9b1700cfaef9 git log cdbaeeb73767..9b1700cfaef9 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 orphis@webrtc.org Enable field trial LegacySimulcastLayerLimit by default 2019-08-05 peah@webrtc.org AEC3: Removing unused code in the echo subtractor Created with: gclient setdep -r src/third_party/webrtc@9b1700cfaef9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:990823 Change-Id: Id638fa2e5f750a0d8fa719f9e98d0352c07fc63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735951Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684115}
-
Jun Cai authored
This CL updates SMS dialog to use xml layout. I uploaded some screenshots of the SMS dialog on the issue page. Bug: 987799 Change-Id: I46e27aefd19104b4bba5032076bc31b0b203a730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725519 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#684114}
-
Sylvain Defresne authored
Bug: 925165 Change-Id: Idcd84485128c8239d3cd811bf0309e1c3c2b8c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736353 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#684113}
-
Lukasz Anforowicz authored
Bug: 942178 Bug: 945164 Bug: 950339 Bug: 977216 Change-Id: I15b8cffe8c1ab47c5c4697b92f89d3cbe7ccbae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717465 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#684112}
-
David Grogan authored
Safari and blink legacy fail this; EdgeHTML, Firefox, and blink NG pass it, but I think blink NG passes it by accident for now. Change-Id: I38acc8ba98d3897aa77305a36c2ae6f2affec640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713143 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#684111}
-
Jenna Himawan authored
Bug: 990534 Change-Id: I6a980d68c33a08306286ff4e6628f291203f55bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733894Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jenna Himawan <jhimawan@google.com> Cr-Commit-Position: refs/heads/master@{#684110}
-
Meilin Wang authored
Bug: 988177 Test: manually verified the message shown on Assistant OOBE ready sreen. Change-Id: I18be0fc6d09697c0076ef45d4e283c234ea12e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733846Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#684109}
-
Will Harris authored
This reverts commit 6bbf3348. Reason for revert: The issue is now fixed. Relanding. Original change's description: > Disable renderer CIG by default. > > This is causing crashes on some configurations and needs investigation. > > BUG=750886,990640 > > Change-Id: Idfdd06b219a95bed854cce9048860692ded011b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736106 > Commit-Queue: Will Harris <wfh@chromium.org> > Commit-Queue: James Forshaw <forshaw@chromium.org> > Reviewed-by: James Forshaw <forshaw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683904} TBR=forshaw@chromium.org,wfh@chromium.org Change-Id: I84f75f23b897770fd5429a400086db78aff52479 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 750886, 990640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737434Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#684108}
-